)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ce5e2efe2270cd604b8126723daf7a4609e1f438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9c65e4e_6066b25d","updated":"2026-03-09 16:22:08.000000000","message":"Looks like you already saw https://review.opendev.org/c/openstack/liberasurecode/+/977488 -- and yeah, I think we\u0027ll probably want to have *some* further discussions before we move ahead with either of these.","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"}],"include/erasurecode/erasurecode.h":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"8b08e4f6df0d62fcc008d7f4a697ee5d615603cc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  EC_BACKEND_ISA_L_RS_CAUCHY \u003d 7,"},{"line_number":52,"context_line":"  EC_BACKEND_LIBPHAZR \u003d 8,"},{"line_number":53,"context_line":"  EC_BACKEND_ISA_L_RS_VAND_INV \u003d 9,"},{"line_number":54,"context_line":"  EC_BACKENDS_MAX,"},{"line_number":55,"context_line":"} ec_backend_id_t;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/* ~\u003d*\u003d~\u003d\u003d~\u003d*\u003d~\u003d EC Fragment metadata - supported checksum types ~\u003d*\u003d~\u003d\u003d~\u003d*\u003d~ */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"139ddc00_f6876bd1","line":54,"updated":"2026-03-08 22:15:11.000000000","message":"Is there a particular code style we\u0027re adhearing too? \nsome part of me kinda likes all the values lined up, reminds me of c, and the latter reminds me more of python.\n\nDon\u0027t really mind which way we do it, so long as it\u0027s consistant.","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ce5e2efe2270cd604b8126723daf7a4609e1f438","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  EC_BACKEND_ISA_L_RS_CAUCHY \u003d 7,"},{"line_number":52,"context_line":"  EC_BACKEND_LIBPHAZR \u003d 8,"},{"line_number":53,"context_line":"  EC_BACKEND_ISA_L_RS_VAND_INV \u003d 9,"},{"line_number":54,"context_line":"  EC_BACKENDS_MAX,"},{"line_number":55,"context_line":"} ec_backend_id_t;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/* ~\u003d*\u003d~\u003d\u003d~\u003d*\u003d~\u003d EC Fragment metadata - supported checksum types ~\u003d*\u003d~\u003d\u003d~\u003d*\u003d~ */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2c7a70c8_1941c15b","line":54,"in_reply_to":"139ddc00_f6876bd1","updated":"2026-03-09 16:22:08.000000000","message":"\u003e Is there a particular code style we\u0027re adhearing too?\n\nWhatever clang-format defaults to ;-)\n\n\u003e Don\u0027t really mind which way we do it, so long as it\u0027s consistant.\n\nThat\u0027s the big thing that I want to push for -- it doesn\u0027t need to be perfect, but having *some* consistent formatting seems like a win so we don\u0027t need to nit-pick over `mat[row*size+col]` vs `mat[row*size + col]` vs `mat[row * size + col]`","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"8b08e4f6df0d62fcc008d7f4a697ee5d615603cc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      uint64_t x, y; /* reserved for future expansion */"},{"line_number":85,"context_line":"      uint64_t z, a; /* reserved for future expansion */"},{"line_number":86,"context_line":"    } reserved;"},{"line_number":87,"context_line":"  } priv_args1;"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  void *priv_args2;      /** flexible placeholder for"},{"line_number":90,"context_line":"                          * future backend args */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"722fd02d_38f94cf6","line":87,"updated":"2026-03-08 22:15:11.000000000","message":"So we go from 4 spaces to 2? I don\u0027t mind the 4 spaces. Also personally are the former comments easier to read?\n\nAgain, I guess it comes down to what coding style we want and I don\u0027t really mind so long as it\u0027s consistent.","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"8b08e4f6df0d62fcc008d7f4a697ee5d615603cc","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                          uint64_t orig_data_size, /* input */"},{"line_number":156,"context_line":"                          char ***encoded_data,"},{"line_number":157,"context_line":"                          char ***encoded_parity,  /* output */"},{"line_number":158,"context_line":"                          uint64_t *fragment_len); /* output */"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"/**"},{"line_number":161,"context_line":" * Cleanup structures allocated by librasurecode_encode"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"59798599_238650fe","line":158,"updated":"2026-03-08 22:15:11.000000000","message":"Yeah, this looks much better","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"8b08e4f6df0d62fcc008d7f4a697ee5d615603cc","unresolved":false,"context_lines":[{"line_number":263,"context_line":"  uint32_t chksum[LIBERASURECODE_MAX_CHECKSUM_LEN]; /* 32 */"},{"line_number":264,"context_line":"  uint8_t chksum_mismatch;                          /*  1 */"},{"line_number":265,"context_line":"  uint8_t backend_id;                               /*  1 */"},{"line_number":266,"context_line":"  uint32_t backend_version;                         /*  4 */"},{"line_number":267,"context_line":"} fragment_metadata_t;"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fffa790b_e5da4a36","line":266,"updated":"2026-03-08 22:15:11.000000000","message":"Huh, the comments here are all inline, but not back earlier in this file. So we shold be consistent.","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"8b08e4f6df0d62fcc008d7f4a697ee5d615603cc","unresolved":false,"context_lines":[{"line_number":325,"context_line":"  uint32_t metadata_chksum; /*  4 bytes */"},{"line_number":326,"context_line":"  // We must be aligned to 16-byte boundaries"},{"line_number":327,"context_line":"  // So, size this array accordingly"},{"line_number":328,"context_line":"  uint8_t aligned_padding[9];"},{"line_number":329,"context_line":"} fragment_header_t;"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"#define FRAGSIZE_2_BLOCKSIZE(fragment_size)                                    \\"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"60fe481c_8d78d5b2","line":328,"updated":"2026-03-08 22:15:11.000000000","message":"The lining up I think reads better in my brain.","commit_id":"c32d17d79af9309a16e7b30c4806bf2276058e66"}]}