)]}'
{"scripts/fetch_wheels.py":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"99a789fb20df3247a73d5b978dc96fc8371848c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"def get_token(protocol, registry, repo):"},{"line_number":14,"context_line":"    if registry \u003d\u003d \u0027registry.hub.docker.com\u0027:"},{"line_number":15,"context_line":"      authserver \u003d \u0027auth.docker.io/\u0027"},{"line_number":16,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":17,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_557c2db4","line":14,"updated":"2018-03-28 14:42:09.000000000","message":"the \u0027registry\u0027 variable as defined in the code should not ever be this address. It would be docker.io if empty","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"53c00585fffd01357dc2d5263bb1f463af71a0ac","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"def get_token(protocol, registry, repo):"},{"line_number":14,"context_line":"    if registry \u003d\u003d \u0027registry.hub.docker.com\u0027:"},{"line_number":15,"context_line":"      authserver \u003d \u0027auth.docker.io/\u0027"},{"line_number":16,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":17,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_bee796ac","line":14,"in_reply_to":"bf659307_557c2db4","updated":"2018-03-29 06:25:31.000000000","message":"I took this value from the default value of get_blob function\u0027s registry arg, but I agree on changing it","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"99a789fb20df3247a73d5b978dc96fc8371848c5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      authserver \u003d \u0027auth.docker.io/\u0027"},{"line_number":16,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":17,"context_line":"    else:"},{"line_number":18,"context_line":"      authserver \u003d registry+\u0027/v2/\u0027"},{"line_number":19,"context_line":"      service \u003d registry if registry.find(\u0027:\u0027) \u003d\u003d -1 else registry.split(\u0027:\u0027)[0]"},{"line_number":20,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":21,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_955ba552","line":18,"updated":"2018-03-28 14:42:09.000000000","message":"nitpick, \"registry + \u0027/v2/\u0027\"","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"53c00585fffd01357dc2d5263bb1f463af71a0ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      authserver \u003d \u0027auth.docker.io/\u0027"},{"line_number":16,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":17,"context_line":"    else:"},{"line_number":18,"context_line":"      authserver \u003d registry+\u0027/v2/\u0027"},{"line_number":19,"context_line":"      service \u003d registry if registry.find(\u0027:\u0027) \u003d\u003d -1 else registry.split(\u0027:\u0027)[0]"},{"line_number":20,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":21,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_be6a36ea","line":18,"in_reply_to":"bf659307_955ba552","updated":"2018-03-29 06:25:31.000000000","message":"OK, I\u0027ll change it to:\n\"{}/v2\".format(registry)","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"99a789fb20df3247a73d5b978dc96fc8371848c5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":17,"context_line":"    else:"},{"line_number":18,"context_line":"      authserver \u003d registry+\u0027/v2/\u0027"},{"line_number":19,"context_line":"      service \u003d registry if registry.find(\u0027:\u0027) \u003d\u003d -1 else registry.split(\u0027:\u0027)[0]"},{"line_number":20,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":21,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"},{"line_number":22,"context_line":"    print(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_980e7c30","line":19,"updated":"2018-03-28 14:42:09.000000000","message":"im confused, under what circumstance should we be spliting the registry variable here (we should have already parsed it all)","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"53c00585fffd01357dc2d5263bb1f463af71a0ac","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":17,"context_line":"    else:"},{"line_number":18,"context_line":"      authserver \u003d registry+\u0027/v2/\u0027"},{"line_number":19,"context_line":"      service \u003d registry if registry.find(\u0027:\u0027) \u003d\u003d -1 else registry.split(\u0027:\u0027)[0]"},{"line_number":20,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":21,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"},{"line_number":22,"context_line":"    print(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5eee7ab4","line":19,"in_reply_to":"bf659307_980e7c30","updated":"2018-03-29 06:25:31.000000000","message":"We need to split it if the port is included in registry name:\ne.g. localhost:7000/myrepo/myimage:latest","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"99a789fb20df3247a73d5b978dc96fc8371848c5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                return protocol_detection(registry, PROTOCOLS[index + 1])"},{"line_number":62,"context_line":"        except urllib2.URLError as err:"},{"line_number":63,"context_line":"            if \u0027Connection refused\u0027 in err.reason:"},{"line_number":64,"context_line":"                return protocol_detection(registry, PROTOCOLS[index+1])"},{"line_number":65,"context_line":"        except:"},{"line_number":66,"context_line":"            print(\"Cannot detect protocol for registry: {}\".format(registry))"},{"line_number":67,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5831c4eb","line":64,"updated":"2018-03-28 14:42:09.000000000","message":"nitpick, spacing\n\nPROTOCOLS[index + 1]","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"53c00585fffd01357dc2d5263bb1f463af71a0ac","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                return protocol_detection(registry, PROTOCOLS[index + 1])"},{"line_number":62,"context_line":"        except urllib2.URLError as err:"},{"line_number":63,"context_line":"            if \u0027Connection refused\u0027 in err.reason:"},{"line_number":64,"context_line":"                return protocol_detection(registry, PROTOCOLS[index+1])"},{"line_number":65,"context_line":"        except:"},{"line_number":66,"context_line":"            print(\"Cannot detect protocol for registry: {}\".format(registry))"},{"line_number":67,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3e74e6fd","line":64,"in_reply_to":"bf659307_5831c4eb","updated":"2018-03-29 06:25:31.000000000","message":"Acknowledged. I\u0027m going to change it.","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"99a789fb20df3247a73d5b978dc96fc8371848c5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    resp \u003d urllib2.urlopen(r)"},{"line_number":76,"context_line":"    return resp.read()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def parse_image(full_image):"},{"line_number":79,"context_line":"    slash_occurences \u003d len(re.findall(\u0027/\u0027,full_image))"},{"line_number":80,"context_line":"    repo \u003d None"},{"line_number":81,"context_line":"    registry \u003d \u0027registry.hub.docker.com\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_95ff2533","line":78,"updated":"2018-03-28 14:42:09.000000000","message":"i dont see a reason for this section to be reworked","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"53c00585fffd01357dc2d5263bb1f463af71a0ac","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    resp \u003d urllib2.urlopen(r)"},{"line_number":76,"context_line":"    return resp.read()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def parse_image(full_image):"},{"line_number":79,"context_line":"    slash_occurences \u003d len(re.findall(\u0027/\u0027,full_image))"},{"line_number":80,"context_line":"    repo \u003d None"},{"line_number":81,"context_line":"    registry \u003d \u0027registry.hub.docker.com\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7e057e45","line":78,"in_reply_to":"bf659307_95ff2533","updated":"2018-03-29 06:25:31.000000000","message":"To be honest, it didn\u0027t do what I need and I wasn\u0027t been able to patch it.\nThis are the test I needed this function to pass (we can of course change registry.hub.docker.com with docker.io):\n        def test_image_without_registry_with_version_tag(self):\n            image \u003d \u0027repo/myimage:v46\u0027\n            self.assertEqual(fetch_wheels.parse_image(image), (\u0027registry.hub.docker.com\u0027,\u0027repo/myimage\u0027,\u0027v46\u0027))\n        def test_image_without_registry_without_version_tag(self):\n            image \u003d \u0027repo/myimage\u0027\n            self.assertEqual(fetch_wheels.parse_image(image), (\u0027registry.hub.docker.com\u0027,\u0027repo/myimage\u0027,\u0027latest\u0027))\n        def test_image_with_registry_without_version_tag(self):\n            image \u003d \u0027internalregistry.example.com/repo/myimage\u0027\n            self.assertEqual(fetch_wheels.parse_image(image), (\u0027internalregistry.example.com\u0027, \u0027repo/myimage\u0027, \u0027latest\u0027))\n        def test_image_with_registry_with_version_tag(self):\n            image \u003d \u0027internalregistry.example.com/repo/myimage:v3.1\u0027\n            self.assertEqual(fetch_wheels.parse_image(image), (\u0027internalregistry.example.com\u0027, \u0027repo/myimage\u0027, \u0027v3.1\u0027))\n        def test_image_with_registry_port_number_with_version_tag(self):\n            image \u003d \u0027internalregistry.example.com:443/repo/myimage:v3.1\u0027\n            self.assertEqual(fetch_wheels.parse_image(image), (\u0027internalregistry.example.com:443\u0027, \u0027repo/myimage\u0027, \u0027v3.1\u0027))","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"99a789fb20df3247a73d5b978dc96fc8371848c5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"def parse_image(full_image):"},{"line_number":79,"context_line":"    slash_occurences \u003d len(re.findall(\u0027/\u0027,full_image))"},{"line_number":80,"context_line":"    repo \u003d None"},{"line_number":81,"context_line":"    registry \u003d \u0027registry.hub.docker.com\u0027"},{"line_number":82,"context_line":"    if slash_occurences \u003d\u003d 2:"},{"line_number":83,"context_line":"        registry, repo, image \u003d full_image.split(\u0027/\u0027)"},{"line_number":84,"context_line":"    elif slash_occurences \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f5bea163","line":81,"updated":"2018-03-28 14:42:09.000000000","message":"this is not correct, we are parsing the image name and you won\u0027t find \u0027registry.hub.docker.com/memcached:latest\u0027.\n\nYou will find \u0027docker.io/memcached:latest\u0027","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"53c00585fffd01357dc2d5263bb1f463af71a0ac","unresolved":false,"context_lines":[{"line_number":78,"context_line":"def parse_image(full_image):"},{"line_number":79,"context_line":"    slash_occurences \u003d len(re.findall(\u0027/\u0027,full_image))"},{"line_number":80,"context_line":"    repo \u003d None"},{"line_number":81,"context_line":"    registry \u003d \u0027registry.hub.docker.com\u0027"},{"line_number":82,"context_line":"    if slash_occurences \u003d\u003d 2:"},{"line_number":83,"context_line":"        registry, repo, image \u003d full_image.split(\u0027/\u0027)"},{"line_number":84,"context_line":"    elif slash_occurences \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5ef8ba47","line":81,"in_reply_to":"bf659307_f5bea163","updated":"2018-03-29 06:25:31.000000000","message":"We can change it, of course. See the other comments.","commit_id":"f2f62be3bd87b30c6b013ba69ecaf6e0921b8d92"}]}
