)]}'
{"scripts/fetch_wheels.py":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"15885a9aff231567a77b847d45b6c33f76c4d12e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # python3"},{"line_number":11,"context_line":"    from urllib import request as urllib2"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"def docker_registry():"},{"line_number":14,"context_line":"    return \u0027registry.hub.docker.com\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def get_token(protocol, registry, repo):"},{"line_number":17,"context_line":"    if registry \u003d\u003d docker_registry():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7f873111","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":36},"updated":"2018-04-05 14:13:24.000000000","message":"Is there a reason this is a function rather than a global constant?","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"1f2779eba7e7fc576ab0a3a340f10a0db79754ee","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    # python3"},{"line_number":11,"context_line":"    from urllib import request as urllib2"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"def docker_registry():"},{"line_number":14,"context_line":"    return \u0027registry.hub.docker.com\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def get_token(protocol, registry, repo):"},{"line_number":17,"context_line":"    if registry \u003d\u003d docker_registry():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_83a701a8","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":36},"in_reply_to":"bf659307_7f873111","updated":"2018-04-10 06:16:56.000000000","message":"Not really, I can change it to a global constant.","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"15885a9aff231567a77b847d45b6c33f76c4d12e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":20,"context_line":"    else:"},{"line_number":21,"context_line":"      authserver \u003d \"{}/v2\".format(registry)"},{"line_number":22,"context_line":"      service \u003d registry if registry.find(\u0027:\u0027) \u003d\u003d -1 \\"},{"line_number":23,"context_line":"                         else registry.split(\u0027:\u0027)[0]"},{"line_number":24,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":25,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"},{"line_number":26,"context_line":"    print(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f1d61528","line":23,"range":{"start_line":22,"start_character":6,"end_line":23,"end_character":52},"updated":"2018-04-05 14:13:24.000000000","message":"It would be better to use https://docs.python.org/3.5/library/urllib.parse.html#urllib.parse.urlparse here","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"1f2779eba7e7fc576ab0a3a340f10a0db79754ee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      service \u003d \u0027registry.docker.io\u0027"},{"line_number":20,"context_line":"    else:"},{"line_number":21,"context_line":"      authserver \u003d \"{}/v2\".format(registry)"},{"line_number":22,"context_line":"      service \u003d registry if registry.find(\u0027:\u0027) \u003d\u003d -1 \\"},{"line_number":23,"context_line":"                         else registry.split(\u0027:\u0027)[0]"},{"line_number":24,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":25,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"},{"line_number":26,"context_line":"    print(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_63ac2d8c","line":23,"range":{"start_line":22,"start_character":6,"end_line":23,"end_character":52},"in_reply_to":"bf659307_f1d61528","updated":"2018-04-10 06:16:56.000000000","message":"Ack, I will try to change it to use urlparse","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"15885a9aff231567a77b847d45b6c33f76c4d12e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                         else registry.split(\u0027:\u0027)[0]"},{"line_number":24,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":25,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"},{"line_number":26,"context_line":"    print(url)"},{"line_number":27,"context_line":"    try:"},{"line_number":28,"context_line":"        r \u003d urllib2.Request(url\u003durl)"},{"line_number":29,"context_line":"        resp \u003d urllib2.urlopen(r)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_9f880523","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":14},"updated":"2018-04-05 14:13:24.000000000","message":"Can we remove this?","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"1f2779eba7e7fc576ab0a3a340f10a0db79754ee","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                         else registry.split(\u0027:\u0027)[0]"},{"line_number":24,"context_line":"    url \u003d \"{}://{}/token?service\u003d{}\u0026\" \\"},{"line_number":25,"context_line":"            \"scope\u003drepository:{}:pull\".format(protocol, authserver, service, repo)"},{"line_number":26,"context_line":"    print(url)"},{"line_number":27,"context_line":"    try:"},{"line_number":28,"context_line":"        r \u003d urllib2.Request(url\u003durl)"},{"line_number":29,"context_line":"        resp \u003d urllib2.urlopen(r)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_c3f3b9e6","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":14},"in_reply_to":"bf659307_9f880523","updated":"2018-04-10 06:16:56.000000000","message":"Of course, I only mimicked the way it was done previously (some print statement for easier debug).","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"15885a9aff231567a77b847d45b6c33f76c4d12e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    except urllib2.HTTPError as err:"},{"line_number":33,"context_line":"        if err.reason \u003d\u003d \u0027Not Found\u0027:"},{"line_number":34,"context_line":"            return None"},{"line_number":35,"context_line":"    except:"},{"line_number":36,"context_line":"        raise"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_sha(repo, tag, registry, protocol, token):"},{"line_number":39,"context_line":"    url \u003d \"{}://{}/v2/{}/manifests/{}\".format(protocol, registry, repo, tag)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3f90d94e","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":13},"updated":"2018-04-05 14:13:24.000000000","message":"This is pointless","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"1f2779eba7e7fc576ab0a3a340f10a0db79754ee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    except urllib2.HTTPError as err:"},{"line_number":33,"context_line":"        if err.reason \u003d\u003d \u0027Not Found\u0027:"},{"line_number":34,"context_line":"            return None"},{"line_number":35,"context_line":"    except:"},{"line_number":36,"context_line":"        raise"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_sha(repo, tag, registry, protocol, token):"},{"line_number":39,"context_line":"    url \u003d \"{}://{}/v2/{}/manifests/{}\".format(protocol, registry, repo, tag)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_e3983d6b","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":13},"in_reply_to":"bf659307_3f90d94e","updated":"2018-04-10 06:16:56.000000000","message":"Ack - I will remove it.","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"15885a9aff231567a77b847d45b6c33f76c4d12e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    resp \u003d urllib2.urlopen(r)"},{"line_number":57,"context_line":"    return resp.read()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def protocol_detection(registry, protocol\u003d\u0027http\u0027):"},{"line_number":60,"context_line":"    PROTOCOLS \u003d (\u0027http\u0027,\u0027https\u0027)"},{"line_number":61,"context_line":"    index \u003d PROTOCOLS.index(protocol)"},{"line_number":62,"context_line":"    try:"},{"line_number":63,"context_line":"        url \u003d \"{}://{}\".format(protocol, registry)"},{"line_number":64,"context_line":"        r \u003d urllib2.Request(url)"},{"line_number":65,"context_line":"        resp \u003d urllib2.urlopen(r)"},{"line_number":66,"context_line":"    except (urllib2.URLError,urllib2.HTTPError) as err:"},{"line_number":67,"context_line":"        if err.reason \u003d\u003d \u0027Forbidden\u0027:"},{"line_number":68,"context_line":"            return protocol"},{"line_number":69,"context_line":"        elif index \u003c len(PROTOCOLS) - 1:"},{"line_number":70,"context_line":"            return protocol_detection(registry, PROTOCOLS[index + 1])"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            raise Exception, \"Cannot detect protocol for registry: {} due to error: {}\".format(registry,err)"},{"line_number":73,"context_line":"    except:"},{"line_number":74,"context_line":"        raise"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        return protocol"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def get_wheels(url):"},{"line_number":79,"context_line":"    r \u003d urllib2.Request(url\u003durl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_517ca11f","line":76,"range":{"start_line":59,"start_character":0,"end_line":76,"end_character":23},"updated":"2018-04-05 14:13:24.000000000","message":"Same comment as above, https://docs.python.org/3.5/library/urllib.parse.html#urllib.parse.urlparse should remove the need for this function","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"},{"author":{"_account_id":28041,"name":"Virgil Chereches","email":"virgil.chereches@gmail.com","username":"brutus333"},"change_message_id":"1f2779eba7e7fc576ab0a3a340f10a0db79754ee","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    resp \u003d urllib2.urlopen(r)"},{"line_number":57,"context_line":"    return resp.read()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def protocol_detection(registry, protocol\u003d\u0027http\u0027):"},{"line_number":60,"context_line":"    PROTOCOLS \u003d (\u0027http\u0027,\u0027https\u0027)"},{"line_number":61,"context_line":"    index \u003d PROTOCOLS.index(protocol)"},{"line_number":62,"context_line":"    try:"},{"line_number":63,"context_line":"        url \u003d \"{}://{}\".format(protocol, registry)"},{"line_number":64,"context_line":"        r \u003d urllib2.Request(url)"},{"line_number":65,"context_line":"        resp \u003d urllib2.urlopen(r)"},{"line_number":66,"context_line":"    except (urllib2.URLError,urllib2.HTTPError) as err:"},{"line_number":67,"context_line":"        if err.reason \u003d\u003d \u0027Forbidden\u0027:"},{"line_number":68,"context_line":"            return protocol"},{"line_number":69,"context_line":"        elif index \u003c len(PROTOCOLS) - 1:"},{"line_number":70,"context_line":"            return protocol_detection(registry, PROTOCOLS[index + 1])"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            raise Exception, \"Cannot detect protocol for registry: {} due to error: {}\".format(registry,err)"},{"line_number":73,"context_line":"    except:"},{"line_number":74,"context_line":"        raise"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        return protocol"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def get_wheels(url):"},{"line_number":79,"context_line":"    r \u003d urllib2.Request(url\u003durl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_23b875c6","line":76,"range":{"start_line":59,"start_character":0,"end_line":76,"end_character":23},"in_reply_to":"bf659307_517ca11f","updated":"2018-04-10 06:16:56.000000000","message":"I am not sure we can get rid of this function. The script is called with WHEELS env variable which can hold the path to a docker image (which does not allow specifying the protocol/scheme) or the URL to a local hosted wheels package (which includes protocol - see line 109). So in the first case we do not know a-priori which protocol to use when connecting to registry and we cannot use the urlparse function to find since the scheme is not allowed in the docker image path.","commit_id":"a57ceb88ffe127b5eb25b2ccaa275d095ad353ab"}]}
