)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3ff5256a7934f40d4d1e3d9fb6496df9e9bb559f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jean-Philippe Evrard \u003cjean-philippe@evrard.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-27 09:41:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add OpenSUSE Leap 15 support for Requirements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I002d63fc1a24990a85d21121f8ed33d6ef664343"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_79583f56","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":26},"updated":"2018-07-27 10:02:52.000000000","message":"s/for Requirements// please","commit_id":"4e5491350e0545af1800ca4aa329c7da7fef2a35"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"09b8bda6dca5d26ebd401b4c496930b2e1eb58bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jean-Philippe Evrard \u003cjean-philippe@evrard.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-27 09:41:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add OpenSUSE Leap 15 support for Requirements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I002d63fc1a24990a85d21121f8ed33d6ef664343"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_d4483a63","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":26},"in_reply_to":"5f7c97a3_79583f56","updated":"2018-07-27 10:14:11.000000000","message":"I will do step by step, first starting with requirements building, then doing other services. If they are all working with a single patch I will remove \"for requirements\", else I\u0027d separate those patches.","commit_id":"4e5491350e0545af1800ca4aa329c7da7fef2a35"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"4b4545678c7866ed9e129290830a7e8d1477acc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jean-Philippe Evrard \u003cjean-philippe@evrard.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-27 09:41:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add OpenSUSE Leap 15 support for Requirements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I002d63fc1a24990a85d21121f8ed33d6ef664343"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_5f3c43bf","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":26},"in_reply_to":"5f7c97a3_d4483a63","updated":"2018-07-27 11:14:51.000000000","message":"still this patch is adding opensuse support for all images. not only for requirements.","commit_id":"4e5491350e0545af1800ca4aa329c7da7fef2a35"}],"bindep.txt":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"53a83b7c0ef665901fb1bf727df3e9d156ed6ddc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"libgcrypt                   [platform:rpm !platform:suse requirements]"},{"line_number":43,"context_line":"libgcrypt-devel             [platform:suse requirements]"},{"line_number":44,"context_line":"libjpeg-dev                 [platform:dpkg requirements]"},{"line_number":45,"context_line":"libjpeg-devel               [platform:rpm !platform:suse requirements]"},{"line_number":46,"context_line":"libjpeg-devel               [platform:rpm requirements]"},{"line_number":47,"context_line":"libjpeg8-devel              [platform:suse requirements]"},{"line_number":48,"context_line":"libkrb5-dev                 [platform:dpkg requirements]"}],"source_content_type":"text/plain","patch_set":11,"id":"5f7c97a3_310b2524","line":45,"updated":"2018-08-03 15:17:33.000000000","message":"this package name is shared with the other platform:rpm stuff","commit_id":"e5e8a056dfe64b796c55db72082fd4ec9e1973d4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2a17dad19c9ed6fb1755a3419abc4dfa9b5ce330","unresolved":false,"context_lines":[{"line_number":42,"context_line":"libgcrypt                   [platform:rpm !platform:suse requirements]"},{"line_number":43,"context_line":"libgcrypt-devel             [platform:suse requirements]"},{"line_number":44,"context_line":"libjpeg-dev                 [platform:dpkg requirements]"},{"line_number":45,"context_line":"libjpeg-devel               [platform:rpm !platform:suse requirements]"},{"line_number":46,"context_line":"libjpeg-devel               [platform:rpm requirements]"},{"line_number":47,"context_line":"libjpeg8-devel              [platform:suse requirements]"},{"line_number":48,"context_line":"libkrb5-dev                 [platform:dpkg requirements]"}],"source_content_type":"text/plain","patch_set":11,"id":"3f79a3b5_f79e1a53","line":45,"in_reply_to":"5f7c97a3_310b2524","updated":"2018-08-03 17:58:36.000000000","message":"Opensuse has libjpeg62-devel and libjpeg8-devel but no libjpeg-devel. That\u0027s why !platform:suse","commit_id":"e5e8a056dfe64b796c55db72082fd4ec9e1973d4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"f06f4066b7ae2389dd628e40cb286eaa7f221c14","unresolved":false,"context_lines":[{"line_number":43,"context_line":"libgcrypt-devel             [platform:suse requirements]"},{"line_number":44,"context_line":"libjpeg-dev                 [platform:dpkg requirements]"},{"line_number":45,"context_line":"libjpeg-devel               [platform:rpm !platform:suse requirements]"},{"line_number":46,"context_line":"libjpeg-devel               [platform:rpm requirements]"},{"line_number":47,"context_line":"libjpeg8-devel              [platform:suse requirements]"},{"line_number":48,"context_line":"libkrb5-dev                 [platform:dpkg requirements]"},{"line_number":49,"context_line":"liblapack-dev               [platform:dpkg requirements]"}],"source_content_type":"text/plain","patch_set":13,"id":"3f79a3b5_3212435a","line":46,"updated":"2018-08-06 15:29:22.000000000","message":"remove this line or the one above. the package name is the same and there is no reason to do that, no matter what the end goal you are trying to achieve is","commit_id":"cbfaadc1f4f613f85a2e6a40eded8922af53a37f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d6a578168e48ddb05f221b53adcae37cd9f2413f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"libgcrypt-devel             [platform:suse requirements]"},{"line_number":44,"context_line":"libjpeg-dev                 [platform:dpkg requirements]"},{"line_number":45,"context_line":"libjpeg-devel               [platform:rpm !platform:suse requirements]"},{"line_number":46,"context_line":"libjpeg-devel               [platform:rpm requirements]"},{"line_number":47,"context_line":"libjpeg8-devel              [platform:suse requirements]"},{"line_number":48,"context_line":"libkrb5-dev                 [platform:dpkg requirements]"},{"line_number":49,"context_line":"liblapack-dev               [platform:dpkg requirements]"}],"source_content_type":"text/plain","patch_set":13,"id":"3f79a3b5_5818411c","line":46,"in_reply_to":"3f79a3b5_3212435a","updated":"2018-08-06 16:15:48.000000000","message":"it\u0027s just a mistake.","commit_id":"cbfaadc1f4f613f85a2e6a40eded8922af53a37f"}],"scripts/cleanup.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7569773daef2834aebb2c55bef551c7bebcdab1c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            remove_packages\u003d(\"python-virtualenv\")"},{"line_number":27,"context_line":"        else"},{"line_number":28,"context_line":"            remove_packages\u003d(\"python3-virtualenv\")"},{"line_number":29,"context_line":"        fi "},{"line_number":30,"context_line":"        zypper remove -y --clean-deps \\"},{"line_number":31,"context_line":"            git-core \\"},{"line_number":32,"context_line":"            patch \\"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_dc90ea51","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":11},"updated":"2018-08-02 11:31:02.000000000","message":"drop space","commit_id":"5967368dd22cdc69682ee9ceacbdbe9f6cd6b156"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7569773daef2834aebb2c55bef551c7bebcdab1c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        zypper remove -y --clean-deps \\"},{"line_number":31,"context_line":"            git-core \\"},{"line_number":32,"context_line":"            patch \\"},{"line_number":33,"context_line":"            python-virtualenv \\"},{"line_number":34,"context_line":"            python3-virtualenv"},{"line_number":35,"context_line":"            gcc7 \\"},{"line_number":36,"context_line":"            ${remove_packages}"},{"line_number":37,"context_line":"        zypper clean -a"},{"line_number":38,"context_line":"        ;;"},{"line_number":39,"context_line":"    *)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_fc74c638","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":30},"updated":"2018-08-02 11:31:02.000000000","message":"what\u0027s the point of checking for PYTHON3 if you remove both virtualenv packages anyway?","commit_id":"5967368dd22cdc69682ee9ceacbdbe9f6cd6b156"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"53a83b7c0ef665901fb1bf727df3e9d156ed6ddc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        zypper remove -y --clean-deps \\"},{"line_number":31,"context_line":"            git-core \\"},{"line_number":32,"context_line":"            patch \\"},{"line_number":33,"context_line":"            gcc7 \\"},{"line_number":34,"context_line":"            ${remove_packages}"},{"line_number":35,"context_line":"        zypper clean -a"},{"line_number":36,"context_line":"        ;;"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5f7c97a3_f114cd44","line":33,"updated":"2018-08-03 15:17:33.000000000","message":"hmmm why was gcc7 installed?","commit_id":"e5e8a056dfe64b796c55db72082fd4ec9e1973d4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2e1ce840e4b6a2c1adccb9ef1315d0fe654b6e15","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        zypper remove -y --clean-deps \\"},{"line_number":31,"context_line":"            git-core \\"},{"line_number":32,"context_line":"            patch \\"},{"line_number":33,"context_line":"            gcc7 \\"},{"line_number":34,"context_line":"            ${remove_packages}"},{"line_number":35,"context_line":"        zypper clean -a"},{"line_number":36,"context_line":"        ;;"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3f79a3b5_2d8e7078","line":33,"in_reply_to":"5f7c97a3_f114cd44","updated":"2018-08-06 10:24:53.000000000","message":"it gets installed in several places when installing libraries, even if no recommended packages are installed. This cleans up the images at all times, as gcc is not likely to be used in final images anyway.","commit_id":"e5e8a056dfe64b796c55db72082fd4ec9e1973d4"}],"scripts/install.sh":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"dda27f7c3e674c9593c01b873170197a197c2bbc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           rpm_python_packages+\u003d(\"python3-devel\" \"python3-setuptools\")"},{"line_number":43,"context_line":"        fi"},{"line_number":44,"context_line":"        zypper --non-interactive --gpg-auto-import-keys refresh"},{"line_number":45,"context_line":"        zypper --non-interactive install -y \\"},{"line_number":46,"context_line":"            ca-certificates \\"},{"line_number":47,"context_line":"            gcc \\"},{"line_number":48,"context_line":"            git-core \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5f7c97a3_63c86aa6","line":45,"updated":"2018-07-30 09:03:01.000000000","message":"the -y is redundant if you use --non-interactive. could you remove it?","commit_id":"def6c14d930a535f37a7c983ae73e73e05703916"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"fb34e6e3bbbb62f512d97a57f6cc2976004aa312","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           rpm_python_packages+\u003d(\"python3-devel\" \"python3-setuptools\")"},{"line_number":43,"context_line":"        fi"},{"line_number":44,"context_line":"        zypper --non-interactive --gpg-auto-import-keys refresh"},{"line_number":45,"context_line":"        zypper --non-interactive install -y \\"},{"line_number":46,"context_line":"            ca-certificates \\"},{"line_number":47,"context_line":"            gcc \\"},{"line_number":48,"context_line":"            git-core \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5f7c97a3_43068ece","line":45,"in_reply_to":"5f7c97a3_63c86aa6","updated":"2018-07-30 09:08:58.000000000","message":"This is still WIP.\n\nYes I will remove it.","commit_id":"def6c14d930a535f37a7c983ae73e73e05703916"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7569773daef2834aebb2c55bef551c7bebcdab1c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            sudo \\"},{"line_number":52,"context_line":"            tar \\"},{"line_number":53,"context_line":"            ${rpm_python_packages[@]}"},{"line_number":54,"context_line":"        #NOTE(evrardjp) Temporary workaround until"},{"line_number":55,"context_line":"        # https://review.openstack.org/#/c/586038/ is merged and released"},{"line_number":56,"context_line":"        sed -i \u0027s/ID\u003d\"opensuse-leap\"/ID\u003d\"opensuse\"/g\u0027 /etc/os-release"},{"line_number":57,"context_line":"        ;;"},{"line_number":58,"context_line":"    *)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_fcc28634","line":55,"range":{"start_line":54,"start_character":8,"end_line":55,"end_character":73},"updated":"2018-08-02 11:31:02.000000000","message":"add \u0027bindep\u0027 somewhere into comment so there would be no need to go to review to check what it is about?","commit_id":"5967368dd22cdc69682ee9ceacbdbe9f6cd6b156"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"53a83b7c0ef665901fb1bf727df3e9d156ed6ddc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        zypper --non-interactive --gpg-auto-import-keys refresh"},{"line_number":45,"context_line":"        zypper --non-interactive install --no-recommends \\"},{"line_number":46,"context_line":"            ca-certificates \\"},{"line_number":47,"context_line":"            gcc \\"},{"line_number":48,"context_line":"            git-core \\"},{"line_number":49,"context_line":"            lsb-release \\"},{"line_number":50,"context_line":"            patch \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5f7c97a3_1112a956","line":47,"updated":"2018-08-03 15:17:33.000000000","message":"why are you installing gcc here?","commit_id":"e5e8a056dfe64b796c55db72082fd4ec9e1973d4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2e1ce840e4b6a2c1adccb9ef1315d0fe654b6e15","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        zypper --non-interactive --gpg-auto-import-keys refresh"},{"line_number":45,"context_line":"        zypper --non-interactive install --no-recommends \\"},{"line_number":46,"context_line":"            ca-certificates \\"},{"line_number":47,"context_line":"            gcc \\"},{"line_number":48,"context_line":"            git-core \\"},{"line_number":49,"context_line":"            lsb-release \\"},{"line_number":50,"context_line":"            patch \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3f79a3b5_6dd9c881","line":47,"in_reply_to":"5f7c97a3_1112a956","updated":"2018-08-06 10:24:53.000000000","message":"good catch,it\u0027s probably not needed anymore.","commit_id":"e5e8a056dfe64b796c55db72082fd4ec9e1973d4"}],"scripts/setup_pip.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"3ff5256a7934f40d4d1e3d9fb6496df9e9bb559f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# NOTE(SamYaple): This little dance allows us to install the latest pip and"},{"line_number":12,"context_line":"# setuptools without get_pip.py or the python-pip package (which is in epel on"},{"line_number":13,"context_line":"# centos)"},{"line_number":14,"context_line":"${TMP_VIRTUALENV} --version"},{"line_number":15,"context_line":"if (( $(${TMP_VIRTUALENV} --version | cut -d. -f1) \u003e\u003d 14 )); then"},{"line_number":16,"context_line":"    SETUPTOOLS\u003d\"--no-setuptools\""},{"line_number":17,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_993d1be8","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":27},"updated":"2018-07-27 10:02:52.000000000","message":"leftover from debugging?","commit_id":"4e5491350e0545af1800ca4aa329c7da7fef2a35"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a49c6779ded22e1c0ebc24369364d47d97c14422","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# NOTE(SamYaple): This little dance allows us to install the latest pip and"},{"line_number":12,"context_line":"# setuptools without get_pip.py or the python-pip package (which is in epel on"},{"line_number":13,"context_line":"# centos)"},{"line_number":14,"context_line":"${TMP_VIRTUALENV} --version"},{"line_number":15,"context_line":"if (( $(${TMP_VIRTUALENV} --version | cut -d. -f1) \u003e\u003d 14 )); then"},{"line_number":16,"context_line":"    SETUPTOOLS\u003d\"--no-setuptools\""},{"line_number":17,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f7c97a3_f428d685","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":27},"in_reply_to":"5f7c97a3_993d1be8","updated":"2018-07-27 10:12:54.000000000","message":"yup :)","commit_id":"4e5491350e0545af1800ca4aa329c7da7fef2a35"}]}
