)]}'
{"scripts/requirements.sh":[{"author":{"_account_id":7822,"name":"Chris Hoge (not involved in upstream development)","email":"chris@hogepodge.com","username":"hogepodge"},"change_message_id":"7d5f5be2d881d42efa29339ed2e2ce5a93a21312","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# build time is huge and on !x86 we do not get binaries from Pypi."},{"line_number":31,"context_line":"egrep -v \"(scipy|scikit-learn)\" /upper-constraints.txt | split -l1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Install packages from PIP_PACKAGES prior to wheel build to be able to"},{"line_number":34,"context_line":"# control package versions specified in setup_requires, that pip has no way"},{"line_number":35,"context_line":"# to control. This allows to work around such issues as"},{"line_number":36,"context_line":"# https://github.com/lxc/pylxd/issues/308"},{"line_number":37,"context_line":"if [ ! -z \"${PIP_PACKAGES}\" ]; then"},{"line_number":38,"context_line":"  pip install -c /upper-constraints.txt ${PIP_PACKAGES}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_9fa2293f","line":35,"range":{"start_line":33,"start_character":2,"end_line":35,"end_character":55},"updated":"2018-10-19 05:00:13.000000000","message":"Can we update this comment to be a bit more clear? Something along the lines of:\n\n\"\nWhen a package uses the variable \u0027setup_requires\u0027 in \u0027setup.py\u0027, \u0027pip wheel\u0027\ndependency management will be overridden, resulting in possible incompatibilities\nbetween packages. Installing the upper-constraints.txt before building the wheels\nensures the correct package versions will be available and installed locally.\n\nhttps://pip.readthedocs.io/en/stable/user_guide/#installation-bundles\n\"\n\nAfter the wheels are built, is it possible to remove the duplicate pip installed packages to help keep the size of requirements in check?","commit_id":"1f2499cfbb6dfeadf1d3d654ff9fa77b17bd29db"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"18cdc2ac0a33e6f32ebc41a92e3fd1971f774bc2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# build time is huge and on !x86 we do not get binaries from Pypi."},{"line_number":31,"context_line":"egrep -v \"(scipy|scikit-learn)\" /upper-constraints.txt | split -l1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Install packages from PIP_PACKAGES prior to wheel build to be able to"},{"line_number":34,"context_line":"# control package versions specified in setup_requires, that pip has no way"},{"line_number":35,"context_line":"# to control. This allows to work around such issues as"},{"line_number":36,"context_line":"# https://github.com/lxc/pylxd/issues/308"},{"line_number":37,"context_line":"if [ ! -z \"${PIP_PACKAGES}\" ]; then"},{"line_number":38,"context_line":"  pip install -c /upper-constraints.txt ${PIP_PACKAGES}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_ff6233a7","line":35,"range":{"start_line":33,"start_character":2,"end_line":35,"end_character":55},"in_reply_to":"3f79a3b5_9fa2293f","updated":"2018-10-19 14:26:42.000000000","message":"Thank you so much. That sounds much better.\nRegarding package duplication, all files and directories except *.(whl|txt) are removed as a final step of this script.","commit_id":"1f2499cfbb6dfeadf1d3d654ff9fa77b17bd29db"}]}