)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"151c4ee0d7b526f4729bdb1df0a5d68d66b5e149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"735e81ee_ed5b878e","updated":"2023-08-08 08:43:50.000000000","message":"recheck","commit_id":"5fc14ac7b230bd694f21c68ae5501e00c423dd89"}],"scripts/collect_info.sh":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"95af72d84639c15c738a9657c5e180c01947f94c","unresolved":true,"context_lines":[{"line_number":33,"context_line":"git log -1 \u003e\u003e ${PROJECT_INFO}"},{"line_number":34,"context_line":"popd"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ \"${PROJECT}\" \u003d\u003d \"infra|requirements\" ]]; then"},{"line_number":37,"context_line":"    mkdirp /etc/${PROJECT}/"},{"line_number":38,"context_line":"    cp -r /var/lib/openstack/etc/${PROJECT}/* /etc/${PROJECT}/ | true"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"f776d354_df1f97b3","line":36,"updated":"2023-08-04 17:20:38.000000000","message":"I think what we looking for is \n\nif [[ ! ${PROJECT} \u003d~ \"[infra|requirements]\" ]]; then","commit_id":"6d2f601cfc734fe2f2d379393e5d0cfca007bfeb"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"3fb1a8acbfc7f174f26972235f93182a73a798a0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"git log -1 \u003e\u003e ${PROJECT_INFO}"},{"line_number":34,"context_line":"popd"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ \"${PROJECT}\" \u003d\u003d \"infra|requirements\" ]]; then"},{"line_number":37,"context_line":"    mkdirp /etc/${PROJECT}/"},{"line_number":38,"context_line":"    cp -r /var/lib/openstack/etc/${PROJECT}/* /etc/${PROJECT}/ | true"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1d9a5620_1fd0bdf5","line":36,"in_reply_to":"f776d354_df1f97b3","updated":"2023-08-07 14:48:39.000000000","message":"Done","commit_id":"6d2f601cfc734fe2f2d379393e5d0cfca007bfeb"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"b78e022370ab38ac2f8b31695c89376d74a6d42f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"popd"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ \"${PROJECT}\" \u003d\u003d \"infra|requirements\" ]]; then"},{"line_number":37,"context_line":"    mkdirp /etc/${PROJECT}/"},{"line_number":38,"context_line":"    cp -r /var/lib/openstack/etc/${PROJECT}/* /etc/${PROJECT}/ | true"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"c4b3672d_7ae3c779","line":37,"updated":"2023-08-04 16:33:31.000000000","message":"shouldn\u0027t this be `mkdir -p` ?","commit_id":"6d2f601cfc734fe2f2d379393e5d0cfca007bfeb"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"3fb1a8acbfc7f174f26972235f93182a73a798a0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"popd"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ \"${PROJECT}\" \u003d\u003d \"infra|requirements\" ]]; then"},{"line_number":37,"context_line":"    mkdirp /etc/${PROJECT}/"},{"line_number":38,"context_line":"    cp -r /var/lib/openstack/etc/${PROJECT}/* /etc/${PROJECT}/ | true"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6ff9b2e2_ea877829","line":37,"in_reply_to":"c4b3672d_7ae3c779","updated":"2023-08-07 14:48:39.000000000","message":"Done","commit_id":"6d2f601cfc734fe2f2d379393e5d0cfca007bfeb"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"7c9365a04f5d4c8afbf53465a27ffb53272df894","unresolved":true,"context_lines":[{"line_number":33,"context_line":"git log -1 \u003e\u003e ${PROJECT_INFO}"},{"line_number":34,"context_line":"popd"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ ! ${PROJECT} \u003d~ ^(infra|requirements)$ ]]; then"},{"line_number":37,"context_line":"    mkdir -p \"/etc/${PROJECT}/\""},{"line_number":38,"context_line":"    cp -r \"/var/lib/openstack/etc/${PROJECT}\"/* \"/etc/${PROJECT}/\" || true"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"e389e946_bddf5525","line":36,"updated":"2023-08-09 09:21:55.000000000","message":"IMO it should be safe to copy default files to /etc/\u003cproject\u003e. But this is not a better place to do this since this script is for collecting image info. Let\u0027s create yet another script (let say configure_packages.sh) and run it right after pip_install.sh. \n\nAlso I would definitely make it optional with some environment variable (and disabled by default) to copy default config files. This way we could enable coping default config files only for some images and only for some releases in the openstack-helm-images.","commit_id":"5fc14ac7b230bd694f21c68ae5501e00c423dd89"}]}