)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2cbcf7fad231706fef8d0ed4623ef0c80c641e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d9661f1_351a1678","updated":"2024-03-25 16:25:33.000000000","message":"This is annoying, but I think we should get this covered with a unit test please?","commit_id":"56dde2e613abf2360b88ae703a743eab8c8115b1"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"f53d931720a5b7425a373e40992b8cf0dcf3a424","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67075527_98bae3a3","in_reply_to":"4d9661f1_351a1678","updated":"2024-03-27 13:41:50.000000000","message":"Done","commit_id":"56dde2e613abf2360b88ae703a743eab8c8115b1"},{"author":{"_account_id":33467,"name":"Matt Pryor","email":"matt@stackhpc.com","username":"mkjpryor"},"change_message_id":"b792d7bdb3065641c229592549534fbf65f31f38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6f575d3_947b55cb","updated":"2024-04-04 09:50:11.000000000","message":"Just a couple of extra verification in the tests","commit_id":"ce333fa637b44f2753d74b81c7208d8e00f587d8"}],"magnum_capi_helm/tests/test_driver.py":[{"author":{"_account_id":33467,"name":"Matt Pryor","email":"matt@stackhpc.com","username":"mkjpryor"},"change_message_id":"b792d7bdb3065641c229592549534fbf65f31f38","unresolved":true,"context_lines":[{"line_number":2439,"context_line":"            )  # Default to {} so that next .get isn\u0027t called on None type"},{"line_number":2440,"context_line":"            .get(\"k8sKeystoneAuth\", {})"},{"line_number":2441,"context_line":"            .get(\"enabled\")"},{"line_number":2442,"context_line":"        )"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"    @mock.patch.object(driver.Driver, \"_get_k8s_keystone_auth_enabled\")"},{"line_number":2445,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":3,"id":"6615d7e2_9bc8b85c","line":2442,"updated":"2024-04-04 09:50:11.000000000","message":"Should we also check that the `authWebhook` is set correctly?","commit_id":"ce333fa637b44f2753d74b81c7208d8e00f587d8"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"33ad61d4a6140ddb926e4dd2332593f37fecda9a","unresolved":false,"context_lines":[{"line_number":2439,"context_line":"            )  # Default to {} so that next .get isn\u0027t called on None type"},{"line_number":2440,"context_line":"            .get(\"k8sKeystoneAuth\", {})"},{"line_number":2441,"context_line":"            .get(\"enabled\")"},{"line_number":2442,"context_line":"        )"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"    @mock.patch.object(driver.Driver, \"_get_k8s_keystone_auth_enabled\")"},{"line_number":2445,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":3,"id":"72edd80d_364084e7","line":2442,"in_reply_to":"6615d7e2_9bc8b85c","updated":"2024-04-05 08:42:47.000000000","message":"Done","commit_id":"ce333fa637b44f2753d74b81c7208d8e00f587d8"},{"author":{"_account_id":33467,"name":"Matt Pryor","email":"matt@stackhpc.com","username":"mkjpryor"},"change_message_id":"b792d7bdb3065641c229592549534fbf65f31f38","unresolved":true,"context_lines":[{"line_number":2488,"context_line":"            .get(\"openstack\", {})"},{"line_number":2489,"context_line":"            .get(\"k8sKeystoneAuth\", {})"},{"line_number":2490,"context_line":"            .get(\"enabled\")"},{"line_number":2491,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"6712d16a_3f5d00fc","line":2491,"updated":"2024-04-04 09:50:11.000000000","message":"In this case, I think the result comes out as `None` with the code as written right? Does this assert do the right thing in that case?\n\nAlso, should we verify that `authWebhook` is not set?","commit_id":"ce333fa637b44f2753d74b81c7208d8e00f587d8"},{"author":{"_account_id":33467,"name":"Matt Pryor","email":"matt@stackhpc.com","username":"mkjpryor"},"change_message_id":"8c7b8fa13c87afe9a5529b77b275c3a00a5abec2","unresolved":false,"context_lines":[{"line_number":2488,"context_line":"            .get(\"openstack\", {})"},{"line_number":2489,"context_line":"            .get(\"k8sKeystoneAuth\", {})"},{"line_number":2490,"context_line":"            .get(\"enabled\")"},{"line_number":2491,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"53d3b836_0f7329e6","line":2491,"in_reply_to":"1f0c02b4_72202397","updated":"2024-04-05 15:10:08.000000000","message":"Done","commit_id":"ce333fa637b44f2753d74b81c7208d8e00f587d8"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"33ad61d4a6140ddb926e4dd2332593f37fecda9a","unresolved":true,"context_lines":[{"line_number":2488,"context_line":"            .get(\"openstack\", {})"},{"line_number":2489,"context_line":"            .get(\"k8sKeystoneAuth\", {})"},{"line_number":2490,"context_line":"            .get(\"enabled\")"},{"line_number":2491,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f0c02b4_72202397","line":2491,"in_reply_to":"6712d16a_3f5d00fc","updated":"2024-04-05 08:42:47.000000000","message":"Yes I think it does because the Helm values for the Keystone webhook are omitted if the label is False so we cannot use assertEqual(..., False) here unless we change the driver code to explicitly set addons.openstack.k8sKeystoneAuth.enabled \u003d False.\n\nGood point on the authWebhook check though, I\u0027ve added that.","commit_id":"ce333fa637b44f2753d74b81c7208d8e00f587d8"}]}