)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8fd2e4745ac89b65fc70dd12342a982f1455c168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"deb1ab26_7e9592f3","updated":"2024-04-16 10:49:58.000000000","message":"Please also add the option to disable health checks to match","commit_id":"cb2494977333f98d64f9a5a00189695f61c50a52"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"a779017029dab8f8f7d47095ee5a2e4b3e251fe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dbfc61ba_c382a97d","in_reply_to":"deb1ab26_7e9592f3","updated":"2024-04-16 15:23:28.000000000","message":"Done","commit_id":"cb2494977333f98d64f9a5a00189695f61c50a52"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"cf20f5877c45ff76ee95b22934ec0242dd19adcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b5a2b80_678c52c2","updated":"2024-05-06 06:37:13.000000000","message":"-1 for visibility","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"dafdbd88d6b7a7be88961f89e1332cad409b0e26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c69e6028_2dea170f","updated":"2024-04-29 14:01:05.000000000","message":"Thanks for the change! Just some minor comments to avoid maintenance for future us.","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"}],"magnum_capi_helm/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0ddb03c13313064872bc13dfc607009231c2f5e1","unresolved":true,"context_lines":[{"line_number":654,"context_line":"    def _get_octavia_lb_algorithm(self, cluster):"},{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            return \"ROUND_ROBIN\""},{"line_number":658,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def _get_allowed_cidrs(self, cluster):"}],"source_content_type":"text/x-python","patch_set":2,"id":"276d26bc_5f30448d","line":657,"updated":"2024-04-16 08:48:56.000000000","message":"This needs to be source ip port I think?","commit_id":"cb2494977333f98d64f9a5a00189695f61c50a52"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"a779017029dab8f8f7d47095ee5a2e4b3e251fe9","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    def _get_octavia_lb_algorithm(self, cluster):"},{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            return \"ROUND_ROBIN\""},{"line_number":658,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def _get_allowed_cidrs(self, cluster):"}],"source_content_type":"text/x-python","patch_set":2,"id":"61041be2_fee5f8c1","line":657,"in_reply_to":"276d26bc_5f30448d","updated":"2024-04-16 15:23:28.000000000","message":"Done","commit_id":"cb2494977333f98d64f9a5a00189695f61c50a52"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b7be84f758e2dcc7932563eba1d2400bf595992e","unresolved":true,"context_lines":[{"line_number":654,"context_line":"    def _get_octavia_lb_algorithm(self, cluster):"},{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            # OVN only supports one algorithm"},{"line_number":658,"context_line":"            return \"SOURCE_IP_PORT\""},{"line_number":659,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":660,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dbab39de_972a4658","line":657,"range":{"start_line":657,"start_character":12,"end_line":657,"end_character":14},"updated":"2024-04-16 15:28:43.000000000","message":"we usually use # NOTE(somebody): something or at least # NOTE: something","commit_id":"e19c32df575403017ed9566d400a8b11b7e7ce3f"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"7027c2dcc201852447b4c589086509ea514ca746","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    def _get_octavia_lb_algorithm(self, cluster):"},{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            # OVN only supports one algorithm"},{"line_number":658,"context_line":"            return \"SOURCE_IP_PORT\""},{"line_number":659,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":660,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ac02a668_5269bab6","line":657,"range":{"start_line":657,"start_character":12,"end_line":657,"end_character":14},"in_reply_to":"dbab39de_972a4658","updated":"2024-04-18 12:52:10.000000000","message":"Done","commit_id":"e19c32df575403017ed9566d400a8b11b7e7ce3f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"dafdbd88d6b7a7be88961f89e1332cad409b0e26","unresolved":true,"context_lines":[{"line_number":649,"context_line":"        )"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def _get_octavia_provider(self, cluster):"},{"line_number":652,"context_line":"        return self._label(cluster, \"octavia_provider\", \"amphora\").lower()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_octavia_lb_algorithm(self, cluster):"},{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"}],"source_content_type":"text/x-python","patch_set":4,"id":"23909890_49d59bc2","line":652,"range":{"start_line":652,"start_character":67,"end_line":652,"end_character":72},"updated":"2024-04-29 14:01:05.000000000","message":"is there a reason to do this? e.g. some deployment tool using `OVN` instead of `ovn` and cannot be changed?","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"ca1f405609d8cbb1d9fe7209a1fb9bf059331af3","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        )"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def _get_octavia_provider(self, cluster):"},{"line_number":652,"context_line":"        return self._label(cluster, \"octavia_provider\", \"amphora\").lower()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_octavia_lb_algorithm(self, cluster):"},{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ca37d29_904389a2","line":652,"range":{"start_line":652,"start_character":67,"end_line":652,"end_character":72},"in_reply_to":"23909890_49d59bc2","updated":"2024-05-13 09:03:48.000000000","message":"Thanks for the feedback. I agree that it probably makes sense to allow `OVN` here too.","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"dafdbd88d6b7a7be88961f89e1332cad409b0e26","unresolved":true,"context_lines":[{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            # NOTE(scott): OVN only supports one algorithm"},{"line_number":658,"context_line":"            return \"SOURCE_IP_PORT\""},{"line_number":659,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def _get_allowed_cidrs(self, cluster):"}],"source_content_type":"text/x-python","patch_set":4,"id":"8f4936a0_e7073990","line":658,"updated":"2024-04-29 14:01:05.000000000","message":"I think we should just let the user provide both the provider and algorithm if they want to use OVN. That is the current case with the Heat driver, and also the current case with Octavia.\n\nI am aiming to get the driver as thin as possible, so we do not have to maintain this code when upstream changes (e.g. ovn-octavia supporting other algo, or Octavia setting this for us automagically)","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"},{"author":{"_account_id":33467,"name":"Matt Pryor","email":"matt@stackhpc.com","username":"mkjpryor"},"change_message_id":"5b43c177c59155210a7e0ae76d6ac455e32e7fbd","unresolved":true,"context_lines":[{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            # NOTE(scott): OVN only supports one algorithm"},{"line_number":658,"context_line":"            return \"SOURCE_IP_PORT\""},{"line_number":659,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def _get_allowed_cidrs(self, cluster):"}],"source_content_type":"text/x-python","patch_set":4,"id":"57f06fbd_b49b29c2","line":658,"in_reply_to":"2d1d4a18_f01a4955","updated":"2024-05-15 09:57:48.000000000","message":"Personally, I prefer that the driver does something that works by default - principle of least surprise.\n\nIf a user specified the OVN driver but left the LB algorithm as ROUND_ROBIN, it just wouldn\u0027t work, and would additionally be quite difficult to debug from the user side I think (i.e. without access to the Magnum logs).","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"ca1f405609d8cbb1d9fe7209a1fb9bf059331af3","unresolved":true,"context_lines":[{"line_number":655,"context_line":"        provider \u003d self._get_octavia_provider(cluster)"},{"line_number":656,"context_line":"        if provider \u003d\u003d \"ovn\":"},{"line_number":657,"context_line":"            # NOTE(scott): OVN only supports one algorithm"},{"line_number":658,"context_line":"            return \"SOURCE_IP_PORT\""},{"line_number":659,"context_line":"        return self._label(cluster, \"octavia_lb_algorithm\", \"ROUND_ROBIN\")"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def _get_allowed_cidrs(self, cluster):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2d1d4a18_f01a4955","line":658,"in_reply_to":"8f4936a0_e7073990","updated":"2024-05-13 09:03:48.000000000","message":"What you say regarding the thinness of the driver makes sense. I do still think that it\u0027s better to do the right think automatically if possible so have changed the code so that the default label is selected automatically based on the driver but the user can still override it by supplying the label. This way it should still satisfy the desire to reduce maintenance burden (unless OVN removed support for SOURCE_IP_PORT) but if you feel strongly about this then I am happy to revert the change and just default to ROUND_ROBIN always.","commit_id":"63d281e6749a07fe636603ae53e0e4f0e5fbfc9c"}]}