)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"db51240436be0343a2b62b2db4406e62efe6658d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Magnum supports control plane resizing as of:"},{"line_number":10,"context_line":"* https://review.opendev.org/c/openstack/magnum-specs/+/905281"},{"line_number":11,"context_line":"* https://review.opendev.org/c/openstack/magnum/+/906086"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds the driver functions that support this, and explicitly"},{"line_number":14,"context_line":"specifies a list of allowed sizes for create and resize."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7d1c51b3_f3ee23bb","line":11,"updated":"2024-06-13 12:58:33.000000000","message":"Should that be in Depends-On?","commit_id":"4f9a7cae479d221a7febc3da4297a2e13bc142b9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4f76febe2d2a524ec1b8196a1f83073286a33441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44188527_36aab885","updated":"2024-05-28 10:24:23.000000000","message":"I think this looks OK, but it would be good to get it unit tested please (and passing the pep8 checks).","commit_id":"4f9a7cae479d221a7febc3da4297a2e13bc142b9"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"07c826bb57ded984a1749ecc2a1190e138d9c2e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77e759f3_4d3fcaec","in_reply_to":"44188527_36aab885","updated":"2024-05-29 02:25:11.000000000","message":"Yes good points, I\u0027ll address these.","commit_id":"4f9a7cae479d221a7febc3da4297a2e13bc142b9"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"362ea60dd363f5fcac9fb033a2c3e598baacb505","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"767b1911_ffd86ec1","in_reply_to":"77e759f3_4d3fcaec","updated":"2024-05-29 02:28:31.000000000","message":"Oops - I inadvertently marked this as resolved.","commit_id":"4f9a7cae479d221a7febc3da4297a2e13bc142b9"}],"magnum_capi_helm/driver.py":[{"author":{"_account_id":35572,"name":"Pawel Kubica","email":"pawel.kubica@comarch.com","username":"pawcykca"},"change_message_id":"37c2cb177ac4e4466437e8bc4a8cfacfe2b7f3d3","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        # CAPI supports control plane resizes to low uneven numbers."},{"line_number":77,"context_line":"        return [1, 3, 5, 7]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def validate_master_resize(self, node_count):"},{"line_number":80,"context_line":"        if node_count not in self.allowed_control_plane_sizes:"},{"line_number":81,"context_line":"            raise exception.MasterNGResizeSizeNotSupported("},{"line_number":82,"context_line":"                requested_size\u003dnode_count,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b00f7ea_34eeef88","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":49},"updated":"2024-05-28 11:25:50.000000000","message":"Where do you use this new function?","commit_id":"4f9a7cae479d221a7febc3da4297a2e13bc142b9"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"07c826bb57ded984a1749ecc2a1190e138d9c2e2","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        # CAPI supports control plane resizes to low uneven numbers."},{"line_number":77,"context_line":"        return [1, 3, 5, 7]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def validate_master_resize(self, node_count):"},{"line_number":80,"context_line":"        if node_count not in self.allowed_control_plane_sizes:"},{"line_number":81,"context_line":"            raise exception.MasterNGResizeSizeNotSupported("},{"line_number":82,"context_line":"                requested_size\u003dnode_count,"}],"source_content_type":"text/x-python","patch_set":1,"id":"66780143_67b3283a","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":49},"in_reply_to":"5b00f7ea_34eeef88","updated":"2024-05-29 02:25:11.000000000","message":"This is a (proposed) new function in the base driver class. It is not yet merged into Magnum master. The base class implementation does not support resizing, so here we override it to allow the action within the bounds.  https://review.opendev.org/c/openstack/magnum/+/906086/5/magnum/drivers/common/driver.py#233\n\nThe actual (proposed) usage of this function within Magnum is in `cluster_actions.py`\nhttps://review.opendev.org/c/openstack/magnum/+/906086/5/magnum/api/controllers/v1/cluster_actions.py#133\n\nThis patchset in magnum-capi-helm can not merge until https://review.opendev.org/c/openstack/magnum/+/906086 does. I will add the \u0027depends on\u0027 to the commit message.","commit_id":"4f9a7cae479d221a7febc3da4297a2e13bc142b9"}]}