)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9133496e3f6c6e3718054e44615a68791f32d023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5101fe24_763095d3","updated":"2024-05-28 09:01:04.000000000","message":"OK, this looks good, but lets add a reno note please.","commit_id":"1eb2b03bede56365429e24448c6427de679bc9cf"},{"author":{"_account_id":33467,"name":"Matt Pryor","email":"matt@stackhpc.com","username":"mkjpryor"},"change_message_id":"925f83d76467b0de36180a832cf36dc5c62320df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c785f77_143d70f0","updated":"2024-05-28 10:19:34.000000000","message":"Looks good to me. Nice work.","commit_id":"2300100462ae5ebecd6f315100bb48b4ac6eabde"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cdda069bda785f47beed805890fab39cae1dd049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9810db0a_a6822a90","updated":"2024-05-28 10:06:24.000000000","message":"Thank you, that reno looks good to me.","commit_id":"2300100462ae5ebecd6f315100bb48b4ac6eabde"}],"magnum_capi_helm/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9133496e3f6c6e3718054e44615a68791f32d023","unresolved":true,"context_lines":[{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        # If min/max node counts are not defined on the default"},{"line_number":649,"context_line":"        # worker group then fall back to equivalent cluster labels"},{"line_number":650,"context_line":"        if self._is_default_worker_nodegroup(cluster, nodegroup):"},{"line_number":651,"context_line":"            # Magnum seems to set min_node_count \u003d 1 on default group"},{"line_number":652,"context_line":"            # but we still want to be able to override that with labels"},{"line_number":653,"context_line":"            if min_nodes is None or min_nodes \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc574fec_b874c472","line":650,"updated":"2024-05-28 09:01:04.000000000","message":"This is the fix I would like here, along with the","commit_id":"1eb2b03bede56365429e24448c6427de679bc9cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cdda069bda785f47beed805890fab39cae1dd049","unresolved":false,"context_lines":[{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        # If min/max node counts are not defined on the default"},{"line_number":649,"context_line":"        # worker group then fall back to equivalent cluster labels"},{"line_number":650,"context_line":"        if self._is_default_worker_nodegroup(cluster, nodegroup):"},{"line_number":651,"context_line":"            # Magnum seems to set min_node_count \u003d 1 on default group"},{"line_number":652,"context_line":"            # but we still want to be able to override that with labels"},{"line_number":653,"context_line":"            if min_nodes is None or min_nodes \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6c526e5_abc9ca51","line":650,"in_reply_to":"dc574fec_b874c472","updated":"2024-05-28 10:06:24.000000000","message":"Acknowledged","commit_id":"1eb2b03bede56365429e24448c6427de679bc9cf"}]}
