)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"571817ec75c257c04f2008b18958058d7e8252e7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve default min/max node count behaviour when autoscaling is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes an issue where creating a cluster with the 2 or more nodes in the default worker group and with `auto_scaling_enabled\u003dtrue` but with neither `{min,max}_node_count` labels set would lead to a situation where the default worker group would only have 1 node instead of 2. The reason for this seems to be that the `min_node_count` and `max_node_count` values which are passed through to CAPI take priority over the initial `node_count` field and the min count currently defaults to 1. In these cases, I think the expected user behaviour is to have `node_count` \u003d\u003d `min_node_count` \u003d\u003d `max_node_count` and for autoscaling to be disabled on the default node group."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I65e65bf64c97cf5ab659d6d7d158c32692a63348"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f0516d40_a3100909","line":9,"updated":"2024-07-15 07:22:21.000000000","message":"can you wrap at 72 characters? and maybe and a newline somewhere, so it\u0027s readable? ;-)","commit_id":"57f888bb3b0f474ebd931b976fe38992042e9520"},{"author":{"_account_id":36412,"name":"Scott Davidson","email":"sdavidson327@gmail.com","username":"sd109"},"change_message_id":"9edb1417d4cab7c35f2c171c131cddc40e97c0ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve default min/max node count behaviour when autoscaling is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes an issue where creating a cluster with the 2 or more nodes in the default worker group and with `auto_scaling_enabled\u003dtrue` but with neither `{min,max}_node_count` labels set would lead to a situation where the default worker group would only have 1 node instead of 2. The reason for this seems to be that the `min_node_count` and `max_node_count` values which are passed through to CAPI take priority over the initial `node_count` field and the min count currently defaults to 1. In these cases, I think the expected user behaviour is to have `node_count` \u003d\u003d `min_node_count` \u003d\u003d `max_node_count` and for autoscaling to be disabled on the default node group."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I65e65bf64c97cf5ab659d6d7d158c32692a63348"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f87c143b_477d2453","line":9,"in_reply_to":"f0516d40_a3100909","updated":"2024-07-16 15:52:51.000000000","message":"Done","commit_id":"57f888bb3b0f474ebd931b976fe38992042e9520"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b1e5d8f6948fe12224c8e8722d8c4ebac9ca13f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"408f79d9_ceea7415","updated":"2024-07-30 16:27:12.000000000","message":"OK, this looks good.\n\nIt would be nice to add a release note here, although I guess its more of a bug fix, so not a blocker.","commit_id":"e7ec3b08f4f62745efa085d72e619ca200e48ec2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"22313c96bfb6915018b1b2c90dae2ab010cd2b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"afde1b8c_46567fad","updated":"2024-08-01 16:10:46.000000000","message":"This looks good.\n\nGoing to re-approve given the trivial changes made to this here.","commit_id":"318b1269ef5ae77819121b70978a6a0a917ac7a1"}]}