)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"96ed18a7bc355c0b95e3904b1e45a785c60330f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa60f3ef_6c939216","updated":"2025-04-07 00:33:43.000000000","message":"In Magnum `labels` are an extension of fields/properties on an object (ClusterTemplate, Cluster, NodeGroup), and allow extra configuration for a driver. A better name for these would be \"driver configuration\".\n\nIn Kubernetes `labels` are used by selectors and are expected to accept arbitrary values[1].\n\nI think this patchset has good intentions and a good use case but it takes Magnum driver configuration values and shoves it all into the Kubernetes Node as labels. I feel we **must** separate the two.\n\nI would really like to clean up our use of \"labels\" in Magnum, and allow arbitrary Kubernetes labels to end up on the target nodes. So I\u0027m keen to hear more - this is a good topic for the vPTG this week.\n\nThis patchset also conflicts with my Label Normalisation spec[1] as the spec proposes a much tighter limit on acceptable labels, and this patchset implies arbitrary labels would be possible, so please add any feedback there, too!\n\nHow do you think Magnum, and the Magnum-CAPI driver should proceed here?\n\n[1] https://kubernetes.io/docs/reference/node/node-labels/\n[2] https://review.opendev.org/c/openstack/magnum-specs/+/943358","commit_id":"b5daafe2ff7f2fa0fa41c409fd88da0644e13d42"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"66977488c00b860aea965a608c14550d92c1f822","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad7a3cc1_7492f078","in_reply_to":"aa60f3ef_6c939216","updated":"2025-04-07 00:34:59.000000000","message":"Marking comment as unresolved.","commit_id":"b5daafe2ff7f2fa0fa41c409fd88da0644e13d42"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"5b1f389a352c854e3f00282db33501c0c8c1ee73","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e436fde8_06fc6711","in_reply_to":"ad7a3cc1_7492f078","updated":"2025-04-07 00:40:39.000000000","message":"Magnum label definition in existing docs: https://docs.openstack.org/magnum/latest/user/index.html#labels\n\nA better link for Kubernetes labels is https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/","commit_id":"b5daafe2ff7f2fa0fa41c409fd88da0644e13d42"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"4127af17c03ba760aec1ea9e91ee70b8724e04e9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e922db51_b68982b7","in_reply_to":"e436fde8_06fc6711","updated":"2025-04-07 15:16:22.000000000","message":"A good topic for discussion tomorrow on PTG :)","commit_id":"b5daafe2ff7f2fa0fa41c409fd88da0644e13d42"}]}