)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"85e9ec359a7d674bbacd5076e1122d9895e112ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d4b072a_f91e5458","updated":"2025-06-10 09:11:14.000000000","message":"I was hoping on a simple approach to unblock people quickly.\n\nI should update the commit message on the risks here, certainly you can break existing clusters with this config.\n\nI did wonder about caching the conf on cluster create, but this may depend on core magnum changes, unless I can find someone odd to put the details. ideas welcome!","commit_id":"cf1f88d4cbec27b3d184052c96fb8fa2cca96804"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"a028c50e4879cf15c701ba37db884af313d004c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3931fdb_afd79720","updated":"2025-06-10 21:35:45.000000000","message":"Some discussion on this feature in Magnum meeting: https://meetings.opendev.org/meetings/magnum/2025/magnum.2025-06-10-08.00.log.html#l-30","commit_id":"cf1f88d4cbec27b3d184052c96fb8fa2cca96804"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"53816ebe875abe7a14fdb5da7748adba2f628e78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aef7807f_0bfcc672","updated":"2025-08-05 13:46:21.000000000","message":"I have not tested this, but I would very much something like this to be merged. Right now I\u0027m forking/patching the helm chart to avoid conflicts with my network setup.","commit_id":"25ffe4ab89b18a6142b2d6881314df498db30691"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"397a47edf18dc28612e1b38bf75387bfd5125d05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13324078_fde2126b","updated":"2025-06-18 00:00:58.000000000","message":"I need to spend some time with this to test and understand it fully before +2, but want to signal my support for the updated approach.\n\nIt has the flexibility needed to allow versioning and controlled updates during upgrades, which was my previous concern.","commit_id":"25ffe4ab89b18a6142b2d6881314df498db30691"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"1d1ce36ad57ab736d4035a0809ab1729abaf7c84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f87e18e_881eb6c5","in_reply_to":"aef7807f_0bfcc672","updated":"2025-08-06 16:13:23.000000000","message":"which configs are you overriding?","commit_id":"25ffe4ab89b18a6142b2d6881314df498db30691"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"eca052eeb4be97bf9cd8684931e91e473dbad2b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"002e2588_17567e5a","updated":"2025-08-19 02:30:33.000000000","message":"Tested and this works well to override chart images with our local OCI mirror without forking the entire chart.\n\nOne request for better config docs and I\u0027ll upgrade to +2.","commit_id":"61a77845c9ca431e58f042bb6c611a564819fa91"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"78938b4d2fdb86b978abd3c3f7559581a34caa49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb7d41ba_ef4344b7","in_reply_to":"002e2588_17567e5a","updated":"2025-11-12 14:41:48.000000000","message":"Hi @dale@catalystcloud.nz I have added suggested changes, can we push this forward?","commit_id":"61a77845c9ca431e58f042bb6c611a564819fa91"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"a76b9e56999025370032cbe91d3750b34de90c8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e05fc2e4_c95b2aac","updated":"2025-12-31 09:52:23.000000000","message":"recheck","commit_id":"cfa76518555a67e65e6feba80659e4c7c2ddf5c6"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"63ae77c9a86b022257e392c408a732dbb96a4dda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0f56814b_720f9b1e","updated":"2025-12-31 10:58:54.000000000","message":"recheck","commit_id":"569da8ad694b444334ac3f66a699c1a3a11f741d"}],"magnum_capi_helm/conf.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"eca052eeb4be97bf9cd8684931e91e473dbad2b8","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            \"Take care to not break existing clusters that may already \""},{"line_number":74,"context_line":"            \"be using the configured labels.\""},{"line_number":75,"context_line":"            \"If configure the label \u0027all\u0027 those values will be applied \""},{"line_number":76,"context_line":"            \"to all clusters.\""},{"line_number":77,"context_line":"        ),"},{"line_number":78,"context_line":"    ),"},{"line_number":79,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":4,"id":"81b054f2_d4d5106e","line":76,"updated":"2025-08-19 02:30:33.000000000","message":"The docs in the commit message are helpful, but this config help text is less clear about how to format the configuration option.\n\nCould this be improved? Are there additional docs that need adding to help use of this new config?\n\nSuggest adding something like:\n\"A comma separated key:value list where the key corresponds to the label \u0027helm_value_override_files\u0027 on cluster templates, and the key \u0027all\u0027 is applied to all clusters. The value must be a filename of a yaml values file that is used as overrides to the helm chart.\"\n\"This can be useful to apply operator customisations to helm charts without modifying and publishing the entire chart. Take care to not break existing clusters that may already be using the configured labels.\"","commit_id":"61a77845c9ca431e58f042bb6c611a564819fa91"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"76d602940b4759aac5b0043c8e08a0957b28ada3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \"Take care to not break existing clusters that may already \""},{"line_number":74,"context_line":"            \"be using the configured labels.\""},{"line_number":75,"context_line":"            \"If configure the label \u0027all\u0027 those values will be applied \""},{"line_number":76,"context_line":"            \"to all clusters.\""},{"line_number":77,"context_line":"        ),"},{"line_number":78,"context_line":"    ),"},{"line_number":79,"context_line":"    cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":4,"id":"4a56ebd5_097042b6","line":76,"in_reply_to":"81b054f2_d4d5106e","updated":"2025-11-12 14:34:38.000000000","message":"I have added suggested changes with small alteration.","commit_id":"61a77845c9ca431e58f042bb6c611a564819fa91"}],"magnum_capi_helm/driver.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8f70eb5c77b23f802ebbd5f81527373552baa759","unresolved":true,"context_lines":[{"line_number":891,"context_line":"        # always check to see if \"all\" has been configured"},{"line_number":892,"context_line":"        values \u003d {}"},{"line_number":893,"context_line":"        if \"all\" in CONF.capi_helm.helm_value_override_files:"},{"line_number":894,"context_line":"            values \u003d self._load_yaml_from_file("},{"line_number":895,"context_line":"                CONF.capi_helm.helm_value_override_files[\"all\"]"},{"line_number":896,"context_line":"            )"},{"line_number":897,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d55d0921_5d63ab71","line":894,"updated":"2025-11-13 06:40:37.000000000","message":"With my Kolla hat on - I don’t like the approach of a lot of files that need to be copied in… Any alternative?","commit_id":"146fce5b885f2458ad0b8919b36ede5e1f600c5a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6e4f73bfe84decdbd51650aaff04e3095ecfd7cd","unresolved":true,"context_lines":[{"line_number":891,"context_line":"        # always check to see if \"all\" has been configured"},{"line_number":892,"context_line":"        values \u003d {}"},{"line_number":893,"context_line":"        if \"all\" in CONF.capi_helm.helm_value_override_files:"},{"line_number":894,"context_line":"            values \u003d self._load_yaml_from_file("},{"line_number":895,"context_line":"                CONF.capi_helm.helm_value_override_files[\"all\"]"},{"line_number":896,"context_line":"            )"},{"line_number":897,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a36ed050_da9b5cd9","line":894,"in_reply_to":"d55d0921_5d63ab71","updated":"2025-11-14 14:28:16.000000000","message":"We could have one file, with an index into the top level?\n\nOpen to ideas, this seemed the simplest.","commit_id":"146fce5b885f2458ad0b8919b36ede5e1f600c5a"}],"releasenotes/notes/add-helm-value-overrides-file-f82bc177d5672783.yaml":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"eca052eeb4be97bf9cd8684931e91e473dbad2b8","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added `CONF.capi_helm.helm_value_override_files` to allow magnum"},{"line_number":5,"context_line":"    operators to add additional helm values to all clusters, based"},{"line_number":6,"context_line":"    on labels added to that cluster, alongside option to specify"},{"line_number":7,"context_line":"    `all` which applies to all clusters."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ceb8657_52028c52","line":6,"updated":"2025-08-19 02:30:33.000000000","message":"s/cluster/cluster template/","commit_id":"61a77845c9ca431e58f042bb6c611a564819fa91"},{"author":{"_account_id":34213,"name":"Grzegorz Bialas","display_name":"Grzegorz Bialas","email":"grzegorz@stackhpc.com","username":"gbialas"},"change_message_id":"76d602940b4759aac5b0043c8e08a0957b28ada3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added `CONF.capi_helm.helm_value_override_files` to allow magnum"},{"line_number":5,"context_line":"    operators to add additional helm values to all clusters, based"},{"line_number":6,"context_line":"    on labels added to that cluster, alongside option to specify"},{"line_number":7,"context_line":"    `all` which applies to all clusters."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"089216af_5d4bcb06","line":6,"in_reply_to":"3ceb8657_52028c52","updated":"2025-11-12 14:34:38.000000000","message":"Done","commit_id":"61a77845c9ca431e58f042bb6c611a564819fa91"}]}