)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38122,"name":"Jasleen","display_name":"Jasleen Kaur","email":"jasleen@stackhpc.com","username":"JasleenKaur"},"change_message_id":"419299f58f2c5dccde90c3764a28ee937a92b384","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07894ebe_61d1e044","updated":"2025-07-02 13:47:47.000000000","message":"TODO: Unittests and release notes","commit_id":"af43a1e1c8d8c389ebbceaec9bf3aa81c0c3fee8"},{"author":{"_account_id":38122,"name":"Jasleen","display_name":"Jasleen Kaur","email":"jasleen@stackhpc.com","username":"JasleenKaur"},"change_message_id":"5e9e54b32563d020d4d0d7e64f7c4d13a79316a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21d18999_5dd33c2a","in_reply_to":"07894ebe_61d1e044","updated":"2025-07-03 12:42:00.000000000","message":"Release notes and unittests added","commit_id":"af43a1e1c8d8c389ebbceaec9bf3aa81c0c3fee8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3a3b757a1c8b55fb7e47230f7575849e42e43627","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a850977_262568ad","updated":"2025-07-11 13:52:32.000000000","message":"Missing docs on what types of authentication do we support","commit_id":"f6af84fc3f7fe8832bdeb7c87e430c745ae95220"},{"author":{"_account_id":38122,"name":"Jasleen","display_name":"Jasleen Kaur","email":"jasleen@stackhpc.com","username":"JasleenKaur"},"change_message_id":"8b04958a0e22fc3fb20aaf8ecf83a7b0e36562d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4ca97928_4df8ef63","in_reply_to":"9a850977_262568ad","updated":"2025-07-14 10:16:40.000000000","message":"Done","commit_id":"f6af84fc3f7fe8832bdeb7c87e430c745ae95220"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7d2e4037eb0ecc8fdb72aeaa57f7d9b8ef49fa24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"385c7372_65c14ded","updated":"2025-07-14 12:34:52.000000000","message":"LGTM, thanks Jasleen!","commit_id":"6bbaf653c3b96020a1137c3d60a46237585f7614"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"161823bba04a62a80cf503bc5e31e319dbe228ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4db9b322_be98bdaa","updated":"2025-07-20 21:36:14.000000000","message":"Looks good, thank you Jasleen","commit_id":"ff7a57ceaf1bd96b16ed1bbece19cf5755bc2b7b"}],"doc/source/install/index.rst":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da425dc81ae4ee4eaf9997c9ccfc2cbd976caebe","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  [capi_helm]"},{"line_number":28,"context_line":"  kubeconfig_file \u003d /etc/magnum/kubeconfig"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"We currently support two authentication methods to access"},{"line_number":31,"context_line":"the Cluster API management cluster:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- Certificate-Based Authentication:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c5dcb86e_5796f8c3","line":30,"updated":"2025-07-14 11:39:21.000000000","message":"I think it would look better in a note - see https://145c848ab8b40afe5c57-498f1015c47ee06cc2525a14ef8131d8.ssl.cf1.rackcdn.com/openstack/fde1beec3158421e8c9f7c9f4bffdb21/docs/install/index.html for rendered output","commit_id":"bd16779ed1932cb358283245910cbff42474d421"},{"author":{"_account_id":38122,"name":"Jasleen","display_name":"Jasleen Kaur","email":"jasleen@stackhpc.com","username":"JasleenKaur"},"change_message_id":"73c5b5a51200847d424b8db05993c181a275d533","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  [capi_helm]"},{"line_number":28,"context_line":"  kubeconfig_file \u003d /etc/magnum/kubeconfig"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"We currently support two authentication methods to access"},{"line_number":31,"context_line":"the Cluster API management cluster:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- Certificate-Based Authentication:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d1ab8b56_c55197e3","line":30,"in_reply_to":"c5dcb86e_5796f8c3","updated":"2025-07-14 12:29:04.000000000","message":"Done","commit_id":"bd16779ed1932cb358283245910cbff42474d421"},{"author":{"_account_id":38122,"name":"Jasleen","display_name":"Jasleen Kaur","email":"jasleen@stackhpc.com","username":"JasleenKaur"},"change_message_id":"73c5b5a51200847d424b8db05993c181a275d533","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  [capi_helm]"},{"line_number":28,"context_line":"  kubeconfig_file \u003d /etc/magnum/kubeconfig"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"We currently support two authentication methods to access"},{"line_number":31,"context_line":"the Cluster API management cluster:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- Certificate-Based Authentication:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dab3e781_5219a790","line":30,"in_reply_to":"c5dcb86e_5796f8c3","updated":"2025-07-14 12:29:04.000000000","message":"Done","commit_id":"bd16779ed1932cb358283245910cbff42474d421"}],"magnum_capi_helm/kubernetes.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"52badad61f20c425d0d3f215ecf83cfae4c61a94","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":"        client_key, cleanup_file_key \u003d ensure_file_cert(user, \"client-key\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if client_cert and client_key:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if cleanup_file and client_cert:"},{"line_number":87,"context_line":"                self._tempfiles.append(client_cert)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4c6fe210_0e0298e0","line":84,"updated":"2025-07-16 04:23:52.000000000","message":"There\u0027s an (unlikely) edge case here when only one of `client-key` or `client-certificate` exist then there will be leaking temporary files created by this class.\n\nI think the `ensure_file_cert` function should move inside this class and add the cleanup to `self._tempfiles` instead of returning the \"cleanup please\" boolean. It\u0027s currently more complicated than needed.\n\nHaving said that, the edge case is unlikely to be hit with most common kubeconfig files. I\u0027m happy to approve this patchset and do this small refactor separately.","commit_id":"6bbaf653c3b96020a1137c3d60a46237585f7614"},{"author":{"_account_id":38122,"name":"Jasleen","display_name":"Jasleen Kaur","email":"jasleen@stackhpc.com","username":"JasleenKaur"},"change_message_id":"85cfcb4c70f40c898da33862b271e33a7215836b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":"        client_key, cleanup_file_key \u003d ensure_file_cert(user, \"client-key\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if client_cert and client_key:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if cleanup_file and client_cert:"},{"line_number":87,"context_line":"                self._tempfiles.append(client_cert)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e73786d7_d4427c4a","line":84,"in_reply_to":"4c6fe210_0e0298e0","updated":"2025-07-18 14:02:57.000000000","message":"Made the required changes to add the `ensure_file_cert` function inside the class. The `self._tempfiles` are now appended in the function itself rather than using a boolean outside the class.","commit_id":"6bbaf653c3b96020a1137c3d60a46237585f7614"}]}