)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"4c42e7a79a8934c34fb0ec20d79555ccbe82c83d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4066edc0_299cf38c","updated":"2025-10-14 07:36:46.000000000","message":"This looks functional and my comments are largely cosmetic code style.\n\nWe should consider how magnum-capi-helm approaches the release notes for this, given it\u0027s not implemented in the capo helm charts.","commit_id":"81b6d7b53024c46099a861ba795f30bda5016df0"}],"magnum_capi_helm/driver.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"4c42e7a79a8934c34fb0ec20d79555ccbe82c83d","unresolved":true,"context_lines":[{"line_number":899,"context_line":"            ]"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        if not cidrs:"},{"line_number":902,"context_line":"            cidrs \u003d [fixed_subnet_cidr]"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        return cidrs"},{"line_number":905,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9557a11f_1c67aee5","line":902,"updated":"2025-10-14 07:36:46.000000000","message":"This should probably be an early return if `network_id` or `subnet_id` are None, rather than if the subnet lookup gave no results.","commit_id":"81b6d7b53024c46099a861ba795f30bda5016df0"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"4c42e7a79a8934c34fb0ec20d79555ccbe82c83d","unresolved":true,"context_lines":[{"line_number":904,"context_line":"        return cidrs"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    def _get_proxy_settings("},{"line_number":907,"context_line":"        self, context, cluster, network_id, subnet_id, fixed_subnet_cidr"},{"line_number":908,"context_line":"    ):"},{"line_number":909,"context_line":"        proxy \u003d {}"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"52e87266_0c24ba80","line":907,"updated":"2025-10-14 07:36:46.000000000","message":"Could we simplify the responsibility and improve readability of this function by removing `network_id`, `subnet_id` and `fixed_subnet_cidr` parameters and replacing them with already calculated `subnet_cidrs`?","commit_id":"81b6d7b53024c46099a861ba795f30bda5016df0"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"4c42e7a79a8934c34fb0ec20d79555ccbe82c83d","unresolved":true,"context_lines":[{"line_number":915,"context_line":"            proxy[\"httpsProxy\"] \u003d cluster.cluster_template.https_proxy"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        if cluster.cluster_template.no_proxy:"},{"line_number":918,"context_line":"            no_proxy \u003d cluster.cluster_template.no_proxy"},{"line_number":919,"context_line":"            # Update noProxy with fixed networks or subnets"},{"line_number":920,"context_line":"            cidrs \u003d self._get_network_cidrs("},{"line_number":921,"context_line":"                context, network_id, subnet_id, fixed_subnet_cidr"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b8984d9_154b523a","line":918,"updated":"2025-10-14 07:36:46.000000000","message":"Would it be reasonable to just split this by `,` and then you are only manipulating a list (or set), then use a single `join` at the end?","commit_id":"81b6d7b53024c46099a861ba795f30bda5016df0"}]}