)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"d973795412a4bb05edee05a387dca648b1a349e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78a2d4d7_303eee31","updated":"2022-01-10 21:31:03.000000000","message":"Rebase and syntax nits","commit_id":"0d533ec8457d15cff0f204181b4fa76fb513c385"}],"specs/victoria/helm-config.rst":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"070bf0c1ca19eb5e69c30fa2626f723186e3b58f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Some of the add-ons in a kubernetes cluster, are configured with helm, some"},{"line_number":14,"context_line":"not. Using helm for popular charts is a very good practice to minimize the"},{"line_number":15,"context_line":"number of manifests to maintain and benefit from contributors in the ecosystem."},{"line_number":16,"context_line":"Currently, metrics-server, prometheus-operator and metrics-server are the"},{"line_number":17,"context_line":"biggest charts deployed with helm. Some helm values can be passed as labels,"},{"line_number":18,"context_line":"and there are other default values in magnum\u0027s fragments, so not everything"},{"line_number":19,"context_line":"can be set with the magnum API and some are the defaults of the chart."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff570b3c_f31684f1","line":16,"range":{"start_line":16,"start_character":50,"end_line":16,"end_character":65},"updated":"2020-05-13 14:04:41.000000000","message":"repeated. maybe you want to say nginx?","commit_id":"aafce1ba7d9409345a0534e8fa328dc8a84d61c8"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2a87160af78daddf7aeea0ebd48a70e7740609cf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Some of the add-ons in a kubernetes cluster, are configured with helm, some"},{"line_number":14,"context_line":"not. Using helm for popular charts is a very good practice to minimize the"},{"line_number":15,"context_line":"number of manifests to maintain and benefit from contributors in the ecosystem."},{"line_number":16,"context_line":"Currently, metrics-server, prometheus-operator and metrics-server are the"},{"line_number":17,"context_line":"biggest charts deployed with helm. Some helm values can be passed as labels,"},{"line_number":18,"context_line":"and there are other default values in magnum\u0027s fragments, so not everything"},{"line_number":19,"context_line":"can be set with the magnum API and some are the defaults of the chart."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff570b3c_36e0eacc","line":16,"range":{"start_line":16,"start_character":50,"end_line":16,"end_character":65},"in_reply_to":"ff570b3c_f31684f1","updated":"2020-05-13 14:33:54.000000000","message":"Done","commit_id":"aafce1ba7d9409345a0534e8fa328dc8a84d61c8"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4a10b5760a69a1584ec06cd5b7a128a4f25ea201","unresolved":false,"context_lines":[{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_d122f1b8","line":72,"range":{"start_line":72,"start_character":33,"end_line":72,"end_character":44},"updated":"2020-05-19 10:28:06.000000000","message":"this can be base64 string OR a json/yaml encoded (we can have a validator in the API for this).","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"458d583e5836b252a4fca68964b4fe9031eecf96","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_63cd1e30","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":12},"updated":"2020-05-19 04:47:30.000000000","message":"Should we use helm_charts to be consistent with the other two?","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d921f431db787f839e6624fec80014a2f4fc4f02","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_69e33fda","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":12},"in_reply_to":"ff570b3c_63cd1e30","updated":"2020-05-19 07:43:08.000000000","message":"No, it will be one chart.\n\nThe others are many.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"80491bc978c9c79dc83ffc153b35c756ad496290","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_2f3e4bc0","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":12},"in_reply_to":"ff570b3c_69e33fda","updated":"2020-05-20 06:38:44.000000000","message":"Got it, thanks.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e447a0f9a8972e184ae3785648349abbc3540cf4","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_e47f8ddd","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":19},"updated":"2020-05-18 09:01:24.000000000","message":"what are your thoughts on providing helm_chart and helm_requirements via the same input and depending on whether the client is v2 or v3, write these separately to 2 files for backward compatibility? over longer term, we will only need the helm_chart option so makes sense to prepare for that.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5b38d93e8da923c88163b521ec396af8c192514c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_06056614","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":19},"in_reply_to":"ff570b3c_0600c6aa","updated":"2020-05-18 09:29:59.000000000","message":"I am not proposing using synthetic fields for acheiving this goal. In this implementation, user can combine Charts.yaml and requirements.yaml into the same file if using v1 and just provide Charts.yaml if using v2. Magnum would take care of the splitting into two files based on whether its v1 or v2 client (hopefully v2 in most cases).","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7b9074cbc50a61a9443407a884b6302765071ff2","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_c913815b","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":19},"in_reply_to":"ff570b3c_06056614","updated":"2020-05-18 09:30:39.000000000","message":"s/client/chart","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"ad0e21cf6ad4f8969dc56fc21784c588e5437ea2","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_298afd68","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":19},"in_reply_to":"ff570b3c_497771a1","updated":"2020-05-18 09:34:46.000000000","message":"I would appreciate it, if you take the care of rewriting the spec.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"cc1d26c920ed816013b3d677d58c12391e1091b8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_497771a1","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":19},"in_reply_to":"ff570b3c_c913815b","updated":"2020-05-18 09:33:18.000000000","message":"I will accept it. I can\u0027t go through a long spec again and no one else seems to have an opinion.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"adabec47fcd73b819922764b08d0d30b07ab8ce9","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"New fields in Cluster Template"},{"line_number":72,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":73,"context_line":"* helm_chart"},{"line_number":74,"context_line":"* helm_requirements"},{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_0600c6aa","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":19},"in_reply_to":"ff570b3c_e47f8ddd","updated":"2020-05-18 09:25:37.000000000","message":"let\u0027s think of DB schema too. The reason I proposed both fields is to take care of the chart v1 and v2 issue. I obviously knew about it, I linked the documents after all.\n\nI think it is bad to have synthetic fields that are used only in magnum and nowhere else.\n\nIf this bothers you (or we just want want less code which I stronly prefer),  we could support only charts v2. I\u0027m totally fine with it. I can\u0027t tell about people in the comunity.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"458d583e5836b252a4fca68964b4fe9031eecf96","unresolved":false,"context_lines":[{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"},{"line_number":78,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":79,"context_line":"* helm_values"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_e353ee69","line":78,"updated":"2020-05-19 04:47:30.000000000","message":"If we can use these 3 new fields to solve this issue, I will be happy. I have some silly simple questions here:\n\n1. I can see we\u0027re using  DictType here, and we\u0027re passing in a yaml file from command line. Can you please let me know when below yaml passed in, what\u0027s the key and value of the dict here?\n\n    prometheus-operator:\n      grafana:\n        resources:\n          requests:\n            memory: 512Mi\n    nginx-ingress:\n      controller:\n        name: controller\n        image:\n          tag: 0.32.0","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"80491bc978c9c79dc83ffc153b35c756ad496290","unresolved":false,"context_lines":[{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"},{"line_number":78,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":79,"context_line":"* helm_values"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_4f2f3f87","line":78,"in_reply_to":"ff570b3c_897a13ee","updated":"2020-05-20 06:38:44.000000000","message":"I see. It would be nice to clarify that in the spec.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d921f431db787f839e6624fec80014a2f4fc4f02","unresolved":false,"context_lines":[{"line_number":75,"context_line":"* helm_values"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"New field in Cluster"},{"line_number":78,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":79,"context_line":"* helm_values"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_897a13ee","line":78,"in_reply_to":"ff570b3c_e353ee69","updated":"2020-05-19 07:43:08.000000000","message":"This is a very common missconseption, I\u0027m trying to make clear. The fact that the client takes a values file, doesn\u0027t mean it sends a file. The content is becoming a dict and sent to the server.\n\nThis:\n helm_values:\n   prometheus-operator:\n     nameOverride: prometheus\n     fullnameOverride: prometheus\n     alertmanager:\n       alertmanagerSpec:\n         image:\n           repository: quay.io/prometheus/alertmanager\n         priorityClassName: \"system-cluster-critical\"\n     # Dashboard\n     grafana:\n       resources:\n         requests:\n           cpu: 100m\n           memory: 128Mi\n       script: |\n         #!/bin.bash\n         #\n         echo \"Hello ${name}\"\n     kubeApiServer:\n       tlsConfig:\n         insecureSkipVerify: true\n\nbecomes:\n  \"helm_values\": {\n    \"prometheus-operator\": {\n      \"nameOverride\": \"prometheus\",\n      \"fullnameOverride\": \"prometheus\",\n      \"alertmanager\": {\n        \"alertmanagerSpec\": {\n          \"image\": {\n            \"repository\": \"quay.io/prometheus/alertmanager\"\n          },\n          \"priorityClassName\": \"system-cluster-critical\"\n        }\n      },\n      \"grafana\": {\n        \"resources\": {\n          \"requests\": {\n            \"cpu\": \"100m\",\n            \"memory\": \"128Mi\"\n          }\n        },\n        \"script\": \"#!/bin.bash\\n#\\necho \\\"Hello ${name}\\\"\\n\"\n      },\n      \"kubeApiServer\": {\n        \"tlsConfig\": {\n          \"insecureSkipVerify\": true\n        }\n      }\n    }\n  }","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"458d583e5836b252a4fca68964b4fe9031eecf96","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    ..."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    cat cluster-values.yaml"},{"line_number":145,"context_line":"    prometheus-operator:"},{"line_number":146,"context_line":"      grafana:"},{"line_number":147,"context_line":"        resources:"},{"line_number":148,"context_line":"          requests:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_83c83222","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":23},"updated":"2020-05-19 04:47:30.000000000","message":"Is there a strong mapping between the names in values, requirements and charts?","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"80491bc978c9c79dc83ffc153b35c756ad496290","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    ..."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    cat cluster-values.yaml"},{"line_number":145,"context_line":"    prometheus-operator:"},{"line_number":146,"context_line":"      grafana:"},{"line_number":147,"context_line":"        resources:"},{"line_number":148,"context_line":"          requests:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_ef5573fb","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":23},"in_reply_to":"ff570b3c_49e2bba1","updated":"2020-05-20 06:38:44.000000000","message":"Sound good to me.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d921f431db787f839e6624fec80014a2f4fc4f02","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    ..."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    cat cluster-values.yaml"},{"line_number":145,"context_line":"    prometheus-operator:"},{"line_number":146,"context_line":"      grafana:"},{"line_number":147,"context_line":"        resources:"},{"line_number":148,"context_line":"          requests:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_49e2bba1","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":23},"in_reply_to":"ff570b3c_83c83222","updated":"2020-05-19 07:43:08.000000000","message":"Very strong. Users need to know how charts work. This is not a convention I came up with. It is how helm works. (And it works very well IMO :))\n\n\neg:\nreference in requirements: https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/requirements.yaml#L15\n\nreference in values: https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/values.yaml#L602\n\n\nNOTE:\nyou can do (IMO silly) things like below, where you override names.\nhttps://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/requirements.yaml#L2\nhttps://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/values.yaml#L475\n\n\nBUT! In magnum, we won\u0027t care much because we just forward the helm configuration. If the cloud operator decides conventions like above (with renames that I don\u0027t like but other may find useful), it will work fine.","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"29a6b08fb1d73177a808627b42f61e6cfe22ed91","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        image:"},{"line_number":154,"context_line":"          tag: 0.32.0"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    openstack coe cluster create --cluster-template kube \\"},{"line_number":157,"context_line":"    --helm-values cluster-values.yaml \\"},{"line_number":158,"context_line":"    ..."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Assignee(s)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_8d9ef151","line":157,"range":{"start_line":156,"start_character":0,"end_line":157,"end_character":39},"updated":"2020-05-14 09:17:40.000000000","message":"the question here is whether the cluster-values.yaml override or replace CT values.yaml :D","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e447a0f9a8972e184ae3785648349abbc3540cf4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        image:"},{"line_number":154,"context_line":"          tag: 0.32.0"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    openstack coe cluster create --cluster-template kube \\"},{"line_number":157,"context_line":"    --helm-values cluster-values.yaml \\"},{"line_number":158,"context_line":"    ..."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Assignee(s)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_061a866d","line":157,"range":{"start_line":156,"start_character":0,"end_line":157,"end_character":39},"in_reply_to":"ff570b3c_0de141d1","updated":"2020-05-18 09:01:24.000000000","message":"Ok cool","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"822acfff278c2e5125f622061fccc45d04a9bb49","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        image:"},{"line_number":154,"context_line":"          tag: 0.32.0"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    openstack coe cluster create --cluster-template kube \\"},{"line_number":157,"context_line":"    --helm-values cluster-values.yaml \\"},{"line_number":158,"context_line":"    ..."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Assignee(s)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_0de141d1","line":157,"range":{"start_line":156,"start_character":0,"end_line":157,"end_character":39},"in_reply_to":"ff570b3c_8d9ef151","updated":"2020-05-14 09:18:57.000000000","message":"Helm solves this for us https://review.opendev.org/#/c/727756/2/specs/victoria/helm-config.rst@90","commit_id":"b6da33bc9d75c41bfa83d119b94c2c46f8ae884f"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"3f39d682de1920d647ecf80acec498924b53d17a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"All three new fields are of Dict type, where the key is a string and the value"},{"line_number":88,"context_line":"is a string too. WSME [#]_ does not support indefinite levels of dicts"},{"line_number":89,"context_line":"(in helm_values especially, the depth can grow a lot) so a dict of strings is"},{"line_number":90,"context_line":"the maximm depth we can achieve."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Add a decorator to validate that the value of each field is a valid json"},{"line_number":93,"context_line":"object."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_b5390ca5","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":10},"updated":"2020-05-20 08:56:15.000000000","message":"maximum","commit_id":"29c4845784f5f52dddcceddf3b6d868b93365260"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"a00dd850efc5b34e241da503fea05162532ee551","unresolved":false,"context_lines":[{"line_number":29,"context_line":"on other charts and no templates). The cluster template will be extended"},{"line_number":30,"context_line":"with three new fields."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* helm_chart, the definition of the chart [#]_"},{"line_number":33,"context_line":"* helm_requirements, the chart dependencies [#]_"},{"line_number":34,"context_line":"* helm_values, the chart values [#]_"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_849edc04","line":32,"updated":"2020-05-27 16:48:02.000000000","message":"Why is this needed if there\u0027s a single meta chart which is built internally by magnum?","commit_id":"0f9d7d4b5702357816790a549c491193a19b1593"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"808dc5be07dd36c794ee5fed66f374e7f3f8d257","unresolved":false,"context_lines":[{"line_number":81,"context_line":"* helm_values"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"New field in Cluster"},{"line_number":84,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":85,"context_line":"* helm_values"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"All three new fields are of Dict type, where the key is a string and the value"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_c2bd3d69","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":19},"updated":"2021-04-15 10:02:58.000000000","message":"same here","commit_id":"0f9d7d4b5702357816790a549c491193a19b1593"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b1c0797836b94c40183ca6f62a97d07decddf9a6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":85,"context_line":"* helm_values"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"All three new fields are of Dict type, where the key is a string and the value"},{"line_number":88,"context_line":"is a string too. WSME [#]_ does not support indefinite levels of dicts"},{"line_number":89,"context_line":"(in helm_values especially, the depth can grow a lot) so a dict of strings is"},{"line_number":90,"context_line":"the maximum depth we can achieve."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_5ff3fc9e","line":87,"updated":"2020-05-27 09:43:33.000000000","message":"Can we use json.dumps and json.loads on the client and server side to deal with the depth. That means we will only handle the chart name as key and all the value will be a string dumps from json.dumps.","commit_id":"0f9d7d4b5702357816790a549c491193a19b1593"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5181f97ff3f51592925f02a5f8010704fbdb271a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"wsme.types.DictType(wtypes.text, wtypes.text):"},{"line_number":85,"context_line":"* helm_values"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"All three new fields are of Dict type, where the key is a string and the value"},{"line_number":88,"context_line":"is a string too. WSME [#]_ does not support indefinite levels of dicts"},{"line_number":89,"context_line":"(in helm_values especially, the depth can grow a lot) so a dict of strings is"},{"line_number":90,"context_line":"the maximum depth we can achieve."}],"source_content_type":"text/x-rst","patch_set":4,"id":"b3e98ccd_bceff33e","line":87,"in_reply_to":"ff570b3c_5ff3fc9e","updated":"2021-04-15 09:52:55.000000000","message":"+1","commit_id":"0f9d7d4b5702357816790a549c491193a19b1593"}]}