)]}'
{".zuul.yaml":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"57b6cb725200ba178583b21fd73af52d207e2f27","unresolved":true,"context_lines":[{"line_number":5,"context_line":"      - tempest-plugin-jobs"},{"line_number":6,"context_line":"    check:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - magnum-tempest-plugin-tests-functional-k8s-fcos"},{"line_number":9,"context_line":"    gate:"},{"line_number":10,"context_line":"      jobs:"},{"line_number":11,"context_line":"        - magnum-tempest-plugin-tests-api"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"3c3668f8_14cc55f9","line":8,"range":{"start_line":8,"start_character":49,"end_line":8,"end_character":57},"updated":"2023-09-11 11:50:17.000000000","message":"do you want to name it like the driver name - k8s_fedora_coreos_v1 ?","commit_id":"01ba87ab5c264dbc770605ca158a91d2e04c5e93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"611c56f68fd2a1aa242bc77e00e21e697fb2e759","unresolved":true,"context_lines":[{"line_number":5,"context_line":"      - tempest-plugin-jobs"},{"line_number":6,"context_line":"    check:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - magnum-tempest-plugin-tests-functional-k8s-fcos"},{"line_number":9,"context_line":"    gate:"},{"line_number":10,"context_line":"      jobs:"},{"line_number":11,"context_line":"        - magnum-tempest-plugin-tests-api"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"a3c219a6_4d8e05df","line":8,"range":{"start_line":8,"start_character":49,"end_line":8,"end_character":57},"in_reply_to":"3c3668f8_14cc55f9","updated":"2023-09-11 12:15:45.000000000","message":"yeah, will do :-)","commit_id":"01ba87ab5c264dbc770605ca158a91d2e04c5e93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"40be9947ed81f330f0273469c78b066f35d25a7f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      - tempest-plugin-jobs"},{"line_number":6,"context_line":"    check:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - magnum-tempest-plugin-tests-functional-k8s-fcos"},{"line_number":9,"context_line":"    gate:"},{"line_number":10,"context_line":"      jobs:"},{"line_number":11,"context_line":"        - magnum-tempest-plugin-tests-api"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"ee178785_40a98773","line":8,"range":{"start_line":8,"start_character":49,"end_line":8,"end_character":57},"in_reply_to":"a3c219a6_4d8e05df","updated":"2023-09-22 13:51:45.000000000","message":"Done","commit_id":"01ba87ab5c264dbc770605ca158a91d2e04c5e93"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71e5558333d003d2e012679830c976518631f0bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4e2fd6b5_e1ae5c9c","updated":"2023-08-31 13:50:10.000000000","message":"recheck holding a node for debugging","commit_id":"94fe2b5f7c458c8a69f996e2e6c69fc536552c1b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1fd32b4a897a4a3e2d16259a0893d7f7bb4c3e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":210,"id":"b17337a3_b69f1446","updated":"2024-01-10 07:23:15.000000000","message":"recheck get fresh logs","commit_id":"86059cd4d5bebe7433bfc7cff8499a9f3dd1c0ce"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9e503f246339f788f167591a135d0f494ea478ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":216,"id":"3ecc8b90_93e406fa","updated":"2024-01-10 22:42:44.000000000","message":"Looking good - it passes! one question below.","commit_id":"993f9b9d2567ba99f3f50e719ac0f9b06b4e5339"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"873fc7655ac7b1db150e9feaabbc2b99af1a6949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":232,"id":"0965eff5_c037921d","updated":"2024-02-01 20:14:30.000000000","message":"recheck","commit_id":"c5f799ee0740414076b294a11455fabe10a2a2ab"}],"magnum_tempest_plugin/common/config.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9e503f246339f788f167591a135d0f494ea478ff","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        cls.dns_nameserver \u003d CONF.magnum.dns_nameserver"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def set_copy_logs(cls, config):"},{"line_number":141,"context_line":"        if \u0027copy_logs\u0027 not in CONF.magnum:"},{"line_number":142,"context_line":"            cls.copy_logs \u003d True"},{"line_number":143,"context_line":"        if \u0027copy_logs_success\u0027 not in CONF.magnum:"}],"source_content_type":"text/x-python","patch_set":216,"id":"349e4939_5c4a229f","line":140,"updated":"2024-01-10 22:42:44.000000000","message":"This function sets a default on two class variables and then immediately sets them again based on magnum config?\n\nDo you need to add some `else` in here, or does this act in a different way to what I\u0027m reading?","commit_id":"993f9b9d2567ba99f3f50e719ac0f9b06b4e5339"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4593acf1c95dcb096ff82116843114782634924a","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        cls.dns_nameserver \u003d CONF.magnum.dns_nameserver"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def set_copy_logs(cls, config):"},{"line_number":141,"context_line":"        if \u0027copy_logs\u0027 not in CONF.magnum:"},{"line_number":142,"context_line":"            cls.copy_logs \u003d True"},{"line_number":143,"context_line":"        if \u0027copy_logs_success\u0027 not in CONF.magnum:"}],"source_content_type":"text/x-python","patch_set":216,"id":"8426d3df_8f2bf8ea","line":140,"in_reply_to":"349e4939_5c4a229f","updated":"2024-01-11 08:25:04.000000000","message":"That\u0027s a good question, I basically did copy paste from earlier implementation, I can try to rework that, but first would like to get to a point where a failed cluster creation gets us logs from that.","commit_id":"993f9b9d2567ba99f3f50e719ac0f9b06b4e5339"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d036bef19b7c0970eb74587dddc9c7fbf1fd892","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        cls.dns_nameserver \u003d CONF.magnum.dns_nameserver"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def set_copy_logs(cls, config):"},{"line_number":141,"context_line":"        if \u0027copy_logs\u0027 not in CONF.magnum:"},{"line_number":142,"context_line":"            cls.copy_logs \u003d True"},{"line_number":143,"context_line":"        if \u0027copy_logs_success\u0027 not in CONF.magnum:"}],"source_content_type":"text/x-python","patch_set":216,"id":"93f3eab5_ea99ad47","line":140,"in_reply_to":"8426d3df_8f2bf8ea","updated":"2024-01-12 10:20:26.000000000","message":"Done","commit_id":"993f9b9d2567ba99f3f50e719ac0f9b06b4e5339"}]}
