)]}'
{"magnum_ui/api/rest/magnum.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0b1d6ce727116a6101d67c1335fe73eae539827e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return change_to_id(magnum.cluster_show(request, cluster_id).to_dict())"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"},{"line_number":105,"context_line":"    def put(self, request, cluster_id):"},{"line_number":106,"context_line":"        \"\"\"Update a Cluster."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Returns the Cluster object on success."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_24022a70","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":11},"updated":"2017-01-26 15:39:51.000000000","message":"I think this api is using patch (not put). See here: https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/cluster.py#L401","commit_id":"4e901e9fe2718bd463d03ecacee55e12df57e406"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"e61185809327497d9813776e1b41e6b01934e109","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return change_to_id(magnum.cluster_show(request, cluster_id).to_dict())"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"},{"line_number":105,"context_line":"    def put(self, request, cluster_id):"},{"line_number":106,"context_line":"        \"\"\"Update a Cluster."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Returns the Cluster object on success."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_4b052c12","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":11},"in_reply_to":"3a461143_24022a70","updated":"2017-01-30 08:26:21.000000000","message":"Done","commit_id":"4e901e9fe2718bd463d03ecacee55e12df57e406"}],"magnum_ui/static/dashboard/container-infra/clusters/update/update.service.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"bc9a791c2402c6e3321cbeaa0af038befcd9300c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * Copyright 2015 Cisco Systems, Inc."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":" * not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a461143_d8a093a8","line":2,"updated":"2017-01-25 20:19:19.000000000","message":"NEC?","commit_id":"06074f49b74a15307945d863867fcd1b1ead5c1d"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"02fe6738729eb21455c66a1629b17b5979abe1be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * Copyright 2015 Cisco Systems, Inc."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":" * not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a461143_b9257fc3","line":2,"in_reply_to":"3a461143_d8a093a8","updated":"2017-01-26 02:32:06.000000000","message":"Done","commit_id":"06074f49b74a15307945d863867fcd1b1ead5c1d"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"bc9a791c2402c6e3321cbeaa0af038befcd9300c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      // load current data"},{"line_number":64,"context_line":"      magnum.getCluster(selected.id).then(onLoad);"},{"line_number":65,"context_line":"      function onLoad(response) {"},{"line_number":66,"context_line":"        config.model.name \u003d response.data.name"},{"line_number":67,"context_line":"          ? response.data.name : \"\";"},{"line_number":68,"context_line":"        config.model.cluster_template_id \u003d response.data.cluster_template_id"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a461143_98e52baa","line":65,"updated":"2017-01-25 20:19:19.000000000","message":"Would it be better to do a deep copy of response.data? https://docs.angularjs.org/api/ng/function/angular.copy\n\nUnless there are fields in response.data that we should not copy over?","commit_id":"06074f49b74a15307945d863867fcd1b1ead5c1d"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"02fe6738729eb21455c66a1629b17b5979abe1be","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      // load current data"},{"line_number":64,"context_line":"      magnum.getCluster(selected.id).then(onLoad);"},{"line_number":65,"context_line":"      function onLoad(response) {"},{"line_number":66,"context_line":"        config.model.name \u003d response.data.name"},{"line_number":67,"context_line":"          ? response.data.name : \"\";"},{"line_number":68,"context_line":"        config.model.cluster_template_id \u003d response.data.cluster_template_id"}],"source_content_type":"text/javascript","patch_set":1,"id":"3a461143_f9770700","line":65,"in_reply_to":"3a461143_98e52baa","updated":"2017-01-26 02:32:06.000000000","message":"First, response.data has unnecessary items not for update. The unnecessary items should be removed befor submit.\nSecond, we shoud ensure to initialize for angular-json-schema, e.g. null will not be set correct for select that has \u0027string\u0027 for its type.","commit_id":"06074f49b74a15307945d863867fcd1b1ead5c1d"}]}