)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"011df44344b85583f002a526d137ccb3e9ed77b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c05bc7a_a53509f8","updated":"2022-06-21 18:49:24.000000000","message":"Unexpected request: GET can be fixed like we did it for Horizon: https://review.opendev.org/c/openstack/horizon/+/843346/3/openstack_dashboard/dashboards/identity/static/dashboard/identity/domains/actions/delete.service.spec.js","commit_id":"e520aa6b3aa976e58fbd97acde0a67c006f7fcde"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9a620476cc5a4734f988bc1de80f1b5529ca79f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"04984612_3d460413","in_reply_to":"7c05bc7a_a53509f8","updated":"2022-06-22 06:10:44.000000000","message":"Done.\nThanks","commit_id":"e520aa6b3aa976e58fbd97acde0a67c006f7fcde"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5e963b5035821ce6167088406967cec085b3cb0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c7693e3_56ee1c87","updated":"2022-08-04 11:05:36.000000000","message":"recheck, check latest CI logs for error.","commit_id":"35ab542c2bb13bdf9278242c0d0c1d95d8803ce3"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e334b6588ddf1c7d972d7e74698d57162eeb30e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5bde4653_e12310e1","updated":"2022-08-08 20:19:54.000000000","message":"apiService.post(...).error and apiService.get(...).error should be .catch(...)","commit_id":"4bc4e91b90c69ed4f38a2378014a1f672ac64c83"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"88c776bbac27ed1089619423ba5348c08bd3aa4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f974fc4_a94781e5","updated":"2022-08-10 21:27:39.000000000","message":"Try to update \nhttps://github.com/openstack/magnum-ui/blob/master/magnum_ui/static/dashboard/container-infra/clusters/resize/resize.service.spec.js#L96\n\nand\nhttps://github.com/openstack/magnum-ui/blob/master/magnum_ui/static/dashboard/container-infra/clusters/rolling-upgrade/upgrade.service.spec.js#L119\n\nwith\ndeferred.promise.catch(angular.noop); \n\nbefore\ndeferred.reject();\n\nlike we have it in \nhttps://review.opendev.org/c/openstack/horizon/+/843346/3/openstack_dashboard/static/app/core/network_qos/actions/delete.action.service.spec.js#229","commit_id":"86d894b7e93bc314952389fd860e2c1f7cfd5206"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"7bf80f199e2eaf7f1ab5b186a52b45a31a3c1f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef023f1b_a4268383","in_reply_to":"4cd995d6_502a9b39","updated":"2022-08-12 08:27:38.000000000","message":"Done, thanks","commit_id":"86d894b7e93bc314952389fd860e2c1f7cfd5206"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"74eb9bd1e794c9e5a562c096724f338de4937b75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6e44ca3_0b3bff7d","in_reply_to":"6f974fc4_a94781e5","updated":"2022-08-11 04:55:40.000000000","message":"I tried the same but it doesn\u0027t work out.\nlet me update the same in the patch.","commit_id":"86d894b7e93bc314952389fd860e2c1f7cfd5206"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e6b1062d85d422211bd24cb8d22025b6df2af415","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4cd995d6_502a9b39","in_reply_to":"c6e44ca3_0b3bff7d","updated":"2022-08-11 19:12:24.000000000","message":"You\u0027re right, I\u0027ve looked through the code more and it seems we have to catch the rejection in a different place. Try to catch it here:\nhttps://github.com/openstack/magnum-ui/blob/e5a8eb4d2a83257bd2c289a8a19a6e00b178300c/magnum_ui/static/dashboard/container-infra/clusters/resize/resize.service.js#L83\nand here:\nhttps://github.com/openstack/magnum-ui/blob/335fb71a58fa5be27ce144daf4585061659d444e/magnum_ui/static/dashboard/container-infra/clusters/rolling-upgrade/upgrade.service.js#L132\n\nAnd if it doesn\u0027t work, probably we\u0027ll need to rewrite it without the rejection as it is done in Horizon, say, here:\nhttps://github.com/openstack/horizon/blob/5e4ca1a9fdec04db08552e9e93fe372b8b8b45ae/openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects-row-actions.service.js#L197","commit_id":"86d894b7e93bc314952389fd860e2c1f7cfd5206"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"a91ae748a39edbcd3460875e44c8bb5314145fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f24e49d9_252b8aeb","updated":"2022-09-01 02:29:19.000000000","message":"@spyros, @michal, @mnaser can you help please?\n\nI am not good in ui","commit_id":"44697255ee89736478b33ed15e864fe5257a810a"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"b30a96ef8dfb9ea8ef518e718422479ece126bea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3cd2aebb_a13ff439","updated":"2022-08-31 11:21:44.000000000","message":"Hi Core team, Can we merge this to unblock CI?","commit_id":"44697255ee89736478b33ed15e864fe5257a810a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ad6b5b9c90947bd92df7efef909ebc942a13a527","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c791b23_176efc08","updated":"2022-09-01 05:36:52.000000000","message":"LGTM","commit_id":"44697255ee89736478b33ed15e864fe5257a810a"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"850dd7439c359df45e3e0c221f5553eeee7fc46f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fcf81e1c_75014b5c","updated":"2022-08-24 17:36:17.000000000","message":"hi core team, Can you merge this patch to unblock the CI.","commit_id":"44697255ee89736478b33ed15e864fe5257a810a"}],"magnum_ui/static/dashboard/container-infra/clusters/create/create.service.spec.js":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"1f04a40ef4f21cc0818d91bd8162dfdd74d313af","unresolved":true,"context_lines":[{"line_number":115,"context_line":"      model.labels \u003d \u0027invalid label\u0027;"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"      service.perform(null, $scope);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      $timeout.flush();"},{"line_number":120,"context_line":"      $scope.$apply();"},{"line_number":121,"context_line":"    }));"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a4e6f65_24eff519","line":118,"updated":"2022-08-08 20:22:58.000000000","message":"We need to add the same expectGET here.","commit_id":"4bc4e91b90c69ed4f38a2378014a1f672ac64c83"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"de8594b6d74eaa83d74ae361520c96b15019c5c3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      model.labels \u003d \u0027invalid label\u0027;"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"      service.perform(null, $scope);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      $timeout.flush();"},{"line_number":120,"context_line":"      $scope.$apply();"},{"line_number":121,"context_line":"    }));"}],"source_content_type":"text/javascript","patch_set":3,"id":"24202c4d_e0d49eec","line":118,"in_reply_to":"7a4e6f65_24eff519","updated":"2022-08-09 07:18:52.000000000","message":"Done.\nThanks","commit_id":"4bc4e91b90c69ed4f38a2378014a1f672ac64c83"}]}