)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1582b1a947ab89a757aa24dc3b039fc49a3bf693","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"12109f7b_9a97cda8","updated":"2024-05-07 05:43:22.000000000","message":"Do we need a reno about changes?","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"331dee190ecdb6483796a4837342972a277615d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7cb3ea8d_c478df4d","in_reply_to":"12109f7b_9a97cda8","updated":"2024-05-07 07:10:47.000000000","message":"Will do; especially as I\u0027m replacing option `floating_ip` with `master_lb_floating_ip_enabled`.","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"d1b91f9054ac520effca8131a650f0a52fff0dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"507fd80d_8a12f405","in_reply_to":"7cb3ea8d_c478df4d","updated":"2024-05-08 00:17:47.000000000","message":"Done","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"4a88057c1793a79c10a18663124f68a717ca5621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"666fcaa6_308f53f8","updated":"2024-05-09 12:59:29.000000000","message":"Thanks! Mostly looks good.\n\nI wish this can be broken up more though. Some parts like control plane node count, text changes, name validation are pretty trivial and can be easily merged.\nOther parts like the FIP have to be tested more. It\u0027s a pity if the whole commit is held up by certain parts.\n\nDo you think you can break off the trivial bits into separate reviews so we can get those merged first? It also helps us focus on the remaining bits better.","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"5d323547a3cfa705fee1226e3ba558b2553b99c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"721949d3_d2ed8e17","in_reply_to":"666fcaa6_308f53f8","updated":"2024-05-09 21:24:12.000000000","message":"Yes, happy to break parts off this that need more discussion. I\u0027ll do the below ones.","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"02c173a9739baae38775fb49de559007333cedb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa52fc6b_82613440","in_reply_to":"721949d3_d2ed8e17","updated":"2024-05-13 04:56:42.000000000","message":"I\u0027ve moved the floating IP sections to a related patchset, so it can be reviewed in isolation: https://review.opendev.org/c/openstack/magnum-ui/+/919449","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"02c173a9739baae38775fb49de559007333cedb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e1564093_752d0859","updated":"2024-05-13 04:56:42.000000000","message":"I\u0027ve split this patchset up further.","commit_id":"d9b5878b555bdc02a8a8009fd2658310a4f073b6"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"32d7ff99bac103ee3c9039f5bdbad91fc58b783f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d34720ec_f3a531fb","updated":"2024-05-14 11:09:32.000000000","message":"mostly good, just have a question, -1 for visibility","commit_id":"708b9d701fcfb806225673a744a5110af3498aa0"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"3a14863b4f928474ce223213ef71d913cc941153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0477e1a9_dce31e09","updated":"2024-05-17 13:46:13.000000000","message":"thanks! tested, looks good.","commit_id":"c7241729723f85804a2ee295628f6d425894af98"}],"magnum_ui/api/rest/magnum.py":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"4a88057c1793a79c10a18663124f68a717ca5621","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                        new_templates +\u003d groups[group]"},{"line_number":166,"context_line":"                    templates \u003d set(new_templates)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # Sort clusters reverse alphabetically by name."},{"line_number":169,"context_line":"        # This should result in newer K8s versions at the top."},{"line_number":170,"context_line":"        templates.sort(key\u003dlambda t: t.name, reverse\u003dTrue)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return {\u0027items\u0027: [change_to_id(n.to_dict()) for n in templates]}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7386cca5_08820d47","line":171,"range":{"start_line":168,"start_character":0,"end_line":171,"end_character":0},"updated":"2024-05-09 12:59:29.000000000","message":"I\u0027m not in favour of this as it messes up with people\u0027s expectation of sort order in a dropdown box. E.g. in a country list, Australia is always up top 😊\n\nIf sorting is necessary, should we follow nova\u0027s example and have a table for it instead, and the table is sortable?","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"5d323547a3cfa705fee1226e3ba558b2553b99c0","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                        new_templates +\u003d groups[group]"},{"line_number":166,"context_line":"                    templates \u003d set(new_templates)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # Sort clusters reverse alphabetically by name."},{"line_number":169,"context_line":"        # This should result in newer K8s versions at the top."},{"line_number":170,"context_line":"        templates.sort(key\u003dlambda t: t.name, reverse\u003dTrue)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return {\u0027items\u0027: [change_to_id(n.to_dict()) for n in templates]}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e0bcae23_73dd98b9","line":171,"range":{"start_line":168,"start_character":0,"end_line":171,"end_character":0},"in_reply_to":"7386cca5_08820d47","updated":"2024-05-09 21:24:12.000000000","message":"This was addressing some of the feedback from our internal UI testing. I don\u0027t mind which order but sorted seems helpful with the naming scheme we use in case we create the templates in an order that doesn\u0027t match k8s versions.\n\nWould you prefer sort with `reverse\u003dFalse` in upstream code, or no sort at all here? (API seems to return them in created order, so a 1.25 template created 1 minute after a 1.28 template would show \"after\".)\n\nHappy to remove this and carry internally, either all or just the `reverse` part.","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"02c173a9739baae38775fb49de559007333cedb7","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                        new_templates +\u003d groups[group]"},{"line_number":166,"context_line":"                    templates \u003d set(new_templates)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # Sort clusters reverse alphabetically by name."},{"line_number":169,"context_line":"        # This should result in newer K8s versions at the top."},{"line_number":170,"context_line":"        templates.sort(key\u003dlambda t: t.name, reverse\u003dTrue)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return {\u0027items\u0027: [change_to_id(n.to_dict()) for n in templates]}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"94ca4df0_20158d1c","line":171,"range":{"start_line":168,"start_character":0,"end_line":171,"end_character":0},"in_reply_to":"e0bcae23_73dd98b9","updated":"2024-05-13 04:56:42.000000000","message":"Moved change to https://review.opendev.org/c/openstack/magnum-ui/+/919448","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"}],"magnum_ui/static/dashboard/container-infra/clusters/workflow/cluster-template.controller.js":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1582b1a947ab89a757aa24dc3b039fc49a3bf693","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      function detectDriver(template) {"},{"line_number":120,"context_line":"        //NOTE(dalees): Method 1: Use the template \u0027driver\u0027 field."},{"line_number":121,"context_line":"        //if ( template.driver \u003d\u003d \"magnum-cluster-api\" || template.driver \u003d\u003d \"\") {"},{"line_number":122,"context_line":"        // return \"ClusterAPI\""},{"line_number":123,"context_line":"        //}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        // Method 2: Fall back to OS matching on the image."},{"line_number":126,"context_line":"        if (template.cluster_distro \u003d\u003d\u003d \"ubuntu\" || template.cluster_distro \u003d\u003d\u003d \"flatcar\") {"}],"source_content_type":"text/javascript","patch_set":3,"id":"ee761bab_3cd966ec","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":11},"updated":"2024-05-07 05:43:22.000000000","message":"Should we have that here? I guess it would make sense to return template.driver if it\u0027s defined, if not - fall back to OS matching - but that function looks a bit of a maintenance burden - if cluster api supports more OSes in future.","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"331dee190ecdb6483796a4837342972a277615d5","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      function detectDriver(template) {"},{"line_number":120,"context_line":"        //NOTE(dalees): Method 1: Use the template \u0027driver\u0027 field."},{"line_number":121,"context_line":"        //if ( template.driver \u003d\u003d \"magnum-cluster-api\" || template.driver \u003d\u003d \"\") {"},{"line_number":122,"context_line":"        // return \"ClusterAPI\""},{"line_number":123,"context_line":"        //}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        // Method 2: Fall back to OS matching on the image."},{"line_number":126,"context_line":"        if (template.cluster_distro \u003d\u003d\u003d \"ubuntu\" || template.cluster_distro \u003d\u003d\u003d \"flatcar\") {"}],"source_content_type":"text/javascript","patch_set":3,"id":"f22f959d_7e908d63","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":11},"in_reply_to":"ee761bab_3cd966ec","updated":"2024-05-07 07:10:47.000000000","message":"Well that\u0027s a good point, I\u0027m not sure what to do here upstream.\n\nI had a need to distinguish the Heat capabilities (keypair and ingress selection) from CAPI (Catalyst hide both keypair and ingress, but only for the CAPI driver).\n\nThe driver name returning is possibly better than what I proposed here (even if it doesn\u0027t group both CAPI drivers) but it still represents a maintenance burden, which I opted to limit to this one function.","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"d1b91f9054ac520effca8131a650f0a52fff0dbb","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      function detectDriver(template) {"},{"line_number":120,"context_line":"        //NOTE(dalees): Method 1: Use the template \u0027driver\u0027 field."},{"line_number":121,"context_line":"        //if ( template.driver \u003d\u003d \"magnum-cluster-api\" || template.driver \u003d\u003d \"\") {"},{"line_number":122,"context_line":"        // return \"ClusterAPI\""},{"line_number":123,"context_line":"        //}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        // Method 2: Fall back to OS matching on the image."},{"line_number":126,"context_line":"        if (template.cluster_distro \u003d\u003d\u003d \"ubuntu\" || template.cluster_distro \u003d\u003d\u003d \"flatcar\") {"}],"source_content_type":"text/javascript","patch_set":3,"id":"3c96b5e7_85cf0bfe","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":11},"in_reply_to":"f22f959d_7e908d63","updated":"2024-05-08 00:17:47.000000000","message":"I\u0027ve moved this particular change to another patchset: https://review.opendev.org/c/openstack/magnum-ui/+/918489\n\nI\u0027d like to separate the discussion around driver detection from the rest of this patchset, as I agree it needs further consideration.","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"}],"magnum_ui/static/dashboard/container-infra/clusters/workflow/workflow.service.js":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1582b1a947ab89a757aa24dc3b039fc49a3bf693","unresolved":true,"context_lines":[{"line_number":93,"context_line":"          \u0027master_count\u0027: {"},{"line_number":94,"context_line":"            type: \u0027number\u0027,"},{"line_number":95,"context_line":"            minimum: 1,"},{"line_number":96,"context_line":"            maximum: 7,"},{"line_number":97,"context_line":"          },"},{"line_number":98,"context_line":"          \u0027master_flavor_id\u0027: { type: \u0027string\u0027 },"},{"line_number":99,"context_line":"          \u0027node_count\u0027: {"}],"source_content_type":"text/javascript","patch_set":3,"id":"764cd0e9_2e0e9f04","line":96,"updated":"2024-05-07 05:43:22.000000000","message":"does it come from somewhere? e.g. kubneretes docs? clusterapi docs?","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"02c173a9739baae38775fb49de559007333cedb7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"          \u0027master_count\u0027: {"},{"line_number":94,"context_line":"            type: \u0027number\u0027,"},{"line_number":95,"context_line":"            minimum: 1,"},{"line_number":96,"context_line":"            maximum: 7,"},{"line_number":97,"context_line":"          },"},{"line_number":98,"context_line":"          \u0027master_flavor_id\u0027: { type: \u0027string\u0027 },"},{"line_number":99,"context_line":"          \u0027node_count\u0027: {"}],"source_content_type":"text/javascript","patch_set":3,"id":"51386790_2e86af3c","line":96,"in_reply_to":"418dbb53_776fedbc","updated":"2024-05-13 04:56:42.000000000","message":"Specifically: \"Theoretically, there is no hard limit. However, an etcd cluster probably should have no more than seven nodes.\"\n\nI would have 3 or 5 here, but maybe someone has a use-case for 7!","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"331dee190ecdb6483796a4837342972a277615d5","unresolved":true,"context_lines":[{"line_number":93,"context_line":"          \u0027master_count\u0027: {"},{"line_number":94,"context_line":"            type: \u0027number\u0027,"},{"line_number":95,"context_line":"            minimum: 1,"},{"line_number":96,"context_line":"            maximum: 7,"},{"line_number":97,"context_line":"          },"},{"line_number":98,"context_line":"          \u0027master_flavor_id\u0027: { type: \u0027string\u0027 },"},{"line_number":99,"context_line":"          \u0027node_count\u0027: {"}],"source_content_type":"text/javascript","patch_set":3,"id":"418dbb53_776fedbc","line":96,"in_reply_to":"764cd0e9_2e0e9f04","updated":"2024-05-07 07:10:47.000000000","message":"Yes; https://etcd.io/docs/v3.3/faq/","commit_id":"b1a6bd00dcc512c48380090dd44ba9ea23cd0d94"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"32d7ff99bac103ee3c9039f5bdbad91fc58b783f","unresolved":true,"context_lines":[{"line_number":349,"context_line":"              help: basePath + \u0027clusters/workflow/network.help.html\u0027,"},{"line_number":350,"context_line":"              type: \u0027section\u0027,"},{"line_number":351,"context_line":"              htmlClass: \u0027row\u0027,"},{"line_number":352,"context_line":"              required: false,"},{"line_number":353,"context_line":"              items: ["},{"line_number":354,"context_line":"                {"},{"line_number":355,"context_line":"                  type: \u0027section\u0027,"}],"source_content_type":"text/javascript","patch_set":7,"id":"7e6cb550_efead296","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":29},"updated":"2024-05-14 11:09:32.000000000","message":"can you explain why we need to do this?\n\nif the defaults work (\"Create New Network\" is selected), it will fulfill \u0027required: true\u0027\n\nif \"Create New Network\" is unselected, then the fixed_network \u0026 fixed_subnet has to be selected, as they are required. This will also meet \u0027required: true\u0027.\n\nam I missing something?","commit_id":"708b9d701fcfb806225673a744a5110af3498aa0"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"0fcc35b1923481a0fc2b62285c3d76b2f239a92c","unresolved":false,"context_lines":[{"line_number":349,"context_line":"              help: basePath + \u0027clusters/workflow/network.help.html\u0027,"},{"line_number":350,"context_line":"              type: \u0027section\u0027,"},{"line_number":351,"context_line":"              htmlClass: \u0027row\u0027,"},{"line_number":352,"context_line":"              required: false,"},{"line_number":353,"context_line":"              items: ["},{"line_number":354,"context_line":"                {"},{"line_number":355,"context_line":"                  type: \u0027section\u0027,"}],"source_content_type":"text/javascript","patch_set":7,"id":"47fc6788_03ebef63","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":29},"in_reply_to":"2cd58b67_60bacbb5","updated":"2024-05-15 23:25:43.000000000","message":"Discussed in weekly meeting the purpose of required (*). Adjusted in the next patchset to show again when \u0027create new network\u0027 is deselected, as there are now required options in the tab.","commit_id":"708b9d701fcfb806225673a744a5110af3498aa0"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"b259e3e2644a11fb534a71d79ca132a7386223f8","unresolved":true,"context_lines":[{"line_number":349,"context_line":"              help: basePath + \u0027clusters/workflow/network.help.html\u0027,"},{"line_number":350,"context_line":"              type: \u0027section\u0027,"},{"line_number":351,"context_line":"              htmlClass: \u0027row\u0027,"},{"line_number":352,"context_line":"              required: false,"},{"line_number":353,"context_line":"              items: ["},{"line_number":354,"context_line":"                {"},{"line_number":355,"context_line":"                  type: \u0027section\u0027,"}],"source_content_type":"text/javascript","patch_set":7,"id":"2cd58b67_60bacbb5","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":29},"in_reply_to":"7e6cb550_efead296","updated":"2024-05-14 20:32:20.000000000","message":"To me, \"required\" means there\u0027s something that *must* be changed in order to submit the form successfully.\n\nIn the case for our Cluster Templates there isn\u0027t - the defaults of \"create new network\" are acceptable and it\u0027s not required for the user to visit that tab. They can, but it\u0027s not mandatory to fill anything in there.\n\nUsing the Nova example, the create instance workflow there doesn\u0027t make \u0027keypair\u0027 or \u0027network ports\u0027 tabs \u0027required\u0027 because the defaults do launch an instance (maybe you can\u0027t log into it, but you can launch it!). You **must** select a flavor though, so that is \u0027required\u0027.","commit_id":"708b9d701fcfb806225673a744a5110af3498aa0"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"798a371a04072527f92948504dc32e6641b60d7a","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                          key: \u0027create_network\u0027,"},{"line_number":369,"context_line":"                          title: gettext(\u0027Create New Network\u0027),"},{"line_number":370,"context_line":"                          onChange: function(isNewNetwork) {"},{"line_number":371,"context_line":"                            if (!isNewNetwork) {"},{"line_number":372,"context_line":"                              model.fixed_network \u003d MODEL_DEFAULTS.fixed_network;"},{"line_number":373,"context_line":"                              model.fixed_subnet \u003d MODEL_DEFAULTS.fixed_subnet;"},{"line_number":374,"context_line":"                            }"}],"source_content_type":"text/javascript","patch_set":7,"id":"6394a621_7a0965ca","line":371,"updated":"2024-05-15 09:12:04.000000000","message":"I will re-test this change and ensure the behaviour change is what I expect.","commit_id":"708b9d701fcfb806225673a744a5110af3498aa0"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"0fcc35b1923481a0fc2b62285c3d76b2f239a92c","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                          key: \u0027create_network\u0027,"},{"line_number":369,"context_line":"                          title: gettext(\u0027Create New Network\u0027),"},{"line_number":370,"context_line":"                          onChange: function(isNewNetwork) {"},{"line_number":371,"context_line":"                            if (!isNewNetwork) {"},{"line_number":372,"context_line":"                              model.fixed_network \u003d MODEL_DEFAULTS.fixed_network;"},{"line_number":373,"context_line":"                              model.fixed_subnet \u003d MODEL_DEFAULTS.fixed_subnet;"},{"line_number":374,"context_line":"                            }"}],"source_content_type":"text/javascript","patch_set":7,"id":"b7c12712_7c079637","line":371,"in_reply_to":"6394a621_7a0965ca","updated":"2024-05-15 23:25:43.000000000","message":"So, this change fixes the following display bug which was present:\n1. Unselect \"Create new network\" checkbox.\n2. Observe `fixed_network` and `fixed_subnet` dropdowns are set to \"choose an existing ...\"\n3. Select \"Create new network\" checkbox.\n4. Unselect \"Create new network\" checkbox.\n5. Observe `fixed_network` and `fixed_subnet` dropdowns have empty text, and none of the dropdown fields are selected - not even \"choose an existing ...\".\n\n(During form submission, the values from the model that may still be set for `fixed_network` and `fixed_subnet` are ignored, so functionality-wise it doesn\u0027t matter when these are reset, or stay stored in the model. This is a UX only change)\n\nIn the next patchset I have removed the \u0027if\u0027 to *always* reset the model values to defaults when the checkbox value is changed **and** I have added logic to set the entire \u0027network\u0027 tab to \"required: true\" when this checkbox is deselected (ie. now the user **must** select a fixed network or fixed subnet to submit the form)","commit_id":"708b9d701fcfb806225673a744a5110af3498aa0"}],"releasenotes/notes/Workflow-updates-for-Create-Cluster-65e4fe510b4d1a4c.yaml":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"4a88057c1793a79c10a18663124f68a717ca5621","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    The Create Cluster workflow option `floating_ip` has been replaced with"},{"line_number":11,"context_line":"    `master_lb_floating_ip_enabled` as the former added floating IP\u0027s to"},{"line_number":12,"context_line":"    all nodes, whereas the replacement only adds a floating IP to the"},{"line_number":13,"context_line":"    K8s API loadbalancer itself. The label `floating_ip` has not changed"},{"line_number":14,"context_line":"    behaviour and can still be used via the advanced input field."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"76c3afa5_1fa058fb","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":72},"updated":"2024-05-09 12:59:29.000000000","message":"floating_ip_enabled isn\u0027t a label though, it is a param of cluster template.\n\nDoes it work if you set a label?","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"02c173a9739baae38775fb49de559007333cedb7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    The Create Cluster workflow option `floating_ip` has been replaced with"},{"line_number":11,"context_line":"    `master_lb_floating_ip_enabled` as the former added floating IP\u0027s to"},{"line_number":12,"context_line":"    all nodes, whereas the replacement only adds a floating IP to the"},{"line_number":13,"context_line":"    K8s API loadbalancer itself. The label `floating_ip` has not changed"},{"line_number":14,"context_line":"    behaviour and can still be used via the advanced input field."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c9221b85_ec91e66c","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":72},"in_reply_to":"1ce1be8f_cad03e11","updated":"2024-05-13 04:56:42.000000000","message":"Updated and moved to https://review.opendev.org/c/openstack/magnum-ui/+/919449","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"5d323547a3cfa705fee1226e3ba558b2553b99c0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    The Create Cluster workflow option `floating_ip` has been replaced with"},{"line_number":11,"context_line":"    `master_lb_floating_ip_enabled` as the former added floating IP\u0027s to"},{"line_number":12,"context_line":"    all nodes, whereas the replacement only adds a floating IP to the"},{"line_number":13,"context_line":"    K8s API loadbalancer itself. The label `floating_ip` has not changed"},{"line_number":14,"context_line":"    behaviour and can still be used via the advanced input field."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ce1be8f_cad03e11","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":72},"in_reply_to":"76c3afa5_1fa058fb","updated":"2024-05-09 21:24:12.000000000","message":"thanks, my mistake - I confused labels with param `floating_ip_enabled` when writing this. I\u0027ll update.","commit_id":"7cb276ca98df64f415fa5cd0d1635856b5afb022"}]}