)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"44d7c980e53b94fc18b301f36bdb0ae0d8025119","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da30f58e_7c5478fc","updated":"2024-05-07 02:18:53.000000000","message":"I think both points are valid, we do have lack of expertise in this and don\u0027t want warnings to block important fixes.\nOn the other hand, having npm fail on warnings will make sure each commit is good and we don\u0027t end up with a huge backlog of warnings to go through again.\n\nLet\u0027s merge this first and discuss in meeting.","commit_id":"8680420c34d655fbf100b59aab7f827cbd18ba65"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ecddfa96053f7a6df9a8d396fb095fb05193435","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf0c1c21_22e3bf4d","updated":"2024-05-06 06:55:20.000000000","message":"Should we make npm lint fail on warnings?","commit_id":"8680420c34d655fbf100b59aab7f827cbd18ba65"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"dfb9d9a188323fb573b28285d7b089308b673c23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99bb3058_bb5621c2","in_reply_to":"bf0c1c21_22e3bf4d","updated":"2024-05-06 21:04:00.000000000","message":"I\u0027m not sure on that - it might be too high of a goalpost for some patches in a repository we don\u0027t touch very often.\n\nThe biggest gain from doing this work was to make new warnings visible (instead of lost in a sea of noise), and reducing the cyclomatic complexity, which in turn improved branch coverage tests. \n\nThe little stuff is less important to enforce, if we don\u0027t have ongoing expertise in this repository.","commit_id":"8680420c34d655fbf100b59aab7f827cbd18ba65"}]}