)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"913e8c06307642b6fc83644e572c9e9e71eb0a41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f03da48_6a653a18","updated":"2024-10-22 09:55:59.000000000","message":"This works for us, and fixes https://bugs.launchpad.net/magnum-ui/+bug/2047106","commit_id":"162f40734ece692a4b8683504a920071a53a0443"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0b0ca28594d271d15d3614642e93fbd71386abd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65f41387_d82f1f2b","updated":"2024-11-13 16:48:29.000000000","message":"recheck - see if issue was intermittent","commit_id":"162f40734ece692a4b8683504a920071a53a0443"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fe7818a5d0dec17279ad6fe5d8fca8eeebb27731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"858bf15b_ddb26595","updated":"2024-11-13 16:50:47.000000000","message":"this seems to work for us as well","commit_id":"162f40734ece692a4b8683504a920071a53a0443"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9590f4c1d12fea72b22a44f2a3aa413867c87f65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"caade8b3_fa116e4d","updated":"2024-11-28 00:28:00.000000000","message":"Regression noted, but otherwise this is way better than the dialog being entirely broken!","commit_id":"4a8ca374f91710e2d904ebf1a22aefbc8dd7aa51"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"a647e6daa9ce2f6ffa10367d5941a0b84deb7ea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e68113b_aba70e08","updated":"2024-12-12 00:31:41.000000000","message":"Verified working. Looking good, thanks for the extra effort this took to separate the nodegroup counts.\n\n(Side note: I was seeing a 406 (Not Acceptable) response from Magnum API until I realised my local settings for `OPENSTACK_API_VERSIONS` was forcing magnum api version to 1.8. The default is 1.10)","commit_id":"970faead7b4910ed280844faa6414514ec0ce944"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"6d50f5154348e9ff534fdb96d8e778a9719ffb72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd1fc8ca_7ea346da","updated":"2024-12-11 09:20:28.000000000","message":"minor nit on a language string, else looks really good.","commit_id":"970faead7b4910ed280844faa6414514ec0ce944"}],"magnum_ui/static/dashboard/container-infra/clusters/resize/resize.service.js":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"9590f4c1d12fea72b22a44f2a3aa413867c87f65","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    function constructModalConfig(cluster, workerNodesList) {"},{"line_number":95,"context_line":"      formModel.original_node_count \u003d cluster.node_count;"},{"line_number":96,"context_line":"      formModel.node_count \u003d cluster.node_count;"},{"line_number":97,"context_line":"      formModel.worker_nodes \u003d workerNodesList;"},{"line_number":98,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"c9761517_c6aebfe5","line":95,"updated":"2024-11-28 00:28:00.000000000","message":"There\u0027s a regression here when multiple worker nodegroups exist. This code should instead find the size of the `default-worker` nodegroup and not use the count of all worker nodes.\n\nSee below line 187 where `default-worker` is explicitly used in the submit.\n\n(In general the UI (and API) is fairly poor at showing nodegroup detail, so I don\u0027t expect *that* to be fixed in this patchset!)\n\nReproduction steps:\n1. Create cluster with 1 control plane and 1 worker.\n2. Create an additional nodegroup with 2 worker nodes.\n3. Open the resize dialog and notice the value is \u00273\u0027 and not \u00271\u0027.\n4. Submit the dialog without changing anything and `default-worker` will resize from 1 to 3.\n5. Open the resize dialog and the new value is \u00275`!","commit_id":"4a8ca374f91710e2d904ebf1a22aefbc8dd7aa51"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"1f81b5ee7b403b53b085ead6b5f352be306ebbc6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    function constructModalConfig(cluster, workerNodesList) {"},{"line_number":95,"context_line":"      formModel.original_node_count \u003d cluster.node_count;"},{"line_number":96,"context_line":"      formModel.node_count \u003d cluster.node_count;"},{"line_number":97,"context_line":"      formModel.worker_nodes \u003d workerNodesList;"},{"line_number":98,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"5d4eeae1_fd651710","line":95,"in_reply_to":"8d8ed6bd_492d83af","updated":"2024-12-12 00:39:18.000000000","message":"Resolved in latest patchset.","commit_id":"4a8ca374f91710e2d904ebf1a22aefbc8dd7aa51"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"310524b4f9be4834cc21de18de9d6e6e1030edf7","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    function constructModalConfig(cluster, workerNodesList) {"},{"line_number":95,"context_line":"      formModel.original_node_count \u003d cluster.node_count;"},{"line_number":96,"context_line":"      formModel.node_count \u003d cluster.node_count;"},{"line_number":97,"context_line":"      formModel.worker_nodes \u003d workerNodesList;"},{"line_number":98,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"8d8ed6bd_492d83af","line":95,"in_reply_to":"c9761517_c6aebfe5","updated":"2024-11-28 21:49:14.000000000","message":"oops, me bad, didn\u0027t test this scenario\nI\u0027ll fix and write a test!","commit_id":"4a8ca374f91710e2d904ebf1a22aefbc8dd7aa51"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"6d50f5154348e9ff534fdb96d8e778a9719ffb72","unresolved":true,"context_lines":[{"line_number":118,"context_line":"        form: ["},{"line_number":119,"context_line":"          {"},{"line_number":120,"context_line":"            key: \u0027node_count\u0027,"},{"line_number":121,"context_line":"            title: gettext(\u0027Node Count (default-workers)\u0027),"},{"line_number":122,"context_line":"            placeholder: gettext(\u0027The default-workers nodegroup node_count.\u0027),"},{"line_number":123,"context_line":"            required: true,"},{"line_number":124,"context_line":"            validationMessage: {"}],"source_content_type":"text/javascript","patch_set":4,"id":"e7dfa7f5_2730d2ca","line":121,"updated":"2024-12-11 09:20:28.000000000","message":"don\u0027t pluralise this, it\u0027s fine being just the name of the nodegroup and may make translation harder.\n\n(same below in placeholder).","commit_id":"970faead7b4910ed280844faa6414514ec0ce944"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"99ea5e4f8b9e72825b47d771e19e6541902bc249","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        form: ["},{"line_number":119,"context_line":"          {"},{"line_number":120,"context_line":"            key: \u0027node_count\u0027,"},{"line_number":121,"context_line":"            title: gettext(\u0027Node Count (default-workers)\u0027),"},{"line_number":122,"context_line":"            placeholder: gettext(\u0027The default-workers nodegroup node_count.\u0027),"},{"line_number":123,"context_line":"            required: true,"},{"line_number":124,"context_line":"            validationMessage: {"}],"source_content_type":"text/javascript","patch_set":4,"id":"ac5b75b6_bf1c4124","line":121,"in_reply_to":"e7dfa7f5_2730d2ca","updated":"2024-12-18 20:48:33.000000000","message":"Done","commit_id":"970faead7b4910ed280844faa6414514ec0ce944"}]}