)]}'
{"magnum/conductor/tasks/heat_tasks.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"31f295332b611c1084ec3c49f93691b497078df6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import taskflow.task as task"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class HeatTask(task.Task):"},{"line_number":19,"context_line":"    def __init__(self, os_client, name\u003dNone, **kwargs):"},{"line_number":20,"context_line":"        self.os_client \u003d os_client"},{"line_number":21,"context_line":"        super(HeatTask, self).__init__(name\u003dname, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_501e4764","line":18,"updated":"2015-03-06 09:12:45.000000000","message":"I think it should be inherited from BaseTask in magnum/conductor/tasks/__init__.py or BaseTask should be removed as it is not used anywhere.","commit_id":"45acd726d06a9a576e74d3ca3a2d40d9d768e4b3"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"7e131991294c325c35fa91910740feef8ea24509","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import taskflow.task as task"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class HeatTask(task.Task):"},{"line_number":19,"context_line":"    def __init__(self, os_client, name\u003dNone, **kwargs):"},{"line_number":20,"context_line":"        self.os_client \u003d os_client"},{"line_number":21,"context_line":"        super(HeatTask, self).__init__(name\u003dname, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_dfa77a4e","line":18,"in_reply_to":"9a80dd14_501e4764","updated":"2015-03-07 06:09:00.000000000","message":"Thanks!","commit_id":"45acd726d06a9a576e74d3ca3a2d40d9d768e4b3"}],"magnum/tests/conductor/tasks/test_heat_tasks.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"31f295332b611c1084ec3c49f93691b497078df6","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"        flow \u003d self._get_update_stack_flow(heat_client)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertRaises(ValueError, engines.run, flow, store\u003dflow_store)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_delete_stack(self):"},{"line_number":128,"context_line":"        heat_client \u003d mock.MagicMock(name\u003d\u0027heat_client\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b564d549","line":125,"updated":"2015-03-06 09:12:45.000000000","message":"Can you please add more test like:\n\n1. test_update_non_existing_stack\n2. test_delete_non_existing_stack","commit_id":"45acd726d06a9a576e74d3ca3a2d40d9d768e4b3"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"7e131991294c325c35fa91910740feef8ea24509","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"        flow \u003d self._get_update_stack_flow(heat_client)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.assertRaises(ValueError, engines.run, flow, store\u003dflow_store)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_delete_stack(self):"},{"line_number":128,"context_line":"        heat_client \u003d mock.MagicMock(name\u003d\u0027heat_client\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_bfae462c","line":125,"in_reply_to":"9a80dd14_b564d549","updated":"2015-03-07 06:09:00.000000000","message":"These tasks is not responsible for these errors. so I think these tests are not necessary.","commit_id":"45acd726d06a9a576e74d3ca3a2d40d9d768e4b3"}]}