)]}'
{"magnum/templates/heat-kubernetes/kubecluster-fedora-ironic.yaml":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ee2fc70107d3f44630bba73f726a475cc7b7c59c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \"$FLANNEL_USE_VXLAN\": {get_param: flannel_use_vxlan}"},{"line_number":109,"context_line":"            \"$PORTAL_NETWORK_CIDR\": {get_param: portal_network_cidr}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  write_heat_params_deployment:"},{"line_number":112,"context_line":"    type: OS::Heat::SoftwareDeployment"},{"line_number":113,"context_line":"    depends_on: disable_selinux_deployment"},{"line_number":114,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_b2466f4d","side":"PARENT","line":111,"updated":"2015-07-07 22:54:48.000000000","message":"Since all software deployments are removed, I guess we can remove the \"os-*\" elements on building the Ironic image https://github.com/openstack/magnum/tree/master/magnum/templates/heat-kubernetes/elements","commit_id":"01c8671430853f9d7499ec92a6e0273c2d0d5449"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"1349ec43660d4fffb865e557f54bf7a478634fa3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  ssh_key_name:"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    description: name of ssh key to be provisioned on our server"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  external_network_id:"},{"line_number":18,"context_line":"    type: string"},{"line_number":19,"context_line":"    description: uuid of a network to use for floating ip addresses"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_2d4a3d84","line":16,"updated":"2015-07-07 01:25:55.000000000","message":"Latest heat-template changes parameter from external_network_id to external_network.","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0ec6fab75232779de6074b42d31faea7d5404f62","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  ssh_key_name:"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    description: name of ssh key to be provisioned on our server"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  external_network_id:"},{"line_number":18,"context_line":"    type: string"},{"line_number":19,"context_line":"    description: uuid of a network to use for floating ip addresses"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_3014984b","line":16,"in_reply_to":"ba3cc151_2d4a3d84","updated":"2015-07-08 00:06:53.000000000","message":"Done","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ee2fc70107d3f44630bba73f726a475cc7b7c59c","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ######################################################################"},{"line_number":79,"context_line":"  #"},{"line_number":80,"context_line":"  # software configs and deployments."},{"line_number":81,"context_line":"  #"},{"line_number":82,"context_line":"  disable_selinux:"},{"line_number":83,"context_line":"    type: \"OS::Heat::SoftwareConfig\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_37a2514c","line":80,"updated":"2015-07-07 22:54:48.000000000","message":"It looks software deployments are removed in this patch, so maybe update the comments to \"software configs\"","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0ec6fab75232779de6074b42d31faea7d5404f62","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  ######################################################################"},{"line_number":79,"context_line":"  #"},{"line_number":80,"context_line":"  # software configs and deployments."},{"line_number":81,"context_line":"  #"},{"line_number":82,"context_line":"  disable_selinux:"},{"line_number":83,"context_line":"    type: \"OS::Heat::SoftwareConfig\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_f00ab025","line":80,"in_reply_to":"ba3cc151_37a2514c","updated":"2015-07-08 00:06:53.000000000","message":"Done","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"1349ec43660d4fffb865e557f54bf7a478634fa3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        - config: {get_resource: enable_etcd}"},{"line_number":95,"context_line":"        - config: {get_resource: configure_kubernetes}"},{"line_number":96,"context_line":"        - config: {get_resource: enable_services}"},{"line_number":97,"context_line":"        - config: {get_resource: configure_flannel}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  write_heat_params:"},{"line_number":100,"context_line":"    type: \"OS::Heat::SoftwareConfig\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_ff08782a","line":97,"updated":"2015-07-07 01:25:55.000000000","message":"please add wait condition handle here to track finishing stack status.","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0ec6fab75232779de6074b42d31faea7d5404f62","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        - config: {get_resource: enable_etcd}"},{"line_number":95,"context_line":"        - config: {get_resource: configure_kubernetes}"},{"line_number":96,"context_line":"        - config: {get_resource: enable_services}"},{"line_number":97,"context_line":"        - config: {get_resource: configure_flannel}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  write_heat_params:"},{"line_number":100,"context_line":"    type: \"OS::Heat::SoftwareConfig\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_53004601","line":97,"in_reply_to":"ba3cc151_ff08782a","updated":"2015-07-08 00:06:53.000000000","message":"Done","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"1349ec43660d4fffb865e557f54bf7a478634fa3","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  kube_master_floating:"},{"line_number":142,"context_line":"    type: \"OS::Neutron::FloatingIP\""},{"line_number":143,"context_line":"    properties:"},{"line_number":144,"context_line":"      floating_network_id:"},{"line_number":145,"context_line":"        get_param: external_network_id"},{"line_number":146,"context_line":"      port_id:"},{"line_number":147,"context_line":"        get_attr: [kube_master, addresses, {get_param: fixed_network}, 0, port]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_cd59515d","line":144,"updated":"2015-07-07 01:25:55.000000000","message":"change to\n\nfloating_network: {get_param: external_network}","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0ec6fab75232779de6074b42d31faea7d5404f62","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  kube_master_floating:"},{"line_number":142,"context_line":"    type: \"OS::Neutron::FloatingIP\""},{"line_number":143,"context_line":"    properties:"},{"line_number":144,"context_line":"      floating_network_id:"},{"line_number":145,"context_line":"        get_param: external_network_id"},{"line_number":146,"context_line":"      port_id:"},{"line_number":147,"context_line":"        get_attr: [kube_master, addresses, {get_param: fixed_network}, 0, port]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_13063e1c","line":144,"in_reply_to":"ba3cc151_cd59515d","updated":"2015-07-08 00:06:53.000000000","message":"Done","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ee2fc70107d3f44630bba73f726a475cc7b7c59c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  kube_minions_external:"},{"line_number":188,"context_line":"    value: {get_attr: [kube_minions, kube_node_external_ip]}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  address:"},{"line_number":191,"context_line":"    value: {get_attr: [kube_master, addresses]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_b72ae18e","line":190,"updated":"2015-07-07 22:54:48.000000000","message":"s/address/addresses/ , although I am not sure why this extra output is needed.","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0ec6fab75232779de6074b42d31faea7d5404f62","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  kube_minions_external:"},{"line_number":188,"context_line":"    value: {get_attr: [kube_minions, kube_node_external_ip]}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  address:"},{"line_number":191,"context_line":"    value: {get_attr: [kube_master, addresses]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_931a4e6e","line":190,"in_reply_to":"ba3cc151_b72ae18e","updated":"2015-07-08 00:06:53.000000000","message":"it was used for debug, have removed now. Thanks","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"928d1006f633d65f372c9c8c62a41803b736c83a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    type: number"},{"line_number":78,"context_line":"    description : \u003e"},{"line_number":79,"context_line":"      timeout for the Wait Conditions"},{"line_number":80,"context_line":"    default: 6000"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"resources:"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba3cc151_375487fc","line":80,"updated":"2015-07-08 04:35:19.000000000","message":"This value seems very high to me. Perhaps 1800 would be more appropriate? Ideally thus setting would come from a parameter that can be tweaked from the Magnum client code.","commit_id":"bb8f509b0300f16e2e1de3a59033871c0e7d80c0"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"841d1f8efa0ba22dede78c8d0b5c03b80d91eec1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    type: number"},{"line_number":78,"context_line":"    description : \u003e"},{"line_number":79,"context_line":"      timeout for the Wait Conditions"},{"line_number":80,"context_line":"    default: 6000"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"resources:"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba3cc151_973d5391","line":80,"in_reply_to":"ba3cc151_375487fc","updated":"2015-07-08 04:38:41.000000000","message":"Hi @Adrian, it was all used in other tempaltes, right now, we\u0027d better make ironic templates work as others.  And then can improve that. As that aslo for k8s, coreos, etc.","commit_id":"bb8f509b0300f16e2e1de3a59033871c0e7d80c0"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"d4e2d77d589141bc1dc2e54fdf94589279473188","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      floating_network:"},{"line_number":183,"context_line":"        get_param: external_network"},{"line_number":184,"context_line":"      port_id:"},{"line_number":185,"context_line":"        get_attr: [kube_master, addresses, {get_param: fixed_network}, 0, port]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  kube_master:"},{"line_number":188,"context_line":"    type: \"OS::Nova::Server\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba3cc151_68b43081","line":185,"updated":"2015-07-09 06:42:23.000000000","message":"I failed to create floating ip, because port has two ip addresses.\nerror message is below.\n\n    BadRequest: resources.kube_master_floating: Bad floatingip request: Port a1c0f9d0-533a-40f4-bc8c-18324464340a has multiple fixed IPs.  Must provide a specific IP when assigning a floating IP\n\nCurrently, devstack create two subnet in fixed network, it means port has two addresses.\nSo we should specify the ip address to create floating ip.","commit_id":"52268629c159e50e7070ddf177a2f4709ef34fbb"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"c0ed0c35e874e7e8b2e93b572d536b585762068e","unresolved":false,"context_lines":[{"line_number":201,"context_line":"  kube_minions:"},{"line_number":202,"context_line":"    type: \"OS::Heat::ResourceGroup\""},{"line_number":203,"context_line":"    depends_on:"},{"line_number":204,"context_line":"      - kube_master"},{"line_number":205,"context_line":"      - master_wait_condition"},{"line_number":206,"context_line":"    properties:"},{"line_number":207,"context_line":"      count: {get_param: number_of_minions}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba3cc151_427a6e25","line":204,"updated":"2015-07-09 02:55:02.000000000","message":"I think this line is not needed, because master_wait_condition is enough.","commit_id":"52268629c159e50e7070ddf177a2f4709ef34fbb"}],"magnum/templates/heat-kubernetes/kubenode-fedora-ironic.yaml":[{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"1349ec43660d4fffb865e557f54bf7a478634fa3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      - kube_node"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      handle: {get_resource: node_wait_handle}"},{"line_number":55,"context_line":"      timeout: 6000"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  ######################################################################"},{"line_number":58,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_3f74a09a","line":55,"updated":"2015-07-07 01:25:55.000000000","message":"In the latest heat-template source, timeout: is used as a parameter, can you do the same here?","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0ec6fab75232779de6074b42d31faea7d5404f62","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      - kube_node"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      handle: {get_resource: node_wait_handle}"},{"line_number":55,"context_line":"      timeout: 6000"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  ######################################################################"},{"line_number":58,"context_line":"  #"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_9331eeef","line":55,"in_reply_to":"ba3cc151_3f74a09a","updated":"2015-07-08 00:06:53.000000000","message":"Done","commit_id":"398e5a871662816093b912f93e73c8974cbbcba8"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"928d1006f633d65f372c9c8c62a41803b736c83a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    description: Network from which to allocate fixed addresses."},{"line_number":43,"context_line":"  wait_condition_timeout:"},{"line_number":44,"context_line":"    type: number"},{"line_number":45,"context_line":"    default: 6000"},{"line_number":46,"context_line":"    description : \u003e"},{"line_number":47,"context_line":"      timeout for the Wait Conditions"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba3cc151_d75c3b1b","line":45,"updated":"2015-07-08 04:35:19.000000000","message":"Again, this would be better as a parameter we could set from the client.","commit_id":"bb8f509b0300f16e2e1de3a59033871c0e7d80c0"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"841d1f8efa0ba22dede78c8d0b5c03b80d91eec1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    description: Network from which to allocate fixed addresses."},{"line_number":43,"context_line":"  wait_condition_timeout:"},{"line_number":44,"context_line":"    type: number"},{"line_number":45,"context_line":"    default: 6000"},{"line_number":46,"context_line":"    description : \u003e"},{"line_number":47,"context_line":"      timeout for the Wait Conditions"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba3cc151_174aa326","line":45,"in_reply_to":"ba3cc151_d75c3b1b","updated":"2015-07-08 04:38:41.000000000","message":"as comment in other file. pls check. Thanks","commit_id":"bb8f509b0300f16e2e1de3a59033871c0e7d80c0"}]}