)]}'
{"magnum/api/controllers/v1/bay.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"5d09a0e6b288bb5146078609c94a2cb106cb6821","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        bay_dict[\u0027project_id\u0027] \u003d auth_token[\u0027project\u0027][\u0027id\u0027]"},{"line_number":268,"context_line":"        bay_dict[\u0027user_id\u0027] \u003d auth_token[\u0027user\u0027][\u0027id\u0027]"},{"line_number":269,"context_line":"        # NOTE(suro-patz): Apply default node_count is 1, None -\u003e 1"},{"line_number":270,"context_line":"        if \u0027node_count\u0027 in bay_dict.keys():"},{"line_number":271,"context_line":"            if bay_dict[\u0027node_count\u0027] is None:"},{"line_number":272,"context_line":"                bay_dict[\u0027node_count\u0027] \u003d 1"},{"line_number":273,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_9d65f6e2","line":270,"updated":"2015-08-03 16:44:58.000000000","message":"Agree with Hongbin, a better solution would be.\n\nif bay_dict.get(\u0027node_count\u0027, None) is None:\n        bay_dict[\u0027node_count\u0027] \u003d 1","commit_id":"316f36148749bf8c96161bb7bfdd6ccf2046b087"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"4ca4412aa0af795d8eefd16b28f8d485769711ec","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        bay_dict[\u0027project_id\u0027] \u003d auth_token[\u0027project\u0027][\u0027id\u0027]"},{"line_number":268,"context_line":"        bay_dict[\u0027user_id\u0027] \u003d auth_token[\u0027user\u0027][\u0027id\u0027]"},{"line_number":269,"context_line":"        # NOTE(suro-patz): Apply default node_count is 1, None -\u003e 1"},{"line_number":270,"context_line":"        if \u0027node_count\u0027 in bay_dict.keys():"},{"line_number":271,"context_line":"            if bay_dict[\u0027node_count\u0027] is None:"},{"line_number":272,"context_line":"                bay_dict[\u0027node_count\u0027] \u003d 1"},{"line_number":273,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_24f138ce","line":270,"updated":"2015-08-03 14:27:27.000000000","message":"I doubt either if branch or else branch is redundant. In particular, when users create a bay without a node_count, it will always hit the if branch (or else branch). Is that correct? If yes, the redundant branch should be removed.","commit_id":"316f36148749bf8c96161bb7bfdd6ccf2046b087"},{"author":{"_account_id":15311,"name":"Surojit Pathak","email":"surojit.pathak@gmail.com","username":"suropathak"},"change_message_id":"505a5c2950eb3efbff31cad092f7a210101d0dc8","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        bay_dict[\u0027project_id\u0027] \u003d auth_token[\u0027project\u0027][\u0027id\u0027]"},{"line_number":268,"context_line":"        bay_dict[\u0027user_id\u0027] \u003d auth_token[\u0027user\u0027][\u0027id\u0027]"},{"line_number":269,"context_line":"        # NOTE(suro-patz): Apply default node_count is 1, None -\u003e 1"},{"line_number":270,"context_line":"        if \u0027node_count\u0027 in bay_dict.keys():"},{"line_number":271,"context_line":"            if bay_dict[\u0027node_count\u0027] is None:"},{"line_number":272,"context_line":"                bay_dict[\u0027node_count\u0027] \u003d 1"},{"line_number":273,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_ce11865f","line":270,"in_reply_to":"1a4dcd0f_24f138ce","updated":"2015-08-03 18:03:38.000000000","message":"@Hongbin,\nI do not think any of the branch is redundant here. We are doing the initialization with default value at API. The request may come from magnum-client, GUI, or any REST client. So depending on how the client forms the bay_dict, following are the possibilities -\n\n1. bay_dict does have a \u0027node_count\u0027\n    1.a value for \u0027node_count\u0027 may be None\n    1.b value for \u0027node_count\u0027 may be an integer \u003e\u003d 1\n2. bay_dict does not have a \u0027node_count\u0027\n\nThe present code addresses 1.a and 2 to initialize.\n\nHaving said that, I find Tom\u0027s suggested code is more compact and satisfies all the conditions.","commit_id":"316f36148749bf8c96161bb7bfdd6ccf2046b087"},{"author":{"_account_id":15311,"name":"Surojit Pathak","email":"surojit.pathak@gmail.com","username":"suropathak"},"change_message_id":"505a5c2950eb3efbff31cad092f7a210101d0dc8","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        bay_dict[\u0027project_id\u0027] \u003d auth_token[\u0027project\u0027][\u0027id\u0027]"},{"line_number":268,"context_line":"        bay_dict[\u0027user_id\u0027] \u003d auth_token[\u0027user\u0027][\u0027id\u0027]"},{"line_number":269,"context_line":"        # NOTE(suro-patz): Apply default node_count is 1, None -\u003e 1"},{"line_number":270,"context_line":"        if \u0027node_count\u0027 in bay_dict.keys():"},{"line_number":271,"context_line":"            if bay_dict[\u0027node_count\u0027] is None:"},{"line_number":272,"context_line":"                bay_dict[\u0027node_count\u0027] \u003d 1"},{"line_number":273,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_4e06d621","line":270,"in_reply_to":"1a4dcd0f_9d65f6e2","updated":"2015-08-03 18:03:38.000000000","message":"Done","commit_id":"316f36148749bf8c96161bb7bfdd6ccf2046b087"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"ec61973d3bc85307eff28da0724f0e72cb6b3337","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        auth_token \u003d context.auth_token_info[\u0027token\u0027]"},{"line_number":267,"context_line":"        bay_dict[\u0027project_id\u0027] \u003d auth_token[\u0027project\u0027][\u0027id\u0027]"},{"line_number":268,"context_line":"        bay_dict[\u0027user_id\u0027] \u003d auth_token[\u0027user\u0027][\u0027id\u0027]"},{"line_number":269,"context_line":"        # NOTE(suro-patz): Apply default node_count is 1, None -\u003e 1"},{"line_number":270,"context_line":"        if bay_dict.get(\u0027node_count\u0027, None) is None:"},{"line_number":271,"context_line":"            bay_dict[\u0027node_count\u0027] \u003d 1"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_b99f6f4f","line":269,"updated":"2015-08-04 14:14:09.000000000","message":"I think here should be NOTE(Madhuri) ;-)","commit_id":"c9e251cba40d5190684e6891873a11e325e3ec6a"}],"magnum/tests/unit/api/controllers/v1/test_bay.py":[{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"adb2383b8725b20abc4fe5eaab94fb321cdba324","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":477,"context_line":"        self.assertEqual(201, response.status_int)"},{"line_number":478,"context_line":"        self.assertEqual(1, response.json[\u0027node_count\u0027])"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def test_create_bay_with_invalid_long_name(self):"},{"line_number":481,"context_line":"        bdict \u003d apiutils.bay_post_data(name\u003d\u0027x\u0027 * 256)"},{"line_number":482,"context_line":"        response \u003d self.post_json(\u0027/bays\u0027, bdict, expect_errors\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_319ee107","line":479,"updated":"2015-08-01 13:57:01.000000000","message":"Should there be a test for the case of {\u0027node_count\u0027:None}  ?  It seems this code path is not covered.","commit_id":"316f36148749bf8c96161bb7bfdd6ccf2046b087"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"5d09a0e6b288bb5146078609c94a2cb106cb6821","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":477,"context_line":"        self.assertEqual(201, response.status_int)"},{"line_number":478,"context_line":"        self.assertEqual(1, response.json[\u0027node_count\u0027])"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def test_create_bay_with_invalid_long_name(self):"},{"line_number":481,"context_line":"        bdict \u003d apiutils.bay_post_data(name\u003d\u0027x\u0027 * 256)"},{"line_number":482,"context_line":"        response \u003d self.post_json(\u0027/bays\u0027, bdict, expect_errors\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_7dca6a51","line":479,"in_reply_to":"3a50d1a3_319ee107","updated":"2015-08-03 16:44:58.000000000","message":"+1","commit_id":"316f36148749bf8c96161bb7bfdd6ccf2046b087"}]}