)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e9620bf8424fcf5e33b4336993712d2f26ce2359","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Adds Combined Support for Container Network Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds network_driver to the following:"},{"line_number":10,"context_line":"  1. api baymodel"},{"line_number":11,"context_line":"  2. conductor template defintions and entrypoints"},{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_4c2abf91","line":10,"updated":"2015-08-20 06:06:41.000000000","message":"Just a suggestion can you tell more what values right now are supported,\nother than flannel. if only few values are supported than this field should \nneed validation like coe field of bay model","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"814367ac49f6fd281fe6ddeac4aa79eb69f12869","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: Adds Combined Support for Container Network Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds network_driver to the following:"},{"line_number":10,"context_line":"  1. api baymodel"},{"line_number":11,"context_line":"  2. conductor template defintions and entrypoints"},{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_fe1c6e6b","line":10,"in_reply_to":"fa1b9901_4c2abf91","updated":"2015-08-20 20:29:46.000000000","message":"initially i see flannel or libnetwork.","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"b74c1bfb5cfea108be97f5ae1ca73963416ccb16","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I312ec863919543aa8ca5d215a028d3a44a9003c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_69ae31e9","line":15,"updated":"2015-08-21 17:22:12.000000000","message":"Does this implement any blueprint or tries to solve an already opened bug ? If yes please mention it.","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"670867dc33a171c4b4a67fc0aca3df17c3b91846","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I312ec863919543aa8ca5d215a028d3a44a9003c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_091695a7","line":15,"in_reply_to":"fa1b9901_69ae31e9","updated":"2015-08-21 17:37:24.000000000","message":"It does address a couple bp\u0027s. I was lazy since it\u0027s a WIP, but I will add them.","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"74e41b703ddc5823f53ac3f73a2a9bfb7ab0ffdd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I312ec863919543aa8ca5d215a028d3a44a9003c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_08128a57","line":15,"updated":"2015-09-03 22:13:41.000000000","message":"does it implements or partially implements any bp ?","commit_id":"abf2718bafbd232b39bcbf02a09672d2d163daab"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"51b1b663b4acbdb67e491ba05f8691a28dd4f897","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I312ec863919543aa8ca5d215a028d3a44a9003c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_38445c45","line":15,"in_reply_to":"da20952f_08128a57","updated":"2015-09-11 21:49:07.000000000","message":"Done","commit_id":"abf2718bafbd232b39bcbf02a09672d2d163daab"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"c2e9ad10ddaf290e5d9d62a395f066577cd4cb47","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I312ec863919543aa8ca5d215a028d3a44a9003c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_538a53c0","line":15,"in_reply_to":"da20952f_08128a57","updated":"2015-09-04 18:14:41.000000000","message":"I would guess this blueprint extend-baymodel-net-attributes  ?","commit_id":"abf2718bafbd232b39bcbf02a09672d2d163daab"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"51b1b663b4acbdb67e491ba05f8691a28dd4f897","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  3. a column to db model"},{"line_number":13,"context_line":"  4. Tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I312ec863919543aa8ca5d215a028d3a44a9003c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_9869e8c2","line":15,"in_reply_to":"da20952f_538a53c0","updated":"2015-09-11 21:49:07.000000000","message":"Done","commit_id":"abf2718bafbd232b39bcbf02a09672d2d163daab"}],"magnum/conductor/template_definition.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9ae54ef5611e67e42d39a51fc2bebc2ffcf425f7","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                           required\u003dTrue)"},{"line_number":357,"context_line":"        self.add_parameter(\u0027network_driver\u0027,"},{"line_number":358,"context_line":"                           baymodel_attr\u003d\u0027network_driver\u0027,"},{"line_number":359,"context_line":"                           required\u003dTrue)"},{"line_number":360,"context_line":"        # TODO(yuanying): Add below lines if apiserver_port parameter"},{"line_number":361,"context_line":"        # is supported"},{"line_number":362,"context_line":"        # self.add_parameter(\u0027apiserver_port\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_dd993fd2","line":359,"updated":"2015-08-21 15:58:16.000000000","message":"I think it is better to make this parameter optional and let individual template pick the default.","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"670867dc33a171c4b4a67fc0aca3df17c3b91846","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                           required\u003dTrue)"},{"line_number":357,"context_line":"        self.add_parameter(\u0027network_driver\u0027,"},{"line_number":358,"context_line":"                           baymodel_attr\u003d\u0027network_driver\u0027,"},{"line_number":359,"context_line":"                           required\u003dTrue)"},{"line_number":360,"context_line":"        # TODO(yuanying): Add below lines if apiserver_port parameter"},{"line_number":361,"context_line":"        # is supported"},{"line_number":362,"context_line":"        # self.add_parameter(\u0027apiserver_port\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_696cf136","line":359,"in_reply_to":"fa1b9901_dd993fd2","updated":"2015-08-21 17:37:24.000000000","message":"Done","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"}],"magnum/db/sqlalchemy/alembic/versions/130e097b5cf2_add_network_driver_baymodel_column.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f28744297b36c3ca07e6fc1c8dc87317050e9d4d","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027baymodel\u0027, sa.Column(\u0027network_driver\u0027,"},{"line_number":35,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027images\u0027,"},{"line_number":37,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":38,"context_line":"                    nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_2b074819","line":35,"updated":"2015-08-28 21:02:09.000000000","message":"I don\u0027t think we need any other parameter in this file as these are auto generated I\u0027ll suggest remove, test and revise it","commit_id":"b342a70efe81324b52f1b1c885d5c0b73796ceb3"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"91d95e1c75567068968208c9e0e0d6f34bd1f27a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027baymodel\u0027, sa.Column(\u0027network_driver\u0027,"},{"line_number":35,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027images\u0027,"},{"line_number":37,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":38,"context_line":"                    nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_382d3c8f","line":35,"in_reply_to":"da20952f_2b074819","updated":"2015-09-11 21:48:37.000000000","message":"Done","commit_id":"b342a70efe81324b52f1b1c885d5c0b73796ceb3"},{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"b1b09d3ed59d280b0d5c48e112cbdb46c3eed91c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                    nullable\u003dTrue)"},{"line_number":42,"context_line":"    op.alter_column(\u0027replicationcontroller\u0027, \u0027images\u0027,"},{"line_number":43,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":44,"context_line":"                    nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_da569329","line":44,"updated":"2015-08-29 01:14:01.000000000","message":"You should not alter other columns except network_driver.","commit_id":"b342a70efe81324b52f1b1c885d5c0b73796ceb3"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"91d95e1c75567068968208c9e0e0d6f34bd1f27a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                    nullable\u003dTrue)"},{"line_number":42,"context_line":"    op.alter_column(\u0027replicationcontroller\u0027, \u0027images\u0027,"},{"line_number":43,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":44,"context_line":"                    nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_183078e8","line":44,"in_reply_to":"da20952f_da569329","updated":"2015-09-11 21:48:37.000000000","message":"Done","commit_id":"b342a70efe81324b52f1b1c885d5c0b73796ceb3"}],"magnum/db/sqlalchemy/alembic/versions/179d44d91994_add_network_driver_column.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"89ef58261c3cfeb7efa350d6875e31f5276a59c6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027baymodel\u0027, sa.Column(\u0027network_driver\u0027,"},{"line_number":35,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027images\u0027,"},{"line_number":37,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":38,"context_line":"                    nullable\u003dTrue)"},{"line_number":39,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_da5e2579","line":36,"updated":"2015-08-21 15:52:16.000000000","message":"Why need to alter column?","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"670867dc33a171c4b4a67fc0aca3df17c3b91846","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027baymodel\u0027, sa.Column(\u0027network_driver\u0027,"},{"line_number":35,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027images\u0027,"},{"line_number":37,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":38,"context_line":"                    nullable\u003dTrue)"},{"line_number":39,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_0999b51f","line":36,"in_reply_to":"fa1b9901_da5e2579","updated":"2015-08-21 17:37:24.000000000","message":"Not sure why. This was auto generated by alembic:\n\nhttps://github.com/openstack/magnum/tree/master/magnum/db/sqlalchemy/alembic\n\nPlease let me know if you feel I should change anything.","commit_id":"47f2bb1bf5500bcd4ec515f808b049a2b0bf83a3"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"12d69a161eec4a3a01be03736d114af33ccc9ea3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027baymodel\u0027, sa.Column(\u0027network_driver\u0027,"},{"line_number":35,"context_line":"                  sa.String(length\u003d255), nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027images\u0027,"},{"line_number":37,"context_line":"                    existing_type\u003dmysql.TEXT(),"},{"line_number":38,"context_line":"                    nullable\u003dTrue)"},{"line_number":39,"context_line":"    op.alter_column(\u0027pod\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b57337e7","line":36,"updated":"2015-08-21 20:41:11.000000000","message":"remove extra fields from here I think only \u0027network_driver \u0027 is required here","commit_id":"69d06739f4ad098428152e493e1ffef9044001e4"}],"magnum/tests/unit/api/controllers/v1/test_baymodel.py":[{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"34e3b38b85e8a9789664f9fc27c37c6e7b4adb7a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertNotIn(\u0027keypair_id\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":55,"context_line":"        self.assertNotIn(\u0027external_network_id\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":56,"context_line":"        self.assertNotIn(\u0027fixed_network\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":57,"context_line":"        self.assertNotIn(\u0027network_driver\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":58,"context_line":"        self.assertNotIn(\u0027docker_volume_size\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":59,"context_line":"        self.assertNotIn(\u0027ssh_authorized_key\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b8b9ae17","line":57,"updated":"2015-08-24 16:00:13.000000000","message":"Is network_driver a required or optional parameter with a default value?  If it is optional, maybe we should add a test creating the bay model without specifying network_driver to see the default value filled in.","commit_id":"69d06739f4ad098428152e493e1ffef9044001e4"},{"author":{"_account_id":6836,"name":"Daneyon Hansen","email":"danehans@cisco.com","username":"danehans"},"change_message_id":"936af5a2fc8a2ac31a9a7cd6276041e686fc48cf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertNotIn(\u0027keypair_id\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":55,"context_line":"        self.assertNotIn(\u0027external_network_id\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":56,"context_line":"        self.assertNotIn(\u0027fixed_network\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":57,"context_line":"        self.assertNotIn(\u0027network_driver\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":58,"context_line":"        self.assertNotIn(\u0027docker_volume_size\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":59,"context_line":"        self.assertNotIn(\u0027ssh_authorized_key\u0027, response[\u0027baymodels\u0027][0])"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b8094c2d","line":57,"in_reply_to":"fa1b9901_b8b9ae17","updated":"2015-09-11 21:47:58.000000000","message":"optional. I updated the code accordingly.","commit_id":"69d06739f4ad098428152e493e1ffef9044001e4"}]}