)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"dcda323c016a19e255f61ce4c5b928a2177c7423","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lei-zhang-99cloud \u003czhang.lei@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-26 17:48:17 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add portType on port option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to http://docs.openstack.org/developer/oslo.config/cfg.html"},{"line_number":10,"context_line":"oslo.config can use portType to support the ability to set valid range"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_61add887","line":7,"updated":"2015-08-27 00:26:39.000000000","message":"port_type","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"31dea2afe770715cfbc771361c86dba0ca82dff6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to http://docs.openstack.org/developer/oslo.config/cfg.html"},{"line_number":10,"context_line":"oslo.config can use portType to support the ability to set valid range"},{"line_number":11,"context_line":"on port option values"},{"line_number":12,"context_line":"Closes-Bug: #1488861"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic4310532f4155ade1706f0bca8df9466665aea97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_5926a317","line":11,"updated":"2015-08-26 15:54:02.000000000","message":"Leave one blank line after you finish brief explanation. makes easily readable. \n\nref: good examples here https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"0a2b0ebbfce669ad03201abc6e810e266b42e992","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to http://docs.openstack.org/developer/oslo.config/cfg.html"},{"line_number":10,"context_line":"oslo.config can use portType to support the ability to set valid range"},{"line_number":11,"context_line":"on port option values"},{"line_number":12,"context_line":"Closes-Bug: #1488861"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic4310532f4155ade1706f0bca8df9466665aea97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_53743cfc","line":11,"in_reply_to":"da20952f_5926a317","updated":"2015-08-26 17:32:56.000000000","message":"+1","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"}],"magnum/common/config.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"42c0a04db91e0c78515b24fb07cdd4be8d54f4c8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from magnum.common import rpc"},{"line_number":22,"context_line":"from magnum import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_type \u003d types.Integer(1, 65535)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def parse_args(argv, default_config_files\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_80de3d6b","line":24,"updated":"2015-08-26 14:23:18.000000000","message":"nit. Prefer \u0027PortType\u0027 instead of \u0027port_type\u0027","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"dcda323c016a19e255f61ce4c5b928a2177c7423","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from magnum.common import rpc"},{"line_number":22,"context_line":"from magnum import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_type \u003d types.Integer(1, 65535)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def parse_args(argv, default_config_files\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_81d82c1f","line":24,"in_reply_to":"da20952f_b39ef805","updated":"2015-08-27 00:26:39.000000000","message":"I still prefer port_type as OpenStack is always using such format for some configuration parameters.","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"0a2b0ebbfce669ad03201abc6e810e266b42e992","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from magnum.common import rpc"},{"line_number":22,"context_line":"from magnum import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_type \u003d types.Integer(1, 65535)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def parse_args(argv, default_config_files\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b39ef805","line":24,"in_reply_to":"fa1b9901_78588131","updated":"2015-08-26 17:32:56.000000000","message":"Agree with Tom +1","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"dcda323c016a19e255f61ce4c5b928a2177c7423","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from magnum.common import rpc"},{"line_number":22,"context_line":"from magnum import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_type \u003d types.Integer(1, 65535)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def parse_args(argv, default_config_files\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_01ec1cc6","line":24,"in_reply_to":"fa1b9901_80de3d6b","updated":"2015-08-27 00:26:39.000000000","message":"I think that python coding style do not like such format.","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"b62800bdbb6ad24b625bb4e710cced81c2f5c720","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from magnum.common import rpc"},{"line_number":22,"context_line":"from magnum import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_type \u003d types.Integer(1, 65535)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def parse_args(argv, default_config_files\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_78588131","line":24,"in_reply_to":"fa1b9901_80de3d6b","updated":"2015-08-26 15:06:43.000000000","message":"Think it should be PORT_TYPE as per other constants in magnum, see https://github.com/openstack/magnum/blob/master/magnum/common/rpc.py#L39","commit_id":"3d1cdccbf61930070a4d034cd0ea377bf5fc0446"}]}