)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a436996b35dca77302c9ffca4d25bd689d929b09","unresolved":false,"context_lines":[{"line_number":16,"context_line":"oslo_versionedobjects contains a fixture for helping generate and test"},{"line_number":17,"context_line":"these hashes, so this fixture is used to test Magnum\u0027s object hashes."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I586f73570dc7b65c83b216d09d11e8dba3c63b2c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_af439f6b","line":19,"updated":"2015-09-02 21:38:08.000000000","message":"does it implements a bluerprint or Closes a Bug.?\ninfo is required if it is WIP, bp or bug?","commit_id":"410166f06043dd0c152ee5574f8901ab3f106a57"}],"magnum/tests/unit/objects/test_objects.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"85d22469a8aba8aa3957d926ef6a4a22cb2fecad","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    \u0027Pod\u0027: \u00271.0-69b579203c6d726be7878c606626e438\u0027,"},{"line_number":428,"context_line":"    \u0027ReplicationController\u0027: \u00271.0-782b7deb9307b2807101541b7e58b8a2\u0027,"},{"line_number":429,"context_line":"    \u0027Service\u0027: \u00271.0-d4b8c0f3a234aec35d273196e18f7ed1\u0027,"},{"line_number":430,"context_line":"    \u0027X509KeyPair\u0027: \u00271.0-e8caa6ddcb64a0dc47b34cb5227656b2\u0027,"},{"line_number":431,"context_line":"}"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_edcea482","line":430,"updated":"2015-08-27 10:36:41.000000000","message":"although can find code it use md5 to get the figerprint, But I \u0027d like you added detailed comments here, how to update the data when ever changes happen, else, it would cost much time to fix the unit test failure in future.","commit_id":"e6c3dbfc1ced492da58fe0bd53579efd4fec54ef"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"5f357777cf2420081e3fbb39e94cb5170dbf406e","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    \u0027Pod\u0027: \u00271.0-69b579203c6d726be7878c606626e438\u0027,"},{"line_number":428,"context_line":"    \u0027ReplicationController\u0027: \u00271.0-782b7deb9307b2807101541b7e58b8a2\u0027,"},{"line_number":429,"context_line":"    \u0027Service\u0027: \u00271.0-d4b8c0f3a234aec35d273196e18f7ed1\u0027,"},{"line_number":430,"context_line":"    \u0027X509KeyPair\u0027: \u00271.0-e8caa6ddcb64a0dc47b34cb5227656b2\u0027,"},{"line_number":431,"context_line":"}"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_07864213","line":430,"in_reply_to":"da20952f_6d2b74ec","updated":"2015-08-27 16:31:45.000000000","message":"Done","commit_id":"e6c3dbfc1ced492da58fe0bd53579efd4fec54ef"},{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"27d3ac289937d401dd82788ada68f4dca2e50344","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    \u0027Pod\u0027: \u00271.0-69b579203c6d726be7878c606626e438\u0027,"},{"line_number":428,"context_line":"    \u0027ReplicationController\u0027: \u00271.0-782b7deb9307b2807101541b7e58b8a2\u0027,"},{"line_number":429,"context_line":"    \u0027Service\u0027: \u00271.0-d4b8c0f3a234aec35d273196e18f7ed1\u0027,"},{"line_number":430,"context_line":"    \u0027X509KeyPair\u0027: \u00271.0-e8caa6ddcb64a0dc47b34cb5227656b2\u0027,"},{"line_number":431,"context_line":"}"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6d2b74ec","line":430,"in_reply_to":"da20952f_edcea482","updated":"2015-08-27 10:39:19.000000000","message":"+1","commit_id":"e6c3dbfc1ced492da58fe0bd53579efd4fec54ef"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"f45215cdd4440f35116002aac25cb5938dc00b76","unresolved":false,"context_lines":[{"line_number":432,"context_line":"# static fingerprints tree (object_data)."},{"line_number":433,"context_line":"#"},{"line_number":434,"context_line":"# In this case, I would need to update the version to 1.1, and copy the"},{"line_number":435,"context_line":"# fingerprint in the \"actual\" output into this static tree."},{"line_number":436,"context_line":"object_data \u003d {"},{"line_number":437,"context_line":"    \u0027Bay\u0027: \u00271.0-61d1573a6e83c31f8c458a241fc17fa1\u0027,"},{"line_number":438,"context_line":"    \u0027BayLock\u0027: \u00271.0-7d1eb08cf2070523bd210369c7a2e076\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3db9ae15","line":435,"updated":"2015-08-31 00:47:55.000000000","message":"1. hi, if I understood it correctly. whenever changes happen in objects(db), we would increase version, right ?\n\n2. another point, if 1) is true, how to get the md5 output ?\n\nlike 9f5e63ccf6cd486c4f913c309751a159, we also need to update that, but I did not get know from above comments, where to get the actual output ?","commit_id":"c37bb6fd9b39de26dea36937a7a7ce1603642c23"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"8f0110a8aa3061d04e217bf4f9f962147cfa23c7","unresolved":false,"context_lines":[{"line_number":432,"context_line":"# static fingerprints tree (object_data)."},{"line_number":433,"context_line":"#"},{"line_number":434,"context_line":"# In this case, I would need to update the version to 1.1, and copy the"},{"line_number":435,"context_line":"# fingerprint in the \"actual\" output into this static tree."},{"line_number":436,"context_line":"object_data \u003d {"},{"line_number":437,"context_line":"    \u0027Bay\u0027: \u00271.0-61d1573a6e83c31f8c458a241fc17fa1\u0027,"},{"line_number":438,"context_line":"    \u0027BayLock\u0027: \u00271.0-7d1eb08cf2070523bd210369c7a2e076\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_5cbd7fb5","line":435,"in_reply_to":"da20952f_3db9ae15","updated":"2015-08-31 06:15:17.000000000","message":"+1 If there is a documentation available that you could provide that will be helpful for all the developers.","commit_id":"c37bb6fd9b39de26dea36937a7a7ce1603642c23"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"033b8e1d876e46d43d4519a89f4785727602e013","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"# This is a static dictionary that holds all fingerprints of the versioned"},{"line_number":419,"context_line":"# objects registered with the MagnumRegistry. Each fingerprint contains"},{"line_number":420,"context_line":"# the version of the object and an md5 hash of RPC-critical parts of the"},{"line_number":421,"context_line":"# object. If either the version or hash change, the static tree needs to be"},{"line_number":422,"context_line":"# updated."},{"line_number":423,"context_line":"# Example: I added a field to Container, but forgot to update the version."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_cc690fc0","line":420,"updated":"2015-09-03 18:44:28.000000000","message":"Just to understand this better what are these RPC-critical parts for an object ?","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"b6cfacdbb8b26c4e80a1ee60e5dd38a6fe64c501","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"# This is a static dictionary that holds all fingerprints of the versioned"},{"line_number":419,"context_line":"# objects registered with the MagnumRegistry. Each fingerprint contains"},{"line_number":420,"context_line":"# the version of the object and an md5 hash of RPC-critical parts of the"},{"line_number":421,"context_line":"# object. If either the version or hash change, the static tree needs to be"},{"line_number":422,"context_line":"# updated."},{"line_number":423,"context_line":"# Example: I added a field to Container, but forgot to update the version."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_cc5fcf3f","line":420,"in_reply_to":"da20952f_cc690fc0","updated":"2015-09-03 18:56:38.000000000","message":"It is anything that cam be executed/accessed remotely. The fixture in oslo.versionedobjects checks for fields and remotable methods when considering version checks.","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"033b8e1d876e46d43d4519a89f4785727602e013","unresolved":false,"context_lines":[{"line_number":419,"context_line":"# objects registered with the MagnumRegistry. Each fingerprint contains"},{"line_number":420,"context_line":"# the version of the object and an md5 hash of RPC-critical parts of the"},{"line_number":421,"context_line":"# object. If either the version or hash change, the static tree needs to be"},{"line_number":422,"context_line":"# updated."},{"line_number":423,"context_line":"# Example: I added a field to Container, but forgot to update the version."},{"line_number":424,"context_line":"#"},{"line_number":425,"context_line":"# The unit tests fail with the following error:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_2cf52bec","line":422,"updated":"2015-09-03 18:44:28.000000000","message":"What happens if the version of the object is not updated but an additional column is added to the object ? Will the hash be still updated ?","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"b6cfacdbb8b26c4e80a1ee60e5dd38a6fe64c501","unresolved":false,"context_lines":[{"line_number":419,"context_line":"# objects registered with the MagnumRegistry. Each fingerprint contains"},{"line_number":420,"context_line":"# the version of the object and an md5 hash of RPC-critical parts of the"},{"line_number":421,"context_line":"# object. If either the version or hash change, the static tree needs to be"},{"line_number":422,"context_line":"# updated."},{"line_number":423,"context_line":"# Example: I added a field to Container, but forgot to update the version."},{"line_number":424,"context_line":"#"},{"line_number":425,"context_line":"# The unit tests fail with the following error:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_4c197f87","line":422,"in_reply_to":"da20952f_2cf52bec","updated":"2015-09-03 18:56:38.000000000","message":"The hash will be updated, and that signals to the developer that the version should be updated.","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"033b8e1d876e46d43d4519a89f4785727602e013","unresolved":false,"context_lines":[{"line_number":427,"context_line":"# actual    \u003d {\u0027Container\u0027: \u00271.0-8542a94420e306698ac1e2afd1cd6248\u0027}"},{"line_number":428,"context_line":"# : Fields or remotable methods in some objects have changed. Make sure the"},{"line_number":429,"context_line":"# versions of the objects has been bumped, and update the hashes in the"},{"line_number":430,"context_line":"# static fingerprints tree (object_data)."},{"line_number":431,"context_line":"#"},{"line_number":432,"context_line":"# In this case, I would need to update the version to 1.1, and copy the"},{"line_number":433,"context_line":"# fingerprint in the \"actual\" output into this static tree."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_0cc70799","line":430,"updated":"2015-09-03 18:44:28.000000000","message":"Thanks for this example. This helps.","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"033b8e1d876e46d43d4519a89f4785727602e013","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    \u0027Bay\u0027: \u00271.0-35edde13ad178e9419e7ea8b6d580bcd\u0027,"},{"line_number":436,"context_line":"    \u0027BayLock\u0027: \u00271.0-7d1eb08cf2070523bd210369c7a2e076\u0027,"},{"line_number":437,"context_line":"    \u0027BayModel\u0027: \u00271.0-06863f04ab4b98307e3d1b736d3137bf\u0027,"},{"line_number":438,"context_line":"    \u0027Container\u0027: \u00271.0-e12affbba5f8a748882a3ae98aced282\u0027,"},{"line_number":439,"context_line":"    \u0027MyObj\u0027: \u00271.0-b43567e512438205e32f4e95ca616697\u0027,"},{"line_number":440,"context_line":"    \u0027Node\u0027: \u00271.0-30943e6e3387a2fae7490b57c4239a17\u0027,"},{"line_number":441,"context_line":"    \u0027Pod\u0027: \u00271.0-69b579203c6d726be7878c606626e438\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ccfa6fbd","line":438,"updated":"2015-09-03 18:44:28.000000000","message":"Should this be 1.0-8542a94420e306698ac1e2afd1cd6248 or is this the new hash calulated after the version changed to 1.1 ; since you updated the Container object ?","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"b6cfacdbb8b26c4e80a1ee60e5dd38a6fe64c501","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    \u0027Bay\u0027: \u00271.0-35edde13ad178e9419e7ea8b6d580bcd\u0027,"},{"line_number":436,"context_line":"    \u0027BayLock\u0027: \u00271.0-7d1eb08cf2070523bd210369c7a2e076\u0027,"},{"line_number":437,"context_line":"    \u0027BayModel\u0027: \u00271.0-06863f04ab4b98307e3d1b736d3137bf\u0027,"},{"line_number":438,"context_line":"    \u0027Container\u0027: \u00271.0-e12affbba5f8a748882a3ae98aced282\u0027,"},{"line_number":439,"context_line":"    \u0027MyObj\u0027: \u00271.0-b43567e512438205e32f4e95ca616697\u0027,"},{"line_number":440,"context_line":"    \u0027Node\u0027: \u00271.0-30943e6e3387a2fae7490b57c4239a17\u0027,"},{"line_number":441,"context_line":"    \u0027Pod\u0027: \u00271.0-69b579203c6d726be7878c606626e438\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_af5ccd19","line":438,"in_reply_to":"da20952f_ccfa6fbd","updated":"2015-09-03 18:56:38.000000000","message":"This is the correct hash for the Container object at HEAD. The version of Container is still 1.0. If any of these differ from the objects at HEAD, I\u0027ll fail py27 in gate on my own test below.","commit_id":"0ff78d918f5964ecfe316ce473fadfe59cdb554c"}]}