)]}'
{"magnum/db/sqlalchemy/api.py":[{"author":{"_account_id":16839,"name":"Cale Rath","email":"ctrath@us.ibm.com","username":"ctrath"},"change_message_id":"4f7a2a0c1165aa250a6caf76adbce7eefb1f6da4","unresolved":false,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    def get_rcs_by_bay_uuid(self, context, bay_uuid):"},{"line_number":890,"context_line":"        # First verify whether the Bay exists"},{"line_number":891,"context_line":"        bay_ref \u003d self.get_bay_by_uuid(context, bay_uuid)"},{"line_number":892,"context_line":"        query \u003d model_query(models.ReplicationController).filter_by("},{"line_number":893,"context_line":"            bay_uuid\u003dbay_uuid)"},{"line_number":894,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b99bf271","line":891,"updated":"2015-08-27 20:18:07.000000000","message":"nit: any reason why you are setting bay_ref?  It appears that you call get_bay_by_uuid to raise an exception if the bay doesn\u0027t exist only, so I don\u0027t believe you need to set bay_ref.","commit_id":"38cda00b19ee6925a7e3a70ce517e210a4e14f7a"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"bc9bb9cf33de4c242dd19f8cdc556d5f8e1d4463","unresolved":false,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    def get_rcs_by_bay_uuid(self, context, bay_uuid):"},{"line_number":890,"context_line":"        # First verify whether the Bay exists"},{"line_number":891,"context_line":"        bay_ref \u003d self.get_bay_by_uuid(context, bay_uuid)"},{"line_number":892,"context_line":"        query \u003d model_query(models.ReplicationController).filter_by("},{"line_number":893,"context_line":"            bay_uuid\u003dbay_uuid)"},{"line_number":894,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6f7d88e6","line":891,"in_reply_to":"da20952f_b99bf271","updated":"2015-08-27 21:07:06.000000000","message":"Yes I agree. My bad.","commit_id":"38cda00b19ee6925a7e3a70ce517e210a4e14f7a"}],"magnum/objects/replicationcontroller.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"88fccf95b358e216ea108a1da3139491ae7bebf1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return rc"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @base.remotable_classmethod"},{"line_number":103,"context_line":"    def list_by_bay_uuid(cls, context, bay_uuid):"},{"line_number":104,"context_line":"        \"\"\"Return a list of :class:`ReplicationController`"},{"line_number":105,"context_line":"        objects associated with a given bay."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_fdd9f657","line":103,"updated":"2015-08-31 00:57:56.000000000","message":"but I did not notice where we would call this ?","commit_id":"d39578354229365379e09489824fea55c584ff83"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"e2d711e4270006ba2a87bda0fca5020ca12d2695","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return rc"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @base.remotable_classmethod"},{"line_number":103,"context_line":"    def list_by_bay_uuid(cls, context, bay_uuid):"},{"line_number":104,"context_line":"        \"\"\"Return a list of :class:`ReplicationController`"},{"line_number":105,"context_line":"        objects associated with a given bay."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6ba50e45","line":103,"in_reply_to":"da20952f_fdd9f657","updated":"2015-08-31 11:15:30.000000000","message":"@Vilobh\n\nI guess these changes are in continuation with https://review.openstack.org/#/c/213368/.","commit_id":"d39578354229365379e09489824fea55c584ff83"}],"magnum/tests/unit/db/test_replicationcontroller.py":[{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"8d559ff83d5b5709ecd5b935d898ea8ce8560f35","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertRaises(exception.BayNotFound,"},{"line_number":115,"context_line":"                          self.dbapi.get_rcs_by_bay_uuid,"},{"line_number":116,"context_line":"                          self.context,"},{"line_number":117,"context_line":"                          magnum_utils.generate_uuid())"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_destroy_rc(self):"},{"line_number":120,"context_line":"        self.dbapi.destroy_rc(self.rc.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3ba58cb4","line":117,"updated":"2015-08-28 01:57:20.000000000","message":"I think you should add a test case which tests the situation that rcs not found.","commit_id":"d39578354229365379e09489824fea55c584ff83"}]}