)]}'
{"magnum/tests/conf_fixture.py":[{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"2612e79e3a97bfc965729d2dad50e87d80a4b419","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from magnum.common import config"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cfg.CONF.import_opt(\u0027host\u0027, \u0027magnum.common.service\u0027)"},{"line_number":24,"context_line":"log.register_options(cfg.CONF)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_d4e7683e","line":23,"updated":"2015-09-03 14:23:55.000000000","message":"It is redundant. Please remove it.","commit_id":"4eb503d8e1476b24b44fbce0fa54d955a38b12b4"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"fa4c10af07ce4cc01e9d25358f948a58b8244153","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from magnum.common import config"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cfg.CONF.import_opt(\u0027host\u0027, \u0027magnum.common.service\u0027)"},{"line_number":24,"context_line":"log.register_options(cfg.CONF)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ab74b8fd","line":23,"in_reply_to":"da20952f_d4e7683e","updated":"2015-09-03 23:13:11.000000000","message":"If this is removed, test will be failed.","commit_id":"4eb503d8e1476b24b44fbce0fa54d955a38b12b4"}],"magnum/tests/unit/test_opts.py":[{"author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"change_message_id":"db705ea37d5f9e70ff47b2801b66574d348996a4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class OptsTestCase(base.BaseTestCase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_list_opts(self):"},{"line_number":22,"context_line":"        self.assertIsInstance(opts.list_opts(), list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_aa30979f","line":22,"updated":"2015-09-02 05:05:11.000000000","message":"I believe this test just check that opts.list_opts() has type list. I think make sense to check that this list has right values  [\u0027host\u0027, \u0027magnum.common.service\u0027]","commit_id":"b51c487a37edd71c9b7a3af3fa88317643816cbc"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"856212427a728af773a319359c866736aef823e2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class OptsTestCase(base.BaseTestCase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_list_opts(self):"},{"line_number":22,"context_line":"        self.assertIsInstance(opts.list_opts(), list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_d7c33389","line":22,"in_reply_to":"da20952f_aa30979f","updated":"2015-09-02 07:22:05.000000000","message":"But I think, if we check right values, right values will be entirely same as list_opts().","commit_id":"b51c487a37edd71c9b7a3af3fa88317643816cbc"}]}
