)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"38778463b9a9bd3bf62494e49356175ad6d0cade","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With docker, users have an option to specify memory size when"},{"line_number":10,"context_line":"creating containers. This patch bring this capability to Magnum."},{"line_number":11,"context_line":"Specifying memory size is optional but recommended. Containers"},{"line_number":12,"context_line":"without memory size specified are assumed to take 0 memory, which"},{"line_number":13,"context_line":"has no QoS guarantee."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ife88284402ff39a7b2e051f6e66913e502f2ba8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_8da051a7","line":12,"updated":"2015-10-02 05:18:35.000000000","message":"Containers without memory size specified are assumed to take 0 memory.\n\u003e\u003e\u003e\u003e\u003e\u003e Is that true? imho, the memory size is unlimited if not specifying memory when create a docker container.","commit_id":"e6c585f99fe3a2d3374a35b9449a83a0c6db35ff"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"42c6ac10c246dff3c6682ce85fad7833c01c5ee9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With docker, users have an option to specify memory size when"},{"line_number":10,"context_line":"creating containers. This patch bring this capability to Magnum."},{"line_number":11,"context_line":"Specifying memory size is optional but recommended. Containers"},{"line_number":12,"context_line":"without memory size specified are assumed to take 0 memory, which"},{"line_number":13,"context_line":"has no QoS guarantee."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ife88284402ff39a7b2e051f6e66913e502f2ba8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_edd78deb","line":12,"in_reply_to":"9a1a9d01_8da051a7","updated":"2015-10-02 05:31:12.000000000","message":"If did not set memory for a container, then inside the container, when you run the command \"cat /proc/meminfo\", the memsize will be same as the docker server; if you check the value from cgroup, you will see the memory size is unlimited.","commit_id":"e6c585f99fe3a2d3374a35b9449a83a0c6db35ff"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"2406a97fa11407855748a84337b81bcd96902383","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With docker, users have an option to specify memory size when"},{"line_number":10,"context_line":"creating containers. This patch bring this capability to Magnum."},{"line_number":11,"context_line":"Specifying memory size is optional but recommended. Containers"},{"line_number":12,"context_line":"without memory size specified are assumed to take 0 memory, which"},{"line_number":13,"context_line":"has no QoS guarantee."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ife88284402ff39a7b2e051f6e66913e502f2ba8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_e5bbf873","line":12,"in_reply_to":"9a1a9d01_ae789cf9","updated":"2015-10-03 11:30:19.000000000","message":"Thanks Hongbin. I think that the \"docker inspect ID\" does not show the exact value of memory and cpushare in a container. Even though you will see both \"Memory\" and \"Cpushare\" as 0 with \"docker inspect ID\" if you did not set those two values when run a container, the actual value for Cpushare is 1024 and Memory is unlimitted if you check the files under /sys/fs/cgroup/memory/docker\n\nroot@devstack007:/sys/fs/cgroup/memory/docker/6251b00eb5cbc0a7453974caa9c83455266393c738812c3e62a83e1e470ec3d8# cat memory.limit_in_bytes \n18446744073709551615\nroot@devstack007:/sys/fs/cgroup/cpu/docker/6251b00eb5cbc0a7453974caa9c83455266393c738812c3e62a83e1e470ec3d8# cat cpu.shares \n1024","commit_id":"e6c585f99fe3a2d3374a35b9449a83a0c6db35ff"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"80e0c1e46989136a4152086516e9939b09027b27","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With docker, users have an option to specify memory size when"},{"line_number":10,"context_line":"creating containers. This patch bring this capability to Magnum."},{"line_number":11,"context_line":"Specifying memory size is optional but recommended. Containers"},{"line_number":12,"context_line":"without memory size specified are assumed to take 0 memory, which"},{"line_number":13,"context_line":"has no QoS guarantee."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ife88284402ff39a7b2e051f6e66913e502f2ba8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_13e0c4f9","line":12,"in_reply_to":"9a1a9d01_ae789cf9","updated":"2015-10-02 17:53:48.000000000","message":"That would be nice. Thanks !","commit_id":"e6c585f99fe3a2d3374a35b9449a83a0c6db35ff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"aca8b8f671418f807bff9f79e2f54232e3790683","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With docker, users have an option to specify memory size when"},{"line_number":10,"context_line":"creating containers. This patch bring this capability to Magnum."},{"line_number":11,"context_line":"Specifying memory size is optional but recommended. Containers"},{"line_number":12,"context_line":"without memory size specified are assumed to take 0 memory, which"},{"line_number":13,"context_line":"has no QoS guarantee."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ife88284402ff39a7b2e051f6e66913e502f2ba8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_ae789cf9","line":12,"in_reply_to":"9a1a9d01_edd78deb","updated":"2015-10-02 14:02:44.000000000","message":"Jay, I tried to create a container with memory unset. I saw the memory is 0 when I did \"docker inspect ID\", but agree with you. The commit message causes confusion. I will rephrase it.","commit_id":"e6c585f99fe3a2d3374a35b9449a83a0c6db35ff"}],"magnum/api/controllers/v1/container.py":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"4932b703afebb09d617dd4f550034d149949e19c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    \"\"\"The status of container\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    memory \u003d wtypes.text"},{"line_number":96,"context_line":"    \"\"\"The memory size of container\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, **kwargs):"},{"line_number":99,"context_line":"        self.fields \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_6a295e9a","line":96,"updated":"2015-09-30 22:03:19.000000000","message":"Consider: Memory limit for the container. Example: 512m\n\nThis is a subtle difference that can indicate the truth that the container may consume between 0 and the specified value, as well as giving the user a clue that it may include units.","commit_id":"bef01423f075f8c86fa8794aebc64ee4e811130c"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"b0730cf47f859526fb11064ecb2c08a15280feec","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    \"\"\"The status of container\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    memory \u003d wtypes.text"},{"line_number":96,"context_line":"    \"\"\"The memory size of container\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, **kwargs):"},{"line_number":99,"context_line":"        self.fields \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_0d2ebcfa","line":96,"in_reply_to":"9a1a9d01_6a295e9a","updated":"2015-09-30 22:15:45.000000000","message":"+1","commit_id":"bef01423f075f8c86fa8794aebc64ee4e811130c"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d9ca812dbad98fc0b8857294c38658d56b1d968d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    \"\"\"The status of container\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    memory \u003d wtypes.text"},{"line_number":96,"context_line":"    \"\"\"The memory size of container\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, **kwargs):"},{"line_number":99,"context_line":"        self.fields \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_48502232","line":96,"in_reply_to":"9a1a9d01_6a295e9a","updated":"2015-09-30 22:53:32.000000000","message":"Done","commit_id":"bef01423f075f8c86fa8794aebc64ee4e811130c"}],"magnum/db/sqlalchemy/alembic/versions/33ef79969018_add_memory_to_container.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"5f6daa6d628ee29109bad5aae034174101003c05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies Co.,LTD."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_33ecd128","line":1,"updated":"2015-10-04 07:28:30.000000000","message":"I don\u0027t think this company info needed here","commit_id":"454911f8308f672b5c4499fd4958a157929dc78d"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"8e9978017e9008b802bc1ec914037c7cf282eb8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies Co.,LTD."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_29d30261","line":1,"in_reply_to":"9a1a9d01_33ecd128","updated":"2015-10-04 14:49:46.000000000","message":"The presence of a copyright notice is neither required nor problematic. this contribution was made in accordance with the guidelines of the license and the above line does not diminish the rights to use, modify, or redistribute  the contribution under the terms of the license. We can safely merge this code without a revision to this header.","commit_id":"454911f8308f672b5c4499fd4958a157929dc78d"}],"magnum/db/sqlalchemy/api.py":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"b0730cf47f859526fb11064ecb2c08a15280feec","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if \u0027user_id\u0027 in filters:"},{"line_number":430,"context_line":"            query \u003d query.filter_by(user_id\u003dfilters[\u0027user_id\u0027])"},{"line_number":431,"context_line":"        if \u0027memory\u0027 in filters:"},{"line_number":432,"context_line":"            query \u003d query.filter_by(memory\u003dfilters[\u0027memory\u0027])"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        return query"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_cdfc4474","line":432,"updated":"2015-09-30 22:15:45.000000000","message":"How does this look to you ?\n\nif filters is None:\n    filters \u003d []\n\npossible_filters \u003d  [\"name\", \"image\", \"project_id\", \"user_id\", \"memory\"]\n\nfilter_names \u003d set(filters).intersection(possible_filters)\nfilter_dict \u003d {filter_name: filters[filter_name]\n                    for filter_name in filter_names}\n\nreturn query.filter_by(**filter_dict)","commit_id":"bef01423f075f8c86fa8794aebc64ee4e811130c"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d9ca812dbad98fc0b8857294c38658d56b1d968d","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if \u0027user_id\u0027 in filters:"},{"line_number":430,"context_line":"            query \u003d query.filter_by(user_id\u003dfilters[\u0027user_id\u0027])"},{"line_number":431,"context_line":"        if \u0027memory\u0027 in filters:"},{"line_number":432,"context_line":"            query \u003d query.filter_by(memory\u003dfilters[\u0027memory\u0027])"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        return query"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_887b9abd","line":432,"in_reply_to":"9a1a9d01_cdfc4474","updated":"2015-09-30 22:53:32.000000000","message":"Fixed it, in a different way.","commit_id":"bef01423f075f8c86fa8794aebc64ee4e811130c"}]}