)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0d6f5e3d332d98ee70b79fd1801f45bd73961e16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use trusts for TLS cert generation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we use the users auth token, which expire after a while."},{"line_number":10,"context_line":"We need to use a trust_id instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1503863"},{"line_number":13,"context_line":"Change-Id: I18162485575794e533fbcbac5fec3790b4d37c64"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_fee15c9b","line":10,"updated":"2015-10-13 08:50:51.000000000","message":"From you code fix, it only target swarm. If just swarm need such fix, please specfic clearly swarm only.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"f305e4024b517b1ad217abb307e38606d21a7de7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use trusts for TLS cert generation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we use the users auth token, which expire after a while."},{"line_number":10,"context_line":"We need to use a trust_id instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1503863"},{"line_number":13,"context_line":"Change-Id: I18162485575794e533fbcbac5fec3790b4d37c64"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_728da87a","line":10,"in_reply_to":"7a2fa921_fee15c9b","updated":"2015-10-13 15:41:07.000000000","message":"+1. I\u0027ll update the commit message.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"}],"magnum/common/keystone.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0d6f5e3d332d98ee70b79fd1801f45bd73961e16","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027tls_delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_be644449","line":27,"updated":"2015-10-13 08:50:51.000000000","message":"1.for here default tls_**, what else configuration could be ?\n\nis it bind to tls only ?\n\n2. althogh we not branch yet, but you add a new opts, do we need expose it to users?\n\nif that case, you need make sure conf.exmaple updated with this","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"f305e4024b517b1ad217abb307e38606d21a7de7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027tls_delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_52be6c00","line":27,"in_reply_to":"7a2fa921_be644449","updated":"2015-10-13 15:41:07.000000000","message":"Good point Kai. Yes, these roles are meant for TLS only. I will update the ops name to reflect that.\n\nI\u0027ll update the example conf file too.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0d6f5e3d332d98ee70b79fd1801f45bd73961e16","unresolved":false,"context_lines":[{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027tls_delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_fe1cfcc2","line":28,"updated":"2015-10-13 08:50:51.000000000","message":"s/magnum/Magnum","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1d373a3d253ea84ae69dda724aad36fefc02fd7b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_9cdfbb0c","line":27,"updated":"2015-10-15 22:11:01.000000000","message":"A role with name \u0027delegation_role\u0027 needs to be pre-created via devstack. Otherwise, it will incur a 404 error.","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d30358009a71c028e6ac36995e5fbc6df208618e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_c0b1a648","line":27,"in_reply_to":"5a2ca52d_4cb40334","updated":"2015-10-16 14:01:35.000000000","message":"@Murali, the gate failed because of the endpoint issue commented by @yuanying. After solving it, you should see a 404 role not found error. And yes, I believe the role needs to be pre-created.","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"9a60bda7e9d92e3162693054d8b6743ea622880e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_4cb40334","line":27,"in_reply_to":"5a2ca52d_66f1e100","updated":"2015-10-16 07:02:21.000000000","message":"@Hongbin: To make the devstack gate pass, should I add this role to the  keystone our devstack is talking to?","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"change_message_id":"71042db42dd6fb26eb2b0c4ad9de4c980f2e75df","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_b2017b07","line":27,"in_reply_to":"5a2ca52d_9cdfbb0c","updated":"2015-10-16 01:25:49.000000000","message":"@Hongbin: does it also mean that operator need to create this role during Magnum setup?","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"af19a3a86adb47b9110dd6dbe76df6376f701454","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_6729e836","line":27,"in_reply_to":"5a2ca52d_9cdfbb0c","updated":"2015-10-15 22:27:52.000000000","message":"Are you sure about this Hongbin?\n\nI wonder how the previous revision of this patch passed the devstack gate. I was doing the same thing before. see below.\n\nhttps://review.openstack.org/#/c/232152/2/magnum/conductor/template_definition.py","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"518cc6983cbe8d271bb435844bcd2666039ff913","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_d56501b5","line":27,"in_reply_to":"5a2ca52d_b2017b07","updated":"2015-10-16 02:10:47.000000000","message":"@Egor: The operator needs to change this default value to a role that they have defined in keystone. That\u0027s the reason I did not want to include a default value such as admin. This will force the operator to change the default value when deploying magnum.","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"change_message_id":"62520f61df49f4b85028cec9b7d9026fb59d44e1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"trust_opts \u003d ["},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027trusts_delegated_roles\u0027,"},{"line_number":27,"context_line":"                default\u003d[\u0027delegation_role\u0027],"},{"line_number":28,"context_line":"                help\u003d_(\u0027Subset of trustor roles to be delegated to Magnum.\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"CONF.register_opts(trust_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_66f1e100","line":27,"in_reply_to":"5a2ca52d_d56501b5","updated":"2015-10-16 04:24:10.000000000","message":"@Murali: thx for clarification, it it\u0027s the case lets put example ins sample config back","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2cb4a81a20f89abad07d3009c0b662145a23d0f5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                kwargs[\u0027auth_ref\u0027] \u003d self.context.auth_token_info[\u0027access\u0027]"},{"line_number":104,"context_line":"                kwargs[\u0027auth_ref\u0027][\u0027version\u0027] \u003d \u0027v2.0\u0027"},{"line_number":105,"context_line":"            elif self._is_v3_valid(self.context.auth_token_info):"},{"line_number":106,"context_line":"                kwargs[\u0027auth_ref\u0027] \u003d self.context.auth_token_info[\u0027token\u0027]"},{"line_number":107,"context_line":"                kwargs[\u0027auth_ref\u0027][\u0027version\u0027] \u003d \u0027v3\u0027"},{"line_number":108,"context_line":"            else:"},{"line_number":109,"context_line":"                LOG.error(_LE(\u0027Unknown version in auth_token_info\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_7c3e5fdb","line":106,"updated":"2015-10-15 22:16:23.000000000","message":"To address @yuanying\u0027s comment about wrong keystone endpoint, you can set the correct endpoint to kwargs:\n\nkwargs[\u0027endpoint\u0027] \u003d self.auth_url","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"9a60bda7e9d92e3162693054d8b6743ea622880e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                kwargs[\u0027auth_ref\u0027] \u003d self.context.auth_token_info[\u0027access\u0027]"},{"line_number":104,"context_line":"                kwargs[\u0027auth_ref\u0027][\u0027version\u0027] \u003d \u0027v2.0\u0027"},{"line_number":105,"context_line":"            elif self._is_v3_valid(self.context.auth_token_info):"},{"line_number":106,"context_line":"                kwargs[\u0027auth_ref\u0027] \u003d self.context.auth_token_info[\u0027token\u0027]"},{"line_number":107,"context_line":"                kwargs[\u0027auth_ref\u0027][\u0027version\u0027] \u003d \u0027v3\u0027"},{"line_number":108,"context_line":"            else:"},{"line_number":109,"context_line":"                LOG.error(_LE(\u0027Unknown version in auth_token_info\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_ec4e2f6e","line":106,"in_reply_to":"5a2ca52d_7c3e5fdb","updated":"2015-10-16 07:02:21.000000000","message":"This does not help. It still tries to post to /v2","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"7aa7dd2554227e9ba9789f54832e948fbde2d400","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def _get_ks_client(self):"},{"line_number":94,"context_line":"        kwargs \u003d {"},{"line_number":95,"context_line":"            \u0027auth_url\u0027: self.auth_url,"},{"line_number":96,"context_line":"            \u0027endpoint\u0027: self.auth_url"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"        if self.context.trust_id:"},{"line_number":99,"context_line":"            kwargs.update(self._get_admin_credentials())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_5d739d80","line":96,"updated":"2015-10-20 07:06:42.000000000","message":"Why we need endpoint here?","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"c25c0e0064b2d3dfdce299a1cea9fd646d501962","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def _get_ks_client(self):"},{"line_number":94,"context_line":"        kwargs \u003d {"},{"line_number":95,"context_line":"            \u0027auth_url\u0027: self.auth_url,"},{"line_number":96,"context_line":"            \u0027endpoint\u0027: self.auth_url"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"        if self.context.trust_id:"},{"line_number":99,"context_line":"            kwargs.update(self._get_admin_credentials())"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_59772c3a","line":96,"in_reply_to":"3a29b11f_5d739d80","updated":"2015-10-29 17:02:42.000000000","message":"From discussing with Muralia, there was an issue where without endpoint, it was trying to talk to v2 API, it looks like. Investigating the issue, wondering if it\u0027s an incorrect service catalog entry or something and then we could just remove this assuming people have sane service catalog entries.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"580b78960747fe5bfba35dffb45cba30a99b5d07","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def _get_ks_client(self):"},{"line_number":94,"context_line":"        kwargs \u003d {"},{"line_number":95,"context_line":"            \u0027auth_url\u0027: self.auth_url,"},{"line_number":96,"context_line":"            \u0027endpoint\u0027: self.auth_url"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"        if self.context.trust_id:"},{"line_number":99,"context_line":"            kwargs.update(self._get_admin_credentials())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_7d7204af","line":96,"in_reply_to":"3a29b11f_5d739d80","updated":"2015-11-02 22:00:35.000000000","message":"Without \u0027endpoint\u0027, the keystone client talk to the V2 endpoint for trusts. I\u0027ve seen other projects include \u0027endpoint\u0027 as well.\n\nThe functional tests were failing for my earlier version of this review. \n\nhttp://logs.openstack.org/52/232152/3/check/gate-functional-dsvm-magnum/e80c4aa/logs/screen-m-cond.txt.gz#_2015-10-14_16_25_57_684","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"55cf94d8a5019cfab2ecc831a57eb77d8e048448","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def create_trust_context(self, client):"},{"line_number":94,"context_line":"        # Sanity check"},{"line_number":95,"context_line":"        if not client.auth_ref.trust_scoped:"},{"line_number":96,"context_line":"                LOG.error(_(\"trust token re-scoping failed!\"))"},{"line_number":97,"context_line":"                raise exception.AuthorizationFailure()"},{"line_number":98,"context_line":"        # All OK so update the context with the token"},{"line_number":99,"context_line":"        self.context.auth_token \u003d client.auth_ref.auth_token"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_ff7fa114","line":96,"updated":"2015-11-03 21:11:53.000000000","message":"Indentation is wrong.","commit_id":"d15d6f4e8d1ca30043c671e520d1aa7bff0c01a8"}],"magnum/conductor/template_definition.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0d6f5e3d332d98ee70b79fd1801f45bd73961e16","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def get_params(self, context, baymodel, bay, **kwargs):"},{"line_number":537,"context_line":"        extra_params \u003d kwargs.pop(\u0027extra_params\u0027, {})"},{"line_number":538,"context_line":"        extra_params[\u0027discovery_url\u0027] \u003d self.get_discovery_url(bay)"},{"line_number":539,"context_line":"        # Get trust id for tls certs"},{"line_number":540,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_deda6017","line":539,"updated":"2015-10-13 08:50:51.000000000","message":"from trusts_delegated_roles config, it default is tls, but it seems can be configed difference, so here comment is not proper to bind to tls special only.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"f305e4024b517b1ad217abb307e38606d21a7de7","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def get_params(self, context, baymodel, bay, **kwargs):"},{"line_number":537,"context_line":"        extra_params \u003d kwargs.pop(\u0027extra_params\u0027, {})"},{"line_number":538,"context_line":"        extra_params[\u0027discovery_url\u0027] \u003d self.get_discovery_url(bay)"},{"line_number":539,"context_line":"        # Get trust id for tls certs"},{"line_number":540,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_120554c1","line":539,"in_reply_to":"7a2fa921_deda6017","updated":"2015-10-13 15:41:07.000000000","message":"This is mean for tls only. I think the right thing to do here is to rename the ops name to reflect that.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8feeea246ff647a1c8264f952a9f3c23027158b0","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"},{"line_number":543,"context_line":"        trust_id \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":544,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d trust_id"},{"line_number":545,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_12d33d61","line":543,"updated":"2015-10-09 20:45:39.000000000","message":"Is that possible to create trust for user (context.user_id)? I think it is better than creating trust for admin.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"19f28aa4bff79d5785f0bba5702e4749a3b8b667","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"},{"line_number":543,"context_line":"        trust_id \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":544,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d trust_id"},{"line_number":545,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_dbda9078","line":543,"in_reply_to":"5a2ca52d_77691a8b","updated":"2015-10-13 18:50:58.000000000","message":"K. Got it.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"0d6f5e3d332d98ee70b79fd1801f45bd73961e16","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"},{"line_number":543,"context_line":"        trust_id \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":544,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d trust_id"},{"line_number":545,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_7e022c71","line":543,"in_reply_to":"7a2fa921_12d33d61","updated":"2015-10-13 08:50:51.000000000","message":"+1","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"f305e4024b517b1ad217abb307e38606d21a7de7","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"},{"line_number":543,"context_line":"        trust_id \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":544,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d trust_id"},{"line_number":545,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_77691a8b","line":543,"in_reply_to":"7a2fa921_7e022c71","updated":"2015-10-13 15:41:07.000000000","message":"That is exactly what this method is doing. It is creating a trust relationship between the user and the magnum service account.\n\nThe create_trust_to_admin method default the trustee to the magnum service account.\n\nThe user_id is got from the context.\n\nDid that answer your question?","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8feeea246ff647a1c8264f952a9f3c23027158b0","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"},{"line_number":543,"context_line":"        trust_id \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":544,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d trust_id"},{"line_number":545,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        return super(AtomicSwarmTemplateDefinition,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b2e5a909","line":544,"updated":"2015-10-09 20:45:39.000000000","message":"Instead of creating a new trust for each bay operation, you can create it once and reuse it later. In particular, you can create a trust on bay-create and retrieve\u0026reuse it in bay-update.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"f305e4024b517b1ad217abb307e38606d21a7de7","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":542,"context_line":"        keystone \u003d osc.keystone()"},{"line_number":543,"context_line":"        trust_id \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":544,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d trust_id"},{"line_number":545,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        return super(AtomicSwarmTemplateDefinition,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_5703beb8","line":544,"in_reply_to":"7a2fa921_b2e5a909","updated":"2015-10-13 15:41:07.000000000","message":"+1. I saw your other review for reusing the user_token. i\u0027ll rebase my patch on top of that.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1d373a3d253ea84ae69dda724aad36fefc02fd7b","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        else:"},{"line_number":372,"context_line":"            roles \u003d cfg.CONF.get(\u0027trusts_delegated_roles\u0027)"},{"line_number":373,"context_line":"            keystone \u003d osc.keystone()"},{"line_number":374,"context_line":"            return keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"class K8sApiAddressOutputMapping(OutputMapping):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_5c336362","line":374,"updated":"2015-10-15 22:11:01.000000000","message":"This returns a trust object, not a trust_id.","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"1d373a3d253ea84ae69dda724aad36fefc02fd7b","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        extra_params[\u0027username\u0027] \u003d context.user_name"},{"line_number":472,"context_line":"        extra_params[\u0027tenant_name\u0027] \u003d context.tenant"},{"line_number":473,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":474,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d self.get_user_trust(context, osc, bay)"},{"line_number":475,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if baymodel.tls_disabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_bc67174c","line":474,"updated":"2015-10-15 22:11:01.000000000","message":"You are replacing token with a trust ID, which is wrong. You need to do one step further: create a trust token with the trust ID. Please reference:\n\nhttp://blogs.rdoproject.org/5858/role-delegation-in-keystone-trusts","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"af19a3a86adb47b9110dd6dbe76df6376f701454","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        extra_params[\u0027username\u0027] \u003d context.user_name"},{"line_number":472,"context_line":"        extra_params[\u0027tenant_name\u0027] \u003d context.tenant"},{"line_number":473,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":474,"context_line":"        extra_params[\u0027trust_id\u0027] \u003d self.get_user_trust(context, osc, bay)"},{"line_number":475,"context_line":"        extra_params[\u0027magnum_url\u0027] \u003d osc.magnum_url()"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if baymodel.tls_disabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_c7ef9ce7","line":474,"in_reply_to":"5a2ca52d_bc67174c","updated":"2015-10-15 22:27:52.000000000","message":"thanks for the link.","commit_id":"088defd59f10fe8a0a63e7d17af75ffff0cad1ac"},{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"7aa7dd2554227e9ba9789f54832e948fbde2d400","unresolved":false,"context_lines":[{"line_number":376,"context_line":"            stack \u003d osc.heat().stacks.get(bay.stack_id)"},{"line_number":377,"context_line":"            return stack.parameters[\u0027trust_id\u0027]"},{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            roles \u003d cfg.CONF.get(\u0027tls_delegation_roles\u0027)"},{"line_number":380,"context_line":"            keystone \u003d osc.keystone()"},{"line_number":381,"context_line":"            trust \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":382,"context_line":"            return trust.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_7d9219a1","line":379,"updated":"2015-10-20 07:06:42.000000000","message":"You should import_opt before using it. And I think cfg.CONF.tls_delegation_roles is better than cfg.CONF.get(\u0027tls_delegation_roles\u0027)","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"580b78960747fe5bfba35dffb45cba30a99b5d07","unresolved":false,"context_lines":[{"line_number":376,"context_line":"            stack \u003d osc.heat().stacks.get(bay.stack_id)"},{"line_number":377,"context_line":"            return stack.parameters[\u0027trust_id\u0027]"},{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            roles \u003d cfg.CONF.get(\u0027tls_delegation_roles\u0027)"},{"line_number":380,"context_line":"            keystone \u003d osc.keystone()"},{"line_number":381,"context_line":"            trust \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":382,"context_line":"            return trust.id"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_6a3c7ce2","line":379,"in_reply_to":"3a29b11f_7d9219a1","updated":"2015-11-02 22:00:35.000000000","message":"@Hua: This work as is. I\u0027ve tested it on my local devstack. All functional tests pass as well.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8bd3a6773fb82512ba2f42e875007a7f5c44c24b","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            roles \u003d cfg.CONF.get(\u0027tls_delegation_roles\u0027)"},{"line_number":380,"context_line":"            keystone \u003d osc.keystone()"},{"line_number":381,"context_line":"            trust \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":382,"context_line":"            return trust.id"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_23453b6f","line":381,"updated":"2015-10-20 21:10:52.000000000","message":"Also, I wonder if Keystone trust created here needs to be clean up at \"bay-delete\".","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"580b78960747fe5bfba35dffb45cba30a99b5d07","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        else:"},{"line_number":379,"context_line":"            roles \u003d cfg.CONF.get(\u0027tls_delegation_roles\u0027)"},{"line_number":380,"context_line":"            keystone \u003d osc.keystone()"},{"line_number":381,"context_line":"            trust \u003d keystone.create_trust_to_admin(role_names\u003droles)"},{"line_number":382,"context_line":"            return trust.id"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_5c96e33f","line":381,"in_reply_to":"3a29b11f_23453b6f","updated":"2015-11-02 22:00:35.000000000","message":"Hongbin, Great point. I agree, we should delete the trust on bay delete. I\u0027ll follow up with a different patch with the delete implementation.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"}],"magnum/templates/docker-swarm/fragments/make-cert.py":[{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"7b0222e7f78740629a40b8df21e3cb5427d2d685","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def write_ca_cert(config):"},{"line_number":82,"context_line":"    bay_cert_url \u003d \u0027%s/certificates/%s\u0027 % (config[\u0027MAGNUM_URL\u0027],"},{"line_number":83,"context_line":"                                           config[\u0027BAY_UUID\u0027])"},{"line_number":84,"context_line":"    headers \u003d {\u0027X-Auth-Token\u0027: config[\u0027TRUST_ID\u0027]}"},{"line_number":85,"context_line":"    ca_cert_resp \u003d requests.get(bay_cert_url,"},{"line_number":86,"context_line":"                                headers\u003dheaders)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_43c75745","line":84,"updated":"2015-10-13 08:12:07.000000000","message":"Is it really working?? I guess, we should get trust_token using trust_id and trustee user password or token.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"f305e4024b517b1ad217abb307e38606d21a7de7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def write_ca_cert(config):"},{"line_number":82,"context_line":"    bay_cert_url \u003d \u0027%s/certificates/%s\u0027 % (config[\u0027MAGNUM_URL\u0027],"},{"line_number":83,"context_line":"                                           config[\u0027BAY_UUID\u0027])"},{"line_number":84,"context_line":"    headers \u003d {\u0027X-Auth-Token\u0027: config[\u0027TRUST_ID\u0027]}"},{"line_number":85,"context_line":"    ca_cert_resp \u003d requests.get(bay_cert_url,"},{"line_number":86,"context_line":"                                headers\u003dheaders)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_9220844b","line":84,"in_reply_to":"7a2fa921_43c75745","updated":"2015-10-13 15:41:07.000000000","message":"I think the name is confusing. This is the trust_token. I will rename it.","commit_id":"06c5e5c75e056f5ef5a5d5bae51ffd9b5e1b1d57"},{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"7aa7dd2554227e9ba9789f54832e948fbde2d400","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def write_ca_cert(config):"},{"line_number":82,"context_line":"    bay_cert_url \u003d \u0027%s/certificates/%s\u0027 % (config[\u0027MAGNUM_URL\u0027],"},{"line_number":83,"context_line":"                                           config[\u0027BAY_UUID\u0027])"},{"line_number":84,"context_line":"    headers \u003d {\u0027X-Auth-Token\u0027: config[\u0027TRUST_ID\u0027]}"},{"line_number":85,"context_line":"    ca_cert_resp \u003d requests.get(bay_cert_url,"},{"line_number":86,"context_line":"                                headers\u003dheaders)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_1dae8585","line":84,"updated":"2015-10-20 07:06:42.000000000","message":"We can not use trust_id to access magnum, we need to get a token by trust_id and access magnum by the token. When we want to get a token by trust_id, username, domain_id or domain_name and password of the trusted user are needed. So we need to pass these into heat parameters.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"64233b25b738476191d1723a73d04dcb22aef80a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def write_ca_cert(config):"},{"line_number":82,"context_line":"    bay_cert_url \u003d \u0027%s/certificates/%s\u0027 % (config[\u0027MAGNUM_URL\u0027],"},{"line_number":83,"context_line":"                                           config[\u0027BAY_UUID\u0027])"},{"line_number":84,"context_line":"    headers \u003d {\u0027X-Auth-Token\u0027: config[\u0027TRUST_ID\u0027]}"},{"line_number":85,"context_line":"    ca_cert_resp \u003d requests.get(bay_cert_url,"},{"line_number":86,"context_line":"                                headers\u003dheaders)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_7913eab8","line":84,"in_reply_to":"3a29b11f_1dae8585","updated":"2015-10-20 18:34:09.000000000","message":"That is true. Trust ID is not a token. It will fail if you use it as token.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"580b78960747fe5bfba35dffb45cba30a99b5d07","unresolved":false,"context_lines":[{"line_number":81,"context_line":"def write_ca_cert(config):"},{"line_number":82,"context_line":"    bay_cert_url \u003d \u0027%s/certificates/%s\u0027 % (config[\u0027MAGNUM_URL\u0027],"},{"line_number":83,"context_line":"                                           config[\u0027BAY_UUID\u0027])"},{"line_number":84,"context_line":"    headers \u003d {\u0027X-Auth-Token\u0027: config[\u0027TRUST_ID\u0027]}"},{"line_number":85,"context_line":"    ca_cert_resp \u003d requests.get(bay_cert_url,"},{"line_number":86,"context_line":"                                headers\u003dheaders)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_3cb8c7c7","line":84,"in_reply_to":"3a29b11f_7913eab8","updated":"2015-11-02 22:00:35.000000000","message":"Ok, I think I finally got this right. Will submit a new patch. Keep an eye out for it.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"}],"magnum/templates/heat-kubernetes/fragments/make-cert-client.sh":[{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"c25c0e0064b2d3dfdce299a1cea9fd646d501962","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Get CA certificate for this bay"},{"line_number":40,"context_line":"curl -X GET \\"},{"line_number":41,"context_line":"    -H \"X-Auth-Token: $TRUST_ID\" \\"},{"line_number":42,"context_line":"    $MAGNUM_URL/certificates/$BAY_UUID | python -c \u0027import sys, json; print json.load(sys.stdin)[\"pem\"]\u0027 \u003e $CA_CERT"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Create config for client\u0027s csr"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a26ad4f_d626ab67","line":41,"updated":"2015-10-29 17:02:42.000000000","message":"From the previous comment about this needing to be a token instead of the trust\u0027s ID, is that an issue here?","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"580b78960747fe5bfba35dffb45cba30a99b5d07","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Get CA certificate for this bay"},{"line_number":40,"context_line":"curl -X GET \\"},{"line_number":41,"context_line":"    -H \"X-Auth-Token: $TRUST_ID\" \\"},{"line_number":42,"context_line":"    $MAGNUM_URL/certificates/$BAY_UUID | python -c \u0027import sys, json; print json.load(sys.stdin)[\"pem\"]\u0027 \u003e $CA_CERT"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Create config for client\u0027s csr"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a26ad4f_bcccd76a","line":41,"in_reply_to":"1a26ad4f_d626ab67","updated":"2015-11-02 22:00:35.000000000","message":"This needs to be renamed to TRUST_TOKEN. I\u0027ve made this change in the latest revision.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"}],"magnum/tests/contrib/post_test_hook.sh":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"64233b25b738476191d1723a73d04dcb22aef80a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# TLS cert generation"},{"line_number":99,"context_line":"openstack role add $TLS_role --project demo --user demo"},{"line_number":100,"context_line":"openstack role add $TLS_role --project demo --user admin"},{"line_number":101,"context_line":"openstack role add $TLS_role --project admin --user admin"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Create magnum specific flavor for use in functional tests."},{"line_number":104,"context_line":"echo_summary \"Create a flavor\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3a29b11f_595e2e77","line":101,"updated":"2015-10-20 18:34:09.000000000","message":"Could you document these steps in quickstart guide as well. IMHO, it is better to take one step further to automate these steps in devstack.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"580b78960747fe5bfba35dffb45cba30a99b5d07","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# TLS cert generation"},{"line_number":99,"context_line":"openstack role add $TLS_role --project demo --user demo"},{"line_number":100,"context_line":"openstack role add $TLS_role --project demo --user admin"},{"line_number":101,"context_line":"openstack role add $TLS_role --project admin --user admin"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Create magnum specific flavor for use in functional tests."},{"line_number":104,"context_line":"echo_summary \"Create a flavor\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a26ad4f_9cbf9ba9","line":101,"in_reply_to":"3a29b11f_595e2e77","updated":"2015-11-02 22:00:35.000000000","message":"Done. I\u0027ve now automated it in devstack. The role is created and added to users during devstack deployment.","commit_id":"5546f0e583bf445a8ff2f2eaf60470a828303fed"}]}
