)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"9274ed2257f0bfcfd6798ba325578bb35126ea12","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-08 10:17:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Functional: refactor _create_baymodel()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch refactors _create_baymodel, gives _create_baymodel an optional"},{"line_number":10,"context_line":"**kwargs to allow created various baymodel."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_d605f579","line":7,"updated":"2015-10-08 18:47:31.000000000","message":"The commit message should be that you added a test case for tls disabled. Then in the description below you can add that you refactored the _create_baymodel() function. Otherwise you\u0027re hiding that you added a test.","commit_id":"32823973f97b0d94b1666f109133c047e857afe2"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9ee2ccf4e2f571cfb2bed797e5727135a476d4c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-08 10:17:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Functional: refactor _create_baymodel()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch refactors _create_baymodel, gives _create_baymodel an optional"},{"line_number":10,"context_line":"**kwargs to allow created various baymodel."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_ae4a5224","line":7,"in_reply_to":"7a2fa921_d605f579","updated":"2015-10-09 02:21:37.000000000","message":"Done","commit_id":"32823973f97b0d94b1666f109133c047e857afe2"}],"magnum/tests/contrib/post_test_hook.sh":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d43ef5823add635526ed384d62e0a0fef617eaf8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"# Credentials for functional testing"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[auth]"},{"line_number":72,"context_line":"auth_url \u003d $OS_AUTH_URL"},{"line_number":73,"context_line":"magnum_url \u003d $BYPASS_URL"},{"line_number":74,"context_line":"username \u003d $OS_USERNAME"},{"line_number":75,"context_line":"tenant_name \u003d $OS_TENANT_NAME"}],"source_content_type":"text/x-sh","patch_set":32,"id":"da85f559_4d31f6a1","line":72,"updated":"2015-11-09 04:57:50.000000000","message":"I guess the problem is the \u0027magnum_url\u0027 here. Could you verify?","commit_id":"9c8b9b06744f83a043496ee5a846c4587be0c2ed"}],"magnum/tests/functional/python_client_base.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"9274ed2257f0bfcfd6798ba325578bb35126ea12","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @classmethod"},{"line_number":95,"context_line":"    def _create_baymodel(cls, name, **kwargs):"},{"line_number":96,"context_line":"        coe \u003d kwargs.pop(\u0027coe\u0027, \u0027kubernetes\u0027)"},{"line_number":97,"context_line":"        docker_volume_size \u003d kwargs.pop(\u0027docker_volume_size\u0027, 1)"},{"line_number":98,"context_line":"        network_driver \u003d kwargs.pop(\u0027network_driver\u0027, \u0027flannel\u0027)"},{"line_number":99,"context_line":"        labels \u003d kwargs.pop(\u0027labels\u0027, {\"K1\": \"V1\", \"K2\": \"V2\"})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_1674cd33","line":96,"updated":"2015-10-08 18:47:31.000000000","message":"I know this is maintaining the original functionality, but do we always want this to default to kubernetes?","commit_id":"32823973f97b0d94b1666f109133c047e857afe2"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9ee2ccf4e2f571cfb2bed797e5727135a476d4c7","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @classmethod"},{"line_number":95,"context_line":"    def _create_baymodel(cls, name, **kwargs):"},{"line_number":96,"context_line":"        coe \u003d kwargs.pop(\u0027coe\u0027, \u0027kubernetes\u0027)"},{"line_number":97,"context_line":"        docker_volume_size \u003d kwargs.pop(\u0027docker_volume_size\u0027, 1)"},{"line_number":98,"context_line":"        network_driver \u003d kwargs.pop(\u0027network_driver\u0027, \u0027flannel\u0027)"},{"line_number":99,"context_line":"        labels \u003d kwargs.pop(\u0027labels\u0027, {\"K1\": \"V1\", \"K2\": \"V2\"})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_732ae591","line":96,"in_reply_to":"7a2fa921_1674cd33","updated":"2015-10-09 02:21:37.000000000","message":"we don\u0027t, the plan is to support all kinds of coes , swarm, mesos","commit_id":"32823973f97b0d94b1666f109133c047e857afe2"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"d2240934be2ed93892576c57c028f8b7846e89c7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            self.assertTrue(baymodel.uuid not in list)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _test_bay_create_and_delete(self, bay_name, baymodel):"},{"line_number":174,"context_line":"        # NOTE(eliqiao): baymodel will be delete after this testing"},{"line_number":175,"context_line":"        bay \u003d self._create_bay(bay_name, baymodel.uuid)"},{"line_number":176,"context_line":"        list \u003d [item.uuid for item in self.cs.bays.list()]"},{"line_number":177,"context_line":"        self.assertTrue(bay.uuid in list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_29e2ae2f","line":174,"updated":"2015-10-09 09:45:56.000000000","message":"s/delete/deleted","commit_id":"d7d4a23cce04d8759b9690914254f1f4d75f7907"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a471103eabe911f24f719acdad35127f9dda4f2e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            self.assertTrue(baymodel.uuid not in list)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _test_bay_create_and_delete(self, bay_name, baymodel):"},{"line_number":174,"context_line":"        # NOTE(eliqiao): baymodel will be delete after this testing"},{"line_number":175,"context_line":"        bay \u003d self._create_bay(bay_name, baymodel.uuid)"},{"line_number":176,"context_line":"        list \u003d [item.uuid for item in self.cs.bays.list()]"},{"line_number":177,"context_line":"        self.assertTrue(bay.uuid in list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_e4a13bf9","line":174,"in_reply_to":"7a2fa921_29e2ae2f","updated":"2015-10-09 09:58:52.000000000","message":"Done","commit_id":"d7d4a23cce04d8759b9690914254f1f4d75f7907"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"134ee3ede600cff5cf5d84a8e67b61405a5ce52f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"class BayAPITLSTest(BaseMagnumClient):"},{"line_number":206,"context_line":"    \"\"\"Base class of TLS enabled test case.\"\"\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def setUp(self):"},{"line_number":209,"context_line":"        super(BayAPITLSTest, self).setUp()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":41,"id":"da85f559_307f9dac","line":208,"updated":"2015-11-11 15:45:45.000000000","message":"It looks this method does nothing. Can we remove this?","commit_id":"e395fe2b24949f446e38adacef140595e6aba7ff"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8b61be3a20353ca55b9fea585709783803282213","unresolved":false,"context_lines":[{"line_number":205,"context_line":"class BayAPITLSTest(BaseMagnumClient):"},{"line_number":206,"context_line":"    \"\"\"Base class of TLS enabled test case.\"\"\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def setUp(self):"},{"line_number":209,"context_line":"        super(BayAPITLSTest, self).setUp()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":41,"id":"da85f559_e59b7916","line":208,"in_reply_to":"da85f559_307f9dac","updated":"2015-11-12 01:51:51.000000000","message":"okay , I will remove when I add swarm test case.","commit_id":"e395fe2b24949f446e38adacef140595e6aba7ff"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"134ee3ede600cff5cf5d84a8e67b61405a5ce52f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                [\"DELETE_FAILED\", \"DELETE_COMPLETE\"])"},{"line_number":223,"context_line":"        except exceptions.NotFound:"},{"line_number":224,"context_line":"            pass"},{"line_number":225,"context_line":"        cls._delete_baymodel(cls.baymodel.uuid)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @classmethod"},{"line_number":228,"context_line":"    def _create_tls_ca_files(cls, client_conf_contents):"}],"source_content_type":"text/x-python","patch_set":41,"id":"da85f559_cb2220a3","line":225,"updated":"2015-11-11 15:45:45.000000000","message":"Maybe I am wrong. Do we need to call the super class:\n\nsuper(BayAPITLSTest, self).tearDownClass()","commit_id":"e395fe2b24949f446e38adacef140595e6aba7ff"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8b61be3a20353ca55b9fea585709783803282213","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                [\"DELETE_FAILED\", \"DELETE_COMPLETE\"])"},{"line_number":223,"context_line":"        except exceptions.NotFound:"},{"line_number":224,"context_line":"            pass"},{"line_number":225,"context_line":"        cls._delete_baymodel(cls.baymodel.uuid)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @classmethod"},{"line_number":228,"context_line":"    def _create_tls_ca_files(cls, client_conf_contents):"}],"source_content_type":"text/x-python","patch_set":41,"id":"da85f559_05931dfb","line":225,"in_reply_to":"da85f559_cb2220a3","updated":"2015-11-12 01:51:51.000000000","message":"ditto, will do a try when add swarm test.\nBTW, it should be:\n\nsuper(BayAPITLSTest, cls).tearDownClass()","commit_id":"e395fe2b24949f446e38adacef140595e6aba7ff"}],"magnum/tests/functional/test_k8s_python_client.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"d2240934be2ed93892576c57c028f8b7846e89c7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(TestKubernetesAPIs, cls).setUpClass()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # TODO(yuanying): Change to `tls_disabled\u003dFalse`"},{"line_number":52,"context_line":"        #                 if k8sclient supports TLS."},{"line_number":53,"context_line":"        cls.baymodel \u003d cls._create_baymodel(\u0027testk8sAPI\u0027)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_49fcca6f","line":52,"updated":"2015-10-09 09:45:56.000000000","message":"This comments is a bit difficult to understand, as I do not know where shall I put the parameter of tls_disabled.\n\nCan we change this to \"Change to `tls_disabled\u003dFalse` if k8sclient supports TLS when creating baymodel\"","commit_id":"d7d4a23cce04d8759b9690914254f1f4d75f7907"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a471103eabe911f24f719acdad35127f9dda4f2e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(TestKubernetesAPIs, cls).setUpClass()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # TODO(yuanying): Change to `tls_disabled\u003dFalse`"},{"line_number":52,"context_line":"        #                 if k8sclient supports TLS."},{"line_number":53,"context_line":"        cls.baymodel \u003d cls._create_baymodel(\u0027testk8sAPI\u0027)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_a47023a5","line":52,"in_reply_to":"7a2fa921_49fcca6f","updated":"2015-10-09 09:58:52.000000000","message":"this is from yuanying \u0027s original comments.\nbut I am glad to change.","commit_id":"d7d4a23cce04d8759b9690914254f1f4d75f7907"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"63c476e9cd9f7ff54c54e506206f5eb05fc4eb69","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(TestKubernetesAPIs, cls).setUpClass()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # TODO(yuanying): Change to `tls_disabled\u003dFalse`"},{"line_number":52,"context_line":"        #                 if k8sclient supports TLS when creating baymodel."},{"line_number":53,"context_line":"        cls.baymodel \u003d cls._create_baymodel(\u0027testk8sAPI\u0027)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_df8c09dc","line":52,"updated":"2015-10-09 12:02:25.000000000","message":"`tls_disanled` is already supported in magnum. and you added test for tls_diabled\u003dFalse, right? so you can delete above lines.","commit_id":"1e15d263dc12e27ab7bb8c22ee505b01cb050690"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"4cb80d703b818f6718b8199a575b0330d576e560","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(TestKubernetesAPIs, cls).setUpClass()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # TODO(yuanying): Change to `tls_disabled\u003dFalse`"},{"line_number":52,"context_line":"        #                 if k8sclient supports TLS when creating baymodel."},{"line_number":53,"context_line":"        cls.baymodel \u003d cls._create_baymodel(\u0027testk8sAPI\u0027)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_4311fb5b","line":52,"in_reply_to":"7a2fa921_96575625","updated":"2015-10-09 14:05:47.000000000","message":"Thanks @Ryan, clear now ;-)","commit_id":"1e15d263dc12e27ab7bb8c22ee505b01cb050690"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"3d7845160c2d035c9c4bd1c4f35596b03a46b9c3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(TestKubernetesAPIs, cls).setUpClass()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # TODO(yuanying): Change to `tls_disabled\u003dFalse`"},{"line_number":52,"context_line":"        #                 if k8sclient supports TLS when creating baymodel."},{"line_number":53,"context_line":"        cls.baymodel \u003d cls._create_baymodel(\u0027testk8sAPI\u0027)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_96575625","line":52,"in_reply_to":"7a2fa921_b61a92c4","updated":"2015-10-09 13:36:37.000000000","message":"@Jay: That\u0027s what test_tls_enabled_bay_create_and_delete() is doing. I agree that I don\u0027t think we need this comment here.","commit_id":"1e15d263dc12e27ab7bb8c22ee505b01cb050690"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"85e49f2fad54043e14ba7cebff38ca5d54182051","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(TestKubernetesAPIs, cls).setUpClass()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # TODO(yuanying): Change to `tls_disabled\u003dFalse`"},{"line_number":52,"context_line":"        #                 if k8sclient supports TLS when creating baymodel."},{"line_number":53,"context_line":"        cls.baymodel \u003d cls._create_baymodel(\u0027testk8sAPI\u0027)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_b61a92c4","line":52,"in_reply_to":"7a2fa921_df8c09dc","updated":"2015-10-09 13:33:50.000000000","message":"I think that the current test is tls_disabled\u003dTrue, so we need to add some test for tls_disabled\u003dFalse?","commit_id":"1e15d263dc12e27ab7bb8c22ee505b01cb050690"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"578e53eb996d86d5b499e1a8cbd4a601ca32771c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        baymodel_uuid \u003d self._test_baymodel_create_and_delete("},{"line_number":33,"context_line":"            \u0027test_k8s_baymodel\u0027,"},{"line_number":34,"context_line":"            delete\u003dFalse,"},{"line_number":35,"context_line":"            tls_disabled\u003dTrue)"},{"line_number":36,"context_line":"        self._test_bay_create_and_delete(\u0027test_k8s_bay\u0027, baymodel_uuid)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_tls_enabled_bay_create_and_delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_5b4ea23b","line":35,"updated":"2015-10-11 01:30:48.000000000","message":"I think that those can be merged to one line","commit_id":"6f5f9fa2bd73d011fba00a80cac534bf61930470"},{"author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"change_message_id":"e75274db6281e88f51f2a5cb720da877a4c346ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                            tls_disabled\u003dFalse)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"},{"line_number":56,"context_line":"        k8s_client \u003d api_client.ApiClient(kube_api_url)"},{"line_number":57,"context_line":"        cls.k8s_api \u003d apiv_api.ApivApi(k8s_client)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_a0db014e","line":56,"updated":"2015-10-10 21:32:19.000000000","message":"@Eli: i think we should add logic to get right certificate for kub client (https://review.openstack.org/#/c/232763/1/doc/source/tls.rst) otherwise it cannot communicate with api.","commit_id":"6f5f9fa2bd73d011fba00a80cac534bf61930470"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"578e53eb996d86d5b499e1a8cbd4a601ca32771c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                            tls_disabled\u003dFalse)"},{"line_number":54,"context_line":"        cls.bay \u003d cls._create_bay(\u0027testk8sAPI\u0027, cls.baymodel.uuid)"},{"line_number":55,"context_line":"        kube_api_url \u003d cls.cs.bays.get(cls.bay.uuid).api_address"},{"line_number":56,"context_line":"        k8s_client \u003d api_client.ApiClient(kube_api_url)"},{"line_number":57,"context_line":"        cls.k8s_api \u003d apiv_api.ApivApi(k8s_client)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_7b491e30","line":56,"in_reply_to":"7a2fa921_a0db014e","updated":"2015-10-11 01:30:48.000000000","message":"+1","commit_id":"6f5f9fa2bd73d011fba00a80cac534bf61930470"}]}