)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"cc603306ee49b3ae36290f6ab7ade538db77c6e4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-12 08:57:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the k8s and mesos proxy doc."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id794b7c0e2552cbca70610e42deccbc7946c1af4"},{"line_number":10,"context_line":"Implements: blueprint add-proxy-mesos"},{"line_number":11,"context_line":"Depends-On: I507f3adffbc90b277705dc553b0fd906e3276cc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da6ed579_5a673c25","line":8,"updated":"2016-01-13 02:15:49.000000000","message":"Nice to include in short what do you plan to include as part of this fix.","commit_id":"2578bae2f915a066b82d55a8b9a490c38fd65da2"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"e92357eace39976c8ee3a09e32e7a8d03a41f566","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-12 08:57:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the k8s and mesos proxy doc."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id794b7c0e2552cbca70610e42deccbc7946c1af4"},{"line_number":10,"context_line":"Implements: blueprint add-proxy-mesos"},{"line_number":11,"context_line":"Depends-On: I507f3adffbc90b277705dc553b0fd906e3276cc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da6ed579_90c0352c","line":8,"in_reply_to":"da6ed579_5a673c25","updated":"2016-01-13 02:58:02.000000000","message":"It\u0027s good practice to be provide description to help the reviewers.  You should assume that a reviewer reading the patch the first time has no idea what the patch is about.\n\nThis patch is dependent on the patch that contains the actual code change to implement the fix.  This patch is very small so in retrospect, it should have just been included in the code patch to avoid confusion.","commit_id":"2578bae2f915a066b82d55a8b9a490c38fd65da2"}],"doc/source/magnum-proxy.rst":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"cb1087588f73b22b291dc8272891b8e0828a1837","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                       --https-proxy \u003chttps://abc-proxy.com:8080\u003e \\"},{"line_number":61,"context_line":"                       --no-proxy \u003c172.24.4.4,172.24.4.9,172.24.4.8\u003e"},{"line_number":62,"context_line":"   "},{"line_number":63,"context_line":"    magnum baymodel-create --name mesosbaymodel \\"},{"line_number":64,"context_line":"                       --image-id ubuntu-mesos \\"},{"line_number":65,"context_line":"                       --keypair-id testkey \\"},{"line_number":66,"context_line":"                       --external-network-id public \\"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa69d971_f6ce85b6","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":47},"updated":"2016-01-07 15:38:26.000000000","message":"Mesos bay doesn\u0027t support proxy yet. Suggest to remove it in this patch and add it back once it is supported.","commit_id":"1e6cb03c95f97f8ff0b01e8f89081fd7ab06261c"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"796b9153f6c87146f0cc705cb21c753c3279778b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                       --https-proxy \u003chttps://abc-proxy.com:8080\u003e \\"},{"line_number":61,"context_line":"                       --no-proxy \u003c172.24.4.4,172.24.4.9,172.24.4.8\u003e"},{"line_number":62,"context_line":"   "},{"line_number":63,"context_line":"    magnum baymodel-create --name mesosbaymodel \\"},{"line_number":64,"context_line":"                       --image-id ubuntu-mesos \\"},{"line_number":65,"context_line":"                       --keypair-id testkey \\"},{"line_number":66,"context_line":"                       --external-network-id public \\"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_a98e4725","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":4},"updated":"2016-01-08 03:40:44.000000000","message":"this is unneeded space","commit_id":"e3c044c356e771dd41745c3aed6a142743020d2a"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"39fe7ab982e3d1da397f5474c198f4fcbf3f177f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                       --https-proxy \u003chttps://abc-proxy.com:8080\u003e \\"},{"line_number":61,"context_line":"                       --no-proxy \u003c172.24.4.4,172.24.4.9,172.24.4.8\u003e"},{"line_number":62,"context_line":"   "},{"line_number":63,"context_line":"magnum baymodel-create --name mesosbaymodel \\"},{"line_number":64,"context_line":"                       --image-id ubuntu-mesos \\"},{"line_number":65,"context_line":"                       --keypair-id testkey \\"},{"line_number":66,"context_line":"                       --external-network-id public \\"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa69d971_2c1257b5","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":6},"updated":"2016-01-08 07:07:30.000000000","message":"Actually you would want the 4 blank spaces here for the RST formatting.  I think Kennan means the blank space in the previous empty line.  You can test out the RST formatting on sites like http://rst.ninjs.org/","commit_id":"44fbb8bd4545b5933ab9218165fee03cdba6ec54"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"949b440e32893a7f7ebab9b2ce5eed42b0c63bb7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when your firewall will not allow you to use those services without a"},{"line_number":8,"context_line":"proxy."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"NOTE: This feature only works with Swarm bays."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Proxy Parameters to define before use"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa69d971_c0fd42b2","line":10,"updated":"2016-01-09 04:31:43.000000000","message":"Not only swarm, but also mesos and kubernetes now","commit_id":"ebde7698919cfde418de9aeb3fdb5d91e9a76671"},{"author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"change_message_id":"5fd65c820219f3c463a45be27fcbad53c2db3a4d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       --coe kubenetes \\"},{"line_number":48,"context_line":"                       --http-proxy \u003chttp://abc-proxy.com:8080\u003e \\"},{"line_number":49,"context_line":"                       --https-proxy \u003chttps://abc-proxy.com:8080\u003e \\"},{"line_number":50,"context_line":"                       --no-proxy \u003c172.24.4.4,172.24.4.9,172.24.4.8\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    magnum baymodel-create --name swarmbaymodel \\"},{"line_number":53,"context_line":"                       --image-id fedora-21-atomic-5 \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa69d971_6d0846da","line":50,"range":{"start_line":50,"start_character":67,"end_line":50,"end_character":68},"updated":"2016-01-08 08:23:35.000000000","message":"It is a problem that how to decide the no_proxy as the ips of nodes are determined after the instances are created.","commit_id":"ebde7698919cfde418de9aeb3fdb5d91e9a76671"},{"author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"change_message_id":"79d6168d1f22266c887921b262a668318f551d63","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       --coe kubenetes \\"},{"line_number":48,"context_line":"                       --http-proxy \u003chttp://abc-proxy.com:8080\u003e \\"},{"line_number":49,"context_line":"                       --https-proxy \u003chttps://abc-proxy.com:8080\u003e \\"},{"line_number":50,"context_line":"                       --no-proxy \u003c172.24.4.4,172.24.4.9,172.24.4.8\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    magnum baymodel-create --name swarmbaymodel \\"},{"line_number":53,"context_line":"                       --image-id fedora-21-atomic-5 \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa69d971_03912f52","line":50,"range":{"start_line":50,"start_character":67,"end_line":50,"end_character":68},"in_reply_to":"fa69d971_6d0846da","updated":"2016-01-08 20:44:41.000000000","message":"@Hua: I think we discussed it before, we cannot figure out nodes ips atomically and it\u0027s up to user to do this","commit_id":"ebde7698919cfde418de9aeb3fdb5d91e9a76671"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"a8ce41975241f1199ca6c49d73bbb1dfcec42a4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when your firewall will not allow you to use those services without a"},{"line_number":8,"context_line":"proxy."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"NOTE: This feature can work on any coe type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Proxy Parameters to define before use"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa69d971_b4eab70d","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":38},"updated":"2016-01-11 10:21:01.000000000","message":"please double check if it only works with coreos( I found hongbin is working on that, I did not think coreos support it now.\n\nMaybe we need specify said supported image now ?","commit_id":"7359661821fbab1ff6a62c8245e2e4179e061b76"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"e8cb1952e8f6c4059a8a9cff26ee3af3ab9e3bf2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when your firewall will not allow you to use those services without a"},{"line_number":8,"context_line":"proxy."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"**NOTE:** This feature can work only on kubernetes with fedora, swarm"},{"line_number":11,"context_line":"with fedora and mesos with coreos."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Proxy Parameters to define before use"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da6ed579_6e0aa2d4","line":10,"updated":"2016-01-12 14:32:21.000000000","message":"this seems not right.\n\nshould say, kubernetes, swarm bays with fedora-atomic, and mesos bays with ubuntu","commit_id":"2578bae2f915a066b82d55a8b9a490c38fd65da2"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"cc603306ee49b3ae36290f6ab7ade538db77c6e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when your firewall will not allow you to use those services without a"},{"line_number":8,"context_line":"proxy."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"**NOTE:** This feature can work only on kubernetes with fedora, swarm"},{"line_number":11,"context_line":"with fedora and mesos with coreos."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Proxy Parameters to define before use"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da6ed579_7aab201e","line":10,"in_reply_to":"da6ed579_6e0aa2d4","updated":"2016-01-13 02:15:49.000000000","message":"+1","commit_id":"2578bae2f915a066b82d55a8b9a490c38fd65da2"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"e92357eace39976c8ee3a09e32e7a8d03a41f566","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when your firewall will not allow you to use those services without a"},{"line_number":8,"context_line":"proxy."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"**NOTE:** This feature can work only on kubernetes with fedora, swarm"},{"line_number":11,"context_line":"with fedora and mesos with coreos."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Proxy Parameters to define before use"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da6ed579_f00f31df","line":10,"in_reply_to":"da6ed579_7aab201e","updated":"2016-01-13 02:58:02.000000000","message":"A line in the doc can be more troublesome than the code :)\nLet me suggest this wording to help move things along:\n\nThis feature has only been tested with the supported bay type and associated image:  Kubernetes and Swarm bay using the Fedora Atomic image, and Mesos bay using the Ubuntu image.","commit_id":"2578bae2f915a066b82d55a8b9a490c38fd65da2"}]}
