)]}'
{"magnum/api/controllers/v1/baymodel.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"476ee0544b817699bf8d7be0c8be769ec6e455b4","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                          \u0027apiserver_port\u0027, \u0027cluster_distro\u0027,"},{"line_number":150,"context_line":"                                          \u0027docker_volume_size\u0027, \u0027tls_disabled\u0027,"},{"line_number":151,"context_line":"                                          \u0027registry_enabled\u0027, \u0027volume_driver\u0027,"},{"line_number":152,"context_line":"                                          \u0027public\u0027, \u0027server_type\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        baymodel.links \u003d [link.Link.make_link(\u0027self\u0027, url,"},{"line_number":155,"context_line":"                                              \u0027baymodels\u0027, baymodel.uuid),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_0f592a8e","line":152,"updated":"2016-05-12 02:01:59.000000000","message":"what about labels. Do we want it to appear in the message body?","commit_id":"2a74917ff3ef14a936c25ce12cc1d8efd1f106ed"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"221f63f4e1b6d7f125666a4ea3cda1dab679966a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                          \u0027apiserver_port\u0027, \u0027cluster_distro\u0027,"},{"line_number":150,"context_line":"                                          \u0027docker_volume_size\u0027, \u0027tls_disabled\u0027,"},{"line_number":151,"context_line":"                                          \u0027registry_enabled\u0027, \u0027volume_driver\u0027,"},{"line_number":152,"context_line":"                                          \u0027public\u0027, \u0027server_type\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        baymodel.links \u003d [link.Link.make_link(\u0027self\u0027, url,"},{"line_number":155,"context_line":"                                              \u0027baymodels\u0027, baymodel.uuid),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_b4d14e32","line":152,"in_reply_to":"dab17558_0f592a8e","updated":"2016-05-12 07:22:56.000000000","message":"Yes I also have this concern. Why not others fields like labels, http_proxy etc.","commit_id":"2a74917ff3ef14a936c25ce12cc1d8efd1f106ed"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"9a09c1d97c3b076284abbddbd87d08abf6fc4e05","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                          \u0027apiserver_port\u0027, \u0027cluster_distro\u0027,"},{"line_number":150,"context_line":"                                          \u0027docker_volume_size\u0027, \u0027tls_disabled\u0027,"},{"line_number":151,"context_line":"                                          \u0027registry_enabled\u0027, \u0027volume_driver\u0027,"},{"line_number":152,"context_line":"                                          \u0027public\u0027, \u0027server_type\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        baymodel.links \u003d [link.Link.make_link(\u0027self\u0027, url,"},{"line_number":155,"context_line":"                                              \u0027baymodels\u0027, baymodel.uuid),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_de1fb6b5","line":152,"in_reply_to":"dab17558_b4d14e32","updated":"2016-05-12 14:24:39.000000000","message":"Eli/Madhuri: I only included fields mentioned in the reported bug. What other fields would you like included?","commit_id":"2a74917ff3ef14a936c25ce12cc1d8efd1f106ed"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"96647cd390b00595c90865e4bc0d74ca76468af6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                          \u0027apiserver_port\u0027, \u0027cluster_distro\u0027,"},{"line_number":150,"context_line":"                                          \u0027docker_volume_size\u0027, \u0027tls_disabled\u0027,"},{"line_number":151,"context_line":"                                          \u0027registry_enabled\u0027, \u0027volume_driver\u0027,"},{"line_number":152,"context_line":"                                          \u0027public\u0027, \u0027server_type\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        baymodel.links \u003d [link.Link.make_link(\u0027self\u0027, url,"},{"line_number":155,"context_line":"                                              \u0027baymodels\u0027, baymodel.uuid),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_9e0b6e2b","line":152,"in_reply_to":"dab17558_de1fb6b5","updated":"2016-05-12 14:29:51.000000000","message":"To address @Eli/@Madhuri comments, an option is simply removing line #145 - #152. Frankly, I don\u0027t see any benefit to maintain the unset list, so just don\u0027t unset anything.","commit_id":"2a74917ff3ef14a936c25ce12cc1d8efd1f106ed"}],"magnum/tests/unit/api/controllers/v1/test_baymodel.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"30c11c4b98b0ca87d74c6dbb27ff588644f8bd51","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestListBayModel(api_base.FunctionalTest):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    _expand_baymodel_attrs \u003d (\u0027name\u0027, \u0027apiserver_port\u0027, \u0027network_driver\u0027,"},{"line_number":45,"context_line":"                              \u0027coe\u0027, \u0027flavor_id\u0027, \u0027fixed_network\u0027,"},{"line_number":46,"context_line":"                              \u0027dns_nameserver\u0027, \u0027http_proxy\u0027,"},{"line_number":47,"context_line":"                              \u0027docker_volume_size\u0027, \u0027server_type\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_8e02f86d","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":26},"updated":"2016-05-13 07:25:14.000000000","message":"if you remove expand from baymodel list operation, I think you may need to cleanup this variable name.","commit_id":"66cbd8c821bda168bc07ab3aaa1fe4d7717fc7ff"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"91800a61da62c39d0456fddfff5bf93f88838f68","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestListBayModel(api_base.FunctionalTest):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    _expand_baymodel_attrs \u003d (\u0027name\u0027, \u0027apiserver_port\u0027, \u0027network_driver\u0027,"},{"line_number":45,"context_line":"                              \u0027coe\u0027, \u0027flavor_id\u0027, \u0027fixed_network\u0027,"},{"line_number":46,"context_line":"                              \u0027dns_nameserver\u0027, \u0027http_proxy\u0027,"},{"line_number":47,"context_line":"                              \u0027docker_volume_size\u0027, \u0027server_type\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_295ae583","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":26},"in_reply_to":"dab17558_8e02f86d","updated":"2016-05-13 08:10:41.000000000","message":"Eli, I have posted a low-hanging-fruit bug for it https://bugs.launchpad.net/magnum/+bug/1581364","commit_id":"66cbd8c821bda168bc07ab3aaa1fe4d7717fc7ff"}]}