)]}'
{"magnum/templates/common/fragments/configure_docker_storage_driver_atomic.sh":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    rm -rf /var/lib/docker/*"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    mkfs.xfs -f ${device_path}"},{"line_number":19,"context_line":"    echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":20,"context_line":"    mount -a"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_06dfb23a","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":15},"updated":"2016-06-29 23:15:30.000000000","message":"Why is the force option needed here? This will overwrite any existing filesystem or partition table. Is this to aid in situations where the host\u0027s storage was not completely cleared after it was used by a previous tenant/user?","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    rm -rf /var/lib/docker/*"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    mkfs.xfs -f ${device_path}"},{"line_number":19,"context_line":"    echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":20,"context_line":"    mount -a"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_c7e9211c","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":15},"in_reply_to":"3aaa91ec_06dfb23a","updated":"2016-06-30 06:37:25.000000000","message":"Ironic template uses ephemeral disk for docker storage, but unfortunately it was formatted as ext4. That\u0027s why I added this option.","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"configure_devicemapper () {"},{"line_number":32,"context_line":"    clear_docker_storage_congiguration"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    pvcreate -f ${device_path}"},{"line_number":35,"context_line":"    vgcreate docker ${device_path}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    echo \"VG\u003ddocker\" \u003e /etc/sysconfig/docker-storage-setup"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_e6ba66e0","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":15},"updated":"2016-06-29 23:15:30.000000000","message":"Same question applies here as above with the mkfs.xfs command.","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"configure_devicemapper () {"},{"line_number":32,"context_line":"    clear_docker_storage_congiguration"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    pvcreate -f ${device_path}"},{"line_number":35,"context_line":"    vgcreate docker ${device_path}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    echo \"VG\u003ddocker\" \u003e /etc/sysconfig/docker-storage-setup"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_7ba724a7","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":15},"in_reply_to":"3aaa91ec_e6ba66e0","updated":"2016-06-30 06:37:25.000000000","message":"ditto","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"}],"magnum/templates/kubernetes/fragments/configure-docker-storage.sh":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ \"$ENABLE_CINDER\" \u003d\u003d \"False\" ]; then"},{"line_number":6,"context_line":"  # FIXME(yuanying): Use ephemeral disk for docker storage"},{"line_number":7,"context_line":"  # Currently Ironic doesn\u0027t support cinder volume,"},{"line_number":8,"context_line":"  # so we must use preserved ephemeral disk instead of cinder volume."},{"line_number":9,"context_line":"  device_path\u003d$(readlink -f /dev/disk/by-label/ephemeral0)"},{"line_number":10,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_66cf967f","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":50},"updated":"2016-06-29 23:15:30.000000000","message":"s/volume/volumes/","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ \"$ENABLE_CINDER\" \u003d\u003d \"False\" ]; then"},{"line_number":6,"context_line":"  # FIXME(yuanying): Use ephemeral disk for docker storage"},{"line_number":7,"context_line":"  # Currently Ironic doesn\u0027t support cinder volume,"},{"line_number":8,"context_line":"  # so we must use preserved ephemeral disk instead of cinder volume."},{"line_number":9,"context_line":"  device_path\u003d$(readlink -f /dev/disk/by-label/ephemeral0)"},{"line_number":10,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_e7f41df2","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":50},"in_reply_to":"3aaa91ec_66cf967f","updated":"2016-06-30 06:37:25.000000000","message":"Done","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [ \"$ENABLE_CINDER\" \u003d\u003d \"False\" ]; then"},{"line_number":6,"context_line":"  # FIXME(yuanying): Use ephemeral disk for docker storage"},{"line_number":7,"context_line":"  # Currently Ironic doesn\u0027t support cinder volume,"},{"line_number":8,"context_line":"  # so we must use preserved ephemeral disk instead of cinder volume."},{"line_number":9,"context_line":"  device_path\u003d$(readlink -f /dev/disk/by-label/ephemeral0)"},{"line_number":10,"context_line":"else"},{"line_number":11,"context_line":"  attempts\u003d60"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_46cc1a89","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":55},"updated":"2016-06-29 23:15:30.000000000","message":"s/ / a /","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [ \"$ENABLE_CINDER\" \u003d\u003d \"False\" ]; then"},{"line_number":6,"context_line":"  # FIXME(yuanying): Use ephemeral disk for docker storage"},{"line_number":7,"context_line":"  # Currently Ironic doesn\u0027t support cinder volume,"},{"line_number":8,"context_line":"  # so we must use preserved ephemeral disk instead of cinder volume."},{"line_number":9,"context_line":"  device_path\u003d$(readlink -f /dev/disk/by-label/ephemeral0)"},{"line_number":10,"context_line":"else"},{"line_number":11,"context_line":"  attempts\u003d60"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_47ded16d","line":8,"range":{"start_line":8,"start_character":54,"end_line":8,"end_character":55},"in_reply_to":"3aaa91ec_46cc1a89","updated":"2016-06-30 06:37:25.000000000","message":"Done","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"}],"magnum/templates/kubernetes/fragments/configure-etcd.sh":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"myip\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cat \u003e /etc/etcd/etcd.conf \u003c\u003cEOF"},{"line_number":8,"context_line":"ETCD_NAME\u003d\"$myip\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_c6e2cad4","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":66},"updated":"2016-06-29 23:15:30.000000000","message":"This might not work, as sometimes the instance metadata service returns a comma separates list of IP addresses. We should define a utility shell function that calls the curl request, and then performs input validation on the value returned.\n\nAlso, I\u0027d rather not introduce a dependency on the metadata service for non-ironic setups. We need a way to only use this approach if KUBE_NODE_IP is not set the normal way.","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"myip\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cat \u003e /etc/etcd/etcd.conf \u003c\u003cEOF"},{"line_number":8,"context_line":"ETCD_NAME\u003d\"$myip\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_5ba4e8a4","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":66},"in_reply_to":"3aaa91ec_c6e2cad4","updated":"2016-06-30 06:37:25.000000000","message":"OK, you are right! I\u0027ll do that.","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"}],"magnum/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (master)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sed -i \u0027"},{"line_number":10,"context_line":"  /^ETCD_LISTEN_CLIENT_URLS\u003d/ s/\u003d.*/\u003d\"http:\\/\\/0.0.0.0:2379\"/"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_46241a0c","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":74},"updated":"2016-06-29 23:15:30.000000000","message":"See my remarks on configure-etcd.sh:5","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (master)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sed -i \u0027"},{"line_number":10,"context_line":"  /^ETCD_LISTEN_CLIENT_URLS\u003d/ s/\u003d.*/\u003d\"http:\\/\\/0.0.0.0:2379\"/"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_bbbb4cc3","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":74},"in_reply_to":"3aaa91ec_46241a0c","updated":"2016-06-30 06:37:25.000000000","message":"ok","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"}],"magnum/templates/kubernetes/fragments/configure-kubernetes-minion.sh":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (minion)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":8,"context_line":"ETCD_SERVER_IP\u003d${ETCD_SERVER_IP:-$KUBE_MASTER_IP}"},{"line_number":9,"context_line":"KUBE_PROTOCOL\u003d\"https\""},{"line_number":10,"context_line":"KUBE_CONFIG\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_e6c70610","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":74},"updated":"2016-06-29 23:15:30.000000000","message":"See my remarks on configure-etcd.sh:5","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (minion)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":8,"context_line":"ETCD_SERVER_IP\u003d${ETCD_SERVER_IP:-$KUBE_MASTER_IP}"},{"line_number":9,"context_line":"KUBE_PROTOCOL\u003d\"https\""},{"line_number":10,"context_line":"KUBE_CONFIG\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_9bef70b0","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":74},"in_reply_to":"3aaa91ec_e6c70610","updated":"2016-06-30 06:37:25.000000000","message":"ok","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"}],"magnum/templates/kubernetes/fragments/write-heat-params-master.yaml":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      KUBE_API_PUBLIC_ADDRESS\u003d\"$KUBE_API_PUBLIC_ADDRESS\""},{"line_number":9,"context_line":"      KUBE_API_PRIVATE_ADDRESS\u003d\"$KUBE_API_PRIVATE_ADDRESS\""},{"line_number":10,"context_line":"      KUBE_API_PORT\u003d\"$KUBE_API_PORT\""},{"line_number":11,"context_line":"      KUBE_NODE_IP\u003d\"$KUBE_NODE_IP\""},{"line_number":12,"context_line":"      KUBE_ALLOW_PRIV\u003d\"$KUBE_ALLOW_PRIV\""},{"line_number":13,"context_line":"      DOCKER_VOLUME\u003d\"$DOCKER_VOLUME\""},{"line_number":14,"context_line":"      DOCKER_STORAGE_DRIVER\u003d\"$DOCKER_STORAGE_DRIVER\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_a6e21e9e","side":"PARENT","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":34},"updated":"2016-06-29 23:15:30.000000000","message":"Let\u0027s keep this around, and only depend on the metadata service when the address can not be correctly determined. This will make bay creations a bit faster because we will not need to wait for several calls to the discovery service. See my remarks on configure-etcd.sh:5","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      KUBE_API_PUBLIC_ADDRESS\u003d\"$KUBE_API_PUBLIC_ADDRESS\""},{"line_number":9,"context_line":"      KUBE_API_PRIVATE_ADDRESS\u003d\"$KUBE_API_PRIVATE_ADDRESS\""},{"line_number":10,"context_line":"      KUBE_API_PORT\u003d\"$KUBE_API_PORT\""},{"line_number":11,"context_line":"      KUBE_NODE_IP\u003d\"$KUBE_NODE_IP\""},{"line_number":12,"context_line":"      KUBE_ALLOW_PRIV\u003d\"$KUBE_ALLOW_PRIV\""},{"line_number":13,"context_line":"      DOCKER_VOLUME\u003d\"$DOCKER_VOLUME\""},{"line_number":14,"context_line":"      DOCKER_STORAGE_DRIVER\u003d\"$DOCKER_STORAGE_DRIVER\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_9b4650be","side":"PARENT","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":34},"in_reply_to":"3aaa91ec_a6e21e9e","updated":"2016-06-30 06:37:25.000000000","message":"ok","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"}],"magnum/templates/kubernetes/fragments/write-heat-params.yaml":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      KUBE_ALLOW_PRIV\u003d\"$KUBE_ALLOW_PRIV\""},{"line_number":9,"context_line":"      KUBE_MASTER_IP\u003d\"$KUBE_MASTER_IP\""},{"line_number":10,"context_line":"      KUBE_API_PORT\u003d\"$KUBE_API_PORT\""},{"line_number":11,"context_line":"      KUBE_NODE_IP\u003d\"$KUBE_NODE_IP\""},{"line_number":12,"context_line":"      ETCD_SERVER_IP\u003d\"$ETCD_SERVER_IP\""},{"line_number":13,"context_line":"      DOCKER_VOLUME\u003d\"$DOCKER_VOLUME\""},{"line_number":14,"context_line":"      DOCKER_STORAGE_DRIVER\u003d\"$DOCKER_STORAGE_DRIVER\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_c6f3ea71","side":"PARENT","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":34},"updated":"2016-06-29 23:15:30.000000000","message":"Keep this. See comments on write-heat-params-master.yaml:11.","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      KUBE_ALLOW_PRIV\u003d\"$KUBE_ALLOW_PRIV\""},{"line_number":9,"context_line":"      KUBE_MASTER_IP\u003d\"$KUBE_MASTER_IP\""},{"line_number":10,"context_line":"      KUBE_API_PORT\u003d\"$KUBE_API_PORT\""},{"line_number":11,"context_line":"      KUBE_NODE_IP\u003d\"$KUBE_NODE_IP\""},{"line_number":12,"context_line":"      ETCD_SERVER_IP\u003d\"$ETCD_SERVER_IP\""},{"line_number":13,"context_line":"      DOCKER_VOLUME\u003d\"$DOCKER_VOLUME\""},{"line_number":14,"context_line":"      DOCKER_STORAGE_DRIVER\u003d\"$DOCKER_STORAGE_DRIVER\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_1b09c084","side":"PARENT","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":34},"in_reply_to":"3aaa91ec_c6f3ea71","updated":"2016-06-30 06:37:25.000000000","message":"ok","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"}],"magnum/templates/kubernetes/kubecluster-fedora-ironic.yaml":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    type: string"},{"line_number":34,"context_line":"    description: glance image used to boot the server"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  master_flavor:"},{"line_number":37,"context_line":"    type: string"},{"line_number":38,"context_line":"    default: baremetal"},{"line_number":39,"context_line":"    description: flavor to use when booting the server"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  minion_flavor:"},{"line_number":42,"context_line":"    type: string"},{"line_number":43,"context_line":"    default: baremetal"},{"line_number":44,"context_line":"    description: flavor to use when booting the server"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  dns_nameserver:"},{"line_number":47,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_c69aca13","line":44,"range":{"start_line":36,"start_character":0,"end_line":44,"end_character":54},"updated":"2016-06-29 23:15:30.000000000","message":"This would mean that the smallest ironic deployment would be two servers. Could we make this work on a single server, because using a whole server as a kube master is almost always going to be a huge waste of server resources. At the very least, maybe we could make the default for the master_flavor a VM, and not a baremetal server.","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    type: string"},{"line_number":34,"context_line":"    description: glance image used to boot the server"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  master_flavor:"},{"line_number":37,"context_line":"    type: string"},{"line_number":38,"context_line":"    default: baremetal"},{"line_number":39,"context_line":"    description: flavor to use when booting the server"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  minion_flavor:"},{"line_number":42,"context_line":"    type: string"},{"line_number":43,"context_line":"    default: baremetal"},{"line_number":44,"context_line":"    description: flavor to use when booting the server"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  dns_nameserver:"},{"line_number":47,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_bb7eace1","line":44,"range":{"start_line":36,"start_character":0,"end_line":44,"end_character":54},"in_reply_to":"3aaa91ec_c69aca13","updated":"2016-06-30 06:37:25.000000000","message":"Done","commit_id":"d8d93204cff4dc1a65d00343ecc861783ca1ee28"}],"magnum/templates/kubernetes/kubemaster.yaml":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            \"$KUBE_API_PUBLIC_ADDRESS\": {get_param: api_public_address}"},{"line_number":211,"context_line":"            \"$KUBE_API_PRIVATE_ADDRESS\": {get_param: api_private_address}"},{"line_number":212,"context_line":"            \"$KUBE_API_PORT\": {get_param: kubernetes_port}"},{"line_number":213,"context_line":"            \"$KUBE_NODE_IP\": {get_attr: [kube_master_eth0, fixed_ips, 0, ip_address]}"},{"line_number":214,"context_line":"            \"$KUBE_ALLOW_PRIV\": {get_param: kube_allow_priv}"},{"line_number":215,"context_line":"            \"$DOCKER_VOLUME\": {get_resource: docker_volume}"},{"line_number":216,"context_line":"            \"$DOCKER_STORAGE_DRIVER\": {get_param: docker_storage_driver}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_2638eeed","side":"PARENT","line":213,"range":{"start_line":213,"start_character":12,"end_line":213,"end_character":85},"updated":"2016-06-29 23:15:30.000000000","message":"Is the only way to determine the address of an ironic node to use the IP Address discovery in the metadata service? Can\u0027t we find some way to learn it through heat so we don\u0027t have all the curl calls coming out of the baremetal hosts? I think doing this once in heat, and passing it through as a variable is much better than calling the metadata service four times over the network.","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            \"$KUBE_API_PUBLIC_ADDRESS\": {get_param: api_public_address}"},{"line_number":211,"context_line":"            \"$KUBE_API_PRIVATE_ADDRESS\": {get_param: api_private_address}"},{"line_number":212,"context_line":"            \"$KUBE_API_PORT\": {get_param: kubernetes_port}"},{"line_number":213,"context_line":"            \"$KUBE_NODE_IP\": {get_attr: [kube_master_eth0, fixed_ips, 0, ip_address]}"},{"line_number":214,"context_line":"            \"$KUBE_ALLOW_PRIV\": {get_param: kube_allow_priv}"},{"line_number":215,"context_line":"            \"$DOCKER_VOLUME\": {get_resource: docker_volume}"},{"line_number":216,"context_line":"            \"$DOCKER_STORAGE_DRIVER\": {get_param: docker_storage_driver}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_dbee188a","side":"PARENT","line":213,"range":{"start_line":213,"start_character":12,"end_line":213,"end_character":85},"in_reply_to":"3aaa91ec_2638eeed","updated":"2016-06-30 06:37:25.000000000","message":"Done","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"}],"magnum/templates/kubernetes/kubeminion.yaml":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"2b412787bbb505d5501feff23bbcdd755264350a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            $KUBE_ALLOW_PRIV: {get_param: kube_allow_priv}"},{"line_number":224,"context_line":"            $KUBE_MASTER_IP: {get_param: kube_master_ip}"},{"line_number":225,"context_line":"            $KUBE_API_PORT: {get_param: kubernetes_port}"},{"line_number":226,"context_line":"            $KUBE_NODE_IP: {get_attr: [kube_minion_eth0, fixed_ips, 0, ip_address]}"},{"line_number":227,"context_line":"            $ETCD_SERVER_IP: {get_param: etcd_server_ip}"},{"line_number":228,"context_line":"            $DOCKER_VOLUME: {get_resource: docker_volume}"},{"line_number":229,"context_line":"            $DOCKER_STORAGE_DRIVER: {get_param: docker_storage_driver}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_4911cd51","side":"PARENT","line":226,"range":{"start_line":226,"start_character":12,"end_line":226,"end_character":83},"updated":"2016-06-29 23:15:30.000000000","message":"I think an equivalent of this should remain here in the template. See previous comments.","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"84101477ecbc727ce3bf0465ecc1e5d2b3fcbb4a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            $KUBE_ALLOW_PRIV: {get_param: kube_allow_priv}"},{"line_number":224,"context_line":"            $KUBE_MASTER_IP: {get_param: kube_master_ip}"},{"line_number":225,"context_line":"            $KUBE_API_PORT: {get_param: kubernetes_port}"},{"line_number":226,"context_line":"            $KUBE_NODE_IP: {get_attr: [kube_minion_eth0, fixed_ips, 0, ip_address]}"},{"line_number":227,"context_line":"            $ETCD_SERVER_IP: {get_param: etcd_server_ip}"},{"line_number":228,"context_line":"            $DOCKER_VOLUME: {get_resource: docker_volume}"},{"line_number":229,"context_line":"            $DOCKER_STORAGE_DRIVER: {get_param: docker_storage_driver}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_3bd91cf4","side":"PARENT","line":226,"range":{"start_line":226,"start_character":12,"end_line":226,"end_character":83},"in_reply_to":"3aaa91ec_4911cd51","updated":"2016-06-30 06:37:25.000000000","message":"Done","commit_id":"3d5413999ebf8b7de890c1e4f1775e9bb2247039"}]}
