)]}'
{"magnum/api/controllers/v1/certificate.py":[{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"4cc5e28408344cec0df7f54a02ad7582ba75d0b9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _set_cluster_uuid(self, value):"},{"line_number":47,"context_line":"        if value and self._cluster_uuid !\u003d value:"},{"line_number":48,"context_line":"            try:"},{"line_number":49,"context_line":"                self._cluster \u003d api_utils.get_resource(\u0027Bay\u0027, value)"},{"line_number":50,"context_line":"                self._cluster_uuid \u003d self._cluster.uuid"},{"line_number":51,"context_line":"            except exception.BayNotFound as e:"},{"line_number":52,"context_line":"                # Change error code because 404 (NotFound) is inappropriate"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_18b95aed","line":49,"updated":"2016-08-12 15:40:42.000000000","message":"Do we not need to call this with \u0027Cluster\u0027 instead of \u0027Bay\u0027?","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c382607eec8ae44b2cfddf45460250f4023a7070","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _set_cluster_uuid(self, value):"},{"line_number":47,"context_line":"        if value and self._cluster_uuid !\u003d value:"},{"line_number":48,"context_line":"            try:"},{"line_number":49,"context_line":"                self._cluster \u003d api_utils.get_resource(\u0027Bay\u0027, value)"},{"line_number":50,"context_line":"                self._cluster_uuid \u003d self._cluster.uuid"},{"line_number":51,"context_line":"            except exception.BayNotFound as e:"},{"line_number":52,"context_line":"                # Change error code because 404 (NotFound) is inappropriate"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_e3a9367d","line":49,"in_reply_to":"9ad45d7e_18b95aed","updated":"2016-08-12 17:27:23.000000000","message":"I don\u0027t believe so. The resource is called Bay in the model. Changing to Cluster will require a change to the schema. Jaycen may be working on this, but it shouldn\u0027t be part of this patch.","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"4cc5e28408344cec0df7f54a02ad7582ba75d0b9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        :param cluster_ident: UUID or logical name of a cluster."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        context \u003d pecan.request.context"},{"line_number":133,"context_line":"        cluster \u003d api_utils.get_resource(\u0027Bay\u0027, cluster_ident)"},{"line_number":134,"context_line":"        policy.enforce(context, \u0027certificate:get\u0027, cluster,"},{"line_number":135,"context_line":"                       action\u003d\u0027certificate:get\u0027)"},{"line_number":136,"context_line":"        certificate \u003d pecan.request.rpcapi.get_ca_certificate(cluster)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d8c7c262","line":133,"updated":"2016-08-12 15:40:42.000000000","message":"Same as above","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c382607eec8ae44b2cfddf45460250f4023a7070","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        :param cluster_ident: UUID or logical name of a cluster."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        context \u003d pecan.request.context"},{"line_number":133,"context_line":"        cluster \u003d api_utils.get_resource(\u0027Bay\u0027, cluster_ident)"},{"line_number":134,"context_line":"        policy.enforce(context, \u0027certificate:get\u0027, cluster,"},{"line_number":135,"context_line":"                       action\u003d\u0027certificate:get\u0027)"},{"line_number":136,"context_line":"        certificate \u003d pecan.request.rpcapi.get_ca_certificate(cluster)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_c3c9925c","line":133,"in_reply_to":"9ad45d7e_d8c7c262","updated":"2016-08-12 17:27:23.000000000","message":"See my answer above.","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"962ef289b6c5981ca0467094d69cf2619cb12c8e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        elif value \u003d\u003d wtypes.Unset:"},{"line_number":57,"context_line":"            self._cluster_uuid \u003d wtypes.Unset"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    cluster_uuid \u003d wsme.wsproperty(wtypes.text, _get_cluster_uuid,"},{"line_number":60,"context_line":"                                   _set_cluster_uuid, mandatory\u003dTrue)"},{"line_number":61,"context_line":"    \"\"\"The cluster UUID\"\"\""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_2104cb15","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":16},"updated":"2016-08-15 19:04:39.000000000","message":"I think this will break the backward-compatibility. You need to add a new attribute \"cluster_uuid\" and keep the old attribute \"bay_uuid\" as is.","commit_id":"87b50376a15bda841b467f4cc8d56772bc2345e7"}],"magnum/objects/certificate.py":[{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"4cc5e28408344cec0df7f54a02ad7582ba75d0b9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Certificate(base.MagnumPersistentObject, base.MagnumObject,"},{"line_number":23,"context_line":"                  base.MagnumObjectDictCompat):"},{"line_number":24,"context_line":"    # Version 1.0: Initial version"},{"line_number":25,"context_line":"    # Version 1.0: Rename bay_uuid to cluster_uuid"},{"line_number":26,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_78917652","line":25,"updated":"2016-08-12 15:40:42.000000000","message":"Version 1.1 in comment","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c382607eec8ae44b2cfddf45460250f4023a7070","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Certificate(base.MagnumPersistentObject, base.MagnumObject,"},{"line_number":23,"context_line":"                  base.MagnumObjectDictCompat):"},{"line_number":24,"context_line":"    # Version 1.0: Initial version"},{"line_number":25,"context_line":"    # Version 1.0: Rename bay_uuid to cluster_uuid"},{"line_number":26,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_a3c61e47","line":25,"in_reply_to":"9ad45d7e_78917652","updated":"2016-08-12 17:27:23.000000000","message":"Done","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e1bd3d1bbd5b42f8cc53d701608e8d73ac013072","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027project_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":30,"context_line":"        \u0027user_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027cluster_uuid\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027csr\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027pem\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_926d1ecf","line":31,"updated":"2016-08-12 18:51:08.000000000","message":"You need to add another migration to rename from bay_uuid to cluster_uuid Refer: http://docs.openstack.org/developer/magnum/objects.html\n\nTo create migration script you can refer hongbin comment on: https://review.openstack.org/#/c/314529/","commit_id":"87b50376a15bda841b467f4cc8d56772bc2345e7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e1bd3d1bbd5b42f8cc53d701608e8d73ac013072","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def from_object_bay(cls, bay):"},{"line_number":38,"context_line":"        return cls(project_id\u003dbay.project_id,"},{"line_number":39,"context_line":"                   user_id\u003dbay.user_id,"},{"line_number":40,"context_line":"                   cluster_uuid\u003dbay.uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_72134a0e","line":37,"updated":"2016-08-12 18:51:08.000000000","message":"shouldn\u0027t we completely remove \"bay\"?\nI mean at all places, we should use cluster, Here from_object_bay(cls, cluster), using two different names will confuse later.","commit_id":"87b50376a15bda841b467f4cc8d56772bc2345e7"}],"magnum/tests/unit/api/controllers/v1/test_certificate.py":[{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"4cc5e28408344cec0df7f54a02ad7582ba75d0b9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @mock.patch(\u0027magnum.api.utils.get_resource\u0027)"},{"line_number":26,"context_line":"    def test_cert_init(self, mock_get_resource):"},{"line_number":27,"context_line":"        cert_dict \u003d api_utils.cert_post_data()"},{"line_number":28,"context_line":"        mock_bay \u003d mock.MagicMock()"},{"line_number":29,"context_line":"        mock_bay.uuid \u003d cert_dict[\u0027cluster_uuid\u0027]"},{"line_number":30,"context_line":"        mock_get_resource.return_value \u003d mock_bay"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d8da2217","line":28,"updated":"2016-08-12 15:40:42.000000000","message":"mock_cluster instead of mock_bay\n\nI realize it\u0027s internal code but matching would be better than non- for future development","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c382607eec8ae44b2cfddf45460250f4023a7070","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @mock.patch(\u0027magnum.api.utils.get_resource\u0027)"},{"line_number":26,"context_line":"    def test_cert_init(self, mock_get_resource):"},{"line_number":27,"context_line":"        cert_dict \u003d api_utils.cert_post_data()"},{"line_number":28,"context_line":"        mock_bay \u003d mock.MagicMock()"},{"line_number":29,"context_line":"        mock_bay.uuid \u003d cert_dict[\u0027cluster_uuid\u0027]"},{"line_number":30,"context_line":"        mock_get_resource.return_value \u003d mock_bay"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_c325120b","line":28,"in_reply_to":"9ad45d7e_d8da2217","updated":"2016-08-12 17:27:23.000000000","message":"Done","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"4cc5e28408344cec0df7f54a02ad7582ba75d0b9","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(TestGetCertificate, self).setUp()"},{"line_number":43,"context_line":"        self.bay \u003d obj_utils.create_test_bay(self.context)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        conductor_api_patcher \u003d mock.patch(\u0027magnum.conductor.api.API\u0027)"},{"line_number":46,"context_line":"        self.conductor_api_class \u003d conductor_api_patcher.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d8f18297","line":43,"updated":"2016-08-12 15:40:42.000000000","message":"Should rename the bay object to cluster.","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c382607eec8ae44b2cfddf45460250f4023a7070","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(TestGetCertificate, self).setUp()"},{"line_number":43,"context_line":"        self.bay \u003d obj_utils.create_test_bay(self.context)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        conductor_api_patcher \u003d mock.patch(\u0027magnum.conductor.api.API\u0027)"},{"line_number":46,"context_line":"        self.conductor_api_class \u003d conductor_api_patcher.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_633f06d7","line":43,"in_reply_to":"9ad45d7e_d8f18297","updated":"2016-08-12 17:27:23.000000000","message":"Done","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"}],"magnum/tests/unit/conductor/handlers/test_ca_conductor.py":[{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"4cc5e28408344cec0df7f54a02ad7582ba75d0b9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        actual_cert \u003d self.ca_handler.get_ca_certificate(self.context,"},{"line_number":53,"context_line":"                                                         mock_bay)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.assertEqual(mock_bay.uuid, actual_cert.cluster_uuid)"},{"line_number":56,"context_line":"        self.assertEqual(mock_bay.user_id, actual_cert.user_id)"},{"line_number":57,"context_line":"        self.assertEqual(mock_bay.project_id, actual_cert.project_id)"},{"line_number":58,"context_line":"        self.assertEqual(\u0027fake-pem\u0027, actual_cert.pem)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_98254a0c","line":55,"updated":"2016-08-12 15:40:42.000000000","message":"mock_bay -\u003e mock_cluster","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c382607eec8ae44b2cfddf45460250f4023a7070","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        actual_cert \u003d self.ca_handler.get_ca_certificate(self.context,"},{"line_number":53,"context_line":"                                                         mock_bay)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.assertEqual(mock_bay.uuid, actual_cert.cluster_uuid)"},{"line_number":56,"context_line":"        self.assertEqual(mock_bay.user_id, actual_cert.user_id)"},{"line_number":57,"context_line":"        self.assertEqual(mock_bay.project_id, actual_cert.project_id)"},{"line_number":58,"context_line":"        self.assertEqual(\u0027fake-pem\u0027, actual_cert.pem)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_063458dc","line":55,"in_reply_to":"9ad45d7e_98254a0c","updated":"2016-08-12 17:27:23.000000000","message":"Done","commit_id":"b62f2e4a4ea24c4c2b7102664d3697ac8d2b06f1"}]}