)]}'
{"magnum/conf/bay_heat.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed5300e3e98c56525a5f8f4d9c22e6fc539e1834","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from magnum.i18n import _"},{"line_number":14,"context_line":"from oslo_config import cfg"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_633070e9","line":13,"updated":"2016-08-22 04:38:06.000000000","message":"move import at last after oslo to be sync with other modules.","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3c5f158f182261de96c4a25e5f080eeee5f2c90a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from magnum.i18n import _"},{"line_number":14,"context_line":"from oslo_config import cfg"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_864c9a71","line":13,"in_reply_to":"1ac06dbe_43c5748c","updated":"2016-08-22 05:33:25.000000000","message":"I tried: tox -epep8 but it didn;t fail. How you identified it will fail","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"13266d6293ffbbdd7c877470c44006cc0675697e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from magnum.i18n import _"},{"line_number":14,"context_line":"from oslo_config import cfg"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_43c5748c","line":13,"in_reply_to":"1ac06dbe_633070e9","updated":"2016-08-22 04:42:27.000000000","message":"what do you mean? if moving i18n module to after oslo, pep8 will absolutely fail.","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"8c7fc8bc4d24fd9dee66a920dcb95539c84b9a6a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from magnum.i18n import _"},{"line_number":14,"context_line":"from oslo_config import cfg"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_92f1706d","line":13,"in_reply_to":"1ac06dbe_864c9a71","updated":"2016-08-22 07:51:04.000000000","message":"ah, my bad, I forgot to put a separate between two statements","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed5300e3e98c56525a5f8f4d9c22e6fc539e1834","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027interval is in minutes. The default is 60 minutes.\u0027)),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027cluster_coe\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027kubernetes\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\u0027Container Orchestration Environments are \u0027"},{"line_number":40,"context_line":"                      \u0027kubernetes or swarm.\u0027))"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_037d3c6e","line":39,"updated":"2016-08-22 04:38:06.000000000","message":"I think other options are also available like mesos, but only two are specified here.","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"13266d6293ffbbdd7c877470c44006cc0675697e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027interval is in minutes. The default is 60 minutes.\u0027)),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027cluster_coe\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027kubernetes\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\u0027Container Orchestration Environments are \u0027"},{"line_number":40,"context_line":"                      \u0027kubernetes or swarm.\u0027))"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_83bf6cfa","line":39,"in_reply_to":"1ac06dbe_037d3c6e","updated":"2016-08-22 04:42:27.000000000","message":"Done","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"}],"magnum/conf/cluster_heat.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"09b25ccde15942f2a54b80ae6e81db5ea9c4f553","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                     ),"},{"line_number":41,"context_line":"               deprecated_group\u003d\u0027bay_heat\u0027,"},{"line_number":42,"context_line":"               deprecated_name\u003d\u0027bay_create_timeout\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cluster_coe\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027kubernetes\u0027,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Container Orchestration Environments are \u0027"},{"line_number":46,"context_line":"                      \u0027kubernetes, mesos or swarm.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_41bb650e","line":43,"range":{"start_line":43,"start_character":16,"end_line":43,"end_character":27},"updated":"2016-09-06 15:24:17.000000000","message":"This config is not used anywhere, so simply remove it.","commit_id":"05ee94ef4613f2977310faab215b662d4e620175"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"1882c029e6b7ead8519eb3cb06c60d1edea497c5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                     ),"},{"line_number":41,"context_line":"               deprecated_group\u003d\u0027bay_heat\u0027,"},{"line_number":42,"context_line":"               deprecated_name\u003d\u0027bay_create_timeout\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cluster_coe\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027kubernetes\u0027,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Container Orchestration Environments are \u0027"},{"line_number":46,"context_line":"                      \u0027kubernetes, mesos or swarm.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_58a0a643","line":43,"range":{"start_line":43,"start_character":16,"end_line":43,"end_character":27},"in_reply_to":"9a89bdaa_41bb650e","updated":"2016-09-06 20:47:02.000000000","message":"Although I agree with hongbin, his request is out of scope for this change, and should be submitted as a separate patch. I submitted that as https://review.openstack.org/366332 and I\u0027m voting to merge this.","commit_id":"05ee94ef4613f2977310faab215b662d4e620175"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"d5f0ab157dbe9460e920e67049d3f6d40631aab4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                     ),"},{"line_number":41,"context_line":"               deprecated_group\u003d\u0027bay_heat\u0027,"},{"line_number":42,"context_line":"               deprecated_name\u003d\u0027bay_create_timeout\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cluster_coe\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027kubernetes\u0027,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Container Orchestration Environments are \u0027"},{"line_number":46,"context_line":"                      \u0027kubernetes, mesos or swarm.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_629ee708","line":43,"range":{"start_line":43,"start_character":16,"end_line":43,"end_character":27},"in_reply_to":"9a89bdaa_58a0a643","updated":"2016-09-20 05:57:54.000000000","message":"Done","commit_id":"05ee94ef4613f2977310faab215b662d4e620175"}],"magnum/db/sqlalchemy/alembic/versions/592131657ca1_add_coe_column_to_baymodel.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed5300e3e98c56525a5f8f4d9c22e6fc539e1834","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import magnum.conf"},{"line_number":28,"context_line":"import sqlalchemy as sa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d magnum.conf.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_43973490","line":27,"updated":"2016-08-22 04:38:06.000000000","message":"move project specific imports at end","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"13266d6293ffbbdd7c877470c44006cc0675697e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import magnum.conf"},{"line_number":28,"context_line":"import sqlalchemy as sa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d magnum.conf.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e344601c","line":27,"in_reply_to":"1ac06dbe_43973490","updated":"2016-08-22 04:42:27.000000000","message":"yatin, please read about pep8 and http://docs.openstack.org/developer/hacking/#real-world-import-order-examples","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3c5f158f182261de96c4a25e5f080eeee5f2c90a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import magnum.conf"},{"line_number":28,"context_line":"import sqlalchemy as sa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d magnum.conf.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_c6e9721c","line":27,"in_reply_to":"1ac06dbe_e344601c","updated":"2016-08-22 05:33:25.000000000","message":"I tried tox -epep8 and it passed.","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"09b25ccde15942f2a54b80ae6e81db5ea9c4f553","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    op.execute("},{"line_number":41,"context_line":"        baymodel.update().values({"},{"line_number":42,"context_line":"            \u0027coe\u0027: op.inline_literal(CONF.cluster_heat.cluster_coe)})"},{"line_number":43,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_61d14957","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":66},"updated":"2016-09-06 15:24:17.000000000","message":"simply hard-code it to \"kubernetes\"","commit_id":"05ee94ef4613f2977310faab215b662d4e620175"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"d5f0ab157dbe9460e920e67049d3f6d40631aab4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    op.execute("},{"line_number":41,"context_line":"        baymodel.update().values({"},{"line_number":42,"context_line":"            \u0027coe\u0027: op.inline_literal(CONF.cluster_heat.cluster_coe)})"},{"line_number":43,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_2294dfe6","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":66},"in_reply_to":"9a89bdaa_61d14957","updated":"2016-09-20 05:57:54.000000000","message":"Done","commit_id":"05ee94ef4613f2977310faab215b662d4e620175"}],"magnum/tests/unit/conductor/handlers/test_bay_conductor.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed5300e3e98c56525a5f8f4d9c22e6fc539e1834","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from heatclient import exc"},{"line_number":20,"context_line":"import magnum.conf"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from mock import patch"},{"line_number":23,"context_line":"from oslo_service import loopingcall"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_83912c9c","line":20,"updated":"2016-08-22 04:38:06.000000000","message":"Move with other magnum imports","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3c5f158f182261de96c4a25e5f080eeee5f2c90a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from heatclient import exc"},{"line_number":20,"context_line":"import magnum.conf"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from mock import patch"},{"line_number":23,"context_line":"from oslo_service import loopingcall"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e6cd8eb8","line":20,"in_reply_to":"1ac06dbe_635190d8","updated":"2016-08-22 05:33:25.000000000","message":"Tried pep8 and it passed, please make me clear if i am wrong.","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"13266d6293ffbbdd7c877470c44006cc0675697e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from heatclient import exc"},{"line_number":20,"context_line":"import magnum.conf"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from mock import patch"},{"line_number":23,"context_line":"from oslo_service import loopingcall"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_635190d8","line":20,"in_reply_to":"1ac06dbe_83912c9c","updated":"2016-08-22 04:42:27.000000000","message":"please read about pep8 and http://docs.openstack.org/developer/hacking/#real-world-import-order-examples","commit_id":"f040668c6e5788c36baea19e9a295f6658d59c29"}]}