)]}'
{"magnum/drivers/k8s_fedora_atomic_ironic_v1/template_def.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e0fddd36b074a87ff64bf3ae3f9d568947ce43a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"KUBE_INSECURE_PORT \u003d \u00278080\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class K8sApiAddressOutputMapping(template_def.OutputMapping):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def set_output(self, stack, baymodel, bay):"},{"line_number":31,"context_line":"        if self.bay_attr is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_24209c49","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":32},"updated":"2016-09-02 15:52:05.000000000","message":"I think it is better to put this class to the drivers/common/template_def since all the k8s drivers share this class, but it doesn\u0027t have to be done in this patch.","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e0fddd36b074a87ff64bf3ae3f9d568947ce43a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            setattr(bay, self.bay_attr, value)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class K8sTemplateDefinition(template_def.BaseTemplateDefinition):"},{"line_number":53,"context_line":"    \"\"\"Base Kubernetes template.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_a4b90cef","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":27},"updated":"2016-09-02 15:52:05.000000000","message":"ditto: it is better to put this to drivers/common/template_def .","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e0fddd36b074a87ff64bf3ae3f9d568947ce43a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                      extra_params\u003dextra_params,"},{"line_number":174,"context_line":"                                      **kwargs)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def get_env_files(self, baymodel):"},{"line_number":177,"context_line":"        if baymodel.master_lb_enabled:"},{"line_number":178,"context_line":"            return [\u0027../../common/templates/environments/with_master_lb.yaml\u0027]"},{"line_number":179,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_64770403","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":21},"updated":"2016-09-02 15:52:05.000000000","message":"missing enable_floating_ip.yaml and disable_floating_ip.yaml ?","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"899cf65aefbe3cad497eccd8007335e45ed8d413","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                      extra_params\u003dextra_params,"},{"line_number":174,"context_line":"                                      **kwargs)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def get_env_files(self, baymodel):"},{"line_number":177,"context_line":"        if baymodel.master_lb_enabled:"},{"line_number":178,"context_line":"            return [\u0027../../common/templates/environments/with_master_lb.yaml\u0027]"},{"line_number":179,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_fd9b2c70","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":21},"in_reply_to":"da7fb54a_64770403","updated":"2016-09-06 20:02:18.000000000","message":"Agreed","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e0fddd36b074a87ff64bf3ae3f9d568947ce43a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    @property"},{"line_number":183,"context_line":"    def template_path(self):"},{"line_number":184,"context_line":"        return os.path.join(os.path.dirname(os.path.realpath(__file__)),"},{"line_number":185,"context_line":"                            \u0027templates/kubecluster-fedora-ironic.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_64aaa41b","line":185,"range":{"start_line":185,"start_character":39,"end_line":185,"end_character":69},"updated":"2016-09-02 15:52:05.000000000","message":"For consistency, better to rename this file to kubecluster.yaml","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"}],"magnum/drivers/k8s_fedora_atomic_ironic_v1/version.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e0fddd36b074a87ff64bf3ae3f9d568947ce43a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"version \u003d \u00271.0.0\u0027"},{"line_number":16,"context_line":"driver \u003d \u0027k8s_fedora_atomic\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_6790e696","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":27},"updated":"2016-09-02 15:52:05.000000000","message":"ironic","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e0fddd36b074a87ff64bf3ae3f9d568947ce43a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da7fb54a_e7c956ae","line":17,"updated":"2016-09-02 15:52:05.000000000","message":"Miss a container_version introduced in this patch: https://github.com/openstack/magnum/commit/50bc376c4d3d6d6abd8841c29dc8a7aa63652c05","commit_id":"f72908cf60e44f6dc328fc048bff969c962fd156"}]}