)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/kube-system-namespace-service.sh":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"0e37c572be6ef7e1aae6b6cc8eb28159e9652e10","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#check for existence of namespace"},{"line_number":36,"context_line":"/usr/bin/kubectl get namespace kube-system"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":39,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/kube-system-namespace.json"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_9393074f","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":25},"updated":"2016-09-30 02:09:40.000000000","message":"This change may be simple: if [[ $? -ne 0 ]];then","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"},{"author":{"_account_id":23440,"name":"jiriprox","email":"jirix.x.prokes@intel.com","username":"jiriprox"},"change_message_id":"99af4417b97195a46513fd774af8127a56c4df2e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#check for existence of namespace"},{"line_number":36,"context_line":"/usr/bin/kubectl get namespace kube-system"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":39,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/kube-system-namespace.json"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_be7d3570","line":38,"range":{"start_line":38,"start_character":5,"end_line":38,"end_character":10},"updated":"2016-09-29 20:33:53.000000000","message":"This check is not working for me. Correct should be:\nif [ \"$?\" !\u003d \"0\" ]; then\n\nNevertheless safer solution should be:\n/usr/bin/kubectl get namespace kube-system\ntemp_res\u003d$?\n\nif [ \"$temp_res\" !\u003d \"0\" ]; then\n    echo \"Creating namespace ...\"\n    /usr/bin/kubectl create -f /srv/kubernetes/kube-system-namespace.json\nelse\n    echo \"Namespace already exists\"\nfi","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"415dd8aa27e8a7f6ebb488da16294dd48ca5d6ed","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#check for existence of namespace"},{"line_number":36,"context_line":"/usr/bin/kubectl get namespace kube-system"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":39,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/kube-system-namespace.json"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_04932fa4","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":25},"in_reply_to":"3a98d1f4_9393074f","updated":"2016-09-30 03:15:46.000000000","message":"@feng, yes but as i replied we have to use \\? to escape $?, otherwise it would be replace with the return code of previous command when the script is executed.","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b0ad642d3a4e3cfa85b78c083af321649d493522","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#check for existence of namespace"},{"line_number":36,"context_line":"/usr/bin/kubectl get namespace kube-system"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":39,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/kube-system-namespace.json"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_644eb370","line":38,"range":{"start_line":38,"start_character":5,"end_line":38,"end_character":10},"in_reply_to":"3a98d1f4_be7d3570","updated":"2016-09-30 03:13:10.000000000","message":"@jiriprox, [ \"\\$?\" !\u003d \"0\" ] ---\u003e gets converted to [ \"$?\" !\u003d \"0\" ] after cat command completes. \\ is used to escape \"?\". How you tried this patch? Have you created the k8s cluster using magnum cluster-create?\nIf i will change this to your suggestion, then it would not work. Rather the script would change to something like below:\ntemp_res\u003d0\nif","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"}],"magnum/drivers/common/templates/kubernetes/fragments/kube-ui-service.sh":[{"author":{"_account_id":23440,"name":"jiriprox","email":"jirix.x.prokes@intel.com","username":"jiriprox"},"change_message_id":"99af4417b97195a46513fd774af8127a56c4df2e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#echo check for existence of kube-ui-v4 replication controller"},{"line_number":90,"context_line":"/usr/bin/kubectl get rc kube-ui-v4 --namespace\u003dkube-system"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":93,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/manifests/kube-ui-rc.yaml --namespace\u003dkube-system"},{"line_number":94,"context_line":"fi"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_5eaa7171","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":3},"updated":"2016-09-29 20:33:53.000000000","message":"This check is not working for me. Correct should be:\nif [ \"$?\" !\u003d \"0\" ]; then\n\nNevertheless safer solution should be:\n/usr/bin/kubectl get rc kube-ui-v4 --namespace\u003dkube-system\ntemp_res\u003d$?\n\nif [ \"$temp_res\" !\u003d \"0\" ]; then\n    echo \"Creating kube-ui replicationcontroller ...\"\n    /usr/bin/kubectl create -f /srv/kubernetes/manifests/kube-ui-rc.yaml --namespace\u003dkube-system\nelse\n    echo \"kube-ui replicationcontroller already exists\"\nfi","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b0ad642d3a4e3cfa85b78c083af321649d493522","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#echo check for existence of kube-ui-v4 replication controller"},{"line_number":90,"context_line":"/usr/bin/kubectl get rc kube-ui-v4 --namespace\u003dkube-system"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":93,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/manifests/kube-ui-rc.yaml --namespace\u003dkube-system"},{"line_number":94,"context_line":"fi"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_6475d396","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":3},"in_reply_to":"3a98d1f4_5eaa7171","updated":"2016-09-30 03:13:10.000000000","message":"@jiriprox, [ \"\\$?\" !\u003d \"0\" ] is actually converted to [ \"$?\" !\u003d \"0\" ] when the cat command completes.\nHow did you created the k8s cluster, have you used magnum cli to create cluster?\nIf i will use your suggestion then, the script would convert to something like below:-\ntemp_res\u003d0\nif [ \"\" !\u003d 0 ]; then\n  ....\nfi","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"},{"author":{"_account_id":23440,"name":"jiriprox","email":"jirix.x.prokes@intel.com","username":"jiriprox"},"change_message_id":"99af4417b97195a46513fd774af8127a56c4df2e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#echo check for existence of kube-ui service"},{"line_number":97,"context_line":"/usr/bin/kubectl get service kube-ui --namespace\u003dkube-system"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":100,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/manifests/kube-ui-svc.yaml --namespace\u003dkube-system"},{"line_number":101,"context_line":"fi"},{"line_number":102,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_fe6edd2d","line":99,"updated":"2016-09-29 20:33:53.000000000","message":"This check is not working for me. Correct should be:\nif [ \"$?\" !\u003d \"0\" ]; then\n\nNevertheless safer solution should be:\n/usr/bin/kubectl get service kube-ui --namespace\u003dkube-system\ntemp_res\u003d$?\n\nif [ \"$temp_res\" !\u003d \"0\" ]; then\n    echo \"Creating kube-ui service ...\"\n    /usr/bin/kubectl create -f /srv/kubernetes/manifests/kube-ui-svc.yaml --namespace\u003dkube-system\nelse\n    echo \"kube-ui service already exists\"\nfi","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b0ad642d3a4e3cfa85b78c083af321649d493522","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#echo check for existence of kube-ui service"},{"line_number":97,"context_line":"/usr/bin/kubectl get service kube-ui --namespace\u003dkube-system"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"if [ \"\\$?\" !\u003d \"0\" ]; then"},{"line_number":100,"context_line":"    /usr/bin/kubectl create -f /srv/kubernetes/manifests/kube-ui-svc.yaml --namespace\u003dkube-system"},{"line_number":101,"context_line":"fi"},{"line_number":102,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a98d1f4_c47227ad","line":99,"in_reply_to":"3a98d1f4_fe6edd2d","updated":"2016-09-30 03:13:10.000000000","message":"same as previous reply","commit_id":"3f86cc4e5245a6515997c62439a0e779a847ae31"}]}