)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/enable-kube-controller-manager-scheduler.sh":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f8c9563cc987ee0fe3e062a44024cbd94801e531","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    - /hyperkube"},{"line_number":51,"context_line":"    - controller-manager"},{"line_number":52,"context_line":"    - --leader-elect\u003dtrue"},{"line_number":53,"context_line":"$(generate_pod_args \"    - \" $KUBE_LOGTOSTDERR $KUBE_LOG_LEVEL $KUBE_MASTER $KUBE_CONTROLLER_MANAGER_ARGS)"},{"line_number":54,"context_line":"    livenessProbe:"},{"line_number":55,"context_line":"      httpGet:"},{"line_number":56,"context_line":"        host: 127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3a71b18c_ec3b56cf","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":19},"updated":"2016-12-11 20:36:15.000000000","message":"Personally, I like the style on the left. It statically declare all the options, which is easier to read. However, if the team prefer this change, I have no problem of that.","commit_id":"ca813a1a0387092d2f8a79cf95294a1a4a4c8a81"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"02d62b8ccb81d6e074a0b73bce7ca47b7c4e1e7e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    - /hyperkube"},{"line_number":51,"context_line":"    - controller-manager"},{"line_number":52,"context_line":"    - --leader-elect\u003dtrue"},{"line_number":53,"context_line":"$(generate_pod_args \"    - \" $KUBE_LOGTOSTDERR $KUBE_LOG_LEVEL $KUBE_MASTER $KUBE_CONTROLLER_MANAGER_ARGS)"},{"line_number":54,"context_line":"    livenessProbe:"},{"line_number":55,"context_line":"      httpGet:"},{"line_number":56,"context_line":"        host: 127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a6eadb0_a5814afd","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":19},"in_reply_to":"1a6eadb0_d73e25d9","updated":"2016-12-16 01:56:04.000000000","message":"Adding my vote to list the options explicitly for readability.\nIs the new function intended to reuse code or to make the list more compact?","commit_id":"ca813a1a0387092d2f8a79cf95294a1a4a4c8a81"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"e09f53f0eec5205c8239d43c7efaa13d62114374","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    - /hyperkube"},{"line_number":51,"context_line":"    - controller-manager"},{"line_number":52,"context_line":"    - --leader-elect\u003dtrue"},{"line_number":53,"context_line":"$(generate_pod_args \"    - \" $KUBE_LOGTOSTDERR $KUBE_LOG_LEVEL $KUBE_MASTER $KUBE_CONTROLLER_MANAGER_ARGS)"},{"line_number":54,"context_line":"    livenessProbe:"},{"line_number":55,"context_line":"      httpGet:"},{"line_number":56,"context_line":"        host: 127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a6eadb0_d73e25d9","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":19},"in_reply_to":"3a71b18c_ec3b56cf","updated":"2016-12-15 09:27:57.000000000","message":"I don\u0027t like this either. I haven\u0027t looked if it can be done in a different way.","commit_id":"ca813a1a0387092d2f8a79cf95294a1a4a4c8a81"}],"magnum/drivers/common/templates/kubernetes/fragments/enable-kube-podmaster.sh":[{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"e0aa2eb12c63ae8d7872acb8450efe3e81d33b61","unresolved":false,"context_lines":[{"line_number":15,"context_line":"unset KUBE_ALLOW_PRIV"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"generate_pod_args() {"},{"line_number":19,"context_line":"    prefix\u003d$1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    for var in \"${@:2}\" ; do"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a77a97e_b5579e24","line":18,"updated":"2016-11-18 19:39:27.000000000","message":"Could you add a comment about what this does? I think I get it, but was scratching my head for a minute. $KUBE_CONTROLLER_MANAGER_ARGS is probably multiple flags, so it loops through them and puts them on different lines, right?","commit_id":"1e33fa31933265fa212432a4a2459809eff7aadf"},{"author":{"_account_id":20031,"name":"Mathieu Velten","email":"mathieu.velten@cern.ch","username":"MatMaul"},"change_message_id":"8623ea8254d1728a90d440384ac628428803ec15","unresolved":false,"context_lines":[{"line_number":15,"context_line":"unset KUBE_ALLOW_PRIV"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"generate_pod_args() {"},{"line_number":19,"context_line":"    prefix\u003d$1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    for var in \"${@:2}\" ; do"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a77a97e_05babc6e","line":18,"in_reply_to":"7a77a97e_b5579e24","updated":"2016-11-21 09:17:30.000000000","message":"Correct ;) I\u0027ll add a comment.","commit_id":"1e33fa31933265fa212432a4a2459809eff7aadf"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"e0aa2eb12c63ae8d7872acb8450efe3e81d33b61","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    - /hyperkube"},{"line_number":101,"context_line":"    - controller-manager"},{"line_number":102,"context_line":"    - --leader-elect\u003dtrue"},{"line_number":103,"context_line":"$(generate_pod_args \"    - \" $KUBE_LOGTOSTDERR $KUBE_LOG_LEVEL $KUBE_MASTER $KUBE_CONTROLLER_MANAGER_ARGS)"},{"line_number":104,"context_line":"    livenessProbe:"},{"line_number":105,"context_line":"      httpGet:"},{"line_number":106,"context_line":"        host: 127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a77a97e_950aa224","line":103,"updated":"2016-11-18 19:39:27.000000000","message":"Is this necessary for all of these variables? I think it would look nicer if the variables with only one flag in them could be written on their own line.","commit_id":"1e33fa31933265fa212432a4a2459809eff7aadf"},{"author":{"_account_id":20031,"name":"Mathieu Velten","email":"mathieu.velten@cern.ch","username":"MatMaul"},"change_message_id":"8623ea8254d1728a90d440384ac628428803ec15","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    - /hyperkube"},{"line_number":101,"context_line":"    - controller-manager"},{"line_number":102,"context_line":"    - --leader-elect\u003dtrue"},{"line_number":103,"context_line":"$(generate_pod_args \"    - \" $KUBE_LOGTOSTDERR $KUBE_LOG_LEVEL $KUBE_MASTER $KUBE_CONTROLLER_MANAGER_ARGS)"},{"line_number":104,"context_line":"    livenessProbe:"},{"line_number":105,"context_line":"      httpGet:"},{"line_number":106,"context_line":"        host: 127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a77a97e_b07228af","line":103,"in_reply_to":"7a77a97e_950aa224","updated":"2016-11-21 09:17:30.000000000","message":"Most of them have a single flag however it also take care of empty ones so I would prefer to keep it that way. A bit more confusing but more generic. However I\u0027ll try to do the statement on several lines to make it clearer to read.","commit_id":"1e33fa31933265fa212432a4a2459809eff7aadf"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4ddbb429e8bc8b64cda89a535f2d090c24cb406a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    local SERVICE_ACCOUNT_PRIVATE_KEY_FILE\u003d/etc/kubernetes/ssl/server.key"},{"line_number":68,"context_line":"    local ROOT_CA_FILE\u003d/etc/kubernetes/ssl/ca.crt"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    if [ \"${TLS_DISABLED}\" \u003d \"True\" ]; then"},{"line_number":71,"context_line":"        SERVICE_ACCOUNT_PRIVATE_KEY_FILE\u003d"},{"line_number":72,"context_line":"        ROOT_CA_FILE\u003d"},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    local TEMPLATE\u003d/srv/kubernetes/manifests/kube-controller-manager.yaml"},{"line_number":76,"context_line":"    [ -f ${TEMPLATE} ] || {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a71b18c_3ba76d50","side":"PARENT","line":73,"range":{"start_line":70,"start_character":0,"end_line":73,"end_character":6},"updated":"2016-12-03 12:22:55.000000000","message":"Will the tls-disabled options still be available?","commit_id":"30f314ed312149c94f80534f2051084b62b9be77"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4ddbb429e8bc8b64cda89a535f2d090c24cb406a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    - controller-manager"},{"line_number":92,"context_line":"    - --master\u003dhttp://127.0.0.1:8080"},{"line_number":93,"context_line":"    - --leader-elect\u003dtrue"},{"line_number":94,"context_line":"    - --service-account-private-key-file\u003d${SERVICE_ACCOUNT_PRIVATE_KEY_FILE}"},{"line_number":95,"context_line":"    - --root-ca-file\u003d${ROOT_CA_FILE}"},{"line_number":96,"context_line":"    livenessProbe:"},{"line_number":97,"context_line":"      httpGet:"},{"line_number":98,"context_line":"        host: 127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a71b18c_bb71bde2","side":"PARENT","line":95,"range":{"start_line":94,"start_character":6,"end_line":95,"end_character":36},"updated":"2016-12-03 12:22:55.000000000","message":"Why these are not needed anymore? (I saw that you removed them above)","commit_id":"30f314ed312149c94f80534f2051084b62b9be77"}]}