)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"5426864aac232b8aa70d9a53566dfb5b06b4734d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-25 10:56:01 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Factorize load balancer code into its own template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1644454"},{"line_number":10,"context_line":"Change-Id: I513b92c205ed97334033ba38ddf1d890ed61ff84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a74a57a_3c5107d9","line":8,"updated":"2016-11-25 22:06:07.000000000","message":"I would appreciate a commit message with slightly more details. Consider listing what has been factorized would suffice.","commit_id":"f0268291b6300adc80460c6cf9f79376657b9f86"}],"magnum/drivers/common/templates/environments/no_master_lb.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c39b12f50403c1e5987c55801ba6de181ea2e21d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::Listener\": \"OS::Heat::None\""},{"line_number":9,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::Pool\": \"OS::Heat::None\""},{"line_number":10,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::HealthMonitor\": \"OS::Heat::None\""},{"line_number":11,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::FloatingIP\": \"OS::Heat::None\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Master node template"},{"line_number":14,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::PoolMember\": \"OS::Heat::None\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_acc72963","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":35},"updated":"2016-12-07 17:32:47.000000000","message":"We need this to keep the current functionality which is to have FIPs in LBaaS","commit_id":"ce3c68424adef31ad0e67841432ce2d239991a1a"}],"magnum/drivers/common/templates/environments/with_master_lb.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3034f45679b15c7f9013faf5770b87835e7eea7b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::Listener\": \"OS::Neutron::LBaaS::Listener\""},{"line_number":9,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::Pool\": \"OS::Neutron::LBaaS::Pool\""},{"line_number":10,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::HealthMonitor\": \"OS::Neutron::LBaaS::HealthMonitor\""},{"line_number":11,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::FloatingIP\": \"OS::Neutron::FloatingIP\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Master node template"},{"line_number":14,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::PoolMember\": \"OS::Neutron::LBaaS::PoolMember\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a74a57a_bc1ba01a","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":37},"updated":"2016-11-24 09:12:26.000000000","message":"I think it\u0027s more intuitive to not put LBaaS here. To have:\nMagnum::Optional::[the actual resource]\n\nThis comment applies in all Magnum::Optional::Neutron::LBaaS::FloatingIP occurrences.","commit_id":"746af8e5fc8500ad8ba65c98009350a8e30cb384"},{"author":{"_account_id":20031,"name":"Mathieu Velten","email":"mathieu.velten@cern.ch","username":"MatMaul"},"change_message_id":"3142fa99f06098a3244574ee6607d4551aa0b759","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::Listener\": \"OS::Neutron::LBaaS::Listener\""},{"line_number":9,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::Pool\": \"OS::Neutron::LBaaS::Pool\""},{"line_number":10,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::HealthMonitor\": \"OS::Neutron::LBaaS::HealthMonitor\""},{"line_number":11,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::FloatingIP\": \"OS::Neutron::FloatingIP\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Master node template"},{"line_number":14,"context_line":"  \"Magnum::Optional::Neutron::LBaaS::PoolMember\": \"OS::Neutron::LBaaS::PoolMember\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a74a57a_bc59e05c","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":37},"in_reply_to":"5a74a57a_bc1ba01a","updated":"2016-11-24 09:23:56.000000000","message":"It is on purpose. If I keep it breaks drivers that support optional LBaaS but not optional fip. And fip on LBaaS is a different use case anyway, with that in place we can easily have [none, master, all, lb] as an enum for fip.","commit_id":"746af8e5fc8500ad8ba65c98009350a8e30cb384"}],"magnum/drivers/common/templates/lb.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3034f45679b15c7f9013faf5770b87835e7eea7b","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  fixed_network:"},{"line_number":6,"context_line":"    type: string"},{"line_number":7,"context_line":"    default: \"\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  fixed_subnet:"},{"line_number":10,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a74a57a_9cab44d6","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":15},"updated":"2016-11-24 09:12:26.000000000","message":"fixed_network is not used in this template","commit_id":"746af8e5fc8500ad8ba65c98009350a8e30cb384"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3034f45679b15c7f9013faf5770b87835e7eea7b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  external_network:"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    default: \"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  protocol:"},{"line_number":18,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a74a57a_9cd98486","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":15},"updated":"2016-11-24 09:12:26.000000000","message":"we have already defined the default in the driver templates.","commit_id":"746af8e5fc8500ad8ba65c98009350a8e30cb384"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"aba04fa8984ab1a6b6cd212fc1f6593eddeaa107","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  external_network:"},{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"    default: \"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  protocol:"},{"line_number":13,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a71b18c_c23e61d9","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":15},"updated":"2016-12-05 17:07:03.000000000","message":"Remove this","commit_id":"6f07965ab6ada031fc3347cfe373909a01c4c77c"}],"magnum/drivers/k8s_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"05e688d334fa5a365cdb0c3b30fba8865e33e679","unresolved":false,"context_lines":[{"line_number":237,"context_line":"  api_lb:"},{"line_number":238,"context_line":"    type: ../../common/templates/lb.yaml"},{"line_number":239,"context_line":"    properties:"},{"line_number":240,"context_line":"      fixed_subnet: {get_param: fixed_subnet}"},{"line_number":241,"context_line":"      external_network: {get_param: external_network}"},{"line_number":242,"context_line":"      protocol: {get_param: loadbalancing_protocol}"},{"line_number":243,"context_line":"      port: {get_param: kubernetes_port}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_d03a16e7","line":240,"updated":"2016-12-08 10:14:31.000000000","message":"get_resource","commit_id":"ce3c68424adef31ad0e67841432ce2d239991a1a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"05e688d334fa5a365cdb0c3b30fba8865e33e679","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  etcd_lb:"},{"line_number":246,"context_line":"    type: ../../common/templates/lb.yaml"},{"line_number":247,"context_line":"    properties:"},{"line_number":248,"context_line":"      fixed_subnet: {get_param: fixed_subnet}"},{"line_number":249,"context_line":"      external_network: {get_param: external_network}"},{"line_number":250,"context_line":"      protocol: HTTP"},{"line_number":251,"context_line":"      port: 2379"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_d043f66a","line":248,"updated":"2016-12-08 10:14:31.000000000","message":"get_resource","commit_id":"ce3c68424adef31ad0e67841432ce2d239991a1a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a9944e6d6f98eb6b619f806e3e72b820fb3e21da","unresolved":false,"context_lines":[{"line_number":297,"context_line":"  api_address_lb_switch:"},{"line_number":298,"context_line":"    type: Magnum::ApiGatewaySwitcher"},{"line_number":299,"context_line":"    properties:"},{"line_number":300,"context_line":"      pool_public_ip: {get_attr: [api_pool_floating, floating_ip_address]}"},{"line_number":301,"context_line":"      pool_private_ip: {get_attr: [api_loadbalancer, vip_address]}"},{"line_number":302,"context_line":"      master_public_ip: {get_attr: [kube_masters, resource.0.kube_master_external_ip]}"},{"line_number":303,"context_line":"      master_private_ip: {get_attr: [kube_masters, resource.0.kube_master_ip]}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_2d513763","line":300,"updated":"2016-12-08 09:57:39.000000000","message":"missed.","commit_id":"ce3c68424adef31ad0e67841432ce2d239991a1a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a9944e6d6f98eb6b619f806e3e72b820fb3e21da","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    type: Magnum::ApiGatewaySwitcher"},{"line_number":299,"context_line":"    properties:"},{"line_number":300,"context_line":"      pool_public_ip: {get_attr: [api_pool_floating, floating_ip_address]}"},{"line_number":301,"context_line":"      pool_private_ip: {get_attr: [api_loadbalancer, vip_address]}"},{"line_number":302,"context_line":"      master_public_ip: {get_attr: [kube_masters, resource.0.kube_master_external_ip]}"},{"line_number":303,"context_line":"      master_private_ip: {get_attr: [kube_masters, resource.0.kube_master_ip]}"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_4d4e73c2","line":301,"updated":"2016-12-08 09:57:39.000000000","message":"missed","commit_id":"ce3c68424adef31ad0e67841432ce2d239991a1a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a9944e6d6f98eb6b619f806e3e72b820fb3e21da","unresolved":false,"context_lines":[{"line_number":305,"context_line":"  etcd_address_lb_switch:"},{"line_number":306,"context_line":"    type: Magnum::ApiGatewaySwitcher"},{"line_number":307,"context_line":"    properties:"},{"line_number":308,"context_line":"      pool_private_ip: {get_attr: [etcd_loadbalancer, vip_address]}"},{"line_number":309,"context_line":"      master_private_ip: {get_attr: [kube_masters, resource.0.kube_master_ip]}"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"  ######################################################################"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_edd57fb9","line":308,"updated":"2016-12-08 09:57:39.000000000","message":"missed","commit_id":"ce3c68424adef31ad0e67841432ce2d239991a1a"}]}