)]}'
{"contrib/drivers/k8s_opensuse_v1/templates/fragments/write-heat-params-master.yaml":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b976ef4dc94932124726a7a44342b2ab62201715","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      TLS_DISABLED\u003d\"$TLS_DISABLED\""},{"line_number":24,"context_line":"      CLUSTER_UUID\u003d\"$CLUSTER_UUID\""},{"line_number":25,"context_line":"      MAGNUM_URL\u003d\"$MAGNUM_URL\""},{"line_number":26,"context_line":"      K8S_SYSTEM_PODS_INITIAL_DELAY\u003d\"$K8S_SYSTEM_PODS_INITIAL_DELAY\""},{"line_number":27,"context_line":"      K8S_SYSTEM_PODS_TIMEOUT\u003d\"$K8S_SYSTEM_PODS_TIMEOUT\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_d7637aaf","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":35},"updated":"2016-12-12 06:16:50.000000000","message":"I think the prefix k8s_system is not required as these parameters as k8s specific itself.","commit_id":"fc03dadd2618d28e1b51631a1fe94c46e5859438"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"30326fa809e41af44b1e8683060ff14ccc51853b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      TLS_DISABLED\u003d\"$TLS_DISABLED\""},{"line_number":24,"context_line":"      CLUSTER_UUID\u003d\"$CLUSTER_UUID\""},{"line_number":25,"context_line":"      MAGNUM_URL\u003d\"$MAGNUM_URL\""},{"line_number":26,"context_line":"      K8S_SYSTEM_PODS_INITIAL_DELAY\u003d\"$K8S_SYSTEM_PODS_INITIAL_DELAY\""},{"line_number":27,"context_line":"      K8S_SYSTEM_PODS_TIMEOUT\u003d\"$K8S_SYSTEM_PODS_TIMEOUT\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_b4799195","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":35},"in_reply_to":"3a71b18c_d7637aaf","updated":"2016-12-12 11:01:32.000000000","message":"k8s can be omitted, I think we must have system though.","commit_id":"fc03dadd2618d28e1b51631a1fe94c46e5859438"}],"contrib/drivers/k8s_opensuse_v1/templates/kubecluster.yaml":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"03f1b642433b464ada8d97ca0aeaac548baa18b3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    description: \u003e"},{"line_number":92,"context_line":"      health check, timeout for system pods (podmaster, scheduler) to answer."},{"line_number":93,"context_line":"      (in seconds)"},{"line_number":94,"context_line":"    default: 1"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  kube_allow_priv:"},{"line_number":97,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_4c18ca75","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":14},"updated":"2016-12-11 20:30:51.000000000","message":"The default time is 1 second? It doesn\u0027t seem to make any sense, or I misunderstand something....","commit_id":"fc03dadd2618d28e1b51631a1fe94c46e5859438"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"b976ef4dc94932124726a7a44342b2ab62201715","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    description: \u003e"},{"line_number":92,"context_line":"      health check, timeout for system pods (podmaster, scheduler) to answer."},{"line_number":93,"context_line":"      (in seconds)"},{"line_number":94,"context_line":"    default: 1"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  kube_allow_priv:"},{"line_number":97,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_57dbea7b","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":14},"in_reply_to":"3a71b18c_4c18ca75","updated":"2016-12-12 06:16:50.000000000","message":"Is 1 sec enough for system pods to boot? The old value was also 1 sec and it causes many failures. I guess we should increase this value.","commit_id":"fc03dadd2618d28e1b51631a1fe94c46e5859438"}],"magnum/drivers/heat/k8s_template_def.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"26d83292528e8a91a1d3577cbdfd7f50e99a4d97","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        label_list \u003d [\u0027flannel_network_cidr\u0027, \u0027flannel_backend\u0027,"},{"line_number":109,"context_line":"                      \u0027flannel_network_subnetlen\u0027,"},{"line_number":110,"context_line":"                      \u0027system_pods_initial_delay\u0027,"},{"line_number":111,"context_line":"                      \u0027system_pods_timeout\u0027]"},{"line_number":112,"context_line":"        for label in label_list:"},{"line_number":113,"context_line":"            extra_params[label] \u003d cluster_template.labels.get(label)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_925bea2d","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":48},"updated":"2017-01-16 16:03:54.000000000","message":"What do you think by adding \"k8s_\" or similar prefix to these labels:\n* k8s_system_pods_initial_delay\n* k8s_system_pods_timeout\nI suggested that because labels are used by all COEs, so it is better to indicate these labels are k8s specific. What do you think?","commit_id":"9727b6e818b03aef7ce8478c3e11d5e9a921dbba"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c54eb67e263b6a5f370f22685e1aa3282469f5d5","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        label_list \u003d [\u0027flannel_network_cidr\u0027, \u0027flannel_backend\u0027,"},{"line_number":109,"context_line":"                      \u0027flannel_network_subnetlen\u0027,"},{"line_number":110,"context_line":"                      \u0027system_pods_initial_delay\u0027,"},{"line_number":111,"context_line":"                      \u0027system_pods_timeout\u0027]"},{"line_number":112,"context_line":"        for label in label_list:"},{"line_number":113,"context_line":"            extra_params[label] \u003d cluster_template.labels.get(label)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a461143_aed6fac2","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":48},"in_reply_to":"5a3905b3_17c61348","updated":"2017-01-26 15:24:55.000000000","message":"system is enough. This label will always be k8s specific. Unless docker introduces pods.","commit_id":"9727b6e818b03aef7ce8478c3e11d5e9a921dbba"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"9e99037fb6cbabb509ebfde5fa1dd2f282442335","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        label_list \u003d [\u0027flannel_network_cidr\u0027, \u0027flannel_backend\u0027,"},{"line_number":109,"context_line":"                      \u0027flannel_network_subnetlen\u0027,"},{"line_number":110,"context_line":"                      \u0027system_pods_initial_delay\u0027,"},{"line_number":111,"context_line":"                      \u0027system_pods_timeout\u0027]"},{"line_number":112,"context_line":"        for label in label_list:"},{"line_number":113,"context_line":"            extra_params[label] \u003d cluster_template.labels.get(label)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_17c61348","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":48},"in_reply_to":"5a3905b3_f6ebb6ae","updated":"2017-01-20 18:09:57.000000000","message":"It only makes sense for the label name to be different between various drivers if the format or semantics of the value supplied for the label differs by COE. In this case, I\u0027m not aware of any such difference. Is there one?","commit_id":"9727b6e818b03aef7ce8478c3e11d5e9a921dbba"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"c300ba468c6706ce5365c04da51c1d15306fbb42","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        label_list \u003d [\u0027flannel_network_cidr\u0027, \u0027flannel_backend\u0027,"},{"line_number":109,"context_line":"                      \u0027flannel_network_subnetlen\u0027,"},{"line_number":110,"context_line":"                      \u0027system_pods_initial_delay\u0027,"},{"line_number":111,"context_line":"                      \u0027system_pods_timeout\u0027]"},{"line_number":112,"context_line":"        for label in label_list:"},{"line_number":113,"context_line":"            extra_params[label] \u003d cluster_template.labels.get(label)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_f6ebb6ae","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":48},"in_reply_to":"7a3c09a3_925bea2d","updated":"2017-01-19 02:47:02.000000000","message":"Patch set 5 did have k8s in the names but it was suggested to remove the prefix :)\nI guess there is argument for either way.","commit_id":"9727b6e818b03aef7ce8478c3e11d5e9a921dbba"}]}