)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"a9e3aeef87555197931b636dc28b85a0a524e49f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa31d9ce_73dc1975","line":19,"updated":"2017-02-16 20:23:14.000000000","message":"could you please add reference to the relevant blueprint/bug?","commit_id":"555b597c8988b9ec00fc6a44523650eaf1dce0e1"}],"magnum/drivers/k8s_coreos_v1/templates/fragments/enable-kubelet-master.yaml":[{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"a9e3aeef87555197931b636dc28b85a0a524e49f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      [Service]"},{"line_number":32,"context_line":"      Environment\u003dKUBELET_VERSION\u003d${KUBE_VERSION}"},{"line_number":33,"context_line":"      Environment\u003dKUBELET_ACI\u003d${HYPERKUBE_IMAGE_REPO}"},{"line_number":34,"context_line":"      Environment\u003d\"RKT_OPTS\u003d--uuid-file-save\u003d${uuid_file} \\"},{"line_number":35,"context_line":"        --volume dns,kind\u003dhost,source\u003d/etc/resolv.conf \\"},{"line_number":36,"context_line":"        --mount volume\u003ddns,target\u003d/etc/resolv.conf \\"},{"line_number":37,"context_line":"        --volume rkt,kind\u003dhost,source\u003d/opt/bin/host-rkt \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa31d9ce_a480058d","line":34,"updated":"2017-02-16 20:23:14.000000000","message":"since these changes seems to be RKT specific, can we do something like below:\n\nif [\"$CONTAINER_RUNTIME\" \u003d\u003d \"docker\"];then\n      ExecStart\u003d/usr/lib/coreos/kubelet-wrapper \\\n        --api-servers\u003dhttp://127.0.0.1:8080 \\\n        --address\u003d0.0.0.0 \\\n        --register-node\u003dtrue \\\n        --register-schedulable\u003dfalse \\\n        --allow-privileged\u003dtrue \\\n        --config\u003d/etc/kubernetes/manifests \\\n        --hostname-override\u003d${KUBE_NODE_IP} \\\n        --logtostderr\u003dtrue \\\n        --v\u003d0\nfi\n\nif [\"$CONTAINER_RUNTIME\" \u003d\u003d \"rkt\"];then\n      uuid_file\u003d\"/var/run/kubelet-pod.uuid\"\n      Environment\u003d\"RKT_OPTS\u003d--uuid-file-save\u003d${uuid_file} \\\n        --volume dns,kind\u003dhost,source\u003d/etc/resolv.conf \\\n        --mount volume\u003ddns,target\u003d/etc/resolv.conf \\\n        --volume rkt,kind\u003dhost,source\u003d/opt/bin/host-rkt \\\n        --mount volume\u003drkt,target\u003d/usr/bin/rkt \\\n        --volume var-lib-rkt,kind\u003dhost,source\u003d/var/lib/rkt \\\n        --mount volume\u003dvar-lib-rkt,target\u003d/var/lib/rkt \\\n        --volume stage,kind\u003dhost,source\u003d/tmp \\\n        --mount volume\u003dstage,target\u003d/tmp \\\n        --volume var-log,kind\u003dhost,source\u003d/var/log \\\n        --mount volume\u003dvar-log,target\u003d/var/log\"\n      ExecStartPre\u003d/usr/bin/mkdir -p /etc/kubernetes/manifests\n      ExecStartPre\u003d/usr/bin/mkdir -p /opt/cni/bin\n      ExecStartPre\u003d/usr/bin/mkdir -p /var/log/containers\n      ExecStartPre\u003d-/usr/bin/rkt rm --uuid-file\u003d${uuid_file}\n      ExecStart\u003d/usr/lib/coreos/kubelet-wrapper \\\n        --api-servers\u003dhttp://127.0.0.1:8080 \\\n        --cni-conf-dir\u003d/etc/kubernetes/cni/net.d \\\n        --network-plugin\u003dcni \\\n        --register-node\u003dtrue \\\n        --container-runtime\u003d${CONTAINER_RUNTIME}\n        --register-schedulable\u003dfalse \\\n        --allow-privileged\u003dtrue \\\n        --pod-manifest-path\u003d/etc/kubernetes/manifests \\\n        --hostname-override\u003d${KUBE_NODE_IP} \\\n        --logtostderr\u003dtrue \\\n        --v\u003d0\n      ExecStop\u003d-/usr/bin/rkt stop --uuid-file\u003d${uuid_file}\nfi","commit_id":"555b597c8988b9ec00fc6a44523650eaf1dce0e1"}],"magnum/drivers/k8s_coreos_v1/templates/kubemaster.yaml":[{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"24cdbdd9e672cb63285657a5ecdaf30683cc37c3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    type: string"},{"line_number":178,"context_line":"    description: \u003e"},{"line_number":179,"context_line":"      Container runtime to use with Kubernetes."},{"line_number":180,"context_line":"    default: \"docker\""},{"line_number":181,"context_line":"    constraints:"},{"line_number":182,"context_line":"      - allowed_values: [\"docker\"]"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"resources:"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_12eb97b1","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":34},"updated":"2017-02-21 22:10:58.000000000","message":"Not needed here since it\u0027s already handled in the parent template.\nGood practice to leave out to avoid masking error from parent.","commit_id":"2f56c5ece7ef36e10a021f071f2f0ba492b7a627"}],"magnum/drivers/k8s_coreos_v1/templates/kubeminion.yaml":[{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"24cdbdd9e672cb63285657a5ecdaf30683cc37c3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    type: string"},{"line_number":133,"context_line":"    description: \u003e"},{"line_number":134,"context_line":"      Container runtime to use with Kubernetes."},{"line_number":135,"context_line":"    default: \"docker\""},{"line_number":136,"context_line":"    constraints:"},{"line_number":137,"context_line":"      - allowed_values: [\"docker\"]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"resources:"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da36d5c6_92eea7b2","line":137,"range":{"start_line":135,"start_character":0,"end_line":137,"end_character":34},"updated":"2017-02-21 22:10:58.000000000","message":"Not needed here since it\u0027s already handled in the parent template.\nGood practice to leave out to avoid masking error from parent.","commit_id":"2f56c5ece7ef36e10a021f071f2f0ba492b7a627"}]}
