)]}'
{"doc/source/dev/kubernetes-load-balancer.rst":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4bfaa611bbbdbb0d48ac38800a084ec2e6b83525","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Steps for the users"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Cinder support needs to be enabled for this feature to work (--volume-driver cinder)."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"For the user, publishing the service endpoint externally involves the following"},{"line_number":94,"context_line":"2 steps:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_a23e85d7","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":85},"updated":"2017-04-04 09:36:49.000000000","message":"This feature requires the OpenStack cloud provider to be enabled. To do so, enable the cinder support (--volume-driver cinder).","commit_id":"adbcaec755319eafa615dc9126f98fe26cf34170"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"072780615ccebf5538c2bec03f68ea4d105caec8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Steps for the users"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This feature requires the OpenStack cloud provider to be enabled."},{"line_number":92,"context_line":"To do so, enable the cinder support (--volume-driver cinder)."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the user, publishing the service endpoint externally involves the following"},{"line_number":95,"context_line":"2 steps:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"bff0334d_2d4ffa34","line":92,"range":{"start_line":91,"start_character":0,"end_line":92,"end_character":61},"updated":"2017-04-10 05:08:10.000000000","message":"I guess this step is no long needed for the load balancer, but we probably want to mention that Magnum config needs to allow the trust-id to be used.  \nIf not, then the user will need to perform some manual steps to enable the load balancer.","commit_id":"c0787b4e94f68bd52088610666d1d17cfe4e53bf"}],"doc/source/userguide.rst":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8fe49cbc80b567a2f2662813636c76b7dbd8bfdd","unresolved":false,"context_lines":[{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"Following are some examples for using Cinder as persistent storage."},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"Using Cinder in Kubernetes"},{"line_number":2213,"context_line":"++++++++++++++++++++++++++"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"**NOTE:** This feature requires Kubernetes version 1.1.1 or above and"},{"line_number":2216,"context_line":"Docker version 1.8.3 or above.  The public Fedora image from Atomic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_89098696","side":"PARENT","line":2213,"range":{"start_line":2212,"start_character":16,"end_line":2213,"end_character":26},"updated":"2017-04-03 14:27:49.000000000","message":"what about doc changes in doc/source/dev/kubernetes-load-balancer.rst","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"853f548fb907ee7dd7ceda15abe08760480faecb","unresolved":false,"context_lines":[{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"Following are some examples for using Cinder as persistent storage."},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"Using Cinder in Kubernetes"},{"line_number":2213,"context_line":"++++++++++++++++++++++++++"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"**NOTE:** This feature requires Kubernetes version 1.1.1 or above and"},{"line_number":2216,"context_line":"Docker version 1.8.3 or above.  The public Fedora image from Atomic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_d4b5d9ce","side":"PARENT","line":2213,"range":{"start_line":2212,"start_character":16,"end_line":2213,"end_character":26},"in_reply_to":"dfeb2761_5f46907e","updated":"2017-04-03 21:00:55.000000000","message":"It\u0027s time to update and merge that doc into the user guide.  I have been holding off on doing that waiting for the trust id to work.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b099f076469ba82ff8a4337ff82dafcbba9f5bb5","unresolved":false,"context_lines":[{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"Following are some examples for using Cinder as persistent storage."},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"Using Cinder in Kubernetes"},{"line_number":2213,"context_line":"++++++++++++++++++++++++++"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"**NOTE:** This feature requires Kubernetes version 1.1.1 or above and"},{"line_number":2216,"context_line":"Docker version 1.8.3 or above.  The public Fedora image from Atomic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_5f46907e","side":"PARENT","line":2213,"range":{"start_line":2212,"start_character":16,"end_line":2213,"end_character":26},"in_reply_to":"dfeb2761_89098696","updated":"2017-04-03 15:25:17.000000000","message":"It can even be in another patch or here.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"295bd1cacdac953fc9fa172513dca28cc17fa58d","unresolved":false,"context_lines":[{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"Following are some examples for using Cinder as persistent storage."},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"Using Cinder in Kubernetes"},{"line_number":2213,"context_line":"++++++++++++++++++++++++++"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"**NOTE:** This feature requires Kubernetes version 1.1.1 or above and"},{"line_number":2216,"context_line":"Docker version 1.8.3 or above.  The public Fedora image from Atomic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_fdec352a","side":"PARENT","line":2213,"range":{"start_line":2212,"start_character":16,"end_line":2213,"end_character":26},"in_reply_to":"dfeb2761_d4b5d9ce","updated":"2017-04-04 07:13:42.000000000","message":"This task should definitely be another patch.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8e94fd519ce6fc563c45ba584a5037609c3b195e","unresolved":false,"context_lines":[{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"Following are some examples for using Cinder as persistent storage."},{"line_number":2211,"context_line":""},{"line_number":2212,"context_line":"Using Cinder in Kubernetes"},{"line_number":2213,"context_line":"++++++++++++++++++++++++++"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"**NOTE:** This feature requires Kubernetes version 1.1.1 or above and"},{"line_number":2216,"context_line":"Docker version 1.8.3 or above.  The public Fedora image from Atomic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_46058013","side":"PARENT","line":2213,"range":{"start_line":2212,"start_character":16,"end_line":2213,"end_character":26},"in_reply_to":"dfeb2761_fdec352a","updated":"2017-04-04 14:54:04.000000000","message":"+1 for another patch","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8fe49cbc80b567a2f2662813636c76b7dbd8bfdd","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (master)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z \"$KUBE_NODE_IP\" ]; then"},{"line_number":8,"context_line":"    # FIXME(yuanying): Set KUBE_NODE_IP correctly"},{"line_number":9,"context_line":"    KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"sed -i \u0027"},{"line_number":13,"context_line":"    /^KUBE_ALLOW_PRIV\u003d/ s/\u003d.*/\u003d\"--allow-privileged\u003d\u0027\"$KUBE_ALLOW_PRIV\"\u0027\"/"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_49a25e4d","side":"PARENT","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":2},"updated":"2017-04-03 14:27:49.000000000","message":"I think this is required for k8s-ironic, but not sure the new change would work.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8e94fd519ce6fc563c45ba584a5037609c3b195e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (master)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z \"$KUBE_NODE_IP\" ]; then"},{"line_number":8,"context_line":"    # FIXME(yuanying): Set KUBE_NODE_IP correctly"},{"line_number":9,"context_line":"    KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"sed -i \u0027"},{"line_number":13,"context_line":"    /^KUBE_ALLOW_PRIV\u003d/ s/\u003d.*/\u003d\"--allow-privileged\u003d\u0027\"$KUBE_ALLOW_PRIV\"\u0027\"/"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_26eefcb3","side":"PARENT","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":2},"in_reply_to":"dfeb2761_3acf5ab1","updated":"2017-04-04 14:54:04.000000000","message":"It should work, i commented as this change seemed not related to the patch. We can remove this.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b099f076469ba82ff8a4337ff82dafcbba9f5bb5","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"configuring kubernetes (master)\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z \"$KUBE_NODE_IP\" ]; then"},{"line_number":8,"context_line":"    # FIXME(yuanying): Set KUBE_NODE_IP correctly"},{"line_number":9,"context_line":"    KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"sed -i \u0027"},{"line_number":13,"context_line":"    /^KUBE_ALLOW_PRIV\u003d/ s/\u003d.*/\u003d\"--allow-privileged\u003d\u0027\"$KUBE_ALLOW_PRIV\"\u0027\"/"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_3acf5ab1","side":"PARENT","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":2},"in_reply_to":"dfeb2761_49a25e4d","updated":"2017-04-03 15:25:17.000000000","message":"k8s-ironic breaks when using the hostname? I don\u0027t see why it will break.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8fe49cbc80b567a2f2662813636c76b7dbd8bfdd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    /^KUBE_ADMISSION_CONTROL\u003d/ s/\u003d.*/\u003d\"\u0027\"${KUBE_ADMISSION_CONTROL}\"\u0027\"/"},{"line_number":40,"context_line":"\u0027 /etc/kubernetes/apiserver"},{"line_number":41,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"#Uncomment the following line to disable Load Balancer feature"},{"line_number":43,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":44,"context_line":"#Uncomment the following line to enable Load Balancer feature"},{"line_number":45,"context_line":"#KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_445a452a","side":"PARENT","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":62},"updated":"2017-04-03 14:27:49.000000000","message":"The removed line are corresponding to loadbalancer feature. and added line for cinder driver feature. In master node i don\u0027t think we need changes related to cinder driver.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"bc97ea29d578b3e9997eba1b25ff85b089c3c034","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    /^KUBE_ADMISSION_CONTROL\u003d/ s/\u003d.*/\u003d\"\u0027\"${KUBE_ADMISSION_CONTROL}\"\u0027\"/"},{"line_number":40,"context_line":"\u0027 /etc/kubernetes/apiserver"},{"line_number":41,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"#Uncomment the following line to disable Load Balancer feature"},{"line_number":43,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":44,"context_line":"#Uncomment the following line to enable Load Balancer feature"},{"line_number":45,"context_line":"#KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_1d78e68d","side":"PARENT","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":62},"in_reply_to":"dfeb2761_26a6fc54","updated":"2017-04-04 15:15:15.000000000","message":"We need to tell magnum to pass the trust id if we want to enable lb. See [1]. We need to solve it in another way, in another patch.\n\n[1] https://review.openstack.org/#/c/445404/5/magnum/drivers/heat/template_def.py","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b099f076469ba82ff8a4337ff82dafcbba9f5bb5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    /^KUBE_ADMISSION_CONTROL\u003d/ s/\u003d.*/\u003d\"\u0027\"${KUBE_ADMISSION_CONTROL}\"\u0027\"/"},{"line_number":40,"context_line":"\u0027 /etc/kubernetes/apiserver"},{"line_number":41,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"#Uncomment the following line to disable Load Balancer feature"},{"line_number":43,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":44,"context_line":"#Uncomment the following line to enable Load Balancer feature"},{"line_number":45,"context_line":"#KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_5a0e9e8d","side":"PARENT","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":62},"in_reply_to":"dfeb2761_445a452a","updated":"2017-04-03 15:25:17.000000000","message":"k8s 1.5.x support authentication using the trust user. We don\u0027t need this anymore.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8e94fd519ce6fc563c45ba584a5037609c3b195e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    /^KUBE_ADMISSION_CONTROL\u003d/ s/\u003d.*/\u003d\"\u0027\"${KUBE_ADMISSION_CONTROL}\"\u0027\"/"},{"line_number":40,"context_line":"\u0027 /etc/kubernetes/apiserver"},{"line_number":41,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"#Uncomment the following line to disable Load Balancer feature"},{"line_number":43,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":44,"context_line":"#Uncomment the following line to enable Load Balancer feature"},{"line_number":45,"context_line":"#KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_26a6fc54","side":"PARENT","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":62},"in_reply_to":"dfeb2761_5a0e9e8d","updated":"2017-04-04 14:54:04.000000000","message":"Sorry i putted comment at wrong place.\nMy intention was why for adding configuration for loadbalancer feature by default we are using \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" driver(line 40,56).","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8fe49cbc80b567a2f2662813636c76b7dbd8bfdd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":56,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":57,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"#Uncomment the following line to enable Kubernetes Load Balancer feature"},{"line_number":59,"context_line":"#KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":60,"context_line":"_EOC_"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_84796d94","side":"PARENT","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":72},"updated":"2017-04-03 14:27:49.000000000","message":"ditto","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b099f076469ba82ff8a4337ff82dafcbba9f5bb5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":56,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":57,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"#Uncomment the following line to enable Kubernetes Load Balancer feature"},{"line_number":59,"context_line":"#KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":60,"context_line":"_EOC_"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_da218efd","side":"PARENT","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":72},"in_reply_to":"dfeb2761_84796d94","updated":"2017-04-03 15:25:17.000000000","message":"k8s 1.5.x support authentication using the trust user. We don\u0027t need this anymore.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8e94fd519ce6fc563c45ba584a5037609c3b195e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":56,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":57,"context_line":"cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"#Uncomment the following line to enable Kubernetes Load Balancer feature"},{"line_number":59,"context_line":"#KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":60,"context_line":"_EOC_"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_064e5896","side":"PARENT","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":72},"in_reply_to":"dfeb2761_da218efd","updated":"2017-04-04 14:54:04.000000000","message":"ditto","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8fe49cbc80b567a2f2662813636c76b7dbd8bfdd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":54,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":57,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":59,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_e4da7915","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":33},"updated":"2017-04-03 14:27:49.000000000","message":"Ironic master template should also handle this new variable if changing common fragments.","commit_id":"536ee9b230b20a35310a07b98d9b56fa123e425a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8e94fd519ce6fc563c45ba584a5037609c3b195e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":54,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":57,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":59,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_c611905f","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":33},"in_reply_to":"dfeb2761_3a863add","updated":"2017-04-04 14:54:04.000000000","message":"I meant, we should set $VOLUME_DRIVER to something in heat-params in fedora ironic master heat template as well.","commit_id":"536ee9b230b20a35310a07b98d9b56fa123e425a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b099f076469ba82ff8a4337ff82dafcbba9f5bb5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":54,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":57,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":59,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfeb2761_3a863add","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":33},"in_reply_to":"dfeb2761_e4da7915","updated":"2017-04-03 15:25:17.000000000","message":"The check must not happen here. We need to prohibit using cinder with ironic in the the python code base not here.\n\nOr in the heat templates","commit_id":"536ee9b230b20a35310a07b98d9b56fa123e425a"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"00c757a4b01316e77c0041ddc2b4181fbc04e7d6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":38,"context_line":"_EOC_"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":41,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":43,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dfeb2761_ff1ad2c9","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":33},"updated":"2017-04-04 17:56:09.000000000","message":"My suggestion is to always run kube_apiserver with the plugin enabled, without having to specify cinder volume driver.  This will allow LB to just work, and cinder support will be ready to go.","commit_id":"f777fc70841ccb545e315d8191c481d0d6dab635"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"38d16d02d147992ce17cbb2340d7d5f63e525877","unresolved":false,"context_lines":[{"line_number":37,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":38,"context_line":"_EOC_"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":41,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":43,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bff0334d_7c21a44d","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":33},"in_reply_to":"dfeb2761_02819ac3","updated":"2017-04-05 22:43:08.000000000","message":"I guess a clearer way to state the issue is that the k8s plugin is needed for multiple functionalities, not just for the cinder volume driver.  Looking ahead, there will likely be more functionalities added in the plugin, so it seems a k8s cluster will need the plugin enabled to be usable.  So instead of tying the plugin with the volume driver as it is now, we should think of a more general approach.  \nEnabling the trust id via the config is a reasonable control for the operator.\nThis parameter indicates whether the trust id is available or not, so we should use this parameter to select whether to enable the k8s plugin in the script.","commit_id":"f777fc70841ccb545e315d8191c481d0d6dab635"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5cf93c03c9df0f127b34c54b934b353c1a68e1b7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS\""},{"line_number":38,"context_line":"_EOC_"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":41,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/apiserver"},{"line_number":42,"context_line":"KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":43,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dfeb2761_02819ac3","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":33},"in_reply_to":"dfeb2761_ff1ad2c9","updated":"2017-04-04 18:48:52.000000000","message":"Since [1], the trust ID is not always present in the vms. I\u0027m not sure what we can do. Maybe we need to change [1] OR have a mode in the config [always put the trustID, only when it is needed (hard to define), never]. I\u0027m in favor of the boolean, pass the trustID or not. Thoughts?\n\n[1] https://review.openstack.org/#/c/437048/","commit_id":"f777fc70841ccb545e315d8191c481d0d6dab635"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"00c757a4b01316e77c0041ddc2b4181fbc04e7d6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    /^KUBE_CONTROLLER_MANAGER_ARGS\u003d/ s#\\(KUBE_CONTROLLER_MANAGER_ARGS\\).*#\\1\u003d\"\u0027\"${KUBE_CONTROLLER_MANAGER_ARGS}\"\u0027\"#"},{"line_number":54,"context_line":"\u0027 /etc/kubernetes/controller-manager"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":57,"context_line":"    cat \u003c\u003c _EOC_ \u003e\u003e /etc/kubernetes/controller-manager"},{"line_number":58,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"\\$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":59,"context_line":"_EOC_"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dfeb2761_1fc9f624","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":33},"updated":"2017-04-04 17:56:09.000000000","message":"ditto","commit_id":"f777fc70841ccb545e315d8191c481d0d6dab635"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"4ced656ca381685471a72f246ff661f65f317578","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003d${ADMISSION_CONTROL_LIST}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":30,"context_line":"    KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"bff0334d_9c04687d","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":32},"updated":"2017-04-05 22:55:47.000000000","message":"How about checking for a non-empty TRUSTEE_USER_ID to enable the plugin?\nThe code in template_definition already ensures that if cinder volume is specified, then TRUSTEE_USER_ID is provided, so we are covered in this use case.\nThis would allow more general use of the plugin for other features, not just cinder volume.","commit_id":"59b7a6b525c14fae02fb4450355b528cece2f566"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4989a7e926adf9fb33b9e25aaa6587e567c12342","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003d${ADMISSION_CONTROL_LIST}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":30,"context_line":"    KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"bff0334d_b603bc42","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":32},"in_reply_to":"bff0334d_9c04687d","updated":"2017-04-06 08:36:28.000000000","message":"The problem comes from here [1] actually. It doesn\u0027t matter what we do in this script.\n[1] https://review.openstack.org/#/c/445404/13/magnum/drivers/heat/template_def.py","commit_id":"59b7a6b525c14fae02fb4450355b528cece2f566"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"6a1f716012a5b592e0b1f6d0f699dbf46c8b901f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003d${ADMISSION_CONTROL_LIST}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d\u003d \"cinder\" ]; then"},{"line_number":30,"context_line":"    KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"bff0334d_cca1f7ab","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":32},"in_reply_to":"bff0334d_b603bc42","updated":"2017-04-06 20:11:18.000000000","message":"The associated change needed there in template_def is to always pass the trust_id for a k8s cluster, if the trust is available.  For other COE, we can enforce a tighter rule on passing the trust_id.","commit_id":"59b7a6b525c14fae02fb4450355b528cece2f566"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a82e90ea9be26572ccd70a202cddbd6d8d958373","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003d${ADMISSION_CONTROL_LIST}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ -z \"$TRUST_ID\" ]; then"},{"line_number":30,"context_line":"    KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"bff0334d_1a0ff189","line":29,"range":{"start_line":29,"start_character":5,"end_line":29,"end_character":7},"updated":"2017-04-07 12:06:54.000000000","message":"You mean -n ? -z : string is null, that is, has zero length","commit_id":"faf73dd87112961a5b4ab77ca9607bb1b89659aa"},{"author":{"_account_id":20031,"name":"Mathieu Velten","email":"mathieu.velten@cern.ch","username":"MatMaul"},"change_message_id":"25b098f067846fb7f474e970c83714b3844e437e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003d${ADMISSION_CONTROL_LIST}\""},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ -z \"$TRUST_ID\" ]; then"},{"line_number":30,"context_line":"    KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"bff0334d_3a1e3570","line":29,"range":{"start_line":29,"start_character":5,"end_line":29,"end_character":7},"in_reply_to":"bff0334d_1a0ff189","updated":"2017-04-07 12:11:39.000000000","message":"Indeed... I hate bash","commit_id":"faf73dd87112961a5b4ab77ca9607bb1b89659aa"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a82e90ea9be26572ccd70a202cddbd6d8d958373","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"--service-account-private-key-file\u003d/srv/kubernetes/server.key --root-ca-file\u003d/srv/kubernetes/ca.crt\""},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"if [ -z \"$TRUST_ID\" ]; then"},{"line_number":51,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-config\u003d/etc/sysconfig/kube_openstack_config --cloud-provider\u003dopenstack\""},{"line_number":52,"context_line":"fi"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"bff0334d_5a7a19f1","line":50,"range":{"start_line":50,"start_character":5,"end_line":50,"end_character":7},"updated":"2017-04-07 12:06:54.000000000","message":"same","commit_id":"faf73dd87112961a5b4ab77ca9607bb1b89659aa"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"20e0f03dd59fd6f45fd441c45df90acbfdf67df9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# The hostname of the node is set to be the Nova name of the instance, and"},{"line_number":48,"context_line":"# the option --hostname-override for kubelet uses the hostname to register the node."},{"line_number":49,"context_line":"# Using any other name will break the load balancer and cinder volume features."},{"line_number":50,"context_line":"HOSTNAME_OVERRIDE\u003d$(hostname --short | sed \u0027s/\\.novalocal//\u0027)"},{"line_number":51,"context_line":"KUBELET_ARGS\u003d\"--config\u003d/etc/kubernetes/manifests --cadvisor-port\u003d4194 ${KUBE_CONFIG} --hostname-override\u003d${HOSTNAME_OVERRIDE}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d \"cinder\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffe62b97_339eb454","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":17},"updated":"2017-03-31 12:35:29.000000000","message":"For consistency, this is ok.","commit_id":"919225dd3e771933dc9d033e6434715faff9ecec"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"20e0f03dd59fd6f45fd441c45df90acbfdf67df9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"HOSTNAME_OVERRIDE\u003d$(hostname --short | sed \u0027s/\\.novalocal//\u0027)"},{"line_number":51,"context_line":"KUBELET_ARGS\u003d\"--config\u003d/etc/kubernetes/manifests --cadvisor-port\u003d4194 ${KUBE_CONFIG} --hostname-override\u003d${HOSTNAME_OVERRIDE}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d \"cinder\" ]; then"},{"line_number":54,"context_line":"    KUBELET_ARGS\u003d\"$KUBELET_ARGS --cloud-provider\u003dopenstack --cloud-config\u003d/etc/sysconfig/kube_openstack_config\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if [ ! -f /usr/bin/udevadm ]; then"},{"line_number":57,"context_line":"        ln -s /sbin/udevadm /usr/bin/udevadm"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"fi"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":63,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --pod-infra-container-image\u003d${INSECURE_REGISTRY_URL}/google_containers/pause\\:0.8.0\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffe62b97_537c981f","line":60,"range":{"start_line":53,"start_character":0,"end_line":60,"end_character":2},"updated":"2017-03-31 12:35:29.000000000","message":"I would prefer to keep this block where it was to have cleaner diff.","commit_id":"919225dd3e771933dc9d033e6434715faff9ecec"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2fc71a4b9a3e8cb28a1d7f3878b3a63c96b3387f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"HOSTNAME_OVERRIDE\u003d$(hostname --short | sed \u0027s/\\.novalocal//\u0027)"},{"line_number":51,"context_line":"KUBELET_ARGS\u003d\"--config\u003d/etc/kubernetes/manifests --cadvisor-port\u003d4194 ${KUBE_CONFIG} --hostname-override\u003d${HOSTNAME_OVERRIDE}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d \"cinder\" ]; then"},{"line_number":54,"context_line":"    KUBELET_ARGS\u003d\"$KUBELET_ARGS --cloud-provider\u003dopenstack --cloud-config\u003d/etc/sysconfig/kube_openstack_config\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if [ ! -f /usr/bin/udevadm ]; then"},{"line_number":57,"context_line":"        ln -s /sbin/udevadm /usr/bin/udevadm"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"fi"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":63,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --pod-infra-container-image\u003d${INSECURE_REGISTRY_URL}/google_containers/pause\\:0.8.0\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"dfeb2761_e0086029","line":60,"range":{"start_line":53,"start_character":0,"end_line":60,"end_character":2},"in_reply_to":"dfeb2761_bdbcc369","updated":"2017-03-31 12:49:02.000000000","message":"OK","commit_id":"919225dd3e771933dc9d033e6434715faff9ecec"},{"author":{"_account_id":20031,"name":"Mathieu Velten","email":"mathieu.velten@cern.ch","username":"MatMaul"},"change_message_id":"b9470f05845426e80e359bbb107c8cc80ad0ca50","unresolved":false,"context_lines":[{"line_number":50,"context_line":"HOSTNAME_OVERRIDE\u003d$(hostname --short | sed \u0027s/\\.novalocal//\u0027)"},{"line_number":51,"context_line":"KUBELET_ARGS\u003d\"--config\u003d/etc/kubernetes/manifests --cadvisor-port\u003d4194 ${KUBE_CONFIG} --hostname-override\u003d${HOSTNAME_OVERRIDE}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d \"cinder\" ]; then"},{"line_number":54,"context_line":"    KUBELET_ARGS\u003d\"$KUBELET_ARGS --cloud-provider\u003dopenstack --cloud-config\u003d/etc/sysconfig/kube_openstack_config\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if [ ! -f /usr/bin/udevadm ]; then"},{"line_number":57,"context_line":"        ln -s /sbin/udevadm /usr/bin/udevadm"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"fi"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":63,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --pod-infra-container-image\u003d${INSECURE_REGISTRY_URL}/google_containers/pause\\:0.8.0\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"dfeb2761_bdbcc369","line":60,"range":{"start_line":53,"start_character":0,"end_line":60,"end_character":2},"in_reply_to":"ffe62b97_537c981f","updated":"2017-03-31 12:45:02.000000000","message":"I moved the block because I need it before the sed using KUBELET_ARGS.","commit_id":"919225dd3e771933dc9d033e6434715faff9ecec"},{"author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"change_message_id":"00c757a4b01316e77c0041ddc2b4181fbc04e7d6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"HOSTNAME_OVERRIDE\u003d$(hostname --short | sed \u0027s/\\.novalocal//\u0027)"},{"line_number":51,"context_line":"KUBELET_ARGS\u003d\"--config\u003d/etc/kubernetes/manifests --cadvisor-port\u003d4194 ${KUBE_CONFIG} --hostname-override\u003d${HOSTNAME_OVERRIDE}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ \"$VOLUME_DRIVER\" \u003d \"cinder\" ]; then"},{"line_number":54,"context_line":"    KUBELET_ARGS\u003d\"$KUBELET_ARGS --cloud-provider\u003dopenstack --cloud-config\u003d/etc/sysconfig/kube_openstack_config\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if [ ! -f /usr/bin/udevadm ]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dfeb2761_3ff83a47","line":53,"range":{"start_line":53,"start_character":6,"end_line":53,"end_character":32},"updated":"2017-04-04 17:56:09.000000000","message":"Similar suggestion as for kube_apiserver: although this is not required for LB, I don\u0027t see a reason for not just enabling the plugin since we are running in an OpenStack cloud anyway.","commit_id":"f777fc70841ccb545e315d8191c481d0d6dab635"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a82e90ea9be26572ccd70a202cddbd6d8d958373","unresolved":false,"context_lines":[{"line_number":50,"context_line":"HOSTNAME_OVERRIDE\u003d$(hostname --short | sed \u0027s/\\.novalocal//\u0027)"},{"line_number":51,"context_line":"KUBELET_ARGS\u003d\"--config\u003d/etc/kubernetes/manifests --cadvisor-port\u003d4194 ${KUBE_CONFIG} --hostname-override\u003d${HOSTNAME_OVERRIDE}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [ -z \"$TRUST_ID\" ]; then"},{"line_number":54,"context_line":"    KUBELET_ARGS\u003d\"$KUBELET_ARGS --cloud-provider\u003dopenstack --cloud-config\u003d/etc/sysconfig/kube_openstack_config\""},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"bff0334d_3a663553","line":53,"range":{"start_line":53,"start_character":5,"end_line":53,"end_character":7},"updated":"2017-04-07 12:06:54.000000000","message":"same","commit_id":"faf73dd87112961a5b4ab77ca9607bb1b89659aa"}],"magnum/drivers/heat/template_def.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8fe49cbc80b567a2f2662813636c76b7dbd8bfdd","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        extra_params[\u0027trustee_password\u0027] \u003d cluster.trustee_password"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Only pass trust ID into the template when it is needed."},{"line_number":249,"context_line":"        if (cluster_template.volume_driver \u003d\u003d \u0027rexray\u0027 or"},{"line_number":250,"context_line":"            cluster_template.volume_driver \u003d\u003d \u0027cinder\u0027 or"},{"line_number":251,"context_line":"                cluster_template.registry_enabled):"},{"line_number":252,"context_line":"            if CONF.trust.cluster_user_trust:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_b376fda3","line":249,"range":{"start_line":249,"start_character":12,"end_line":249,"end_character":54},"updated":"2017-04-03 14:27:49.000000000","message":"cluster_template.volume_driver in (\u0027rexray\u0027, \u0027cinder\u0027) would be more cleaner","commit_id":"536ee9b230b20a35310a07b98d9b56fa123e425a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b099f076469ba82ff8a4337ff82dafcbba9f5bb5","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        extra_params[\u0027trustee_password\u0027] \u003d cluster.trustee_password"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Only pass trust ID into the template when it is needed."},{"line_number":249,"context_line":"        if (cluster_template.volume_driver \u003d\u003d \u0027rexray\u0027 or"},{"line_number":250,"context_line":"            cluster_template.volume_driver \u003d\u003d \u0027cinder\u0027 or"},{"line_number":251,"context_line":"                cluster_template.registry_enabled):"},{"line_number":252,"context_line":"            if CONF.trust.cluster_user_trust:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_da4f4ebb","line":249,"range":{"start_line":249,"start_character":12,"end_line":249,"end_character":54},"in_reply_to":"dfeb2761_b376fda3","updated":"2017-04-03 15:25:17.000000000","message":"+1","commit_id":"536ee9b230b20a35310a07b98d9b56fa123e425a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4e7be97c680e9f981c458577e6284481382e109c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        extra_params[\u0027trustee_password\u0027] \u003d cluster.trustee_password"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Only pass trust ID into the template when it is needed."},{"line_number":249,"context_line":"        if (cluster_template.volume_driver in (\u0027rexray\u0027, \u0027cinder\u0027) or"},{"line_number":250,"context_line":"                cluster_template.registry_enabled):"},{"line_number":251,"context_line":"            if CONF.trust.cluster_user_trust:"},{"line_number":252,"context_line":"                extra_params[\u0027trust_id\u0027] \u003d cluster.trust_id"},{"line_number":253,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bff0334d_39d1b1ce","line":250,"range":{"start_line":249,"start_character":8,"end_line":250,"end_character":51},"updated":"2017-04-07 07:00:10.000000000","message":"Mathieu, let\u0027s pass the trust_id without these checks.","commit_id":"59b7a6b525c14fae02fb4450355b528cece2f566"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubeminion.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"20e0f03dd59fd6f45fd441c45df90acbfdf67df9","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            $NO_PROXY: {get_param: no_proxy}"},{"line_number":256,"context_line":"            $KUBE_VERSION: {get_param: kube_version}"},{"line_number":257,"context_line":"            $WAIT_CURL: {get_attr: [minion_wait_handle, curl_cli]}"},{"line_number":258,"context_line":"            $TRUSTEE_DOMAIN_ID: {get_param: trustee_domain_id}"},{"line_number":259,"context_line":"            $TRUSTEE_USER_ID: {get_param: trustee_user_id}"},{"line_number":260,"context_line":"            $TRUSTEE_USERNAME: {get_param: trustee_username}"},{"line_number":261,"context_line":"            $TRUSTEE_PASSWORD: {get_param: trustee_password}"},{"line_number":262,"context_line":"            $TRUST_ID: {get_param: trust_id}"},{"line_number":263,"context_line":"            $AUTH_URL: {get_param: auth_url}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_93fea069","side":"PARENT","line":260,"range":{"start_line":258,"start_character":12,"end_line":260,"end_character":60},"updated":"2017-03-31 12:35:29.000000000","message":"Do we really need to remove these two?","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2fc71a4b9a3e8cb28a1d7f3878b3a63c96b3387f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            $NO_PROXY: {get_param: no_proxy}"},{"line_number":256,"context_line":"            $KUBE_VERSION: {get_param: kube_version}"},{"line_number":257,"context_line":"            $WAIT_CURL: {get_attr: [minion_wait_handle, curl_cli]}"},{"line_number":258,"context_line":"            $TRUSTEE_DOMAIN_ID: {get_param: trustee_domain_id}"},{"line_number":259,"context_line":"            $TRUSTEE_USER_ID: {get_param: trustee_user_id}"},{"line_number":260,"context_line":"            $TRUSTEE_USERNAME: {get_param: trustee_username}"},{"line_number":261,"context_line":"            $TRUSTEE_PASSWORD: {get_param: trustee_password}"},{"line_number":262,"context_line":"            $TRUST_ID: {get_param: trust_id}"},{"line_number":263,"context_line":"            $AUTH_URL: {get_param: auth_url}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_601c506a","side":"PARENT","line":260,"range":{"start_line":258,"start_character":12,"end_line":260,"end_character":60},"in_reply_to":"dfeb2761_5d80178c","updated":"2017-03-31 12:49:02.000000000","message":"ok, if they are not used anywhere delete them","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"},{"author":{"_account_id":20031,"name":"Mathieu Velten","email":"mathieu.velten@cern.ch","username":"MatMaul"},"change_message_id":"b9470f05845426e80e359bbb107c8cc80ad0ca50","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            $NO_PROXY: {get_param: no_proxy}"},{"line_number":256,"context_line":"            $KUBE_VERSION: {get_param: kube_version}"},{"line_number":257,"context_line":"            $WAIT_CURL: {get_attr: [minion_wait_handle, curl_cli]}"},{"line_number":258,"context_line":"            $TRUSTEE_DOMAIN_ID: {get_param: trustee_domain_id}"},{"line_number":259,"context_line":"            $TRUSTEE_USER_ID: {get_param: trustee_user_id}"},{"line_number":260,"context_line":"            $TRUSTEE_USERNAME: {get_param: trustee_username}"},{"line_number":261,"context_line":"            $TRUSTEE_PASSWORD: {get_param: trustee_password}"},{"line_number":262,"context_line":"            $TRUST_ID: {get_param: trust_id}"},{"line_number":263,"context_line":"            $AUTH_URL: {get_param: auth_url}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_5d80178c","side":"PARENT","line":260,"range":{"start_line":258,"start_character":12,"end_line":260,"end_character":60},"in_reply_to":"ffe62b97_93fea069","updated":"2017-03-31 12:45:02.000000000","message":"We can keep them, but there are unused. the domain is useless if we use the user id instead of the user name.","commit_id":"61a63ce0eab973d45abdb9eb49dd1bd1bc80b59d"}]}
