)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/configure-etcd.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f0d145a0212a91de7a5212d7113309b53c2fa617","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f201791_fc67e124","line":1,"updated":"2017-06-21 11:30:47.000000000","message":"We also need to create the directory and pass it to etcd\u0027s configuration.","commit_id":"5168d09b25698fddca014f8f167bfa7c88b61829"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"ab4c986969fdcff56af891509c8ccb1befb7cb4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f201791_c543583e","line":1,"in_reply_to":"5f201791_fc67e124","updated":"2017-06-28 14:14:15.000000000","message":"You mean creating /var/lib/etcd? If we stick to this no extra config is needed right?","commit_id":"5168d09b25698fddca014f8f167bfa7c88b61829"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f0d145a0212a91de7a5212d7113309b53c2fa617","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    device_path\u003d/dev/disk/by-id/${device_name}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    mkfs.xfs -f ${device_path}"},{"line_number":27,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":28,"context_line":"    mount -a"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f201791_9cb10d93","line":28,"range":{"start_line":26,"start_character":4,"end_line":28,"end_character":12},"updated":"2017-06-21 11:30:47.000000000","message":"I think we need to check if the volume is already formatted.\n\nMaybe it is and has data already.\n\nWe can do this in a subsequent step, though.","commit_id":"5168d09b25698fddca014f8f167bfa7c88b61829"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"ab4c986969fdcff56af891509c8ccb1befb7cb4b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    device_path\u003d/dev/disk/by-id/${device_name}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    mkfs.xfs -f ${device_path}"},{"line_number":27,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":28,"context_line":"    mount -a"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f201791_857b208a","line":28,"range":{"start_line":26,"start_character":4,"end_line":28,"end_character":12},"in_reply_to":"5f201791_9cb10d93","updated":"2017-06-28 14:14:15.000000000","message":"Done","commit_id":"5168d09b25698fddca014f8f167bfa7c88b61829"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8782d701a478d77957c20672430886858d1a7744","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    mkdir -p /var/lib/etcd"},{"line_number":30,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":31,"context_line":"    mount -a"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"if [ -z \"$KUBE_NODE_IP\" ]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_afdca218","line":32,"updated":"2017-06-29 11:19:32.000000000","message":"We need to set directory permissions","commit_id":"a98c20d46de046187b3542ed370359e7d9ab3282"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"179fdbb8b7a3c7da66e9602ce1eb85d224182505","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    mkdir -p /var/lib/etcd"},{"line_number":30,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":31,"context_line":"    mount -a"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"if [ -z \"$KUBE_NODE_IP\" ]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_af61423c","line":32,"in_reply_to":"3f1d235d_afdca218","updated":"2017-06-29 11:26:09.000000000","message":"chown -R etcd:etcd /var/lib/etcd","commit_id":"a98c20d46de046187b3542ed370359e7d9ab3282"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"41fa198cc7c50ec71f3ccd7b51192d55b766df03","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        mkfs.xfs -f ${device_path}"},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"    mkdir -p /var/lib/etcd"},{"line_number":30,"context_line":"    chown -R etcd.etcd /var/lib/etcd"},{"line_number":31,"context_line":"    chmod 755 /var/lib/etcd"},{"line_number":32,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":33,"context_line":"    mount -a"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_299bce72","line":31,"range":{"start_line":30,"start_character":4,"end_line":31,"end_character":27},"updated":"2017-06-30 09:01:39.000000000","message":"We need those after mount","commit_id":"147be225b79a643c55dde3e548da533778a141e6"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"18d51d41966508022f140a6700d15cf999f070cd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"    mkdir -p /var/lib/etcd"},{"line_number":30,"context_line":"    chown -R etcd.etcd /var/lib/etcd"},{"line_number":31,"context_line":"    chmod 755 /var/lib/etcd"},{"line_number":32,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":33,"context_line":"    mount -a"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_eac84875","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":27},"updated":"2017-06-29 11:53:53.000000000","message":"Why do we need this?","commit_id":"147be225b79a643c55dde3e548da533778a141e6"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"eb1a62f8501df169de183c616437f6d7c29024fa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"    mkdir -p /var/lib/etcd"},{"line_number":30,"context_line":"    chown -R etcd.etcd /var/lib/etcd"},{"line_number":31,"context_line":"    chmod 755 /var/lib/etcd"},{"line_number":32,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":33,"context_line":"    mount -a"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_257d511c","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":27},"in_reply_to":"3f1d235d_2a7d201c","updated":"2017-06-29 12:29:46.000000000","message":"ok, 755 seems the default in the package. Doesn\u0027t make sense to me. But we must keep the same behavior. So it is fine. Thanks\n\nhttp://pkgs.fedoraproject.org/cgit/rpms/etcd.git/tree/etcd.spec#n327","commit_id":"147be225b79a643c55dde3e548da533778a141e6"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"b950b908ae11b32252f6b40cc1432b11bd55532b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"    mkdir -p /var/lib/etcd"},{"line_number":30,"context_line":"    chown -R etcd.etcd /var/lib/etcd"},{"line_number":31,"context_line":"    chmod 755 /var/lib/etcd"},{"line_number":32,"context_line":"    echo \"${device_path} /var/lib/etcd xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":33,"context_line":"    mount -a"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3f1d235d_2a7d201c","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":27},"in_reply_to":"3f1d235d_eac84875","updated":"2017-06-29 12:26:32.000000000","message":"I was making sure we set the same permissions as i saw in the existing deployments. It\u0027s probably there already though. Should i remove?","commit_id":"147be225b79a643c55dde3e548da533778a141e6"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"55f513bc85f4c376c15b0b72729821c427e58cd6","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ -n \"$ETCD_VOLUME_SIZE\" ] \u0026\u0026 [ \"$ETCD_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    attempts\u003d60"},{"line_number":8,"context_line":"    while [ ${attempts} -gt 0 ]; do"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3f1d235d_623e068c","line":5,"updated":"2017-07-05 11:57:50.000000000","message":"I think we are ok if we don\u0027t pass ETCD_VOLUME_SIZE since we have this check.\n\nWhat do you think yatin? Mark?","commit_id":"2875c97bff9fe46a2f56f12adff28d7c3e0c2cec"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cccba91d6196ae2d891c97a502f36fb012d9ba85","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ -n \"$ETCD_VOLUME_SIZE\" ] \u0026\u0026 [ \"$ETCD_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    attempts\u003d60"},{"line_number":8,"context_line":"    while [ ${attempts} -gt 0 ]; do"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3f1d235d_a51e65b8","line":5,"in_reply_to":"3f1d235d_05ad199a","updated":"2017-07-05 14:05:19.000000000","message":"I think it will be fine.","commit_id":"2875c97bff9fe46a2f56f12adff28d7c3e0c2cec"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2ed43caf2e5298131022a2a1a2ecb78e79ede666","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ -n \"$ETCD_VOLUME_SIZE\" ] \u0026\u0026 [ \"$ETCD_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    attempts\u003d60"},{"line_number":8,"context_line":"    while [ ${attempts} -gt 0 ]; do"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3f1d235d_05ad199a","line":5,"in_reply_to":"3f1d235d_623e068c","updated":"2017-07-05 13:51:54.000000000","message":"hmm its OK","commit_id":"2875c97bff9fe46a2f56f12adff28d7c3e0c2cec"}]}