)]}'
{"magnum/api/controllers/v1/cluster_actions.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"49c876a3864bf7435c05b53c3b9bedba00c971ef","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            nodegroup)"},{"line_number":127,"context_line":"        return ClusterID(cluster.uuid)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @base.Controller.api_version(\"1.7\")"},{"line_number":130,"context_line":"    @expose.expose(None, types.uuid_or_name,"},{"line_number":131,"context_line":"                   body\u003dClusterUpgradeRequest, status_code\u003d202)"},{"line_number":132,"context_line":"    def upgrade(self, cluster_ident, cluster_upgrade_req):"}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_a031ccee","line":129,"updated":"2019-06-06 20:12:15.000000000","message":"detail, but let\u0027s do 1.8?","commit_id":"3d25c9ed8fb153250f517d34f5eabb0af76b4270"}],"magnum/common/policies/cluster.py":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"8ddb2498a62a6c8e1ada69ed493ebf4cfd4d295c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        operations\u003d["},{"line_number":159,"context_line":"            {"},{"line_number":160,"context_line":"                \u0027path\u0027: \u0027/v1/clusters/{cluster_ident}/actions/upgrade\u0027,"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027PATCH\u0027"},{"line_number":162,"context_line":"            }"},{"line_number":163,"context_line":"        ]"},{"line_number":164,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":18,"id":"bfb3d3c7_07f789f7","line":161,"range":{"start_line":161,"start_character":29,"end_line":161,"end_character":30},"updated":"2019-05-23 09:13:25.000000000","message":"PATCH or POST?","commit_id":"8c94dd8c87ce5ffcd7b07590059ef2ffd23feee9"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"46b6fea262fbb729603f8054d7eb1bed986cbacb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        operations\u003d["},{"line_number":159,"context_line":"            {"},{"line_number":160,"context_line":"                \u0027path\u0027: \u0027/v1/clusters/{cluster_ident}/actions/upgrade\u0027,"},{"line_number":161,"context_line":"                \u0027method\u0027: \u0027PATCH\u0027"},{"line_number":162,"context_line":"            }"},{"line_number":163,"context_line":"        ]"},{"line_number":164,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":18,"id":"bfb3d3c7_4209efda","line":161,"range":{"start_line":161,"start_character":29,"end_line":161,"end_character":30},"in_reply_to":"bfb3d3c7_07f789f7","updated":"2019-05-23 09:54:42.000000000","message":"POST, will fix it.","commit_id":"8c94dd8c87ce5ffcd7b07590059ef2ffd23feee9"}],"magnum/drivers/k8s_fedora_atomic_v1/driver.py":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"8ddb2498a62a6c8e1ada69ed493ebf4cfd4d295c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        heat_params[\"server_image\"] \u003d cluster_template.image_id"},{"line_number":83,"context_line":"        heat_params[\"master_image\"] \u003d cluster_template.image_id"},{"line_number":84,"context_line":"        heat_params[\"minion_image\"] \u003d cluster_template.image_id"},{"line_number":85,"context_line":"        heat_params[\"master_kube_tag\"] \u003d cluster_template.labels[\"kube_tag\"]"},{"line_number":86,"context_line":"        heat_params[\"minion_kube_tag\"] \u003d cluster_template.labels[\"kube_tag\"]"},{"line_number":87,"context_line":"        heat_params[\"update_max_batch_size\"] \u003d max_batch_size"},{"line_number":88,"context_line":"        # Rules: 1. No downgrade 2. Explicitly override 3. Merging based on set"},{"line_number":89,"context_line":"        # Update heat_params based on the data generated above"}],"source_content_type":"text/x-python","patch_set":18,"id":"bfb3d3c7_0713090f","line":86,"range":{"start_line":85,"start_character":8,"end_line":86,"end_character":76},"updated":"2019-05-23 09:13:25.000000000","message":"If master_kube_tag and minion_kube_tags are enforced here, we don\u0027t need to enforce them on https://review.opendev.org/#/c/660851/\n\nAlso, this should only be applied if the master and/or minion args are not defined.","commit_id":"8c94dd8c87ce5ffcd7b07590059ef2ffd23feee9"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"46b6fea262fbb729603f8054d7eb1bed986cbacb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        heat_params[\"server_image\"] \u003d cluster_template.image_id"},{"line_number":83,"context_line":"        heat_params[\"master_image\"] \u003d cluster_template.image_id"},{"line_number":84,"context_line":"        heat_params[\"minion_image\"] \u003d cluster_template.image_id"},{"line_number":85,"context_line":"        heat_params[\"master_kube_tag\"] \u003d cluster_template.labels[\"kube_tag\"]"},{"line_number":86,"context_line":"        heat_params[\"minion_kube_tag\"] \u003d cluster_template.labels[\"kube_tag\"]"},{"line_number":87,"context_line":"        heat_params[\"update_max_batch_size\"] \u003d max_batch_size"},{"line_number":88,"context_line":"        # Rules: 1. No downgrade 2. Explicitly override 3. Merging based on set"},{"line_number":89,"context_line":"        # Update heat_params based on the data generated above"}],"source_content_type":"text/x-python","patch_set":18,"id":"bfb3d3c7_a2f9cbc8","line":86,"range":{"start_line":85,"start_character":8,"end_line":86,"end_character":76},"in_reply_to":"bfb3d3c7_0713090f","updated":"2019-05-23 09:54:42.000000000","message":"Good point. Personally, I prefer to set the master and minion kube tag here to isolate it.","commit_id":"8c94dd8c87ce5ffcd7b07590059ef2ffd23feee9"}],"upgrade.sh":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"8f75c274f3ea537f5c64dc914176fbae4a4ed421","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"IP\u003d\"\""},{"line_number":4,"context_line":"CLUSTER\u003d\"797b39e1-fac2-48d3-8377-d6e6cc443d39\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_5e804247","line":1,"updated":"2018-09-25 01:41:01.000000000","message":"I think this one is only for your personal testing?","commit_id":"9939786c2dbce01a2f5eff0ffa65bda39f8ccf00"}]}