)]}'
{"magnum/conf/drivers.py":[{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"c510fea38af33241966e8451dd2c100356814118","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                default\u003dTrue,"},{"line_number":35,"context_line":"                help\u003d\u0027Allow periodic tasks to pull COE data and send to \u0027"},{"line_number":36,"context_line":"                     \u0027ceilometer.\u0027),"},{"line_number":37,"context_line":"    cfg.ListOpt(\u0027enabled_drivers\u0027,"},{"line_number":38,"context_line":"                default\u003d[\u0027k8s_fedora_atomic_v1\u0027, \u0027k8s_coreos_v1\u0027,"},{"line_number":39,"context_line":"                         \u0027swarm_fedora_atomic_v1\u0027, \u0027swarm_fedora_atomic_v2\u0027,"},{"line_number":40,"context_line":"                         \u0027mesos_ubuntu_v1\u0027, \u0027k8s_fedora_ironic_v1\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_ab8cd935","line":37,"updated":"2018-02-13 14:38:03.000000000","message":"It would be easier to maintain if we would have a default of None meaning all drivers in the entrypoint are enabled. If operators want to enable only a subset, then they can pass a list.","commit_id":"8c4dab9da25c8a396ae39bbf484ee90c7e60f9e6"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"0fc6ecf0dc6e384c20256bc5635c62554b5a0272","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                default\u003dTrue,"},{"line_number":35,"context_line":"                help\u003d\u0027Allow periodic tasks to pull COE data and send to \u0027"},{"line_number":36,"context_line":"                     \u0027ceilometer.\u0027),"},{"line_number":37,"context_line":"    cfg.ListOpt(\u0027enabled_drivers\u0027,"},{"line_number":38,"context_line":"                default\u003d[\u0027k8s_fedora_atomic_v1\u0027, \u0027k8s_coreos_v1\u0027,"},{"line_number":39,"context_line":"                         \u0027swarm_fedora_atomic_v1\u0027, \u0027swarm_fedora_atomic_v2\u0027,"},{"line_number":40,"context_line":"                         \u0027mesos_ubuntu_v1\u0027, \u0027k8s_fedora_ironic_v1\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_77369905","line":37,"in_reply_to":"3fa0c359_ab8cd935","updated":"2018-02-14 12:44:55.000000000","message":"we can go for disabled_drivers then. All installed drivers are enabled by default and the operator blacklist the ones that he wants.","commit_id":"8c4dab9da25c8a396ae39bbf484ee90c7e60f9e6"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"c510fea38af33241966e8451dd2c100356814118","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                default\u003d[\u0027k8s_fedora_atomic_v1\u0027, \u0027k8s_coreos_v1\u0027,"},{"line_number":39,"context_line":"                         \u0027swarm_fedora_atomic_v1\u0027, \u0027swarm_fedora_atomic_v2\u0027,"},{"line_number":40,"context_line":"                         \u0027mesos_ubuntu_v1\u0027, \u0027k8s_fedora_ironic_v1\u0027],"},{"line_number":41,"context_line":"                help\u003d\u0027Enabled driver entry points.\u0027"},{"line_number":42,"context_line":"                ),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_8bb31de9","line":41,"updated":"2018-02-13 14:38:03.000000000","message":"Should say if not specified, then all available drivers are enabled.","commit_id":"8c4dab9da25c8a396ae39bbf484ee90c7e60f9e6"},{"author":{"_account_id":27006,"name":"Kirsten G.","email":"kikis.github@gmail.com","username":"oikiki"},"change_message_id":"d3ac26f89823062093b7fbf084b00ed851e22c14","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.ListOpt(\u0027disabled_drivers\u0027,"},{"line_number":38,"context_line":"                default\u003d[],"},{"line_number":39,"context_line":"                help\u003d\u0027Disabled driver entry points. The default value is []. \u0027"},{"line_number":40,"context_line":"                     \u0027 Means if not specified, then all available drivers \u0027"},{"line_number":41,"context_line":"                     \u0027are enabled.\u0027"},{"line_number":42,"context_line":"                ),"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_a4a3f89d","line":40,"range":{"start_line":40,"start_character":22,"end_line":40,"end_character":36},"updated":"2018-02-21 08:30:35.000000000","message":"Remove leading space and change sentence to : \u0027If no entry points are specified, then...\u0027","commit_id":"05c7f35d23adc7a60b4101889465aad0ce1670cf"}],"magnum/drivers/common/driver.py":[{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"c510fea38af33241966e8451dd2c100356814118","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def load_entry_points(cls):"},{"line_number":36,"context_line":"        for entry_point in iter_entry_points(\u0027magnum.drivers\u0027):"},{"line_number":37,"context_line":"            if entry_point.name in CONF.drivers.enabled_drivers:"},{"line_number":38,"context_line":"                yield entry_point, entry_point.load(require\u003dFalse)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_cb94c539","line":37,"updated":"2018-02-13 14:38:03.000000000","message":"We could do instead \u0027if CONF.drivers.enabled_drivers and entry_point.name in CONF.drivers.enabled_drivers:\u0027","commit_id":"8c4dab9da25c8a396ae39bbf484ee90c7e60f9e6"}],"magnum/tests/unit/api/controllers/v1/test_baymodel.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"0b6cc9b03085e9e78040cc4a64a5199d9556dbf6","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                                                       expect_errors_flag)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_create_baymodel_with_no_network_driver(self):"},{"line_number":662,"context_line":"        baymodel_dict \u003d {\u0027coe\u0027: \u0027swarm\u0027}"},{"line_number":663,"context_line":"        config_dict \u003d {}"},{"line_number":664,"context_line":"        expect_errors_flag \u003d False"},{"line_number":665,"context_line":"        self._test_create_baymodel_network_driver_attr(baymodel_dict,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_86a04e92","line":662,"updated":"2018-02-20 20:46:18.000000000","message":"is this change required?","commit_id":"60303c649c480b9f20dc37bb6e16e72fdef044be"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"0b6cc9b03085e9e78040cc4a64a5199d9556dbf6","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                wraps\u003dself.dbapi.create_cluster_template) as cc_mock:"},{"line_number":693,"context_line":"            mock_image_data.return_value \u003d {\u0027name\u0027: \u0027mock_name\u0027,"},{"line_number":694,"context_line":"                                            \u0027os_distro\u0027: \u0027fedora-atomic\u0027}"},{"line_number":695,"context_line":"            bdict \u003d apiutils.baymodel_post_data(volume_driver\u003d\u0027cinder\u0027)"},{"line_number":696,"context_line":"            response \u003d self.post_json(\u0027/baymodels\u0027, bdict)"},{"line_number":697,"context_line":"            self.assertEqual(bdict[\u0027volume_driver\u0027],"},{"line_number":698,"context_line":"                             response.json[\u0027volume_driver\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_46a6c6ad","line":695,"updated":"2018-02-20 20:46:18.000000000","message":"ditto","commit_id":"60303c649c480b9f20dc37bb6e16e72fdef044be"}],"magnum/tests/unit/api/controllers/v1/test_cluster_template.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"0b6cc9b03085e9e78040cc4a64a5199d9556dbf6","unresolved":false,"context_lines":[{"line_number":754,"context_line":"            expect_errors_flag)"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_create_cluster_template_with_no_network_driver(self):"},{"line_number":757,"context_line":"        cluster_template_dict \u003d {\u0027coe\u0027: \u0027swarm\u0027}"},{"line_number":758,"context_line":"        config_dict \u003d {}"},{"line_number":759,"context_line":"        expect_errors_flag \u003d False"},{"line_number":760,"context_line":"        self._test_create_cluster_template_network_driver_attr("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_06be7eb3","line":757,"updated":"2018-02-20 20:46:18.000000000","message":"ditto","commit_id":"60303c649c480b9f20dc37bb6e16e72fdef044be"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"0b6cc9b03085e9e78040cc4a64a5199d9556dbf6","unresolved":false,"context_lines":[{"line_number":792,"context_line":"                wraps\u003dself.dbapi.create_cluster_template) as cc_mock:"},{"line_number":793,"context_line":"            mock_image_data.return_value \u003d {\u0027name\u0027: \u0027mock_name\u0027,"},{"line_number":794,"context_line":"                                            \u0027os_distro\u0027: \u0027fedora-atomic\u0027}"},{"line_number":795,"context_line":"            bdict \u003d apiutils.cluster_template_post_data(volume_driver\u003d\u0027cinder\u0027)"},{"line_number":796,"context_line":"            response \u003d self.post_json(\u0027/clustertemplates\u0027, bdict)"},{"line_number":797,"context_line":"            self.assertEqual(bdict[\u0027volume_driver\u0027],"},{"line_number":798,"context_line":"                             response.json[\u0027volume_driver\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_c6b3b6e8","line":795,"updated":"2018-02-20 20:46:18.000000000","message":"ditto","commit_id":"60303c649c480b9f20dc37bb6e16e72fdef044be"}],"magnum/tests/unit/db/utils.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"0b6cc9b03085e9e78040cc4a64a5199d9556dbf6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027docker_storage_driver\u0027: kw.get(\u0027docker_storage_driver\u0027,"},{"line_number":42,"context_line":"                                        \u0027devicemapper\u0027),"},{"line_number":43,"context_line":"        \u0027cluster_distro\u0027: kw.get(\u0027cluster_distro\u0027, \u0027fedora-atomic\u0027),"},{"line_number":44,"context_line":"        \u0027coe\u0027: kw.get(\u0027coe\u0027, \u0027kubernetes\u0027),"},{"line_number":45,"context_line":"        \u0027created_at\u0027: kw.get(\u0027created_at\u0027),"},{"line_number":46,"context_line":"        \u0027updated_at\u0027: kw.get(\u0027updated_at\u0027),"},{"line_number":47,"context_line":"        \u0027labels\u0027: kw.get(\u0027labels\u0027, {\u0027key1\u0027: \u0027val1\u0027, \u0027key2\u0027: \u0027val2\u0027}),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_26c29a35","line":44,"updated":"2018-02-20 20:46:18.000000000","message":"ditto","commit_id":"60303c649c480b9f20dc37bb6e16e72fdef044be"}]}