)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By current design, pods under kube-system will run on minion nodes. And given"},{"line_number":10,"context_line":"now we\u0027re not running kubelet on master node, so any service needs to talk"},{"line_number":11,"context_line":"to pods from master node will fail, such as heapster and proxy, see [1]. And"},{"line_number":12,"context_line":"it\u0027s confirmed with calico team that the calico-node container must be running"},{"line_number":13,"context_line":"on master node if user want to use kube-proxy, see [2]. So, the solution is"},{"line_number":14,"context_line":"enabling kubelet on master but disallow the other pods scheduled on master"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bf659307_3f160457","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":52},"updated":"2018-03-30 11:15:26.000000000","message":"heapster is not running on the master node","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By current design, pods under kube-system will run on minion nodes. And given"},{"line_number":10,"context_line":"now we\u0027re not running kubelet on master node, so any service needs to talk"},{"line_number":11,"context_line":"to pods from master node will fail, such as heapster and proxy, see [1]. And"},{"line_number":12,"context_line":"it\u0027s confirmed with calico team that the calico-node container must be running"},{"line_number":13,"context_line":"on master node if user want to use kube-proxy, see [2]. So, the solution is"},{"line_number":14,"context_line":"enabling kubelet on master but disallow the other pods scheduled on master"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bf659307_5a4e666f","line":11,"range":{"start_line":11,"start_character":57,"end_line":11,"end_character":62},"updated":"2018-03-30 11:15:26.000000000","message":"kubectl proxy","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add calico-node on k8s master node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By current design, pods under kube-system will run on minion nodes. And given"},{"line_number":10,"context_line":"now we\u0027re not running kubelet on master node, so any service needs to talk"},{"line_number":11,"context_line":"to pods from master node will fail, such as heapster and proxy, see [1]. And"},{"line_number":12,"context_line":"it\u0027s confirmed with calico team that the calico-node container must be running"},{"line_number":13,"context_line":"on master node if user want to use kube-proxy, see [2]. So, the solution is"},{"line_number":14,"context_line":"enabling kubelet on master but disallow the other pods scheduled on master"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bf659307_da41163b","line":11,"range":{"start_line":10,"start_character":46,"end_line":11,"end_character":34},"updated":"2018-03-30 11:15:26.000000000","message":"we don\u0027t run services on the master node so far, so only the apiserver fails to contact pods. The only indication we have is that kubectl proxy wasn\u0027t working to access the dashboard.","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"now we\u0027re not running kubelet on master node, so any service needs to talk"},{"line_number":11,"context_line":"to pods from master node will fail, such as heapster and proxy, see [1]. And"},{"line_number":12,"context_line":"it\u0027s confirmed with calico team that the calico-node container must be running"},{"line_number":13,"context_line":"on master node if user want to use kube-proxy, see [2]. So, the solution is"},{"line_number":14,"context_line":"enabling kubelet on master but disallow the other pods scheduled on master"},{"line_number":15,"context_line":"with taint/tolerations."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bf659307_fa397ad6","line":13,"range":{"start_line":13,"start_character":35,"end_line":13,"end_character":45},"updated":"2018-03-30 11:15:26.000000000","message":"kubectl proxy","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"enabling kubelet on master but disallow the other pods scheduled on master"},{"line_number":15,"context_line":"with taint/tolerations."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Because the scheduling is disabled on master, so user\u0027s pod can\u0027t be scheduled"},{"line_number":18,"context_line":"to master node. Here is the outpuf when listing nodes:"},{"line_number":19,"context_line":"[fedora@k8scluster-m4ke25d5vu3q-master-0 ~]$ kubectl get nodes"},{"line_number":20,"context_line":"NAME                               STATUS                     ROLES     AGE       VERSION"},{"line_number":21,"context_line":"k8scluster-m4ke25d5vu3q-master-0   Ready,SchedulingDisabled   \u003cnone\u003e    7m        v1.9.3"},{"line_number":22,"context_line":"k8scluster-m4ke25d5vu3q-minion-0   Ready                      \u003cnone\u003e    1m        v1.9.3"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"NOTE: Only running calico-node container on k8s master doesn\u0027t work based on"},{"line_number":25,"context_line":"the way how Magnum deploy k8s. Because when starting the calico-node container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bf659307_da6a76b1","line":22,"range":{"start_line":17,"start_character":0,"end_line":22,"end_character":88},"updated":"2018-03-30 11:15:26.000000000","message":"We don\u0027t need this here.","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"k8scluster-m4ke25d5vu3q-master-0   Ready,SchedulingDisabled   \u003cnone\u003e    7m        v1.9.3"},{"line_number":22,"context_line":"k8scluster-m4ke25d5vu3q-minion-0   Ready                      \u003cnone\u003e    1m        v1.9.3"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"NOTE: Only running calico-node container on k8s master doesn\u0027t work based on"},{"line_number":25,"context_line":"the way how Magnum deploy k8s. Because when starting the calico-node container"},{"line_number":26,"context_line":"on master node, something are not ready yet. If start calico-node on k8s master"},{"line_number":27,"context_line":"after all k8s nodes are ready, it works."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://github.com/projectcalico/calico/issues/1096"},{"line_number":30,"context_line":"[2] https://docs.projectcalico.org/v3.0/getting-started/kubernetes/installation/integration#about-the-calico-components"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bf659307_3a24d2ae","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":40},"updated":"2018-03-30 11:15:26.000000000","message":"I assume that here you mean that, calico node needs the calico-controller to be running first?","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"}],"magnum/drivers/common/templates/kubernetes/fragments/calico-networkmanager.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c0dc5322701d92bfd25bb3fef05d9b24db53db27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#cloud-boothook"},{"line_number":2,"context_line":"#!/bin/sh"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CALICO_NM\u003d/etc/NetworkManager/conf.d/calico.conf"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[ -f ${CALICO_NM} ] || {"},{"line_number":7,"context_line":"echo \"Writing File: $CALICO_NM\""},{"line_number":8,"context_line":"mkdir -p $(dirname ${CALICO_NM})"},{"line_number":9,"context_line":"cat \u003c\u003c EOF \u003e ${CALICO_NM}"},{"line_number":10,"context_line":"[keyfile]"},{"line_number":11,"context_line":"unmanaged-devices\u003dinterface-name:cali*;interface-name:tunl*"},{"line_number":12,"context_line":"EOF"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"systemctl restart NetworkManager"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_9ff23206","line":15,"range":{"start_line":4,"start_character":0,"end_line":15,"end_character":32},"updated":"2018-04-17 08:12:24.000000000","message":"Moving this here:\nhttp://git.openstack.org/cgit/openstack/magnum/tree/magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh#n12\n\nWorks as well and we don\u0027t create one more entry to the heat DB.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5a94818d852ec59971da8af3dd41b1d7e6eeade3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#cloud-boothook"},{"line_number":2,"context_line":"#!/bin/sh"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CALICO_NM\u003d/etc/NetworkManager/conf.d/calico.conf"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[ -f ${CALICO_NM} ] || {"},{"line_number":7,"context_line":"echo \"Writing File: $CALICO_NM\""},{"line_number":8,"context_line":"mkdir -p $(dirname ${CALICO_NM})"},{"line_number":9,"context_line":"cat \u003c\u003c EOF \u003e ${CALICO_NM}"},{"line_number":10,"context_line":"[keyfile]"},{"line_number":11,"context_line":"unmanaged-devices\u003dinterface-name:cali*;interface-name:tunl*"},{"line_number":12,"context_line":"EOF"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"systemctl restart NetworkManager"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_cb746c9c","line":15,"range":{"start_line":4,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"9f6a8fd7_9ff23206","updated":"2018-04-17 10:01:14.000000000","message":"Nice, will do next PS.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"69edfc1f55c7bb8e8f86f1381e6a5b2e6e4f4ac9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#cloud-boothook"},{"line_number":2,"context_line":"#!/bin/sh"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CALICO_NM\u003d/etc/NetworkManager/conf.d/calico.conf"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[ -f ${CALICO_NM} ] || {"},{"line_number":7,"context_line":"echo \"Writing File: $CALICO_NM\""},{"line_number":8,"context_line":"mkdir -p $(dirname ${CALICO_NM})"},{"line_number":9,"context_line":"cat \u003c\u003c EOF \u003e ${CALICO_NM}"},{"line_number":10,"context_line":"[keyfile]"},{"line_number":11,"context_line":"unmanaged-devices\u003dinterface-name:cali*;interface-name:tunl*"},{"line_number":12,"context_line":"EOF"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"systemctl restart NetworkManager"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_61c0ae51","line":15,"range":{"start_line":4,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"9f6a8fd7_cb746c9c","updated":"2018-04-19 03:28:32.000000000","message":"Tested, it works.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cgroup-driver\u003dsystemd\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    sed -i \u0027"},{"line_number":139,"context_line":"    /^KUBELET_ADDRESS\u003d/ s/\u003d.*/\u003d\"--address\u003d0.0.0.0\"/"},{"line_number":140,"context_line":"    /^KUBELET_HOSTNAME\u003d/ s/\u003d.*/\u003d\"\"/"},{"line_number":141,"context_line":"    /^KUBELET_ARGS\u003d/ s|\u003d.*|\u003d\"\u0027\"\\$(/etc/kubernetes/get_require_kubeconfig.sh) ${KUBELET_ARGS}\"\u0027\"|"},{"line_number":142,"context_line":"\u0027 /etc/kubernetes/kubelet"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bf659307_7a8a4a6a","line":139,"range":{"start_line":139,"start_character":41,"end_line":139,"end_character":49},"updated":"2018-03-30 11:15:26.000000000","message":"bind to the private ip or 127.0.0.1 (I hope localhost works) and see the the other security options:\nhttps://review.openstack.org/#/c/556213/2/magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh@105 I haven\u0027t check which ones apply since we don\u0027t have the kubelet certs on the master. bind to 0.0.0.0 on the master without authn/authz is dangerous.","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c0dc5322701d92bfd25bb3fef05d9b24db53db27","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cgroup-driver\u003dsystemd\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    sed -i \u0027"},{"line_number":142,"context_line":"    /^KUBELET_ADDRESS\u003d/ s/\u003d.*/\u003d\"--address\u003d127.0.0.1\"/"},{"line_number":143,"context_line":"    /^KUBELET_HOSTNAME\u003d/ s/\u003d.*/\u003d\"\"/"},{"line_number":144,"context_line":"    /^KUBELET_ARGS\u003d/ s|\u003d.*|\u003d\"\u0027\"\\$(/etc/kubernetes/get_require_kubeconfig.sh) ${KUBELET_ARGS}\"\u0027\"|"},{"line_number":145,"context_line":"\u0027 /etc/kubernetes/kubelet"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_d2e8a117","line":142,"updated":"2018-04-17 08:12:24.000000000","message":"In the end with this config heapster doesn\u0027t work, we need the listen to the node ipv4. without the certs I\u0027m not sure if it will work.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"bc8e52387dff23c0d000b848fe026b660848c725","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cgroup-driver\u003dsystemd\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    sed -i \u0027"},{"line_number":142,"context_line":"    /^KUBELET_ADDRESS\u003d/ s/\u003d.*/\u003d\"--address\u003d127.0.0.1\"/"},{"line_number":143,"context_line":"    /^KUBELET_HOSTNAME\u003d/ s/\u003d.*/\u003d\"\"/"},{"line_number":144,"context_line":"    /^KUBELET_ARGS\u003d/ s|\u003d.*|\u003d\"\u0027\"\\$(/etc/kubernetes/get_require_kubeconfig.sh) ${KUBELET_ARGS}\"\u0027\"|"},{"line_number":145,"context_line":"\u0027 /etc/kubernetes/kubelet"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_0bf58457","line":142,"in_reply_to":"9f6a8fd7_0b7b448c","updated":"2018-04-17 10:21:05.000000000","message":"I\u0027m afraid we might need the same config from the minion and maybe the certs for kubelet :(","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"69edfc1f55c7bb8e8f86f1381e6a5b2e6e4f4ac9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cgroup-driver\u003dsystemd\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    sed -i \u0027"},{"line_number":142,"context_line":"    /^KUBELET_ADDRESS\u003d/ s/\u003d.*/\u003d\"--address\u003d127.0.0.1\"/"},{"line_number":143,"context_line":"    /^KUBELET_HOSTNAME\u003d/ s/\u003d.*/\u003d\"\"/"},{"line_number":144,"context_line":"    /^KUBELET_ARGS\u003d/ s|\u003d.*|\u003d\"\u0027\"\\$(/etc/kubernetes/get_require_kubeconfig.sh) ${KUBELET_ARGS}\"\u0027\"|"},{"line_number":145,"context_line":"\u0027 /etc/kubernetes/kubelet"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_41bd6ad6","line":142,"in_reply_to":"9f6a8fd7_0bf58457","updated":"2018-04-19 03:28:32.000000000","message":"I tried use the master IPv4 address, and the heapster still fails. So you\u0027re probably right, we may need the certs as well.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5a94818d852ec59971da8af3dd41b1d7e6eeade3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cgroup-driver\u003dsystemd\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    sed -i \u0027"},{"line_number":142,"context_line":"    /^KUBELET_ADDRESS\u003d/ s/\u003d.*/\u003d\"--address\u003d127.0.0.1\"/"},{"line_number":143,"context_line":"    /^KUBELET_HOSTNAME\u003d/ s/\u003d.*/\u003d\"\"/"},{"line_number":144,"context_line":"    /^KUBELET_ARGS\u003d/ s|\u003d.*|\u003d\"\u0027\"\\$(/etc/kubernetes/get_require_kubeconfig.sh) ${KUBELET_ARGS}\"\u0027\"|"},{"line_number":145,"context_line":"\u0027 /etc/kubernetes/kubelet"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_0b7b448c","line":142,"in_reply_to":"9f6a8fd7_d2e8a117","updated":"2018-04-17 10:01:14.000000000","message":"Good point. Thanks. I will check how kubeadm do this.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"}],"magnum/drivers/common/templates/kubernetes/fragments/enable-services-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f39b9e3bbf260760cd352bd78dac2e50f4c8feb8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    echo \"activating service kubelet\""},{"line_number":25,"context_line":"    systemctl enable kubelet"},{"line_number":26,"context_line":"    systemctl start kubelet"},{"line_number":27,"context_line":"    kubelet taint nodes `hostname --short | sed \u0027s/\\.novalocal//\u0027` CriticalAddonsOnly\u003dTrue:NoSchedule dedicated\u003dmaster:NoSchedule"},{"line_number":28,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bf659307_ba5d4216","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":129},"updated":"2018-03-30 11:15:26.000000000","message":"Better use this parameter in kubelet configuration:\n--register-with-taints \nhttps://kubernetes.io/docs/reference/generated/kubelet/","commit_id":"a2a7d7385534f8c9d5cd477642f6fbaf78e9b91f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c0dc5322701d92bfd25bb3fef05d9b24db53db27","unresolved":false,"context_lines":[{"line_number":21,"context_line":"done"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [ \"$NETWORK_DRIVER\" \u003d \"calico\" ]; then"},{"line_number":24,"context_line":"    echo \"activating service kubelet\""},{"line_number":25,"context_line":"    systemctl enable kubelet"},{"line_number":26,"context_line":"    systemctl start kubelet"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_1ff062c9","line":24,"updated":"2018-04-17 08:12:24.000000000","message":"We can also restart NM here.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5a94818d852ec59971da8af3dd41b1d7e6eeade3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"done"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [ \"$NETWORK_DRIVER\" \u003d \"calico\" ]; then"},{"line_number":24,"context_line":"    echo \"activating service kubelet\""},{"line_number":25,"context_line":"    systemctl enable kubelet"},{"line_number":26,"context_line":"    systemctl start kubelet"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_cb5b0c2c","line":24,"in_reply_to":"9f6a8fd7_1ff062c9","updated":"2018-04-17 10:01:14.000000000","message":"Hmm... we\u0027re not dealing with the NM on master node.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"69edfc1f55c7bb8e8f86f1381e6a5b2e6e4f4ac9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"done"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [ \"$NETWORK_DRIVER\" \u003d \"calico\" ]; then"},{"line_number":24,"context_line":"    echo \"activating service kubelet\""},{"line_number":25,"context_line":"    systemctl enable kubelet"},{"line_number":26,"context_line":"    systemctl start kubelet"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9f6a8fd7_e1cb5e6f","line":24,"in_reply_to":"9f6a8fd7_cb5b0c2c","updated":"2018-04-19 03:28:32.000000000","message":"If we want to allow running workload on master, we will need the NM work.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubeminion.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c0dc5322701d92bfd25bb3fef05d9b24db53db27","unresolved":false,"context_lines":[{"line_number":426,"context_line":"      group: ungrouped"},{"line_number":427,"context_line":"      config: {get_file: ../../common/templates/kubernetes/fragments/add-proxy.sh}"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"  calico_networkmanager:"},{"line_number":430,"context_line":"    type: OS::Heat::SoftwareConfig"},{"line_number":431,"context_line":"    properties:"},{"line_number":432,"context_line":"      group: ungrouped"},{"line_number":433,"context_line":"      config: {get_file: ../../common/templates/kubernetes/fragments/calico-networkmanager.sh}"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"  kube_minion_init:"},{"line_number":436,"context_line":"    type: OS::Heat::MultipartMime"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_ffd7ae22","line":433,"range":{"start_line":429,"start_character":0,"end_line":433,"end_character":94},"updated":"2018-04-17 08:12:24.000000000","message":"If we drop calico-networkmanager.sh then we also drop this and line 440.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5a94818d852ec59971da8af3dd41b1d7e6eeade3","unresolved":false,"context_lines":[{"line_number":426,"context_line":"      group: ungrouped"},{"line_number":427,"context_line":"      config: {get_file: ../../common/templates/kubernetes/fragments/add-proxy.sh}"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"  calico_networkmanager:"},{"line_number":430,"context_line":"    type: OS::Heat::SoftwareConfig"},{"line_number":431,"context_line":"    properties:"},{"line_number":432,"context_line":"      group: ungrouped"},{"line_number":433,"context_line":"      config: {get_file: ../../common/templates/kubernetes/fragments/calico-networkmanager.sh}"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"  kube_minion_init:"},{"line_number":436,"context_line":"    type: OS::Heat::MultipartMime"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_8b3d14bd","line":433,"range":{"start_line":429,"start_character":0,"end_line":433,"end_character":94},"in_reply_to":"9f6a8fd7_ffd7ae22","updated":"2018-04-17 10:01:14.000000000","message":"will do in next PS.","commit_id":"b1dedaf93565ef2f59ae49f7790afbb11f8c6815"}]}