)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e846271574f84a97cf686f60139ba28b10259a77","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/kube_openstack_config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_72ddbf3e","line":102,"range":{"start_line":102,"start_character":136,"end_line":102,"end_character":157},"updated":"2018-12-18 09:18:53.000000000","message":"So the is happy to make reference to kube_openstack_config rather than cloud-config?","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8e5408055b60e30dbff63a0c606fea1807ef31ff","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/kube_openstack_config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_2d2ccc92","line":102,"range":{"start_line":102,"start_character":136,"end_line":102,"end_character":157},"in_reply_to":"3f79a3b5_72ddbf3e","updated":"2018-12-18 09:36:06.000000000","message":"Not sure if it using it or not. cinder works, octavia works.","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":76,"context_line":"fi"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":79,"context_line":"    KUBE_API_ARGS\u003d\"$KUBE_API_ARGS --cloud-provider\u003dexternal\""},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_6a1ce3c2","line":79,"updated":"2018-12-18 13:53:27.000000000","message":"good!","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_6ac0632d","line":102,"updated":"2018-12-18 13:53:27.000000000","message":"Drop `--cloud-config`","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"30f31d4b326bac28f4ee727600ba517e2fc4cd23","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_5838ddca","line":102,"in_reply_to":"3f79a3b5_4d058115","updated":"2018-12-18 14:53:48.000000000","message":"I am guessing that --external-cloud-volume-plugin\u003dopenstack option necessitates it in this case. However your rule no. 2 probably needs a slight adjustment: the file \"/etc/kubernetes/cloud-config\"  should be available to the following processes (where ever they may be running!, if they are in containers then the file needs to be mounted)\n    - kube-controller-manager\n    - openstack-cloud-controller-manager\n\nThese services do not require \"/etc/kubernetes/cloud-config\".\n    - kubelet\n    - kube-apiserver","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"1a7752544ec8a9e4fcef61dc88e1fe2a1565a140","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_78d1195a","line":102,"in_reply_to":"3f79a3b5_4d058115","updated":"2018-12-18 14:56:25.000000000","message":"This is a snippet from the log of the cloud provider:\nDec 18 14:52:06 kube-onxim3qlsdxp-master-0.novalocal systemd[1]: Started kubernetes-controller-manager.\nDec 18 14:52:06 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: I1218 14:52:06.465680       1 controllermanager.go:122] Version: v1.11.5\nDec 18 14:52:06 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: W1218 14:52:06.466572       1 authentication.go:55] Authentication is disabled\nDec 18 14:52:06 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: I1218 14:52:06.466848       1 insecure_serving.go:49] Serving insecurely on [::]:10252\nDec 18 14:52:06 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: I1218 14:52:06.467263       1 leaderelection.go:185] attempting to acquire leader lease  kube-system/kube-controller-manager...\n\n\n\n\nAt this moment the kube-controller-manager waits a few seconds, then it continues, exits and systemd restarts it. The issue is that during the wait this happens:\n\n# curl 127.0.0.1:10252/healthz \u0026\u0026 echo\nok\n\nThe controller-manager reports ok!!!\n\n\n\n\n\nDec 18 14:52:24 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: I1218 14:52:24.359753       1 leaderelection.go:194] successfully acquired lease kube-system/kube-controller-manager\nDec 18 14:52:24 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: I1218 14:52:24.359851       1 event.go:221] Event(v1.ObjectReference{Kind:\"Endpoints\", Namespace:\"kube-system\", Name:\"kube-controller-manager\", UID:\"7bbb4022-02d0-11e9-88c1-fa163e4bc972\", APIVersion:\"v1\", ResourceVersion:\"2754\", FieldPath:\"\"}): type: \u0027Normal\u0027 reason: \u0027LeaderElection\u0027 kube-onxim3qlsdxp-master-0.novalocal_7cfb3ae5-02d4-11e9-8348-fa163e4bc972 became leader\nDec 18 14:52:24 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: W1218 14:52:24.568235       1 plugins.go:112] WARNING: openstack built-in cloud provider is now deprecated. Please use \u0027external\u0027 cloud provider for openstack: https://github.com/kubernetes/cloud-provider-openstack\nDec 18 14:52:24 kube-onxim3qlsdxp-master-0.novalocal runc[7092]: F1218 14:52:24.569320       1 controllermanager.go:169] error building controller context: cloud provider could not be initialized: could not init cloud provider \"openstack\": no OpenStack cloud provider config file given\nDec 18 14:52:24 kube-onxim3qlsdxp-master-0.novalocal systemd[1]: kube-controller-manager.service: Main process exited, code\u003dexited, status\u003d255/n/a","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"6aa70eec9f1c7c89e128404574831e9df731a4e8","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_ade2159a","line":102,"in_reply_to":"3f79a3b5_4d64a14e","updated":"2018-12-18 14:37:22.000000000","message":"Dec 18 14:36:48 kube-onxim3qlsdxp-master-0.novalocal runc[5367]: F1218 14:36:48.760487       1 controllermanager.go:169] error building controller context: cloud provider could not be initialized: could not init cloud provider \"openstack\": no OpenStack cloud provider config file given","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8adf36ac2ef1bdff4bf26621e30465c361c7853f","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_4d64a14e","line":102,"in_reply_to":"3f79a3b5_6ac0632d","updated":"2018-12-18 14:35:09.000000000","message":"After dropping this, the controller-manager doesn\u0027t start","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"385be6e0388e990b924d8070cc6aefca30f5e6be","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":101,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --cloud-provider\u003dexternal\""},{"line_number":102,"context_line":"    KUBE_CONTROLLER_MANAGER_ARGS\u003d\"$KUBE_CONTROLLER_MANAGER_ARGS --external-cloud-volume-plugin\u003dopenstack --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":103,"context_line":"fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_4d058115","line":102,"in_reply_to":"3f79a3b5_ade2159a","updated":"2018-12-18 14:45:07.000000000","message":"Cool. just making sure we need it. +1 to keep it then.","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":123,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":126,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":127,"context_line":"fi"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"# For using default log-driver, other options should be ignored"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_ead9d326","line":126,"updated":"2018-12-18 13:53:27.000000000","message":"Drop `--cloud-config`","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e846271574f84a97cf686f60139ba28b10259a77","unresolved":false,"context_lines":[{"line_number":121,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":124,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Workaround for Cinder support (fixed in k8s \u003e\u003d 1.6)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_f2854f03","line":124,"range":{"start_line":124,"start_character":91,"end_line":124,"end_character":103},"updated":"2018-12-18 09:18:53.000000000","message":"Is the cloud-config part definitely required here? Doesn\u0027t mention it here: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-kubernetes-integration-options.md","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8e5408055b60e30dbff63a0c606fea1807ef31ff","unresolved":false,"context_lines":[{"line_number":121,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":124,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Workaround for Cinder support (fixed in k8s \u003e\u003d 1.6)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_0d70f0a5","line":124,"range":{"start_line":124,"start_character":91,"end_line":124,"end_character":103},"in_reply_to":"3f79a3b5_f2854f03","updated":"2018-12-18 09:36:06.000000000","message":"100% this what made cinder work.","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":121,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"if [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":124,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal --cloud-config\u003d/etc/kubernetes/cloud-config\""},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Workaround for Cinder support (fixed in k8s \u003e\u003d 1.6)"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_6ac5c334","line":124,"updated":"2018-12-18 13:53:27.000000000","message":"Drop `--cloud-config`","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"}],"magnum/drivers/common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e145580b04467382c057f81cb92efda4020a26c7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      serviceAccountName: openstack-cloud-controller-manager"},{"line_number":152,"context_line":"      containers:"},{"line_number":153,"context_line":"      - name: openstack-cloud-controller-manager"},{"line_number":154,"context_line":"        image: ${occm_prefix}openstack-cloud-controller-manager:v0.2.0"},{"line_number":155,"context_line":"        command:"},{"line_number":156,"context_line":"        - /bin/openstack-cloud-controller-manager"},{"line_number":157,"context_line":"        - --v\u003d2"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_6a3a46c5","line":154,"range":{"start_line":154,"start_character":64,"end_line":154,"end_character":70},"updated":"2018-12-10 15:28:27.000000000","message":"is this correct? there is nothing on docker hub tagged with this version: https://hub.docker.com/r/openstackmagnum/openstack-cloud-controller-manager/","commit_id":"21b1e319c69b192ba860f7d7cb6bd1d73f17a39c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5f898231af3fafe4689f10488e7ed26107447670","unresolved":false,"context_lines":[{"line_number":16,"context_line":"do"},{"line_number":17,"context_line":"    sleep 5"},{"line_number":18,"context_line":"done"},{"line_number":19,"context_line":"kubectl label node \"${node_name}\" node-role.kubernetes.io/master\u003d\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# NOTE(flwang): Let\u0027s keep the same addons yaml file on all masters,"},{"line_number":22,"context_line":"# but if it\u0027s not the primary/bootstrapping master, don\u0027t try to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_1a73bda4","line":19,"updated":"2018-12-11 21:10:59.000000000","message":"Instead of using label with kubectl, we can just set it like this https://review.openstack.org/#/c/561783/15/magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh@163","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"ab88e03815e3b1f51bb90731b3d88df957049f73","unresolved":false,"context_lines":[{"line_number":16,"context_line":"do"},{"line_number":17,"context_line":"    sleep 5"},{"line_number":18,"context_line":"done"},{"line_number":19,"context_line":"kubectl label node \"${node_name}\" node-role.kubernetes.io/master\u003d\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# NOTE(flwang): Let\u0027s keep the same addons yaml file on all masters,"},{"line_number":22,"context_line":"# but if it\u0027s not the primary/bootstrapping master, don\u0027t try to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_9ff55889","line":19,"in_reply_to":"3f79a3b5_1a73bda4","updated":"2018-12-14 07:31:25.000000000","message":"Done","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f86d636e33ace7ec8bbdf419e0f19f8adba4ecc7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"do"},{"line_number":17,"context_line":"    sleep 5"},{"line_number":18,"context_line":"done"},{"line_number":19,"context_line":"kubectl label node \"${node_name}\" node-role.kubernetes.io/master\u003d\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# NOTE(flwang): Let\u0027s keep the same addons yaml file on all masters,"},{"line_number":22,"context_line":"# but if it\u0027s not the primary/bootstrapping master, don\u0027t try to"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_6c30f106","line":19,"in_reply_to":"3f79a3b5_1a73bda4","updated":"2018-12-12 13:07:33.000000000","message":"I will take a look","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        - /bin/openstack-cloud-controller-manager"},{"line_number":282,"context_line":"        - --v\u003d2"},{"line_number":283,"context_line":"        - --cloud-config\u003d/etc/kubernetes/cloud-config"},{"line_number":284,"context_line":"        - --cloud-provider\u003dopenstack"},{"line_number":285,"context_line":"        - --cluster-name\u003d${CLUSTER_UUID}"},{"line_number":286,"context_line":"        - --use-service-account-credentials\u003dtrue"},{"line_number":287,"context_line":"        - --bind-address\u003d127.0.0.1"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_8af37fa2","line":284,"updated":"2018-12-18 13:53:27.000000000","message":"keep --cloud-config, drop --cloud-provider","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"}],"magnum/drivers/common/templates/kubernetes/fragments/write-kube-os-config.sh":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5f898231af3fafe4689f10488e7ed26107447670","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"mkdir -p /etc/kubernetes/"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z \"${TRUST_ID}\" ]; then"},{"line_number":8,"context_line":"    exit 0"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_baf409cf","line":7,"updated":"2018-12-11 21:10:59.000000000","message":"Why do we need this?","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f86d636e33ace7ec8bbdf419e0f19f8adba4ecc7","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"mkdir -p /etc/kubernetes/"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z \"${TRUST_ID}\" ]; then"},{"line_number":8,"context_line":"    exit 0"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_ac584964","line":7,"in_reply_to":"3f79a3b5_4f1dee10","updated":"2018-12-12 13:07:33.000000000","message":"+1 to Bharat","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8f999713ce0d2d2edbf7bfff6c3fb64d1b8fdd72","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"mkdir -p /etc/kubernetes/"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z \"${TRUST_ID}\" ]; then"},{"line_number":8,"context_line":"    exit 0"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3f79a3b5_4f1dee10","line":7,"in_reply_to":"3f79a3b5_baf409cf","updated":"2018-12-12 12:54:23.000000000","message":"I suppose the rest of the instructions in this file are only relevant if TRUST_ID is defined?","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"52b193b277226ac29579563d8061299e6205a863","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[BlockStorage]"},{"line_number":31,"context_line":"bs-version\u003dv2"},{"line_number":32,"context_line":"EOF"},{"line_number":33,"context_line":"cp ${KUBE_OS_CLOUD_CONFIG} /etc/kubernetes/cloud-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Provide optional region parameter if it\u0027s set."},{"line_number":36,"context_line":"if [ -n ${REGION_NAME} ]; then"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_728e1f7c","line":33,"updated":"2018-12-18 09:05:48.000000000","message":"this is required, if the file has a different name it doesn\u0027t work. IMO, one more reason to use csi-cinder.","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8e5408055b60e30dbff63a0c606fea1807ef31ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[BlockStorage]"},{"line_number":31,"context_line":"bs-version\u003dv2"},{"line_number":32,"context_line":"EOF"},{"line_number":33,"context_line":"cp ${KUBE_OS_CLOUD_CONFIG} /etc/kubernetes/cloud-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Provide optional region parameter if it\u0027s set."},{"line_number":36,"context_line":"if [ -n ${REGION_NAME} ]; then"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_cd6998bf","line":33,"in_reply_to":"3f79a3b5_125a4bf3","updated":"2018-12-18 09:36:06.000000000","message":"of course not.","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e846271574f84a97cf686f60139ba28b10259a77","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[BlockStorage]"},{"line_number":31,"context_line":"bs-version\u003dv2"},{"line_number":32,"context_line":"EOF"},{"line_number":33,"context_line":"cp ${KUBE_OS_CLOUD_CONFIG} /etc/kubernetes/cloud-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Provide optional region parameter if it\u0027s set."},{"line_number":36,"context_line":"if [ -n ${REGION_NAME} ]; then"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f79a3b5_125a4bf3","line":33,"in_reply_to":"3f79a3b5_728e1f7c","updated":"2018-12-18 09:18:53.000000000","message":"Now that\u0027s a really strange behaviour!\n\nIs this a known issue documented somewhere?","commit_id":"c955ed941822e818e8f452e2ecf100342ab7d708"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    exit 0"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"KUBE_OS_CLOUD_CONFIG\u003d/etc/kubernetes/cloud-config"},{"line_number":12,"context_line":"cp /etc/pki/tls/certs/ca-bundle.crt /etc/kubernetes/ca-bundle.crt"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Generate a the configuration for Kubernetes services"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_4af1e796","line":11,"updated":"2018-12-18 13:53:27.000000000","message":"Good!","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"1a3ce33bdc991e38f3643a3f700c611aea3e086a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# backwards compatibility, some apps may expect this file from previous magnum versions."},{"line_number":40,"context_line":"cp ${KUBE_OS_CLOUD_CONFIG} /etc/kubernetes/kube_openstack_config"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_6a02a30f","line":40,"range":{"start_line":40,"start_character":43,"end_line":40,"end_character":64},"updated":"2018-12-18 14:06:31.000000000","message":"Cant we just call the bloody thing cloud-config everywhere instead of kube_openstack_config? or `ln -s` instead of `cp`?","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6e49dcda89db6f00ec8a23f90519b5b8589fac07","unresolved":false,"context_lines":[{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# backwards compatibility, some apps may expect this file from previous magnum versions."},{"line_number":40,"context_line":"cp ${KUBE_OS_CLOUD_CONFIG} /etc/kubernetes/kube_openstack_config"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_6aee23b7","line":40,"updated":"2018-12-18 13:53:27.000000000","message":"Ok!","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"1d89a4856e2acea4077cdf05d61f2726ad0ab761","unresolved":false,"context_lines":[{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# backwards compatibility, some apps may expect this file from previous magnum versions."},{"line_number":40,"context_line":"cp ${KUBE_OS_CLOUD_CONFIG} /etc/kubernetes/kube_openstack_config"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3f79a3b5_cd2e715a","line":40,"range":{"start_line":40,"start_character":43,"end_line":40,"end_character":64},"in_reply_to":"3f79a3b5_6a02a30f","updated":"2018-12-18 14:18:13.000000000","message":"not sure how the symlink will play when mounted in pod.","commit_id":"a6d5a9d5ac08a237076228ae2758c490b92144ab"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5f898231af3fafe4689f10488e7ed26107447670","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    description:"},{"line_number":334,"context_line":"      tag of the kubernetes/cloud-provider-openstack"},{"line_number":335,"context_line":"      https://hub.docker.com/r/k8scloudprovider/openstack-cloud-controller-manager/tags/"},{"line_number":336,"context_line":"    default: v0.2.0"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  cloud_provider_enabled:"},{"line_number":339,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7acd1190","line":336,"updated":"2018-12-11 21:10:59.000000000","message":"Now CPO is following the same version of k8s, I\u0027m OK with 0.2.0 for now, but in the future, this one should be consist with the k8s version we\u0027re setting.","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f86d636e33ace7ec8bbdf419e0f19f8adba4ecc7","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    description:"},{"line_number":334,"context_line":"      tag of the kubernetes/cloud-provider-openstack"},{"line_number":335,"context_line":"      https://hub.docker.com/r/k8scloudprovider/openstack-cloud-controller-manager/tags/"},{"line_number":336,"context_line":"    default: v0.2.0"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  cloud_provider_enabled:"},{"line_number":339,"context_line":"    type: boolean"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_2c551921","line":336,"in_reply_to":"3f79a3b5_7acd1190","updated":"2018-12-12 13:07:33.000000000","message":"v0.2.0 is the one that matches 1.11.x, from v1.13.0 the CPO driver matches the k8s release.\n\nhttps://github.com/kubernetes/cloud-provider-openstack/releases/tag/v0.2.0","commit_id":"c3ce967c577575fddc5d9369e4bcb5928ed20956"}]}
